sudish mukundan | 1 Jun 21:29 2009
Picon

sudish mukundan sent you a Friend Request on Yaari

sudish mukundan wants you to join Yaari!

Is sudish your friend?

Yes, sudish is my friend! No, sudish isn't my friend.

Please respond or sudish may think you said no :(

Thanks,
The Yaari Team

-----------------------------------------------------------
Yaari Inc., 358 Angier Ave NE Atlanta, GA 30312
Privacy Policy | Unsubscribe | Terms of Service

YaariYCR194STE484EDB728IOU210

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono
max | 1 Jun 21:34 2009

Re: sudish mukundan sent you a Friend Request on Yaari

> sudish mukundan wants you to join Yaari!
>

please try to avoid such spam to the mailing list
Li, Minjun | 2 Jun 03:18 2009
Picon

add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Hi Folks,

Because I found that manager_destroy function is lack of some exit function calls comparing to manager_free function, I add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called.

 

Best Regards,

Minjun

 

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono
Denis Kenzior | 2 Jun 05:57 2009
Picon

Re: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Monday 01 June 2009 20:18:23 Li, Minjun wrote:
> Hi Folks,
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common removing and
> unregistering exit function for interfaces when manager_free and
> manager_destroy function is called.

Please use proper coding style when submitting patches.  This means tabs 
instead of spaces, and proper spacing, e.g. 'if () {'  The functions should be 
named appropriately, 'foo_free' just won't work.

Also, only include patches that are specific to the fix, things like mode change 
are extraneous.   And include a proper commit message.

>
> Best Regards,
> Minjun

Regards,
-Denis
Li, Minjun | 2 Jun 09:02 2009
Picon

add a common exit function for interfaces when manager_free and manager_destroy function is called

Hi Folks,

I regenerated the patch.

Because I found that manager_destroy function is lack of some exit function calls comparing to manager_free function, I add a common exit function for interfaces when manager_free and manager_destroy function is called.

 

Best Regards,

Minjun

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono
Denis Kenzior | 3 Jun 00:39 2009
Picon

Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Tuesday 02 June 2009 02:02:29 Li, Minjun wrote:
> Hi Folks,
> I regenerated the patch.
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common exit function for
> interfaces when manager_free and manager_destroy function is called.
>

In interface_exit: Please remove if (at)  block, its pointless.

Please get rid of all mode changes, only submit changes to files that are 
relevant to the fix.

Get a proper commit message.  E.g. put the description in the email into the 
commit message.  

> Best Regards,
> Minjun

Regards,
-Denis
Li, Minjun | 3 Jun 03:11 2009
Picon

RE: add a common exit function for interfaces when manager_free and manager_destroy function is called

I regenerated the patch again.
Thank denis for good advice.

Best Regards,

Minjun
-----Original Message-----
From: Kenzior, Denis 
Sent: 2009年6月3日 6:38
To: ofono <at> ofono.org
Cc: Li, Minjun
Subject: Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Tuesday 02 June 2009 02:02:29 Li, Minjun wrote:
> Hi Folks,
> I regenerated the patch.
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common exit function for
> interfaces when manager_free and manager_destroy function is called.
>

In interface_exit: Please remove if (at)  block, its pointless.

Please get rid of all mode changes, only submit changes to files that are 
relevant to the fix.

Get a proper commit message.  E.g. put the description in the email into the 
commit message.  

> Best Regards,
> Minjun

Regards,
-Denis

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono
Xu, Martin | 3 Jun 04:25 2009
Picon

RE: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Hi Mingjun:
Since it uses the kernel coding style, you can use checkpatch.pl from kernel to check your patch before you
submit it. :)
I have attached the script in my attachment in case you are not familiar with kernel. 

-----Original Message-----
From: ofono-bounces <at> ofono.org [mailto:ofono-bounces <at> ofono.org] On Behalf Of Denis Kenzior
Sent: 2009年6月2日 11:58
To: ofono <at> ofono.org
Subject: Re: add a common removing and unregistering exit function for interfaces when manager_free and
manager_destroy function is called

Hi Minjun,

On Monday 01 June 2009 20:18:23 Li, Minjun wrote:
> Hi Folks,
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common removing and
> unregistering exit function for interfaces when manager_free and
> manager_destroy function is called.

Please use proper coding style when submitting patches.  This means tabs 
instead of spaces, and proper spacing, e.g. 'if () {'  The functions should be 
named appropriately, 'foo_free' just won't work.

Also, only include patches that are specific to the fix, things like mode change 
are extraneous.   And include a proper commit message.

>
> Best Regards,
> Minjun

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono <at> ofono.org
http://lists.ofono.org/listinfo/ofono

Attachment (checkpatch.pl): application/octet-stream, 93 KiB
_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono
Denis Kenzior | 3 Jun 04:43 2009
Picon

Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Tuesday 02 June 2009 20:11:37 Li, Minjun wrote:
> I regenerated the patch again.
> Thank denis for good advice.
>

Applied (with a reworded commit description) and pushed upstream.  Thanks.

> Best Regards,
>
> Minjun

Regards,
-Denis
Li, Minjun | 3 Jun 05:08 2009
Picon

RE: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Hi Martin,
Thanks for your kind help!

Best Regards,

Minjun
-----Original Message-----
From: ofono-bounces <at> ofono.org [mailto:ofono-bounces <at> ofono.org] On Behalf Of Xu, Martin
Sent: 2009年6月3日 10:25
To: ofono <at> ofono.org
Subject: RE: add a common removing and unregistering exit function for interfaces when manager_free and
manager_destroy function is called

Hi Mingjun:
Since it uses the kernel coding style, you can use checkpatch.pl from kernel to check your patch before you
submit it. :)
I have attached the script in my attachment in case you are not familiar with kernel. 

-----Original Message-----
From: ofono-bounces <at> ofono.org [mailto:ofono-bounces <at> ofono.org] On Behalf Of Denis Kenzior
Sent: 2009年6月2日 11:58
To: ofono <at> ofono.org
Subject: Re: add a common removing and unregistering exit function for interfaces when manager_free and
manager_destroy function is called

Hi Minjun,

On Monday 01 June 2009 20:18:23 Li, Minjun wrote:
> Hi Folks,
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common removing and
> unregistering exit function for interfaces when manager_free and
> manager_destroy function is called.

Please use proper coding style when submitting patches.  This means tabs 
instead of spaces, and proper spacing, e.g. 'if () {'  The functions should be 
named appropriately, 'foo_free' just won't work.

Also, only include patches that are specific to the fix, things like mode change 
are extraneous.   And include a proper commit message.

>
> Best Regards,
> Minjun

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono <at> ofono.org
http://lists.ofono.org/listinfo/ofono

_______________________________________________
ofono mailing list
ofono <at> ofono.org
http://lists.ofono.org/listinfo/ofono

Gmane