sudish mukundan sent you a Friend Request on Yaari

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono

Re: sudish mukundan sent you a Friend Request on Yaari

> sudish mukundan wants you to join Yaari!
>

please try to avoid such spam to the mailing list

add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono

Re: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Monday 01 June 2009 20:18:23 Li, Minjun wrote:
> Hi Folks,
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common removing and
> unregistering exit function for interfaces when manager_free and
> manager_destroy function is called.

Please use proper coding style when submitting patches.  This means tabs 
instead of spaces, and proper spacing, e.g. 'if () {'  The functions should be 
named appropriately, 'foo_free' just won't work.

Also, only include patches that are specific to the fix, things like mode change 
are extraneous.   And include a proper commit message.

>
> Best Regards,
> Minjun

Regards,
-Denis

add a common exit function for interfaces when manager_free and manager_destroy function is called

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono

Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Tuesday 02 June 2009 02:02:29 Li, Minjun wrote:
> Hi Folks,
> I regenerated the patch.
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common exit function for
> interfaces when manager_free and manager_destroy function is called.
>

In interface_exit: Please remove if (at)  block, its pointless.

Please get rid of all mode changes, only submit changes to files that are 
relevant to the fix.

Get a proper commit message.  E.g. put the description in the email into the 
commit message.  

> Best Regards,
> Minjun

Regards,
-Denis

RE: add a common exit function for interfaces when manager_free and manager_destroy function is called

I regenerated the patch again.
Thank denis for good advice.

Best Regards,

Minjun
-----Original Message-----
From: Kenzior, Denis 
Sent: 2009年6月3日 6:38
To: ofono <at> ofono.org
Cc: Li, Minjun
Subject: Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Tuesday 02 June 2009 02:02:29 Li, Minjun wrote:
> Hi Folks,
> I regenerated the patch.
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common exit function for
> interfaces when manager_free and manager_destroy function is called.
>

In interface_exit: Please remove if (at)  block, its pointless.

Please get rid of all mode changes, only submit changes to files that are 
relevant to the fix.

Get a proper commit message.  E.g. put the description in the email into the 
commit message.  

> Best Regards,
> Minjun

Regards,
-Denis

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono

RE: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Hi Mingjun:
Since it uses the kernel coding style, you can use checkpatch.pl from kernel to check your patch before you
submit it. :)
I have attached the script in my attachment in case you are not familiar with kernel. 

-----Original Message-----
From: ofono-bounces <at> ofono.org [mailto:ofono-bounces <at> ofono.org] On Behalf Of Denis Kenzior
Sent: 2009年6月2日 11:58
To: ofono <at> ofono.org
Subject: Re: add a common removing and unregistering exit function for interfaces when manager_free and
manager_destroy function is called

Hi Minjun,

On Monday 01 June 2009 20:18:23 Li, Minjun wrote:
> Hi Folks,
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common removing and
> unregistering exit function for interfaces when manager_free and
> manager_destroy function is called.

Please use proper coding style when submitting patches.  This means tabs 
instead of spaces, and proper spacing, e.g. 'if () {'  The functions should be 
named appropriately, 'foo_free' just won't work.

Also, only include patches that are specific to the fix, things like mode change 
are extraneous.   And include a proper commit message.

>
> Best Regards,
> Minjun

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono <at> ofono.org
http://lists.ofono.org/listinfo/ofono

_______________________________________________
ofono mailing list
ofono@...
http://lists.ofono.org/listinfo/ofono

Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Tuesday 02 June 2009 20:11:37 Li, Minjun wrote:
> I regenerated the patch again.
> Thank denis for good advice.
>

Applied (with a reworded commit description) and pushed upstream.  Thanks.

> Best Regards,
>
> Minjun

Regards,
-Denis

RE: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Hi Martin,
Thanks for your kind help!

Best Regards,

Minjun
-----Original Message-----
From: ofono-bounces <at> ofono.org [mailto:ofono-bounces <at> ofono.org] On Behalf Of Xu, Martin
Sent: 2009年6月3日 10:25
To: ofono <at> ofono.org
Subject: RE: add a common removing and unregistering exit function for interfaces when manager_free and
manager_destroy function is called

Hi Mingjun:
Since it uses the kernel coding style, you can use checkpatch.pl from kernel to check your patch before you
submit it. :)
I have attached the script in my attachment in case you are not familiar with kernel. 

-----Original Message-----
From: ofono-bounces <at> ofono.org [mailto:ofono-bounces <at> ofono.org] On Behalf Of Denis Kenzior
Sent: 2009年6月2日 11:58
To: ofono <at> ofono.org
Subject: Re: add a common removing and unregistering exit function for interfaces when manager_free and
manager_destroy function is called

Hi Minjun,

On Monday 01 June 2009 20:18:23 Li, Minjun wrote:
> Hi Folks,
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common removing and
> unregistering exit function for interfaces when manager_free and
> manager_destroy function is called.

Please use proper coding style when submitting patches.  This means tabs 
instead of spaces, and proper spacing, e.g. 'if () {'  The functions should be 
named appropriately, 'foo_free' just won't work.

Also, only include patches that are specific to the fix, things like mode change 
are extraneous.   And include a proper commit message.

>
> Best Regards,
> Minjun

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono <at> ofono.org
http://lists.ofono.org/listinfo/ofono

_______________________________________________
ofono mailing list
ofono <at> ofono.org
http://lists.ofono.org/listinfo/ofono