Marc Helbling | 26 Sep 21:07 2014
Picon

Fix for invalid images in Inventor plugin

Hi Robert,

here is a trivial fix in the Inventor plugin. In one code path, the pointer validity is checked after
dereferencing a pointer that can be null (image->valid()) instead of calling ref_ptr::valid (image.valid()).

Hope this is useful.

Cheers,
Marc

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=61183#61183

Attachments: 
http://forum.openscenegraph.org//files/convertfrominventor_124.cpp
Marc Helbling | 19 Sep 10:48 2014
Picon

MeshOptimizers test for empty arrays

Hi Robert,

I'm submitting a small update in the mesh optimizers code.
I've come across scenes that contains geometries with initialized but empty vertex arrays and primitives
and that would make some optimizers crash.

The submission therefore only contains a test on the size of the vertex array for the
VertexCacheMissVisitor and the VertexAccessOrderVisitor visitors.

Hope this is useful. Thank you!
Cheers,
Marc

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=61091#61091

Attachments: 
http://forum.openscenegraph.org//files/meshoptimizers_582.cpp
Marc Helbling | 15 Sep 14:55 2014
Picon

Add option to disable DrawArrays in TriStripper

Hi,

I'm submitting a patch adding an option to prevent the TriStripper to generate DrawArrays when indices are
"in order". The default behavior still allows to generate DrawArrays to be compliant with current code.

The reason behind this submission is that my application should only work with DrawElements (which might
not be a constraint for everyone so I would understand if this doesn't go into trunk).

Thank you!

Cheers,
Marc

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=61044#61044

Attachments: 
http://forum.openscenegraph.org//files/disabledrawarrays_135.zip
Anish Thomas | 9 Sep 11:56 2014
Picon

Re: added support for etc2/eac compression

Hi Robert,

Can you merge this change to the OpenSceneGraph-3.2 branch?

Thank you!

Cheers,
Anish

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=60982#60982
Sukender | 7 Sep 21:50 2014
Picon

Fix for NodeVisitor

Hi Robert,

Here is a...

"
Fix for NodeVisitor not taking into account Drawables as Nodes.
The main issues I found are that my visitors' methods are not called properly, and that
getParentalNodePaths() returns an empty result when called on a Drawable.
"
Based on master, revision 381c1b73cdd94ef0f81f77ea3fb1ee4c1ae378d9 (SVN trunk <at> 14422)

Cheers,

--

-- 
Sukender
Attachment (NodeVisitor.cpp): text/x-c++src, 5945 bytes
_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Sukender | 25 Aug 14:19 2014
Picon

Fix for 3DS reader

Hi Robert,

Please find attached:
"
Fix for 3DS reader, which may read wrong triangles. Actually, indices may suffer a 'short int' overflow, in
two places.
"

Thank you for merging :)

Not related, but I think :
1. The osg::StateSet::ParentList should now be a vector<Node*> instead of a vector<Object*> (now that
Drawables are Nodes), and

2. NodeVisitor should read:
void NodeVisitor::apply(Geode& node)
{
    apply(static_cast<Group&>(node));
}

instead of;
void NodeVisitor::apply(Geode& node)
{
    apply(static_cast<Node&>(node));
}

...don't you think?

Cheers,

(Continue reading)

Tim George | 23 Aug 00:41 2014

Texture2DArray copy constructor seg faults

Hi,

The Texture2DArray copy constructor Texture2DArray(const Texture2DArray& text,const CopyOp&
copyop) seg faults because the _images vector is not initialized prior to calling setImage. I suggest
that it be changed to call setTextureSize with the new dimensions instead of setting the member variables
directly. That will correctly initialize the _images vector.

Attached is the latest OSG trunk Texture2DArray with the proposed change.

besides adding the call to setTextureSize the line:

_modifiedCount.push_back(ImageModifiedCount());

was also removed because this is also taken care of by the setTextureSize call. _textureDepth was
initialized to 0 so that setTextureSize works correctly.

Thanks,

Tim

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=60742#60742

Attachments: 
http://forum.openscenegraph.org//files/texture2darray_171.cpp
Marc Helbling | 22 Aug 20:53 2014
Picon

Add ambient channel in fbx plugin

Hi,

please find attached a patch adding support for ambient material in the FBX plugin. It's a straightfoward
adaptation of the emissive support and has been tested on a proprietary model.
Hope this is useful!

Thank you!

Best,
Marc

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=60741#60741

Attachments: 
http://forum.openscenegraph.org//files/fbx_ambient_514.zip
Clément Bœsch | 13 Aug 14:24 2014

Fix remaining bit of Giflib5 usage

Hi,

Following [1], I'm attaching the src/osgPlugins/gif/ReaderWriterGIF.cpp
file updated with the following diff:

diff --git a/src/osgPlugins/gif/ReaderWriterGIF.cpp b/src/osgPlugins/gif/ReaderWriterGI
index b7f228d..ac89f8e 100644
--- a/src/osgPlugins/gif/ReaderWriterGIF.cpp
+++ b/src/osgPlugins/gif/ReaderWriterGIF.cpp
 <at>  <at>  -561,7 +561,11  <at>  <at>  GifImageStream** obj)
     *width_ret = giffile->SWidth;
     *height_ret = giffile->SHeight;
     *numComponents_ret = 4;
+#if (GIFLIB_MAJOR >= 5)
+    DGifCloseFile(giffile, &Error);
+#else
     DGifCloseFile(giffile);
+#endif
     return buffer;
 }

This is in the continuation of a previous commit (37b8ad60 on the git mirror,
not sure about the related SVN revision) and is required to allow the file to
compile.

I hope I'm following the correct way of submitting patches, although that's
kind of problematic for patches that typically need to move or delete files.

I saw some merge requests on the Github: this could simplify a lot the
workflow, is that OK to use it instead of submitting files here?
(Continue reading)

Wang Rui | 10 Aug 03:27 2014
Picon

Support glVertexAttribDivisor() in osg::Geometry

Hi Robert,

I've just updated the Array/Geometry classes to support glVertexAttribDivisor(), in which the only change to user interface is a new GLint argument to Geometry::setVertexAttribArray(), which is -1 by default (indicating it is disabled). I also update the osgdrawinstanced example to show how it works with instanced geometry.

Cheers,

Wang Rui

_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Wang Rui | 9 Aug 18:51 2014
Picon

Separated blending for multiple rendering targets

Hi Robert,

I've just implemented part of the GL_EXT_draw_buffers2 extension in osg::BlendFunc, which is necessary especially for deferred shading use. It enables developers to decide which of the multiple rendering targets (MRT) can be affected by blending function. Those targets disabling blending are always treated as to save extra geometry attributes in all 4 channels rather than opacity.

This submissions is originated from the following topic in the mail list:

And about the extension:

A new osgblenddrawbuffers example is also submitted to show the importance and usage of the new functionalities.

Cheers,

Wang Rui

_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Gmane