Sukender | 25 Aug 14:19 2014
Picon

Fix for 3DS reader

Hi Robert,

Please find attached:
"
Fix for 3DS reader, which may read wrong triangles. Actually, indices may suffer a 'short int' overflow, in
two places.
"

Thank you for merging :)

Not related, but I think :
1. The osg::StateSet::ParentList should now be a vector<Node*> instead of a vector<Object*> (now that
Drawables are Nodes), and

2. NodeVisitor should read:
void NodeVisitor::apply(Geode& node)
{
    apply(static_cast<Group&>(node));
}

instead of;
void NodeVisitor::apply(Geode& node)
{
    apply(static_cast<Node&>(node));
}

...don't you think?

Cheers,

(Continue reading)

Tim George | 23 Aug 00:41 2014

Texture2DArray copy constructor seg faults

Hi,

The Texture2DArray copy constructor Texture2DArray(const Texture2DArray& text,const CopyOp&
copyop) seg faults because the _images vector is not initialized prior to calling setImage. I suggest
that it be changed to call setTextureSize with the new dimensions instead of setting the member variables
directly. That will correctly initialize the _images vector.

Attached is the latest OSG trunk Texture2DArray with the proposed change.

besides adding the call to setTextureSize the line:

_modifiedCount.push_back(ImageModifiedCount());

was also removed because this is also taken care of by the setTextureSize call. _textureDepth was
initialized to 0 so that setTextureSize works correctly.

Thanks,

Tim

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=60742#60742

Attachments: 
http://forum.openscenegraph.org//files/texture2darray_171.cpp
Marc Helbling | 22 Aug 20:53 2014
Picon

Add ambient channel in fbx plugin

Hi,

please find attached a patch adding support for ambient material in the FBX plugin. It's a straightfoward
adaptation of the emissive support and has been tested on a proprietary model.
Hope this is useful!

Thank you!

Best,
Marc

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=60741#60741

Attachments: 
http://forum.openscenegraph.org//files/fbx_ambient_514.zip
Clément Bœsch | 13 Aug 14:24 2014

Fix remaining bit of Giflib5 usage

Hi,

Following [1], I'm attaching the src/osgPlugins/gif/ReaderWriterGIF.cpp
file updated with the following diff:

diff --git a/src/osgPlugins/gif/ReaderWriterGIF.cpp b/src/osgPlugins/gif/ReaderWriterGI
index b7f228d..ac89f8e 100644
--- a/src/osgPlugins/gif/ReaderWriterGIF.cpp
+++ b/src/osgPlugins/gif/ReaderWriterGIF.cpp
 <at>  <at>  -561,7 +561,11  <at>  <at>  GifImageStream** obj)
     *width_ret = giffile->SWidth;
     *height_ret = giffile->SHeight;
     *numComponents_ret = 4;
+#if (GIFLIB_MAJOR >= 5)
+    DGifCloseFile(giffile, &Error);
+#else
     DGifCloseFile(giffile);
+#endif
     return buffer;
 }

This is in the continuation of a previous commit (37b8ad60 on the git mirror,
not sure about the related SVN revision) and is required to allow the file to
compile.

I hope I'm following the correct way of submitting patches, although that's
kind of problematic for patches that typically need to move or delete files.

I saw some merge requests on the Github: this could simplify a lot the
workflow, is that OK to use it instead of submitting files here?
(Continue reading)

Wang Rui | 10 Aug 03:27 2014
Picon

Support glVertexAttribDivisor() in osg::Geometry

Hi Robert,

I've just updated the Array/Geometry classes to support glVertexAttribDivisor(), in which the only change to user interface is a new GLint argument to Geometry::setVertexAttribArray(), which is -1 by default (indicating it is disabled). I also update the osgdrawinstanced example to show how it works with instanced geometry.

Cheers,

Wang Rui

_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Wang Rui | 9 Aug 18:51 2014
Picon

Separated blending for multiple rendering targets

Hi Robert,

I've just implemented part of the GL_EXT_draw_buffers2 extension in osg::BlendFunc, which is necessary especially for deferred shading use. It enables developers to decide which of the multiple rendering targets (MRT) can be affected by blending function. Those targets disabling blending are always treated as to save extra geometry attributes in all 4 channels rather than opacity.

This submissions is originated from the following topic in the mail list:

And about the extension:

A new osgblenddrawbuffers example is also submitted to show the importance and usage of the new functionalities.

Cheers,

Wang Rui

_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Wang Rui | 9 Aug 16:02 2014
Picon

Improvements of osgQt library

Hi Robert,

The submission includes some fixes for osgQt library and osgQtWidgets example: (1) QTextEdit now works with mouse/drag events, (2) scrollbars will change when OSG window is resizing, (3) improve rendering efficiency of QGraphicsViewAdapter so that it works with complex Qt UI, (4) add new setBackgroundWidget() method to indicate a 'background widget', which will ignore mouse/key events on it and pass them to the 3D scene.

Cheers,

Wang Rui

Attachment (osgqt_submissions.zip): application/zip, 35 KiB
_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Thomas Geymayer | 9 Aug 15:20 2014
Picon

Fix for crash in Texture.cpp: assumeSizedInternalFormat

Hi,

attached is a fixed version of Texture.cpp. assumeSizedInternalFormat
has contained an infinite loop and iterated over a too large range.

Regards,
Tom

--

-- 
Thomas Geymayer  www.tomprogs.at / C-Forum und Tutorial: www.proggen.org
------------------------------------------------------------------------
Institute for Computer Graphics and Vision/Graz University of Technology
------------------------------- Austria --------------------------------
Attachment (Texture.cpp): text/x-c++src, 113 KiB
_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Glenn Waldron | 8 Aug 16:48 2014
Picon

Node: patch for remove*Callback() methods to resolve a crash

Robert,

A couple of customers were getting crashes in Node::removeUpdateCallback. This was fixed by updating the 3 remove methods in Node to match the pattern used in Callback::removeNestedCallback. 

I don't have a reproduction case handy; I am submitting this on behalf of other users. If you need something further or have any questions let me know. Thanks.

This change is made against today's trunk (8-8-2014).

Glenn Waldron / <at> glennwaldron
Attachment (Node): application/octet-stream, 31 KiB
_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Robert Osfield | 3 Aug 19:00 2014
Picon

Test message

Test of whether Dreamhost mailing lists are still functioning.
_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Marc Helbling | 31 Jul 18:58 2014
Picon

Fix shared arrays in VertexAccessOrderVisitor

Hi Robert,

please find a fix for the vertex pretransform visitor (VertexAccessOrderVisitor).
The issue with current code is that arrays are collected *before* duplicating shared arrays which leads to arrays that are correctly duplicated but that are not reordered.

Also the submitted patch contains a small cleaning in GeometryArrayGathrer as the _useDrawElements variable is not used; it is only set in the GeometryArrayGathrer constructor and VertexAccessOrderVisitor already checks that primitives have indexed type.

Best,
Marc
Attachment (MeshOptimizers.cpp): text/x-c++src, 47 KiB
_______________________________________________
osg-submissions mailing list
osg-submissions@...
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Gmane