GTK version, promotion popup
h.g. muller <h.g.muller <at> hccnet.nl>
2009-09-04 08:20:10 GMT
At 23:49 3-9-2009 -0700, Arun Persaud wrote:
>The GTK version also still crashes, for example when promoting a pawn,
>since the promotion-window is not been ported to GTK and the old X-code
>will now create a crash...
Getting rid of the promotion popup altogether is on my to-do list,
so perhaps you should not bother porting the old dialog. One of
the very annoying things about the XBoard promotion popup is
that it is shown even for moves that are already known to be illegal.
Try for instance to play e2d8 from the opening setup. When legality
testing is on, it first shows te promotion popup to make you select
a piece, and no matter what you choose, the move is then rejected
as illegal later. In WinBoard I fixed this, but not yet in XBoard.
Especially in Shogi, where moving any piece type in or out of a rather
deep promotion zone could cause a promotion, this behavior was very
annoying. (For normal Chess you are of course not very likely to draw
Pawns to the last rank by accident.)
But what is even more annoying is that the promotion popup is not
variant-proof. Not all of the 22 piece types can appear in the promotion
menu, although it is patched a little to work in the most common variants
(e.g. in giveaway you can promote to King, and in Gothic to Archbishop
and Chancelor, while in Shogi you can select Yes/No.)
Another problem is that currently internationalization is broken in the
promotion popup: It uses the first letter of the name on the button as
a piece indicator (except for Knight), so if yo change the button labels,
you would get invalid choices unless you would also adapt the
pieceToChar table to the language. (Which is in general undesirable,
as it would preclude you from reading international PGN.)
(Continue reading)