Well, there aren't any patches to count down, so I hope warmer weather approaches where you are, with sailing, soccer, canoing and much spoiling of grand-nippers to follow! Cheers, Colin -- -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- )
In the hope that it might help others, see attached diary of my work building a Lilypond release with GUB, making a trivial edit, pushing the changes to github, and submitting a pull request to Graham. Cheers, Colin. -- Colin Hall
On Fri, Jun 01, 2012 at 12:56:33PM +0100, Colin Hall wrote: > In the hope that it might help others, see attached diary of my > work building a Lilypond release with GUB, making a trivial > edit, pushing the changes to github, and submitting a pull > request to Graham. Wow! I only gave it a quick skim so far, but this looks like an *incredible* resource. Beginners or near-beginners can check through your commands and compare them to what they've done, while more advanced developers can make suggestions to either your workflow or identify problems in the code or docs. I strongly suggest that everybody read this, even if you have absolutely no interest in GUB. If everybody kept records like this, we could help each other so much more. (I'll try a longer read of the diary this evening) - Graham
On Fri, Jun 01, 2012 at 12:56:33PM +0100, Colin Hall wrote: > > In the hope that it might help others, see attached diary of my work building a Lilypond release with GUB, making a trivial edit, pushing the changes to github, and submitting a pull request to Graham. Ok, some more detailed reading, plus a few notes which I'm pretty certain that you already know but I want to make sure that there's no confusion about this (from you or anybody else reading it). - Installing Regtests into LilyDev and Sat Afternoon Session I believe that the perl+tar problems are fixed on my version of gub. It would be really nice if we could identify+fix any links to Jan's version, to avoid other people getting caught by this trap. - random note: a few times I've done ctrl-z to "background" a GUB build, then "fg %1" to resume the build. It seems quite happy with that, so this is a handy way to do something else CPU-intensive for a few minutes in the middle of a four-hour GUB build. - Is this build on x86 or 64 ? I have a vague recollection of it failing for me on 64, but that may have simply been because I was using a different linux distribution at the time. - after taking a break, it would be great if you could reproduce these steps on a different (newer?) linux distribution. We don't want to be stuck on ubuntu 10.04 forever, and there's known problems with (some) later ubuntu versions. Now that you have your feet wet, you're ideally suited to working on those(Continue reading)
Mostly LGTM. Better idea than putting the stuff in a doc-string for a \placeholder function people would hardly ever use. If you really don't like the extra <at> cindex that's fine. The other changes are just stylistic things so the English reads with a better flow. Cheers, Ian http://codereview.appspot.com/6248080/diff/6001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6248080/diff/6001/Documentation/notation/simultaneous.itely#newcode82 Documentation/notation/simultaneous.itely:82: <at> cindex placeholder events http://codereview.appspot.com/6248080/diff/6001/Documentation/notation/simultaneous.itely#newcode83 Documentation/notation/simultaneous.itely:83: A chord acts merely as container for the notes inside and ornamentations "A chord merely acts as a container for notes inside it and and allows articulations or ornaments to be added consistently to all notes inside." http://codereview.appspot.com/6248080/diff/6001/Documentation/notation/simultaneous.itely#newcode84 Documentation/notation/simultaneous.itely:84: added to it. As one consequence, a chord without notes inside does not "As a consequence, a ..."(Continue reading)
On Fri, Jun 1, 2012 at 2:25 PM, Graham Percival <graham <at> percival-music.ca> wrote: > On Fri, Jun 01, 2012 at 12:56:33PM +0100, Colin Hall wrote: >> In the hope that it might help others, see attached diary of my >> work building a Lilypond release with GUB, making a trivial >> edit, pushing the changes to github, and submitting a pull >> request to Graham. > > Wow! I only gave it a quick skim so far, but this looks like an > *incredible* resource. +1 > I strongly suggest that everybody read this, even if you have > absolutely no interest in GUB. done. > If everybody kept records like > this, we could help each other so much more. Good idea. Thanks, Colin! Janek _______________________________________________ lilypond-devel mailing list lilypond-devel <at> gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel(Continue reading)
Reviewers: Ian Hulin (gmail), http://codereview.appspot.com/6248080/diff/6001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6248080/diff/6001/Documentation/notation/simultaneous.itely#newcode82 Documentation/notation/simultaneous.itely:82: On 2012/06/01 17:08:19, Ian Hulin (gmail) wrote: > <at> cindex placeholder events I have my doubts that people will think of that keyword, but I don't have a better candidate. http://codereview.appspot.com/6248080/diff/6001/Documentation/notation/simultaneous.itely#newcode83 Documentation/notation/simultaneous.itely:83: A chord acts merely as container for the notes inside and ornamentations On 2012/06/01 17:08:19, Ian Hulin (gmail) wrote: > "A chord merely acts as a container for notes inside it and and allows > articulations or ornaments to be added consistently to all notes inside." No, that would be wrong. <a-1 c-1 e-1> is different from <a c e>-1 and <a\p c\p e\p> is different from <a c e>\p http://codereview.appspot.com/6248080/diff/6001/Documentation/notation/simultaneous.itely#newcode84 Documentation/notation/simultaneous.itely:84: added to it. As one consequence, a chord without notes inside does not On 2012/06/01 17:08:19, Ian Hulin (gmail) wrote: > "As a consequence, a ..."(Continue reading)
Here's the plan so far for this month. The beginning is delayed due to the amount of work and volunteer availability. Unless otherwise specified, each discussion will set the policy for the next year. If there's something you feel strongly about but are unable to discuss at the scheduled time, let me know and we'll reschedule it. As before, the initial discussion will be started, then a week later we'll have a tentative policy, then another week later we'll have a firm policy as long as there's no great disagreement. 2012 June 13: lilypond is GNU software. The fact that we belong to GNU is not open to debate, but we should clarify our obligations. In the past we haven't paid a great deal of attention to those, but given certain recent events I think this should change. I estimate it will take 10-50 hours to meet the requirements of GNU packages. This discussion will consist of itemizing what needs to be done and ideally also gather volunteers to do this work. 2012 June 20: release policy. The ever-popular debate about when we should have stable releases. I have a radical proposal which would eliminate a great deal of uncertainty after a one-time cost of about 100 hours of work from semi-skilled contributors. This discussion will only effect lilypond 2.18 and up; 2.16 will be released (or not) under the current policy. 2012 June 27: source code formatting. Hopefully this will go smoother than previous discussions; this(Continue reading)
LGTM, apart from one nitpick http://codereview.appspot.com/6248080/diff/11001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6248080/diff/11001/Documentation/notation/simultaneous.itely#newcode89 Documentation/notation/simultaneous.itely:89: (for more possibilities, <at> pxref{Simultaneous expressions}): For consistency, please use <at> ref{} in the NR http://codereview.appspot.com/6248080/
The issue was that s1*0 can affect the default duration of the next note, while <> does not, but the solution of <> was tempered by opinions that <> is cryptic. s1*0 is rarely used. The uses I find, in documentation and mutopiaproject, are to attach a post-fix notation to an object where it is inconvenient or impossible to postfix the notation. This patch fails to explain how <> solves the difficulty for with people have used s1*0. Instead, it demonstrates the considerable leeway to transform clear input to cryptic input, without changing the resulting output. http://codereview.appspot.com/6248080/diff/11001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6248080/diff/11001/Documentation/notation/simultaneous.itely#newcode86 Documentation/notation/simultaneous.itely:86: duration but can still be useful for attaching articulations. The text implies that <> is useful for placing articulations where there are no notes, such as a delayed turn, \relative c'' \new Staff {g2. <>\turn a4} but <> is not useful here, since we need parallel spacer rests anyway, \relative c'' \new Staff<<{g2. a4} {s2 s2\turn}>> http://codereview.appspot.com/6248080/
RSS Feed176 | |
|---|---|
232 | |
467 | |
586 | |
364 | |
337 | |
380 | |
337 | |
834 | |
1175 | |
876 | |
905 | |
579 | |
568 | |
589 | |
688 | |
825 | |
1049 | |
727 | |
784 | |
635 | |
1148 | |
1282 | |
1306 | |
840 | |
454 | |
508 | |
643 | |
752 | |
772 | |
733 | |
676 | |
654 | |
399 | |
350 | |
424 | |
471 | |
583 | |
497 | |
444 | |
414 | |
629 | |
892 | |
715 | |
300 | |
651 | |
1078 | |
986 | |
685 | |
539 | |
368 | |
380 | |
337 | |
468 | |
734 | |
417 | |
382 | |
469 | |
531 | |
399 | |
287 | |
367 | |
327 | |
249 | |
211 | |
239 | |
227 | |
213 | |
238 | |
446 | |
190 | |
140 | |
93 | |
88 | |
163 | |
156 | |
258 | |
526 | |
428 | |
297 | |
231 | |
164 | |
159 | |
167 | |
384 | |
436 | |
420 | |
299 | |
313 | |
185 | |
138 | |
126 | |
193 | |
145 | |
369 | |
243 | |
340 | |
367 | |
321 | |
286 | |
362 | |
280 | |
177 | |
354 | |
274 | |
357 | |
223 | |
206 | |
123 | |
191 | |
213 | |
359 | |
257 | |
226 | |
42 | |
44 | |
47 | |
153 | |
141 | |
133 | |
109 | |
72 | |
49 | |
20 | |
11 | |
34 | |
101 | |
56 | |
89 | |
207 | |
226 | |
199 | |
186 | |
148 | |
149 | |
49 |
