headers
David Kastrup | 1 Dec 2011 01:29
X-Face
Picon
Picon

Re: Trashy Novels

<olafBuddenhagen <at> gmx.net> writes:

> Hi,
>
> On Wed, Sep 21, 2011 at 11:18:40PM +0100, Graham Percival wrote:
>
>> Think of the question in marriage ceremonies: "if anybody knows of a
>> reason why these two should not be wed, speak now or forever hold your
>> peace.".
>> 
>> Despite what one reads[1] in trashy romance novels, that question is
>> mostly ceremonial -- nobody actually expects an objection.
>
> Trashy? Well, YMMV -- but "Jane Eyre" is firmly planted as one of the
> two most famous English novels :-)

Huh?  Obviously "Wuthering Heights" would be one of those you'd consider
more famous (runs in the family), but I don't think "Jane Eyre" can hold
a candle regarding famosity to a number of novels, like "Vanity Fair",
"Oliver Twist", "The Picture of Dorian Grey", "Pride and Prejudice" and
so forth and so on.  Even "Frankenstein" would likely ring a bell with
more people than "Jane Eyre".

--

-- 
David Kastrup
Permalink | Reply | 1 comment |
headers
k-ohara5a5a | 1 Dec 2011 01:32

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

On Wed, 30 Nov 2011 13:30:16 -0800, <Carl.D.Sorensen <at> gmail.com> wrote:

> Looks good to me, but I want to be sure that both Keith and Mike agree
> that this is what ought to be applied, so we don't have two
> non-compatible solutions fighting with each other.

No problem there; Mike incorporated my 2-line patch into this.
I want that 2-line fix to be a separate commit, because it does what the
original bug report wanted, by restoring the intent of the original
code.

The full patch no longer does any harm, but I do not like the idea of
having every Hairpin search through every other element on the page to
find fellow Hairpins and ask them about their neighbors.  We hardware
folk have spoiled you software guys with fast computers.

I also want a way to turn off the new feature.

http://codereview.appspot.com/5438060/diff/4006/lily/hairpin.cc
File lily/hairpin.cc (right):

http://codereview.appspot.com/5438060/diff/4006/lily/hairpin.cc#newcode245
lily/hairpin.cc:245: for (vsize i = 0; i < vertical_axis_groups.size ();
i++)
For each hairpin, say an orchestral score, this loops over about 10-15
staves

http://codereview.appspot.com/5438060/diff/4006/lily/hairpin.cc#newcode248
lily/hairpin.cc:248: for (vsize j = 0; j < vag_elts.size (); j++)
then for each staff this loops over about 100 elements
(Continue reading)

Permalink | Reply | 0 comments |
headers
Reinhold Kainhofer | 1 Dec 2011 01:55
Favicon
Gravatar

Re: GOP-PROP 13: patch management tools

On 2011-11-30 23:27, olafBuddenhagen <at> gmx.net wrote:
> Having participated in or followed a number of free software projects
> (both GNU and other) over the years, I don't know of *any* besides
> LilyPond that uses a dedicated patch review tool. (Including the very
> largest ones, such as Linux or GCC.) Reviews are done almost exclusively
> by email -- and quite frankly, I don't see why anything else would be
> preferred for the actual review. The only problem is tracking the status
> of patches *afterwards*...

KDE uses reviewboard... Until a few years ago, patch reviews were only 
done for patches by newcomers, and that went over the mailing lists. But 
now more and more features are reviewed on reviewboard.

Cheers,
Reinhold

--

-- 
------------------------------------------------------------------
Reinhold Kainhofer, reinhold <at> kainhofer.com, http://reinhold.kainhofer.com/
  * Financial&  Actuarial Math., Vienna Univ. of Technology, Austria
  * http://www.fam.tuwien.ac.at/, DVR: 0005886
  * LilyPond, Music typesetting, http://www.lilypond.org
Permalink | Reply | 1 comment |
headers
Alex Austin | 1 Dec 2011 05:28
Picon

Re: GOP-PROP 13: patch management tools

Openocd has been using gerrit for a month now. You can go to openocd.zylin.com to see how it's being used, and read the HACKING file in the source tree to see how it should be used.

On Nov 30, 2011 5:52 PM, <olafBuddenhagen <at> gmx.net> wrote:
Hi,

On Thu, Sep 22, 2011 at 11:23:10AM +0200, mike <at> apollinemike.com wrote:

> I don't know anything about open source projects outside of LilyPond,
> but could someone branched into other GNU projects perhaps collect
> this sort of info?

Having participated in or followed a number of free software projects
(both GNU and other) over the years, I don't know of *any* besides
LilyPond that uses a dedicated patch review tool. (Including the very
largest ones, such as Linux or GCC.) Reviews are done almost exclusively
by email -- and quite frankly, I don't see why anything else would be
preferred for the actual review. The only problem is tracking the status
of patches *afterwards*...

(Most projects also have some kind of issue tracker; and some use these
for patch reviews occasionally -- but they are generally unloved, as
they usually don't interact well with mailing lists...)

The sanest option seems to be http://ozlabs.org/~jk/projects/patchwork/

  Patchwork is a web-based patch tracking system designed to facilitate
  the contribution and management of contributions to an open-source
  project.

  Patches that have been sent to a mailing list are 'caught' by the
  system, and appear on a web page. Any comments posted that reference
  the patch are appended to the patch page too.

  The project's maintainer can then scan through the list of patches,
  marking each with a certain state, such as Accepted, Rejected or
  Under Review. Old patches can be sent to the archive or deleted.

This doesn't address general issue tracker integration. that is a much
more complex problem: while patches can be discovered automatically, and
only need manual status updates, general issue tracking always requires
explicit classification. Although some issue trackers (such as debbugs,
RT, or nowadays even bugzilla) can be operated through email, this
doesn't mean they integrate with mailing lists seamlessly.

Obviously nobody has found the silver bullet yet :-) (And certainly not
for the lack of trying... This discussion comes up repeatedly in pretty
much every project I know.)

-antrik-

_______________________________________________
lilypond-devel mailing list
lilypond-devel <at> gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
_______________________________________________
lilypond-devel mailing list
lilypond-devel <at> gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Permalink | Reply | 0 comments |
headers
pkx166h | 1 Dec 2011 18:30
Picon

Re: item.cc: make is_non_musical() conform to its name (issue 5373048)

Passes Make and I get no reg test diffs.

James

http://codereview.appspot.com/5373048/
Permalink | Reply | 0 comments |
headers
pkx166h | 1 Dec 2011 18:38
Picon

Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

Passes make and make check

James

http://codereview.appspot.com/5440049/
Permalink | Reply | 0 comments |
headers
pkx166h | 1 Dec 2011 18:47
Picon

Prevents Slur vs Dots collisions. (issue 5434087)

Passes Make and make check

James

http://codereview.appspot.com/5434087/
Permalink | Reply | 0 comments |
headers
pkx166h | 1 Dec 2011 18:50
Picon

Re: Use new scm markup facility defs scheme module (issue 5451058)

Passes make but make check fails:

--snip---

Writing snippets...
Processing...
Running lilypond...GNU LilyPond 2.15.21
<unnamed port>: In procedure scm-error in expression (scm-error (quote
misc-error) #f ...):
<unnamed port>: no code for module (scm markup-facility-defs)
command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I
/home/jlowe/lilypond-git/input/regression/ -I ./out-test -I
/home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation
-I /home/jlowe/lilypond-git/Documentation/snippets -I
/home/jlowe/lilypond-git/input/regression/ -I
/home/jlowe/lilypond-git/Documentation/included/ -I
/home/jlowe/lilypond-git/build/mf/out/ -I
/home/jlowe/lilypond-git/build/mf/out/ -I
/home/jlowe/lilypond-git/Documentation/pictures -I
/home/jlowe/lilypond-git/build/Documentation/pictures/./out-test
-dbackend=eps --formats=ps -djob-count=7 -dseparate-log-files
-dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I
/home/jlowe/lilypond-git/Documentation/included/ -ddump-profile
-dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I
"/home/jlowe/lilypond-git/build/out/lybook-testdb"  -I
"/home/jlowe/lilypond-git/build/input/regression"  -I
"/home/jlowe/lilypond-git/input/regression"  -I
"/home/jlowe/lilypond-git/build/input/regression/out-test"  -I
"/home/jlowe/lilypond-git/input"  -I
"/home/jlowe/lilypond-git/Documentation"  -I
"/home/jlowe/lilypond-git/Documentation/snippets"  -I
"/home/jlowe/lilypond-git/input/regression"  -I
"/home/jlowe/lilypond-git/Documentation/included"  -I
"/home/jlowe/lilypond-git/build/mf/out"  -I
"/home/jlowe/lilypond-git/build/mf/out"  -I
"/home/jlowe/lilypond-git/Documentation/pictures"  -I
"/home/jlowe/lilypond-git/build/Documentation/pictures/out-test"
--formats=eps  -deps-box-padding=3.000000  -dread-file-list
-dno-strip-output-dir
"/home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names--1023650345.ly"
Child returned 1
make[2]: *** [out-test/collated-files.texi] Error 1
make[2]: Leaving directory
`/home/jlowe/lilypond-git/build/input/regression'
make[1]: *** [local-test] Error 2
make[1]: Leaving directory
`/home/jlowe/lilypond-git/build/input/regression'
make: *** [test] Error 2
jlowe <at> jlowe-lilybuntu2:~/lilypond-git/build$

--snip--

James

http://codereview.appspot.com/5451058/
Permalink | Reply | 0 comments |
headers
pkx166h | 1 Dec 2011 18:53
Picon

Re: Adds padding between Hairpins and SpanBars. (issue 5438060)

Fails make

--snip--

  [/home/jlowe/lilypond-git/ly/context-mods-init.ly]
   [/home/jlowe/lilypond-git/ly/engraver-init.ly]]
  [/home/jlowe/lilypond-git/ly/generate-documentation.ly
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/documentation-lib.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/lily-sort.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-functions.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-translation.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-music.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-type-predicates.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-context-mods.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-backend.scm
fatal error: define-grob-properties.scm: cannot find interface for
property: span-bar-padding
make[1]: *** [out/internals.texi] Error 1
make[1]: Leaving directory
`/home/jlowe/lilypond-git/build/Documentation'
make: *** [all] Error 2
jlowe <at> jlowe-lilybuntu2:~/lilypond-git/build$

--snip--

James

http://codereview.appspot.com/5438060/
Permalink | Reply | 0 comments |
headers
pkx166h | 1 Dec 2011 18:59
Picon

Prevents accidentals from hanging over barlines. (issue 5449055)

Passes make and make check results here:

http://code.google.com/p/lilypond/issues/detail?id=2066#c1

James

http://codereview.appspot.com/5449055/
Permalink | Reply | 0 comments |

Gmane