pkx166h | 20 Apr 18:31 2015
Picon

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx166h <at> gmail.com)


https://codereview.appspot.com/120480043/diff/240001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

https://codereview.appspot.com/120480043/diff/240001/Documentation/notation/input.itely#newcode2674
Documentation/notation/input.itely:2674: * Controlling MIDI dynamics::
On 2014/12/28 23:40:30, Trevor Daniels wrote:
> I would put these in the order:
>    The MIDI block
>    Controlling MIDI dynamics
>    MIDI instruments (taken from Enhancing MIDI output)
>    Using repeats with MIDI
>    Enhancing MIDI output (just the articulate script)

Done.

https://codereview.appspot.com/120480043/diff/240001/Documentation/notation/input.itely#newcode2732
Documentation/notation/input.itely:2732: accent, marcato and portato.
On 2014/12/28 23:40:29, Trevor Daniels wrote:
> We need a proper list here showing clearly what is supported, so users
new to
> midi output can see at the outset what it can do for them.  I asked
for this
> early in October ("The clear statement currently shown in NR 3.5.3
should be
> reinstated somehow, and reflected accurately in the text.") but I
don't see it
> anywhere yet.  The basic facilities can then be compared with the
enhancements
> provided by the articulate script to see if that is going to be
(Continue reading)

Jose E. Marchesi | 20 Apr 13:21 2015
Picon

Re: [Jose E. Marchesi] [IMPORTANT] Accepting student applications


Reminder: we are still missing accepted proposals for the following projects.

mediagoblin (1)
GNUstep (1)
GNUnet (2)
lilypond (2)
wget (3)

Please send us the requested information below before Wednesday 22 April
at 12:00.  Thanks.

    FYI, we got 18 slots in Google Summer of Code this year.

    From: jemarch <at> gnu.org (Jose E. Marchesi)
    Subject: [IMPORTANT] Accepting student applications
    To: summer-of-code <at> gnu.org
    Date: Wed, 15 Apr 2015 20:43:59 +0200 (4 days, 16 hours, 32 minutes ago)

    
    Hi hackers.

    Good news: this year we got as many slots as we asked for.  This means
    that everyone gets their desired slots:

    | Project     | Slots |
    |-------------+-------|
    | gnucap      |     0 |
    | kawa        |     0 |
    | classpath   |     0 |
(Continue reading)

Dan Eble | 19 Apr 14:24 2015
Picon

Re: Issue 4345 in lilypond: Patch: Part combiner: allow a2 chords

> Comment #7 on issue 4345 by kristofbastiaensen: Patch: Part combiner: allow a2 chords
> https://code.google.com/p/lilypond/issues/detail?id=4345
> 
> I've put up my code on github: https://github.com/kuribas/part-combiner
> 
> I honestly don't understand why they kept the broken part combiner…

Kristof,

Thanks for publicizing that.  I haven’t reviewed your code, but I notice that there are no examples.  I
speak only as a contributor, but I expect that people would probably be more motivated to consider your
algorithm if you provided examples that show how your implementation improves on Lilypond's.  These
examples could then become regression tests once the failures are corrected.

Accepting a major rewrite that changes the default output significantly is probably not going to happen
because of the effect it will have on existing scores, but it seems likely that we could create a friendier
way to select the part-analysis algorithm to use and include alternatives similar to the way there are
alternative page-breaking algorithms.
— 
Dan

_______________________________________________
lilypond-devel mailing list
lilypond-devel <at> gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
pkx166h | 18 Apr 10:46 2015
Picon

Remove cygwin_conv_to_posix_path (issue 227200043 by trueroad <at> gmail.com)

Patch on countdown for April 21st

https://codereview.appspot.com/227200043/
pkx166h | 18 Apr 10:45 2015
Picon

Set CFLAGS and LDFLAGS to build python modules (issue 227850044 by trueroad <at> gmail.com)

Patch on countdown for April 21st

https://codereview.appspot.com/227850044/
nine.fierce.ballads | 18 Apr 05:40 2015
Picon

Part combiner: move direction handling out of iterator (issue 226430043 by nine.fierce.ballads <at> gmail.com)

Reviewers: ,

Description:
Part combiner: move direction handling out of iterator

Please review this at https://codereview.appspot.com/226430043/

Affected files (+18, -67 lines):
   M lily/part-combine-iterator.cc
   M ly/music-functions-init.ly
   M scm/part-combiner.scm

Index: lily/part-combine-iterator.cc
diff --git a/lily/part-combine-iterator.cc b/lily/part-combine-iterator.cc
index  
2428d4a70fb41f26bfcbce5cd0e8dcb07c1a818f..653e338a91c9faaedba2dae3e784c98b1a0da2a0  
100644
--- a/lily/part-combine-iterator.cc
+++ b/lily/part-combine-iterator.cc
 <at>  <at>  -65,11 +65,6  <at>  <at>  private:
    Moment start_moment_;

    SCM split_list_;
-  SCM direction_;
-  SCM directionOne_;
-  SCM directionTwo_;
-  SCM horizontalShiftOne_;
-  SCM horizontalShiftTwo_;

    Stream_event *unisono_event_;
(Continue reading)

tdanielsmusic | 17 Apr 23:03 2015

Re: Issue 3799: New satb.ly built-in template and template framework (issue 225860043 by tdanielsmusic <at> googlemail.com)

Patch set 2 contains a number of code improvements as well as four
regression tests and a (minimal) change to the documentation.  The main
changes from patch set 1 are:

- There is now a distinction between Women/Men music variables in their
own right and WomenDivided/MenDivided variables which are used when
modifying the instrument names and midi instruments associated with the
two-voice staves.

- There is a distinction between prefixes and names which are hardwired
into the code, such as InstrumentName, Music, TwoVoicesPerStaff, etc and
those which may be modified or extended by the template.  The latter are
defined in the template itself, the former in base-tkit.ly.

I have not in this patch taken up Dan's suggestion to make a
score-building function, mainly because I have not yet found a way of
doing this to my satisfaction.  I'd like this now to be considered as a
candidate for updating the code base.

Trevor

https://codereview.appspot.com/225860043/
Thomas Morley | 16 Apr 00:50 2015
Picon

display-scheme-music not working inside markup-command-definition?

Hi,

exploring chordnaming further, I thought it might be nice, if a
formating procedures for ChordNames could be used in a markup-command
outputting equal designed chord-names.

Though, looks like I have a problem:

#(display-scheme-music #{ \chordmode { c:m } #})
works ofcourse.

But for

#(define-markup-command (foo parser location)()
  (display-scheme-music #{ \chordmode { c:m } #})
  (interpret-markup parser location "xy"))

\markup \foo

I get this:

Preprocessing graphical
objects.../home/harm/lilypond-git/build/out/share/lilypond/current/scm/parser-ly-from-scheme.scm:70:21:
In procedure ly:parser-clone in expression (ly:parser-clone parser
closures ...):
/home/harm/lilypond-git/build/out/share/lilypond/current/scm/parser-ly-from-scheme.scm:70:21:
Wrong type argument in position 1 (expecting Lily_parser): #<
Output_def>

I've not a real clue what's wrong and how to fix/proceed.
(Continue reading)

v.villenave | 15 Apr 08:26 2015
Picon

Updated patch for issue 155 (issue 230860044 by Carl.D.Sorensen <at> gmail.com)

Hi Carl,
thanks for resurrecting this patch! From what I understand, the logic
behind this patch looks quite sensible (but IANAP, so please take it
with a grain of salt).

Perhaps you could add a regtest demonstrating this feature (or add a
dotted+accidental note to parenthesize.ly)? Just in case it breaks again
in the future.

https://codereview.appspot.com/230860044/diff/1/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/230860044/diff/1/scm/output-lib.scm#newcode909
scm/output-lib.scm:909: (let* ((paren
(parentheses-iotem::calc-parenthesis-stencils grob))
Possible typo?

https://codereview.appspot.com/230860044/
v.villenave | 13 Apr 01:52 2015
Picon

Re: parenthesizeStencil and bracketifyStencil (issue 6397043)

On 2012/07/14 12:11:09, janek wrote:
> this is really cool!

Hi everybody,
since this patch seems to have gone cold, I thought I’d update it a bit
and re-upload it:
https://codereview.appspot.com/226110044/



https://codereview.appspot.com/6397043/

_______________________________________________
lilypond-devel mailing list
lilypond-devel <at> gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
pkx166h | 13 Apr 00:45 2015
Picon

Re: Issue 3615: more consistency with key sig grobs (issue 219460043 by paulwmorris <at> gmail.com)

author	Paul Morris <paulwmorris <at> gmail.com>	
	Sun, 29 Mar 2015 18:09:52 +0000 (14:09 -0400)
committer	James Lowe <pkx166h <at> gmail.com>	
	Sun, 12 Apr 2015 22:42:44 +0000 (23:42 +0100)
commit	cbe0ea8e6413ddf779de852755ce811b5a8319fe

https://codereview.appspot.com/219460043/

Gmane