thomasmorley65 | 1 Aug 00:46 2015
Picon

Fix ugly output from make-parenthesis-stencil for increased thickness (issue 257140044 by thomasmorley65 <at> gmail.com)

Reviewers: ,

Message:
please review

Description:
Fix ugly output from make-parenthesis-stencil for increased thickness

issue 4532

This was caused by the fix for issue 3930. Small and very small
object were focused by 3930 and it did the job.
Though, obviously increasing the thickness for
make-bezier-sandwich-stencil
should have been limited.

Please review this at https://codereview.appspot.com/257140044/

Affected files (+1, -1 lines):
   M scm/stencil.scm

Index: scm/stencil.scm
diff --git a/scm/stencil.scm b/scm/stencil.scm
index  
e64cc2b91c8662fad2736fd71d5fc56bb5a0ca48..f73b08163052b0567d0f2628887bbd8bd552dd19  
100644
--- a/scm/stencil.scm
+++ b/scm/stencil.scm
 <at>  <at>  -159,7 +159,7  <at>  <at>  the more angular the shape of the parenthesis."
        upper-end-point
(Continue reading)

thomasmorley65 | 31 Jul 21:32 2015
Picon

Let fret-diagram scale markups to fit into dots (issue 258070043 by thomasmorley65 <at> gmail.com)

Reviewers: ,

Message:
Please review

Description:
Let fret-diagram scale markups to fit into dots

Issue 4531

Follow up to issue 4120.
Also adding
- documentation
- a new regtest

Please review this at https://codereview.appspot.com/258070043/

Affected files (+84, -6 lines):
   M Documentation/notation/fretted-strings.itely
   A input/regression/fretdiagram-markup-in-dots.ly
   M scm/fret-diagrams.scm

Index: Documentation/notation/fretted-strings.itely
diff --git a/Documentation/notation/fretted-strings.itely  
b/Documentation/notation/fretted-strings.itely
index  
1ce12cd7061bafec97a80f6213913da3e70e9b74..7e2d18725b57cbc90dae0092e3b4ff6b354d6d8d  
100644
--- a/Documentation/notation/fretted-strings.itely
+++ b/Documentation/notation/fretted-strings.itely
(Continue reading)

thomasmorley65 | 30 Jul 22:21 2015
Picon

Re: Let \autochange accept optional arguments for the turning-point and clefs (issue 259080043 by thomasmorley65 <at> gmail.com)

Please review.

It's a pity that obviously putting something like #{ c' #} or #{ \clef
bass #} in music-functions-init.ly is currently not possible.
Trying so returns:
"
error: unrecognized string, not in text script or \lyricmode
   c'
"
or
"
error: unknown escaped string: `\clef'
  \clef treble
"

It works in any user.ly-file, though.

https://codereview.appspot.com/259080043/
tdanielsmusic | 30 Jul 20:15 2015

Issue 4338: fix revocery description of \octaveCheck (issue 255570043 by dak <at> gnu.org)

LTGM

Trevor

https://codereview.appspot.com/255570043/
James | 30 Jul 13:01 2015
Picon

PATCHES: Countdown for August 2nd 2015

Hello,

Here is the current patch countdown list. The next countdown will be on
August 2nd.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

PUSH:

James Lowe: Doc: CG - Tightening up of the Bug Squad intro
http://code.google.com/p/lilypond/issues/detail?id=4521

James Lowe: CG: fix internal link and add note on Help us section
http://code.google.com/p/lilypond/issues/detail?id=4520

David Kastrup: merely loading articulate.ly should not change default output
http://code.google.com/p/lilypond/issues/detail?id=4517

David Kastrup: chord step 14 should be flat by default
http://code.google.com/p/lilypond/issues/detail?id=4433

David Kastrup: MusicXML test suite:
42a-MultiVoice-TwoVoicesOnStaff-Lyrics.xml very last lyric element
should be "Voice2" instead of "Voice1"
http://code.google.com/p/lilypond/issues/detail?id=4188

____________________
(Continue reading)

lemzwerg | 29 Jul 19:45 2015

Avoid "Parsed object should be dead" message from issue 4505 (issue 258030043 by dak <at> gnu.org)

LGTM

https://codereview.appspot.com/258030043/
nine.fierce.ballads | 27 Jul 16:58 2015
Picon

Issue 4527: remove declarations of undefined callbacks (issue 251500043 by nine.fierce.ballads <at> gmail.com)

Reviewers: ,

Message:
While working with David's script from this thread:

http://lists.gnu.org/archive/html/lilypond-devel/2015-07/msg00096.html
I noticed that a bunch of callbacks are declared but not defined.

Description:
remove declarations of undefined callbacks

Please review this at https://codereview.appspot.com/251500043/

Affected files (+0, -16 lines):
   M lily/include/align-interface.hh
   M lily/include/axis-group-interface.hh
   M lily/include/beam.hh
   M lily/include/break-align-interface.hh
   M lily/include/breathing-sign.hh
   M lily/include/hara-kiri-group-spanner.hh
   M lily/include/multi-measure-rest.hh
   M lily/include/note-head.hh
   M lily/include/repeated-music.hh
   M lily/include/rest.hh
   M lily/include/side-position-interface.hh
   M lily/include/stem.hh
   M lily/include/tie.hh

Index: lily/include/align-interface.hh
diff --git a/lily/include/align-interface.hh  
(Continue reading)

trueroad | 27 Jul 14:10 2015
Picon

Add comment to font.scm and lilypond-fonts.conf.in (issue 257940043 by pkx166h <at> gmail.com)


https://codereview.appspot.com/257940043/diff/1/scm/font.scm
File scm/font.scm (right):

https://codereview.appspot.com/257940043/diff/1/scm/font.scm#newcode254
scm/font.scm:254: ; are aliases that are defined in
mf/lilypond-fonts.conf.in.
`mf/lilypond-fonts.conf.in' is filename in the source files.
It is changed by makefiles at building lilypond binaries and installers.
Its installed filename is `font/lilypond-fonts.conf'.

https://codereview.appspot.com/257940043/
James | 27 Jul 10:24 2015
Picon

PATCHES: Countdown for July 30th 2015

Hello,

Here is the current patch countdown list. The next countdown will be on
July 30th.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

PUSH:

David Kastrup: event-chord-wrap! needs to call expand-repeat-notes!
http://code.google.com/p/lilypond/issues/detail?id=4519

David Kastrup: \offset can’t handle mutable properties and unpure-pure
containers
http://code.google.com/p/lilypond/issues/detail?id=4516

James Lowe: Doc: CG - removed information about test-patchy
http://code.google.com/p/lilypond/issues/detail?id=4515

David Kastrup: Detect uninitialized variables in Lily module
http://code.google.com/p/lilypond/issues/detail?id=4514

David Kastrup: Remove redundant occurences of this->
http://code.google.com/p/lilypond/issues/detail?id=4512

James Lowe: Doc: NR add  <at> knownissue for Percent Repeats and meter or
timing changes
(Continue reading)

Werner LEMBERG | 27 Jul 10:15 2015
Picon

can't use `git cl'


Folks,

What's the status of `git cl upload'?  It always fails with `incorrect
username or password'.  I've eventually read the thread

  http://lilypond.1069038.n5.nabble.com/git-cl-upload-has-stopped-working-td177113.html

Is there any outcome?  Or do we have to manually create Google Code
issues and add links to the Rietveld issue?

    Werner
tdanielsmusic | 26 Jul 20:59 2015

Re: NR Changing Defaults: document \etc (issue 256990043 by dak <at> gnu.org)

Apart from nitpicking, doc changes LGTM

Trevor

https://codereview.appspot.com/256990043/diff/20001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/256990043/diff/20001/Documentation/notation/changing-defaults.itely#newcode4769
Documentation/notation/changing-defaults.itely:4769:
 <at> lilypond[quote,verbatim,ragged-right] padText =
We normally write  <at> lilypond[ ... ] on a line by itself, as in the second
example below, and indent subsequently by 2 spaces.

https://codereview.appspot.com/256990043/

Gmane