Ali Cuota | 27 Jan 17:05 2015
Picon

strange behaviour with dotted note before gregorian music

Hello again,

version "2.18.0"
I have a western-notation piece that finishes with a dotted-note a4.
(very last note)
then a gregorian piece.
both comes in a book.ly with include "..."
Compiling the sole gregorian is ok
Compiling the book makes the gregorian have dotted (augmentum) at
every notes except \pes
This is note so terriffic since putting a s8*1/1000 at the western
piece or at the beginning of the gregorian piece solves the problem,
but I would say this is a bug...

Franck
nine.fierce.ballads | 27 Jan 04:29 2015
Picon

Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ballads <at> gmail.com)

Reviewers: ,

Description:
Rest_collision::calc_positioning_done now uses the pure height of
rests because the height of certain rests depends on their position on
the staff, which Rest_collision is responsible for adjusting.

There are differences in regression test output that I can not yet
explain.  The differences do not appear when I run lilypond by itself,
so I'm expecting to have to dig up the exact command the regtests run.
I'm posting this review anyway in hopes that a reviewer will recognize
the problem.

Please review this at https://codereview.appspot.com/193590043/

Affected files (+5, -5 lines):
   M lily/rest-collision.cc

Index: lily/rest-collision.cc
diff --git a/lily/rest-collision.cc b/lily/rest-collision.cc
index  
7648f6d9a09825109e54f879442e3b3d1c2f2fca..c7c032eb399761f55aaa69181c06928f59747ad7  
100644
--- a/lily/rest-collision.cc
+++ b/lily/rest-collision.cc
 <at>  <at>  -171,8 +171,8  <at>  <at>  Rest_collision::calc_positioning_done (SCM smob)
        common = common_refpoint_of_array (ordered_rests[UP], common,  
Y_AXIS);

        Real diff
(Continue reading)

david.nalesnik | 27 Jan 01:03 2015
Picon

Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nalesnik <at> gmail.com)

Reviewers: ,

Message:
Please review.

Description:
Issue 2535: Staccato on stem side alignment when other articulations are
present

The default positioning of staccato dots in combination with other
articulations
is poor, because the dot is positioned midway between the center of the
note head
and the stem, while all other scripts are centered on the note head.

A mechanism is needed to allow a staccato dot to be positioned
differently when alone
and when in combination with other articulations.  The property
'toward-stem-shift
controls the alignment of scripts appearing on the side of the stem.
This patch
changes the type of 'toward-stem-shift to number-pair rather than
number.  The first
member of the pair indicates the shift when alone, the second the shift
when the
script is contained by a ScriptColumn object.  The vast majority of
articulations
default to '(0.0 . 0.0), indicating that they are always centered above
the note head
when on the stem side.  Three articulations--staccato, staccatissimo,
(Continue reading)

James Lowe | 26 Jan 13:53 2015
Picon

PATCHES: Countdown for January 29th. 2015

Hello,

Here is the current patch countdown list. The next countdown will be on 
January 29th.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

PUSH:

David Nalesnik: Patch: Document 'scripts/add to relevant interfaces
http://code.google.com/p/lilypond/issues/detail?id=4269

David Nalesnik: Patch: Missing spaces in 
lily/pure-from-neighbor-interface.cc
http://code.google.com/p/lilypond/issues/detail?id=4268

David Nalesnik: Patch: doc fix for lily/stem-engraver.cc
http://code.google.com/p/lilypond/issues/detail?id=4265

____________________

COUNTDOWN:

James Lowe: Articulate.ly: Fix bug introduced in commit 88e1d22 
(previously issue 4247)
http://code.google.com/p/lilypond/issues/detail?id=4270

(Continue reading)

Paul Morris | 25 Jan 03:18 2015

Re: Web: revise navigation bars with CSS gradients(issue193140043bypaulwmorris <at> gmail.com)

> On Jan 24, 2015, at 5:06 PM, Phil Holmes <mail <at> philholmes.net> wrote:
> 
> I believe I've kicked a website rebuild off. Could you confirm thr results are as expected, please?

Hmmm... I'm not seeing any difference. (at least not yet...?)  After the changes take effect the main
navigation bar should be:

  LilyPond  Introduction  Download  Manuals  Community

but I'm still seeing:

  Main  Introduction  Download  Manuals  Community

It's odd because I see there was a change to the website content [1] that happened after my first edit to
lilypond-texi2html.init [2], but that didn't cause my first edit to take effect on the site.

-Paul

[1] http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=49e785b963a90000331fcb7279a7273221a4a91c

[2] http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=64efd90c42747ecb731b6d1710635f384a46a237
James Lowe | 22 Jan 07:49 2015
Picon

PATCHES: Countdown for January 25th. 2015

Hello,

Here is the current patch countdown list. The next countdown will be on
January 25th.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

PUSH:

James Lowe: Web: Broken Link to LSR - URL needs fixing
http://code.google.com/p/lilypond/issues/detail?id=4260

James Lowe: Patch: Web: revise navigation bars with CSS gradients
http://code.google.com/p/lilypond/issues/detail?id=4258

____________________

COUNTDOWN:

David Nalesnik: Patch: Document 'scripts/add to relevant interfaces
http://code.google.com/p/lilypond/issues/detail?id=4269

David Nalesnik: Patch: Missing spaces in
lily/pure-from-neighbor-interface.cc
http://code.google.com/p/lilypond/issues/detail?id=4268

David Nalesnik: Patch: doc fix for lily/stem-engraver.cc
(Continue reading)

pkx166h | 21 Jan 15:23 2015
Picon

Re: Articulate.ly: Fix mordent and prall timing for short notes (issue 190530043 by botialoach <at> gmail.com)

On 2015/01/20 22:08:16, Peter Chubb wrote:
> articulate.ly: Fix \trillSpan problem

Peter, I can see 4 patches uploaded here but it looks like from the time
stamps that this was some git-cl error or something similar?

Can you confirm in case you need anything testing

James

https://codereview.appspot.com/190530043/
david.nalesnik | 20 Jan 01:24 2015
Picon

Document 'scripts/add to relevant interfaces (issue 195190043 by david.nalesnik <at> gmail.com)

Reviewers: ,

Message:
Please review.

Description:
Document 'scripts/add to relevant interfaces

Please review this at https://codereview.appspot.com/195190043/

Affected files (+3, -1 lines):
   M lily/script-column.cc
   M lily/tuplet-bracket.cc
   M scm/define-grob-properties.scm

Index: lily/script-column.cc
diff --git a/lily/script-column.cc b/lily/script-column.cc
index  
d1dbb158242dbf21e924df08cb858e02364d315a..0e797b543f2948cccd5495686ceb3895a76dd16c  
100644
--- a/lily/script-column.cc
+++ b/lily/script-column.cc
 <at>  <at>  -179,5 +179,5  <at>  <at>  ADD_INTERFACE (Script_column,
                 "  <at> code{script-priority} and  
 <at> code{outside-staff-priority}.",

                 /* properties */
-               ""
+               "scripts "
                );
(Continue reading)

Trevor Daniels | 20 Jan 00:20 2015
Picon

satb built-in template [was Re: Grand Advanced Stylesheet Project (GASP)]


Johan Vromans wrote Monday, January 19, 2015 4:02 PM

>> There is a built-in template almost exactly like this in LilyPond already
> 
> I does, indeed, use a very similar approach. It doesn't provide for guitar
> chords and (automatic) metronome track but I could add that.

Improvements would be very welcome, but there are some defects also
which Devon Schudy and I attempted to fix almost a year ago, but the
patch attracted comments which caused it to stall.  For the background,
see issues 3777 and 3799 and https://codereview.appspot.com/51230043

Perhaps I should pick out the non-contentious parts and post a patch for
just those.

Trevor
James | 19 Jan 19:23 2015
Picon

PATCHES: Countdown for January 22nd 2015

Hello,

Here is the current patch countdown list. The next countdown will be on 
January 22nd.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

COUNTDOWN:

James Lowe: Web: Broken Link to LSR - URL needs fixing
http://code.google.com/p/lilypond/issues/detail?id=4260

James Lowe: Patch: Web: revise navigation bars with CSS gradients
http://code.google.com/p/lilypond/issues/detail?id=4258

____________________

REVIEW:

: Patch: Missing spaces in lily/pure-from-neighbor-interface.cc
http://code.google.com/p/lilypond/issues/detail?id=4268

David Nalesnik: Patch: doc fix for lily/stem-engraver.cc
http://code.google.com/p/lilypond/issues/detail?id=4265

____________________

(Continue reading)

david.nalesnik | 19 Jan 15:20 2015
Picon

Missing spaces in lily/pure-from-neighbor-interface.cc (issue 192370043 by david.nalesnik <at> gmail.com)

Reviewers: ,

Message:
small correction...

Description:
Missing spaces in lily/pure-from-neighbor-interface.cc

Please review this at https://codereview.appspot.com/192370043/

Affected files (+2, -2 lines):
   M lily/pure-from-neighbor-interface.cc

Index: lily/pure-from-neighbor-interface.cc
diff --git a/lily/pure-from-neighbor-interface.cc  
b/lily/pure-from-neighbor-interface.cc
index  
cffe887d1437fd0eb9bc3234eaad0ba286446297..e4be5c4db10f13510c2fce627e1922e024040374  
100644
--- a/lily/pure-from-neighbor-interface.cc
+++ b/lily/pure-from-neighbor-interface.cc
 <at>  <at>  -53,8 +53,8  <at>  <at>  Pure_from_neighbor_interface::calc_pure_relevant_grobs  
(SCM smob)
  }

  ADD_INTERFACE (Pure_from_neighbor_interface,
-               "A collection of routines to allow for objects' pure"
-               "heights and heights to be calculated based on the"
+               "A collection of routines to allow for objects' pure "
+               "heights and heights to be calculated based on the "
(Continue reading)


Gmane