David Kastrup | 24 Jun 18:49 2016
Picon
Picon

Re: compiling lilypond fails

Knut Petersen <Knut_Petersen <at> t-online.de> writes:

> Am 24.06.2016 um 18:15 schrieb David Kastrup:
>> Knut Petersen <Knut_Petersen <at> t-online.de> writes:
>>
>>> Am 24.06.2016 um 16:43 schrieb David Kastrup:
>>>> Ok, next try.
>>>>
>>> On top of HEAD:
>>>
>>> In file included from /home/knut/sources/lily/lily/slur-engraver.cc:32:0:
>>> /home/knut/sources/lily/lily/slur-engraver.cc: In static member function 'static void Slur_engraver::boot()':
>>> /home/knut/sources/lily/lily/include/translator.icc:115:40: error:
'&Slur_proto_engraver::listen_slur' is not a valid template argument for type 'void
(Slur_engraver::*)(Stream_event*)' because it is of type 'void (Slur_proto_engraver::*)(Stream_event*)'
>>>        listen_finder<&cl::listen_ ## m> (),                               \
>>>                                          ^
>>> /home/knut/sources/lily/lily/slur-engraver.cc:65:3: note: in expansion of macro 'ADD_LISTENER'
>>>     ADD_LISTENER (Slur_engraver, slur);
>>>     ^
>>> /home/knut/sources/lily/lily/include/translator.icc:115:40: note: standard conversions are
not allowed in this context
>>>        listen_finder<&cl::listen_ ## m> (),                               \
>>>                                          ^
>>> /home/knut/sources/lily/lily/slur-engraver.cc:65:3: note: in expansion of macro 'ADD_LISTENER'
>>>     ADD_LISTENER (Slur_engraver, slur);
>>>     ^
>> Running out of ideas here.  Can you run this with -k (which means keep
>> going upon error) and direct error output to file, like 2>/tmp/make.log ?
>
(Continue reading)

Nathan Chou | 24 Jun 13:41 2016
Picon

[GSoC] spanners project update

Hello,

Just wanted to update on my progress for the GSoC cross-voice spanners
project. The approach I am currently trying uses the existing
spanner-id property (which can be set like { c\=hello\< d\=hello\! });
spanners with an id are handled as potentially being cross-voice. Each
engraver maintains a static list member (so it is shared between all
instances of an engraver) of named spanners and the voice each spanner
currently belongs to. When listening to events or acknowledging grobs,
an engraver can then examine the list to see which spanners currently
belong to its voice and modify them, or associate a particular spanner
with its voice, for instance.

I have tried this approach with the Dynamic_engraver. My code is not
complete, but what I currently have is at
https://github.com/starrynte/lilypond/compare/master...experimental .
The code should compile and "works", for example, on:

\relative c'' << { c2\=hello\< g } \\ { c,4 d e\=hello\! f } >>

A few notes:
- I temporarily prevented Hairpins from being announced to the Voice
context, since cross-voice ones caused issues with the
Dynamic_align_engraver, which I have not changed or looked at much
yet. Of course, this causes the hairpins to currently be positioned
weirdly.
- I intend to check for still-active spanners when the Score context
is destroyed, and warn about unterminated cross-voice spanners then.

Does this general idea seem reasonable? Any feedback is much appreciated.
(Continue reading)

Marc Hohl | 24 Jun 10:09 2016
Picon

compiling lilypond fails

Hi list,

after a recent "git pull", the call "make -j3" fails with

---

In file included from slur-engraver.cc:32:0:
slur-engraver.cc: In static member function 'static void 
Slur_engraver::boot()':
./include/translator.icc:115:40: error: 
'&Slur_proto_engraver::listen_slur' is not a valid template argument for 
type 'void (Slur_engraver::*)(Stream_event*)' because it is of type 
'void (Slur_proto_engraver::*)(Stream_event*)'
       method_finder<&cl::listen_ ## m> (),                               \
                                         ^
slur-engraver.cc:65:3: note: in expansion of macro 'ADD_LISTENER'
    ADD_LISTENER (Slur_engraver, slur);
    ^
./include/translator.icc:115:40: note: standard conversions are not 
allowed in this context
       method_finder<&cl::listen_ ## m> (),                               \
                                         ^
slur-engraver.cc:65:3: note: in expansion of macro 'ADD_LISTENER'
    ADD_LISTENER (Slur_engraver, slur);
    ^
make[1]: *** [out/slur-engraver.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/marc/git/lilypond/lily'
make: *** [all] Fehler 2

(Continue reading)

James Lowe | 24 Jun 08:29 2016
Picon

PATCHES: Countdown for June 24th

Hello,

Here is the current patch countdown list. The next countdown will be on
June 27th.

A quick synopsis of all patches currently in the review process can be
found here:

http://Phil Holmes.net/lilypond/allura/


__________

Push:

4898 Set rhythmic-location early in paper-column-engraver - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4898
http://codereview.appspot.com/295600043

4897 Allow multiple \with per context creation - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4897
http://codereview.appspot.com/296470043

Countdown:

4902 Improve `-dgs-load-fonts` option for TTF that doesn't have glyph 
names - Masamichi Hosoda
https://sourceforge.net/p/testlilyissues/issues/4902
http://codereview.appspot.com/301990043

(Continue reading)

john | 23 Jun 22:02 2016
Picon

Reimplement issue 4781 for musicxml2ly more literally. (issue 302050043 by john <at> weathervanefarm.net)

Reviewers: ,

Message:
Issue 4781 is reimplemented as requested by David Kastrup.

Description:
Reimplement issue 4781 for musicxml2ly more literally.
Reimplementation was necessary as part of the implementation of issue
4751, but some of the code changes for 4781 were omitted. This
reproduces all the 4781 changes.

Please review this at https://codereview.appspot.com/302050043/

Affected files (+8, -13 lines):
   M python/musicxml.py

Index: python/musicxml.py
diff --git a/python/musicxml.py b/python/musicxml.py
index  
f0b82f1333c7613bcd80f5c418c8f99afb96f35e..ae5ca80a59647dca423d6b374bf6b595b53ee315  
100644
--- a/python/musicxml.py
+++ b/python/musicxml.py
 <at>  <at>  -145,11 +145,11  <at>  <at>  class Music_xml_spanner(Music_xml_node):
  class Measure_element(Music_xml_node):

      def get_voice_id(self):
-        voice_id = self.get_maybe_exist_named_child('voice')
-        if voice_id:
-            return voice_id.get_text()
(Continue reading)

Thomas Morley | 22 Jun 11:54 2016
Picon

What to do with input/regression/page-spacing.ly

Hi,

in input/regression/page-spacing.ly several commands for
    \overrideProperty
    Score.NonMusicalPaperColumn.line-break-system-details
    ...
are applied, i.e. settings for Y-extent, refpoint-Y-extent,
next-padding, next-space, bottom-space.

As far as I can tell none of them has any visual effect anymore as
opposed to (far) earlier ly-version.
Attached a cut off from
http://lilypond.org/doc/v2.10/input/regression/collated-files.pdf
page 86
(In my pdf-viewer every glyph is omitted, incompatlible software for
such an old file I guess, but that's not the point here)
You'll see those settings _had_ an effect with v2.10
Additionally, the `obsolete-between-system-space` there let me guess
that convert-ly was applied to it at some point of time and since then
nobody touched it.

Strange enough, the last commit I've found tackling paper-system.scm is

commit 920dccaf627f00ec2d5bbd49ffeb9ad01236da3b
Author: Joe Neeman <joeneeman <at> gmail.com>
Date:   Fri Jun 9 02:20:21 2006 +0000

        * scm/paper-system.scm (paper-system-annotate): also annotate the
        estimated pure-Y-extent

(Continue reading)

Richard Shann | 21 Jun 12:41 2016

A regression

I have a file that fails to compile with 2.19.43 with this message

Starting lilypond 2.19.43 [junk.ly]...
Processing `/tmp/frescobaldi-PRgtuJ/tmpBD232F/junk.ly'
Parsing...
Interpreting music...[8][16][24][32]
Preprocessing graphical objects...
Interpreting music...[8][16][24][32]
Preprocessing graphical objects...
Interpreting music...[8][16][24]
Preprocessing graphical objects...
Interpreting music...[8][16][24][32][40][48]
Preprocessing graphical objects...
Interpreting music...
Preprocessing graphical objects...
Calculating line breaks... 
Drawing systems... 
Finding the ideal number of pages...
Fitting music on 4 or 5
pages...lilypond:
/home/gub/NewGub/gub/target/linux-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/page-breaking.cc:1040:
void Page_breaking::line_divisions_rec(vsize, const Line_division&, const Line_division&,
Page_breaking::Line_division*): Assertion `my_index == 0' failed.
Exited with exit status 1.

(this happened after inserting a page break). It compiles ok with
2.18.2. My question is, would it be helpful to anyone to have the file?
(Obviously cutting it down to a minimal example is not an option). I
would have to paste the local includes in (or something) to construct
the non-minimal example, so I ask before doing the work...
(Continue reading)

Benkő Pál | 21 Jun 11:30 2016
Picon

looking for Christian Mondrup

all,

does anybody know a working e-mail address of his?  perhaps do you still
lurk here, Christian?

thanks,
p
James Lowe | 21 Jun 09:41 2016
Picon

PATCHES: Countdown for June 21st

Hello,

Here is the current patch countdown list. The next countdown will be on
June 24th.

A quick synopsis of all patches currently in the review process can be
found here:

http://Phil Holmes.net/lilypond/allura/


__________

Push:

4895 Give SystemStartSquare a default of 5.0 for collapse-height - 
Thomas Morley
https://sourceforge.net/p/testlilyissues/issues/4895
http://codereview.appspot.com/303760043

4894 Remove unescaped  <at> funindex entries - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4894
http://codereview.appspot.com/295570043

4893 Correct accidental type for mensural fictas - Phil Holmes
https://sourceforge.net/p/testlilyissues/issues/4893
http://codereview.appspot.com/297540043

Countdown:

(Continue reading)

John Gourlay | 20 Jun 04:48 2016
Picon

Possible errors reimplementing musicxml2ly fix for issue 4581

I sent the message below to Tobias Kretschmar using the email address tobias.kretschmar <at> gmx.de and after
a few days it was returned as undeliverable. Does anyone know an alternate way to reach him? Tobias, are you
following this email list?

John Gourlay

——-

Tobias,

In my recent work on LilyPond issue 4751 I had to reimplement the changes you made for issue 4581 in February.
It seems that I might have done an inadequate job, and I’m hoping that you will be able to help clarify the
issue. It would be especially useful if you could explain in more detail how you originally verified that
the bug was fixed. Was the bug originally evident in the LilyPond output from the regression test
42a-MultiVoice-TwoVoicesOnStaff-Lyrics.xml? I am attaching the PDF output from this test as it is
produced now. Is it correct?

The background of this, in brief, is that I brought a large body of changes into musicxml2ly that were made
over several years separately from LilyPond in the Philomelos project. Not fully understanding the
Philomelos changes, I opted to preserve the Philomelos code when it seemed to work rather than recreating
the latest LilyPond code. The effect of this strategy was apparently to remove some of your changes. If you
are interested you can see the whole discussion between me and David Kastrup at the end of the long series of
comments to issue 4751.

John Gourlay

_______________________________________________
(Continue reading)

lemzwerg | 19 Jun 20:49 2016

Issue 4902: Improve `-dgs-load-fonts` option for TTF that doesn't have glyph names (issue 302000043 by trueroad <at> gmail.com)

LGTM.

https://codereview.appspot.com/302000043/diff/1/lily/open-type-font-scheme.cc
File lily/open-type-font-scheme.cc (right):

https://codereview.appspot.com/302000043/diff/1/lily/open-type-font-scheme.cc#newcode216
lily/open-type-font-scheme.cc:216: bool has_glyph_names =
face->face_flags & FT_FACE_FLAG_GLYPH_NAMES;
bool has_glyph_names = FT_HAS_GLYPH_NAMES(face);

https://codereview.appspot.com/302000043/

Gmane