markpolesky | 24 Jul 23:00 2014
Picon

Doc: NR - Pitches.itely - dodecaphonic-no-repeat text alt (issue 116990043 by pkx166h <at> gmail.com)


https://codereview.appspot.com/116990043/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/116990043/diff/1/Documentation/notation/pitches.itely#newcode2446
Documentation/notation/pitches.itely:2446: suppressed for pitches
immediately repeated within the same Staff.
I'd either write "staff" or " <at> code{Staff} context", but not "Staff".

https://codereview.appspot.com/116990043/
markpolesky | 24 Jul 22:55 2014
Picon

Re: Add an expert font tree interface (issue 108700043 by perpeduumimmobile <at> gmail.com)


https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly
File input/regression/font-expert-selection.ly (right):

https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode33
input/regression/font-expert-selection.ly:33: ;; definition,
irregardless of the name given. (Only before the score?
regardless

https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode66
input/regression/font-expert-selection.ly:66: #(define fonts
#(define fonts
    (make-palladio-dejavu-tree
      (/ myStaffSize 20)))

https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode77
input/regression/font-expert-selection.ly:77: \markup \huge { \sans "xxx
sans xxx" "xxx serif xxx" \typewriter "xxx monospace xxx" }
\markup \huge {
   \sans "xxx sans xxx"
   "xxx serif xxx"
   \typewriter "xxx monospace xxx"
}

https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode81
input/regression/font-expert-selection.ly:81: \new Staff <<
`\new Staff << >>' is redundant, just do `\context Voice'

https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode90
input/regression/font-expert-selection.ly:90: \override LyricText .
(Continue reading)

James | 24 Jul 12:19 2014
Picon

PATCHES: Countdown for July 27th 2014

Hello,

Here is the current patch countdown list. The next countdown will be on 
July 27th.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

PUSH:

David Kastrup: Patch: Fix parts of apparently dead code make-stream-event
http://code.google.com/p/lilypond/issues/detail?id=4007

Janek Warchoł: Patch: Set X-parent of TextScript to NoteColumn instead 
of PaperColumn
http://code.google.com/p/lilypond/issues/detail?id=4005

____________________

COUNTDOWN:

Mark Polesky: Make list of `non-staff lines' easier to find in IR.
http://code.google.com/p/lilypond/issues/detail?id=4026

Mark Polesky: Clarify break-align symbols and space-alist args in IR.
http://code.google.com/p/lilypond/issues/detail?id=4024

James Lowe: Patch: Doc: NR - Pitches.itely - dodecaphonic-no-repeat text alt
(Continue reading)

Mark Polesky | 22 Jul 23:09 2014
Picon

some working grob properties are unlisted?

I noticed that the 'baseline-skip property works with the
InstrumentName grob, which confuses me, because in the IR
entry for IntsrumentName, none of the supported interfaces
listed at the bottom provide the 'baseline-skip property.

Should InstrumentName support text-interface, which provides
'baseline-skip?  Or should some properties from
text-interface also be added to system-start-text-interface,
which *is* supported by InstrumentName (and if so, which
ones)?

But more importantly, how does a property work when it's not
provided by any of the grob's interfaces?  Ambiguities like
that bother me.

Mark
Mark Polesky | 22 Jul 22:31 2014
Picon

thoughts on changing \magnifyMusic, please comment

I'm wondering whether I should do either of these:
1) rename \magnifyMusic to \magnifyVoice
2) change the \magnifyMusic interface to match \magnifyStaff

Regarding #2, currently \magnifyStaff can be used in a
Staff's \with block, but \magnifyMusic *can't* be used in a
Voice's \with block.  \magnifyStaff settings are reverted by
issuing `\magnifyStaff 1', and \magnifyMusic settings are
reverted when the music block argument is closed:

  \magnifyStaff:

    \new Staff \with {
      \magnifyStaff #2/3
    } {
      \new Voice {
        c4 c c c
        % we could do `\magnifyStaff 1' here if we wanted
        c4 c c c
      }
    }

    or...

    \new Staff {
      c4 c c c
      \magnifyStaff #2/3
      c4 c c c
      \magnifyStaff 1
      c4 c c c
(Continue reading)

markpolesky | 22 Jul 10:52 2014
Picon

Re: typo/oversight in align-interface.cc and page-layout-problem.cc (issue 115770043 by thomasmorley65 <at> gmail.com)


https://codereview.appspot.com/115770043/diff/1/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (left):

https://codereview.appspot.com/115770043/diff/1/lily/page-layout-problem.cc#oldcode38
lily/page-layout-problem.cc:38: Returns the number of footntoes
associated with a given line.
footntoes?  Not handnfingers?

https://codereview.appspot.com/115770043/
julien.rioux | 21 Jul 20:30 2014
Picon

Re: CG: Update of Patchy instructions (issue 112280043 by pkx166h <at> gmail.com)

Thanks for this! Some comments.
Cheers,
Julien

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi
File Documentation/contributor/administration.itexi (right):

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode161
Documentation/contributor/administration.itexi:161: knowledge of of
compiling LilyPond and its documentation along with
"of of"

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode172
Documentation/contributor/administration.itexi:172: requires some human
intervention in order to to visually check for any
"to to"

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode178
Documentation/contributor/administration.itexi:178: compile, including
building all the LilyPond documentation, finally
The script makes sure that the new HEAD compiles, it does not attempt to
compile every individual commit.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode238
Documentation/contributor/administration.itexi:238: Commit access
 <at> emph{is} required to test patches, but a valid login
"to test patches" -> "to test and push new commits"

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode256
Documentation/contributor/administration.itexi:256: of the
(Continue reading)

James | 21 Jul 09:01 2014

PATCHES: Countdown for July 24th - 2014

Hello,

Here is the current patch countdown list. The next countdown will be on
July 24th.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20
Owner%20ID%20Summary&sort=patch

____________________

PUSH:

Mark Polesky: No spacing entry from KeyCancellation to `custos'
http://code.google.com/p/lilypond/issues/detail?id=4017

Mark Polesky: Add \magnifyStaff.
http://code.google.com/p/lilypond/issues/detail?id=4015

Thomas Morley: typos/oversight in align-interface.cc and
page-layout-problem.cc
http://code.google.com/p/lilypond/issues/detail?id=4008

David Kastrup: Patch: Pitch alterations use SCM rather than flower rationals
http://code.google.com/p/lilypond/issues/detail?id=3967

____________________

COUNTDOWN:

(Continue reading)

lemzwerg | 21 Jul 02:28 2014

Allow specifying different alignment for grob and its parent (issue 118950043 by janek.lilypond <at> gmail.com)

LGTM.

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.scm#newcode814
scm/define-grob-properties.scm:814: Value  <at> w{ <at> code{-1}} means left
aligned,  <at> code{0} <at> tie{}centered, and
... value <at> tie{} <at> code{-1} ...

https://codereview.appspot.com/118950043/diff/1/scm/define-grob-properties.scm#newcode818
scm/define-grob-properties.scm:818: setting  <at> code{LyricText} alignment
to  <at> code{'(-1 . 1)} will result in
... will result in a ...

https://codereview.appspot.com/118950043/
PhilEHolmes | 20 Jul 17:06 2014

Re: Changes from LSR doc run (issue 116040043 by PhilEHolmes <at> googlemail.com)

Please review.

https://codereview.appspot.com/116040043/
Abraham Lee | 20 Jul 16:43 2014
Picon

Re: Next step for easier custom music font switching

Janek,

Thanks for your thoughts.

On Sun, Jul 20, 2014 at 3:47 AM, Janek Warchoł 
<janek.lilypond <at> gmail.com> wrote:
> Btw, just to make sure: have you seen
> https://code.google.com/p/lilypond/issues/detail?id=4014 ?
> 

Yeah, I saw that and I think it's awesome!

> A thought: i'm missing the possibility to set the weight of the music
> font used by LilyPond for a particular score.  In other words: let's
> 
‘2’
Yeah, that makes sense. That's exactly how Feta (Emmentaler) is 
designed. Each optical size has a different weight, where "heavier" 
ones are designed for smaller print sizes and "lighter" ones are 
designed for larger print sizes. In the font files, they are actually 
the same size. 

The challenge here is how each of the glyphs get "heavier" or 
"lighter". This is a non-trivial design problem. I guess we could use 
FontForge's ability to uniformly change a font's weight, but I think 
this automagic change might not be what we really want (maybe it is). 
If you look at what changes the weights of the different optical text 
fonts, you'll find it's more than just making all the lines thicker 
(which is what FontForge does). Even Feta doesn't change like this 
through the different sizes. It changes more in some places than in 
(Continue reading)


Gmane