janek.lilypond | 27 Aug 23:23 2014
Picon

Issue 3299: better alignment with PaperColumn parent (issue 132280043 by janek.lilypond <at> gmail.com)

Reviewers: ,

Message:
Please review.  I hope that the regtest (see output here
https://code.google.com/p/lilypond/issues/detail?id=3299#c9) and commit
message are clear.

best,
Janek

Description:
Issue 3299: better alignment with PaperColumn parent

PaperColumns are the objects that define where a musical moment
"happens" on the staff horizontally.  However, the noteheads aren't
center-aligned on PaperColumns - according to notation rules they
are left-aligned.  Because of that an object centered on a notehead
is not actually centered on the PaperColumn, which results in a
discrepancy between objects attached to NoteHeads and PaperColumns.

This commit fixes that by introducing a placeholder extent which is
used for aligning such grobs.

Please review this at https://codereview.appspot.com/132280043/

Affected files (+162, -49 lines):
   M Documentation/notation/vocal.itely
   A input/regression/alignment-of-grobs-attached-to-paper-column.ly
   D input/regression/unassociated-lyrics-alignment.ly
   M lily/paper-column.cc
(Continue reading)

dak | 27 Aug 21:32 2014
Picon
Picon

Re: Reimplement Smobs via templates rather than preprocessor (issue 137780043 by dak <at> gnu.org)

On 2014/08/27 19:25:02, dak wrote:
> Run scripts/auxiliar/smob-convert.sh

Sigh.  Patch set 1 was a reverse patch.  I am afraid I'll likely need to
start over.

https://codereview.appspot.com/137780043/
janek.lilypond | 27 Aug 09:39 2014
Picon

Fix ugly code in ClefModifier alignment (issue 134770043 by janek.lilypond <at> gmail.com)

Reviewers: ,

Message:
Pushed as

commit 54e99169c083ddde748e0f583c2d007cfe937044
Author: Janek Warchoł <lemniskata.bernoullego <at> gmail.com>
Date:   Sun Aug 17 14:59:35 2014 +0200

     Fix ugly code in ClefModifier alignment

Description:
Fix ugly code in ClefModifier alignment

Please review this at https://codereview.appspot.com/134770043/


Affected files (+2, -5 lines):
   M lily/clef-modifier.cc


Index: lily/clef-modifier.cc
diff --git a/lily/clef-modifier.cc b/lily/clef-modifier.cc
index  
6d802ad2710948b271a669469f992be44f29dd2c..c56b935a16155eff89655acdd564f213a0ddcad9  
100644
--- a/lily/clef-modifier.cc
+++ b/lily/clef-modifier.cc
 <at>  <at>  -25,27 +25,24  <at>  <at>  struct Clef_modifier
    DECLARE_GROB_INTERFACE ();
  };
(Continue reading)

James | 27 Aug 08:03 2014
Picon

PATCHES: Countdown for August 30th 2014

Hello,

Here is the current patch countdown list. The next countdown will be on
August 30th.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

PUSH:

Janek Warchoł: Patch: Fix ugly code in ClefModifier alignment
http://code.google.com/p/lilypond/issues/detail?id=4074

David Kastrup: Patch: scheme-tutorial.itely: missing closing paren
http://code.google.com/p/lilypond/issues/detail?id=4071

Janek Warchoł: Patch: Use aligned-on-x-parent instead of other callbacks
for some grobs
http://code.google.com/p/lilypond/issues/detail?id=4062

Keith OHara: weird attachment of Lyrics to NullVoice in polyphony
http://code.google.com/p/lilypond/issues/detail?id=3825

Keith OHara: Remove tied accidentals after line-breaking  (was Tie
avoids accidental even when its stencil = ##f)
http://code.google.com/p/lilypond/issues/detail?id=3646

____________________
(Continue reading)

pkx166h | 25 Aug 09:28 2014
Picon

indclude notnames bn, etc., in English (issue 133840043 by k-ohara5a5a <at> oco.net)

Excuse my ignorance, is this going to need any extra documentation or
perhaps a changes.tely entry?

https://codereview.appspot.com/133840043/
Dan Eble | 25 Aug 01:05 2014
Picon

Accidental_engraver check_pitch_against_rules()

There is a static function in accidental-engraver.cc named check_pitch_against_rules.  Is there
something about this function that makes a C++ implementation better than a Scheme implementation,
other than C++ is more readable?

Thanks,
— 
Dan
tdanielsmusic | 24 Aug 22:24 2014

Issue 4064: Remove misleading \notemode example (issue 128410043 by tdanielsmusic <at> googlemail.com)

Reviewers: ,

Message:
Pushed to staging as
e2fd43a13df7e8ce16e7528c8d5b6cc69aba78b8

Closing ...

Description:
Issue 4064: Remove misleading \notemode example

  - Entering note mode has not been required for
    this example since Release 15.

  - Also replace non-standard headings with Level 5
    headings.

Please review this at https://codereview.appspot.com/128410043/

Affected files (+9, -28 lines):
   M Documentation/notation/changing-defaults.itely

Index: Documentation/notation/changing-defaults.itely
diff --git a/Documentation/notation/changing-defaults.itely  
b/Documentation/notation/changing-defaults.itely
index  
70ffece67ecc5ee67b01ce3e6d866f78420f5457..c38727bc85b46f37f37cb798d44abd7d8b57a576  
100644
--- a/Documentation/notation/changing-defaults.itely
+++ b/Documentation/notation/changing-defaults.itely
(Continue reading)

James | 24 Aug 13:25 2014
Picon

PATCHES: Countdown for August 27th 2014

Hello,

Here is the current patch countdown list. The next countdown will be on
August 27th.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

PUSH:

David Kastrup: Cyclic markup detection unable to deal with non-linear
code execution
http://code.google.com/p/lilypond/issues/detail?id=4070

David Kastrup: Patch: Add a convert-ly rule for xxx #'yyy #'zzz = ->
xxx.yyy.zzz =
http://code.google.com/p/lilypond/issues/detail?id=4068

Trevor Daniels: Bad example for \notemode in
Documentation/notation/changing-defaults.itely
http://code.google.com/p/lilypond/issues/detail?id=4064

David Kastrup: Support temporary divisi staves
http://code.google.com/p/lilypond/issues/detail?id=3518

____________________

COUNTDOWN:
(Continue reading)

Carl.D.Sorensen | 23 Aug 22:40 2014
Picon

Re: Issue 3072: Nested overrides get confused with multiple contexts in play (issue 131770043 by dak <at> gnu.org)

On 2014/08/16 18:55:57, dak wrote:
> On 2014/08/16 18:36:50, lemzwerg wrote:

> If you like the encapsulation, you like the patch for issue 2507.  If
you like
> that nested properties will just work without handwaving and ifs and
buts, you
> like this issue.

I really like this solution.  I spent some time trying to figure out how
to get reverts
right during my work on beaming; I never found a good algorithm.  This
makes it
nice.

> The encapsulation means that it should be reasonably straightforward
to swap out
> the internals for something different again at some other point of
time if
> that's desirable.

I love the encapsulation.  Separating implementation from function is
always good.

Thanks,

Carl

https://codereview.appspot.com/131770043/
(Continue reading)

Florian Knupfer | 23 Aug 22:11 2014
Picon

emacs minor mode

Hello,

I've written a minor mode for Lilypond and emacs which I would like to 
contribute. It displays the notes in the score in a distance which correlates 
to the time the note consumes. The consequence is, that the pipes at the end 
of the line are all aligned. If a bar is overfull or underfull +- symbols are 
displayed. The meter is determined by statistical means. Also it analyses the 
structure of the music and highlights important beats according to their 
frequency. Additionaly, if a bar number is written after a pipe, it enumerates 
all consecutive bars.

It can be retrieved at: https://github.com/knupfer/lilypond-pretty-print
A screenshot can be seen here: 
http://knupfer.github.io/images/Screenshot_2014-08-22-17-59-55.png

I'm not experienced as a programmer and appreciate very much ideas to improve 
this mode and my skills.

Greets
Janek Warchoł | 23 Aug 16:05 2014
Picon

inactive for a few weeks

Hi all,

together with Urs we're starting work on new Crowd engraving project,
and i'll have to focus on that for the next several weeks, so i
probably won't work on Lilypond itself (except for finishing issues
4062 and 4074).

best,
Janek

Gmane