dak | 19 Oct 18:58 2014
Picon
Picon

Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmusic <at> googlemail.com)


https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly
File ly/property-init.ly (right):

https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359
ly/property-init.ly:359: lineBreaksOn =
It might be more consistent with other overrides in this file to make
the commands for (re-)establishing the default settings, namely
\lineBreaksOn and \pageBreaksOn, be reverts rather than overrides.

https://codereview.appspot.com/156400043/
Phil Holmes | 19 Oct 18:57 2014
Picon

GUB update

Keen observers will have noticed that I've not been able to keep to my 
normal schedule of LilyPond releases.  The is down to the fact that some 
of the recent patches are not compatible with the original GCC version in 
te GUB repo.  I've been working on updating this, but having problems 
getting one od its dependencies (MPFR) at the the correct revision level.  
I concluded that it might be simplest to create a new VM with an updated 
version of GUB on my build machine.  This then meant I needed to check I 
had enough disk space and discovered my stash of old builds had nearly run 
me out of hard disk.  So I've offloaded them onto a NAS drive, but I still 
need to carefully update all the versions in the GUB repo and create a new 
VM.

Added to this, I'm rehearsing for HMS Pinafore right now (performance in 
10 days) and have just had a new BMW i3 delivered, so playing with that.

I've not forgotten, and will do my best to get this sorted before I have a 
3 week holiday, which will also affect my schedule...
david.nalesnik | 19 Oct 17:30 2014
Picon

Improvements to measure counter (issue 156380043 by david.nalesnik <at> gmail.com)

Reviewers: ,

Message:
Please review.

Description:
Improvements to measure counter

Improvements to measure counter

This patch adds no new functionality to the measure counter, but
there are improvements to the code.

The stencil callback has been shortened, as there is no need to
search for columns which are already available as the bounds of
broken spanners.  It has also been moved to scm/output-lib.scm,
where other such functions are.

The engraver has been streamlined by the removal of an unnecessary
variable and levels of nesting.  Comments have been revised.

Please review this at https://codereview.appspot.com/156380043/

Affected files (+88, -118 lines):
   M scm/music-functions.scm
   M scm/output-lib.scm
   M scm/scheme-engravers.scm
lilyliska | 18 Oct 20:02 2014

Re: Issue 461: LilyPond should accept a tie between notes which are enharmonically identical (issue 159050043 by dak <at> gnu.org)

LGTM too.

Of course this doesn't look right out-of-the-box (maybe it would be good
to let the Tie being printed as a Slur instead). But as one can use
\shape it's at least possible to use that as a working and semantically
correct solution.
It even works with cross-staff ties (although I suspect that their
layout is very fragile).

https://codereview.appspot.com/159050043/
dak | 18 Oct 19:19 2014
Picon
Picon

Re: Issue 4154: Compact Chord Symbols Patch (issue 153160043 by dak <at> gnu.org)

On 2014/10/09 12:02:16, richard_rshann.plus.com wrote:

> Well, that depends what I meant by the existing code - the specific
file
> I was modifying calls chordRootNamer which is initialized to
> note-name-≥markup which is in chord-names.scm:62, and that is where
the
> quoted construct exists in the current lilypond code, in fact I see it
> is repeated several times in that file.

Well, pulling code from a different file and functionality in parts into
a different file where they are basically integrated as flat code into
some parts of the code while other parts still call the other file --
that's a total maintenance and reading nightmare.  If the duplicated
code needs changes or maintenance, it is quite improbable that someone
working on it will find and change *both* copies as needed.

It would be best to extend the code to be able to do both tasks.  If
that is not reasonably possible, it would be good to factor out common
elements but keep the code doing the non-common parts in the same file.

https://codereview.appspot.com/153160043/
James | 18 Oct 08:58 2014
Picon

PATCHES: Countdown for October 21st 2014

Hello,

Here is the current patch countdown list. The next countdown will be on
October 21st.

You can always view the most current countdown list here:
http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

____________________

PUSH:

Trevor Daniels: LM contains incorrect advice for tying notes across voices
http://code.google.com/p/lilypond/issues/detail?id=4162

____________________

COUNTDOWN:

David Nalesnik: Patch: non-existent procedure-with-setter used in
input/regression/scheme-text-spanner.ly
http://code.google.com/p/lilypond/issues/detail?id=4165

James Lowe: Patch: Added recorder diagram
http://code.google.com/p/lilypond/issues/detail?id=4163

Trevor Daniels: Doc: Isolated durations are not mentioned in the LM
http://code.google.com/p/lilypond/issues/detail?id=3813

____________________
(Continue reading)

v.villenave | 17 Oct 08:40 2014
Picon

Additions in event-listener.ly (issue 152600043 by pkx166h <at> gmail.com)

Greetings Philippe and James,
this looks good overall, I just have one minor comment.

https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly
File ly/event-listener.ly (right):

https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode129
ly/event-listener.ly:129: (+ 60 (ly:pitch-semitones
AFAICS, .ly files use spaces, not tabs. Check the indentation.

https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode144
ly/event-listener.ly:144: "note"
Strictly speaking, this isn't a "note". "Drumnote" may be too long, how
about "stroke" or something else?

https://codereview.appspot.com/152600043/
david.nalesnik | 16 Oct 23:15 2014
Picon

non-existent procedure-with-setter in input/regression/scheme-text-spanner.ly (issue 157100043 by david.nalesnik <at> gmail.com)

Reviewers: ,

Message:
Please review.

Description:
No procedure-with-setter is provided for ly:spanner-set-bound! in
scm/music-functions.scm.  This patch removes the faulty usage in
input/regression/scheme-text-spanner.ly.

Please review this at https://codereview.appspot.com/157100043/

Affected files (+6, -6 lines):
   M input/regression/scheme-text-spanner.ly

Index: input/regression/scheme-text-spanner.ly
diff --git a/input/regression/scheme-text-spanner.ly  
b/input/regression/scheme-text-spanner.ly
index  
8442f60a96573d6e2810e9d1e8557f8878821f8e..6dc74454098841d5033a4c9a92ff1eef4482b9a2  
100644
--- a/input/regression/scheme-text-spanner.ly
+++ b/input/regression/scheme-text-spanner.ly
 <at>  <at>  -145,13 +145,13  <at>  <at>  schemeTextSpannerEngraver =
        ((stop-translation-timestep trans)
         (if (and (ly:spanner? span)
                  (null? (ly:spanner-bound span LEFT)))
-           (set! (ly:spanner-bound span LEFT)
-                 (ly:context-property context 'currentMusicalColumn)))
+           (ly:spanner-set-bound! span LEFT
(Continue reading)

pkx166h | 15 Oct 16:08 2014
Picon

Re: Additions in event-listener.ly (issue 8165043)

On 2013/04/09 19:08:56, phil Hezaine wrote:
> only add drum-note and drum-name

This has now been moved to https://codereview.appspot.com/152600043 for
tracker issue http://code.google.com/p/lilypond/issues/detail?id=4164

someone asked for this on the user lists, and I saw that it had never
been implemented in the main code, so have downloaded the patch and it
still applies to current master.

It is undergoing testing now.

Thanks

Jameds

https://codereview.appspot.com/8165043/
nine.fierce.ballads | 13 Oct 15:51 2014
Picon

Issue 4156: Define Smob<> constructors (issue 157750043 by dak <at> gnu.org)

LGTM

https://codereview.appspot.com/157750043/
pkx166h | 12 Oct 22:33 2014
Picon

Added recorder diagram (issue 153380043 by pkx166h <at> gmail.com)

Reviewers: erik.flister_gmail.com,

Message:
Please review and give advice.

Description:
Provided by Erik Flister

Added recorder diagram

issues still to be resolved and need help:-

1h (half-covered) works for eg 'flute two',
but on my recorder thumb (T) it doesn't work
it just shows fully covered.

Please review this at https://codereview.appspot.com/153380043/

Affected files (+170, -0 lines):
   M scm/display-woodwind-diagrams.scm

Gmane