28 Dec 2012 22:11
23 Oct 2012 16:11
[PATCH] lid: avoid reading beyond end of buffer for a long name
FYI, From 30b13233f7a4d01d3a1826244661a6588e8c3f98 Mon Sep 17 00:00:00 2001 From: Jim Meyering <jim@...> Date: Tue, 23 Oct 2012 16:10:21 +0200 Subject: [PATCH] lid: avoid reading beyond end of buffer for a long name * libidu/idfile.h (stzncpy): Define, from coreutils. * src/lid.c (query_ambiguous_prefix): Avoid buffer overrun. Using strncpy to copy a too-long name would result in a "name" that is not NUL-terminated, yet that name would be treated as a NUL-terminated string immediately afterwards, via report_func, which attempts to print it. * libidu/fnprint.c (root_name): Use stzncpy in place of strncpy. --- libidu/fnprint.c | 6 +----- libidu/idfile.h | 15 +++++++++++++++ src/lid.c | 4 ++-- 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/libidu/fnprint.c b/libidu/fnprint.c index b8d97ce..4129441 100644 --- a/libidu/fnprint.c +++ b/libidu/fnprint.c <at> <at> -46,11 +46,7 <at> <at> root_name (char const *file_name) char const *dot = strrchr (file_name, '.'); if (dot) - { - int length = dot - file_name;(Continue reading)
23 Oct 2012 14:58
enable --enable-gcc-warnings by default in a from-clone build
Eric did this in libvirt, and I liked it, so also in coreutils. Finally, I'm updating all other C projects I tend to do the same thing: From a6211c988649214a6cfaa10ba13d77b8e65a8fff Mon Sep 17 00:00:00 2001 From: Eric Blake <eblake@...> Date: Tue, 23 Oct 2012 11:08:51 +0200 Subject: [PATCH] build: default to --enable-gcc-warnings in a git tree Anyone building from cloned sources can be assumed to have a new enough environment, such that enabling gcc warnings by default will be useful. Tarballs still default to no warnings, and the default can still be overridden with --disable-gcc-warnings. * configure.ac (gl_gcc_warnings): Set default based on environment. --- configure.ac | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4716744..b80a85d 100644 --- a/configure.ac +++ b/configure.ac <at> <at> -29,7 +29,11 <at> <at> AC_ARG_ENABLE([gcc-warnings], *) AC_MSG_ERROR([bad value $enableval for gcc-warnings option]) ;; esac gl_gcc_warnings=$enableval], - [gl_gcc_warnings=no] + [if test -d "$srcdir"/.git; then + gl_gcc_warnings=yes + else + gl_gcc_warnings=no(Continue reading)
13 Sep 2012 23:44
JavaScript support and non-ASCII identifiers
[apologies if this isn't the right list; please redirect if that's the case] I've started toying with adding JavaScript support to idutils. The JavaScript grammar is defined in terms of a stream of UTF-16 code units (not, unfortunately, in terms of Unicode code points), and JS identifiers can contain non-ASCII characters. What kind of 'struct token' should I return for that? Is there a defined encoding for non-ASCII characters in the ID database? If we elect to use UTF-8 in ID databases, then we'll need to depend on something like iconv to convert to and from the locale's current encoding --- assuming that the files read are using that. If we elect to use the locale's coded character set in ID databases, then interpreting a database's contents correctly will depend on the coded character set being the same as it was when the database was created, which seems unfortunate. The JavaScript scanner would still need to use iconv to get the UTF-16 stream it needs, so this approach won't avoid introducing a dependency on iconv. For now, I'm going to punt on non-ASCII characters, treating them all as identifier components.
13 Sep 2012 22:03
Patch: update .gitignore file
After I did an out-of-tree build of idutils from git.savannah.gnu.org, I ended up with a bunch of generated files that git wasn't sure what to do with, so I added them to .gitignore. It seems like the 'm4' directory is entirely created by gnulib(?), so I added the whole directory. If it helps, this patch is the sole commit on the 'gitignore' branch of this git repository: git://github.com/jimblandy/idutils.git commit 63b956caa5bfaf52f6865e32739b1cab5a8610e1 Author: Jim Blandy <jimb@...> Date: Thu Sep 13 11:21:08 2012 -0700 Update .gitignore for files added by build. diff --git a/.gitignore b/.gitignore index ef49d35..6558547 100644 --- a/.gitignore +++ b/.gitignore <at> <at> -16,6 +16,8 <at> <at> /build-aux /config.cache /gnulib-tests/.gitignore +/gnulib-tests/Makefile.in +/gnulib-tests/glthread/ /gnulib-tests/test-* /gnulib-tests/uniwidth /idutils-*.tar.xz(Continue reading)
11 May 2012 13:10
[PATCH 2/3] maint: avoid new syntax-check failures
FYI, with this, "make distcheck" now runs the syntax-check rules, so problems like the one introduced by the NEWS spelling fix will be less likely to be pushed. From 2973ee3e9709b4355316bd0fdb31b83ea1cdb61e Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@...> Date: Fri, 11 May 2012 12:13:33 +0200 Subject: [PATCH 1/3] build: update gnulib submodule to latest --- gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnulib b/gnulib index 4ddd9dd..1f96aa0 160000 --- a/gnulib +++ b/gnulib <at> <at> -1 +1 <at> <at> -Subproject commit 4ddd9dd5c80d2058001c9bec68b7f0ef0bc3a56f +Subproject commit 1f96aa01f72bba8c9a0600280594a1a92bb505fc -- 1.7.10.1.553.gb7fbce0 From baaa6740c7a197f9d4a919e689507144fb1da00f Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@...> Date: Fri, 11 May 2012 12:52:52 +0200 Subject: [PATCH 2/3] maint: avoid new syntax-check failures * cfg.mk (old_NEWS_hash): Update to reflect typo fix in old NEWS. * doc/idutils.texi: Add "." before <at> xref.(Continue reading)
18 Apr 2012 08:32
[PATCH] maint: fix comment/doc typos
FYI, From 3e12f18c5be18db461e7f869fbb70032f3ce6f70 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@...> Date: Wed, 18 Apr 2012 08:31:34 +0200 Subject: [PATCH] maint: fix comment/doc typos Found using https://github.com/lyda/misspell-check * ChangeLog-2007: As above. * NEWS: Likewise. * src/mkid.c: Likewise. --- ChangeLog-2007 | 2 +- NEWS | 2 +- src/mkid.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ChangeLog-2007 b/ChangeLog-2007 index dbd8778..4c1bd36 100644 --- a/ChangeLog-2007 +++ b/ChangeLog-2007 <at> <at> -61,7 +61,7 <at> <at> 2006-08-22 Claudio Fontana <claudio@...> * doc/idutils.texi: fix wrong example .emacs entry, where - a non existant 'gid' lisp is loaded instead of 'idutils'. + a nonexistent 'gid' lisp is loaded instead of 'idutils'. 2006-08-05 Claudio Fontana <claudio@...>(Continue reading)
3 Feb 2012 14:11
[PATCH] maint: adjust the URL that will appear in the generated announcement
FYI, From a6e015120290900e2894db96d55975c2ffbc0347 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@...> Date: Fri, 3 Feb 2012 14:10:55 +0100 Subject: [PATCH] maint: adjust the URL that will appear in the generated announcement * cfg.mk (url_dir_list): Use this http://ftp.gnu.org/gnu/$(PACKAGE) for the first link listed in the generated announcement. announce-gen now provides the faster mirror link automatically. --- cfg.mk | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/cfg.mk b/cfg.mk index 253946d..9b68f6f 100644 --- a/cfg.mk +++ b/cfg.mk <at> <at> -14,6 +14,10 <at> <at> # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. +# Use the direct link. This is guaranteed to work immediately, while +# it can take a while for the faster mirror links to become usable. +url_dir_list = http://ftp.gnu.org/gnu/$(PACKAGE) + # Used in maint.mk's web-manual rule manual_title = GNU idutils: ID database utilities(Continue reading)
3 Feb 2012 14:09
idutils-4.6 released [stable]
This is to announce a stable release of idutils.
The idutils package contains tools to create and efficiently search
an index of "identifiers" from specified files:
http://www.gnu.org/software/idutils/
Since 4.5 there have been two bug fixes and some build and portability
improvements inherited via gnulib. See the NEWS below for a summary.
Here are the compressed sources and a GPG detached signature[*]:
http://ftp.gnu.org/gnu/idutils/idutils-4.6.tar.xz
http://ftp.gnu.org/gnu/idutils/idutils-4.6.tar.xz.sig
Use a mirror for higher download bandwidth:
http://ftpmirror.gnu.org/idutils/idutils-4.6.tar.xz
[*] Use a .sig file to verify that the corresponding file (without the
.sig suffix) is intact. First, be sure to download both the .sig file
and the corresponding tarball. Then, run a command like this:
gpg --verify idutils-4.6.tar.xz.sig
If that command fails because you don't have the required public key,
then run this command to import it:
gpg --keyserver keys.gnupg.net --recv-keys 7FD9FCCB000BEEEE
and rerun the 'gpg --verify' command.
This release was bootstrapped with the following tools:
(Continue reading)
2 Feb 2012 08:38
build/gnulib adjustments
Mostly infrastructure and build-related improvements: [PATCH 1/9] tests: disable gnulib's get-rusage-as test [PATCH 2/9] build: fix man-page-building and cross-check rules [PATCH 3/9] build: turn off two of gcc's warning options [PATCH 4/9] build: add const and pure attributes, per gcc [PATCH 5/9] build: work around new warning/suggestion to use "pure" [PATCH 6/9] build: update bootstrap from gnulib, and adapt [PATCH 7/9] maint: make copyright statements more consistent; update [PATCH 8/9] tests: adapt framework for upcoming automake-1.12 [PATCH 9/9] maint: use gnulib's readme-release module README-release | 85 --------------- b/.gitignore | 33 ++---- b/bootstrap | 250 ++++++++++++++++------------------------------ b/bootstrap.conf | 3 b/cfg.mk | 3 b/configure.ac | 2 b/gnulib | 2 b/lib/Makefile.am | 11 ++ b/libidu/idfile.h | 14 +- b/libidu/idu-hash.c | 2 b/libidu/scanners.h | 3 b/libidu/walker.c | 29 ++--- b/man/Makefile.am | 30 +---- b/src/lid.c | 14 +- b/src/mkid.c | 16 +- b/testsuite/CuSkip.pm | 39 +++++++ b/testsuite/Makefile.am | 2 b/testsuite/check.mk | 27 ++--(Continue reading)
1 Jan 2012 10:21
[PATCH] maint: avoid new syntax-check failure due to #if HAVE_SYS_TYPES_H
FYI, I've just pushed this, in addition to a global copyright update. From 3afda48cd4dbb6c5ca6de443cdba0f918443181c Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@...> Date: Sun, 1 Jan 2012 10:21:01 +0100 Subject: [PATCH] maint: avoid new syntax-check failure due to #if HAVE_SYS_TYPES_H * libidu/idfile.h: Include <sys/types.h> unconditionally. I.e., drop the now-redundant #if HAVE_SYS_TYPES_H guard. gnulib guarantees the presence of that header. --- libidu/idfile.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/libidu/idfile.h b/libidu/idfile.h index b77c85a..fe531db 100644 --- a/libidu/idfile.h +++ b/libidu/idfile.h <at> <at> -21,9 +21,7 <at> <at> #define _idfile_h_ 1 #include <config.h> -#if HAVE_SYS_TYPES_H -# include <sys/types.h> -#endif +#include <sys/types.h> #include <stdio.h> #include <string.h> #include "obstack.h"(Continue reading)
RSS Feed