[PATCH] AutoSize fixes for bug 402849 - Please Review

Attached patch fixes bug #402849 and basically boils down to two main things

- We should check whether children are in AutoSize and only then ask
for PreferredSize, else use ExplicitBounds.
- Apply padding to the preferred size for Form.

If no objections, I will commit.

Thanks,
Ivan

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Fwd: [PATCH] AutoSize fixes for bug 355408 - Please Review

Hey,

Attached patch fixes bug 355408.  We have to take in account controls
and their size regardless of their dock/anchor state when calculating
row/column sizes.

If there are no objections I will commit.

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Where to find the installed library in mono

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Re: Where to find the installed library in mono

On Tue, Jul 1, 2008 at 7:39 AM, Tushar Neupaney
<tushar.neupaney <at> gmail.com> wrote:
> Dear All,
>
> First Sorry to ask such stupid question. I am a newbie in Mono. Can any one
> just tell me how to find out what libraries are installed in my system.
> I have Fedora 8 running and my application does not work because it says the
> following:

Looks like you need to install libgdiplus, though that should have
been a dependency of installing mono-winforms.

Sandy
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Re: Where to find the installed library in mono

If it is just a case of looking for libgdiplus in the wrong place, you 
can see where Mono is looking for it with this:

MONO_LOG_LEVEL="debug" MONO_LOG_MASK="dll" mono myapp.exe

Jonathan

Sandy Armstrong wrote:
> On Tue, Jul 1, 2008 at 7:39 AM, Tushar Neupaney
> <tushar.neupaney <at> gmail.com> wrote:
>> Dear All,
>>
>> First Sorry to ask such stupid question. I am a newbie in Mono. Can any one
>> just tell me how to find out what libraries are installed in my system.
>> I have Fedora 8 running and my application does not work because it says the
>> following:
> 
> Looks like you need to install libgdiplus, though that should have
> been a dependency of installing mono-winforms.
> 
> Sandy
> _______________________________________________
> Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-winforms-list
> 
> 

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Re: Fwd: [PATCH] AutoSize fixes for bug 355408 - Please Review

Hey Ivan,

Your patch leaves two blocks of unreachable code.

Also, layout is extremely tricky and easily testable, so EVERY change to 
default/table/flow layout MUST have a test case.  See TableLayoutTest.cs.

Other than that, it looks ok.

Jonathan

Ivan N. Zlatev wrote:
> Hey,
> 
> Attached patch fixes bug 355408.  We have to take in account controls
> and their size regardless of their dock/anchor state when calculating
> row/column sizes.
> 
> If there are no objections I will commit.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-winforms-list

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Re: Fwd: [PATCH] AutoSize fixes for bug 355408 - Please Review

On Wed, Jul 2, 2008 at 4:48 PM, Jonathan Pobst <monkey <at> jpobst.com> wrote:
> Hey Ivan,
>
> Your patch leaves two blocks of unreachable code.
>

Ops. I blame my editor's automagic unsurround feature :)

> Also, layout is extremely tricky and easily testable, so EVERY change to
> default/table/flow layout MUST have a test case.  See TableLayoutTest.cs.
>

Yeah I was going to write the tests, but thought I might get this
looked at first. So yeah, I will write the tests and then commit.
Thanks.
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Form.SetBoundsCore minimum size for minimized forms

This is necessary because of the change to InternalWindowManager.IconicSize in revision 104901. I did
not see it until now because of bug 406786.

      

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Re: Form.SetBoundsCore minimum size for minimized forms

Looks fine.  Please commit.

Jonathan

George Giolfan wrote:
> This is necessary because of the change to InternalWindowManager.IconicSize in revision 104901. I did
not see it until now because of bug 406786.
> 
> 
>       
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-winforms-list

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Theme selection

Currently ThemeVisualStyles is selected if Application.RenderWithVisualStyles returns true.
However the user can switch to a Windows theme that uses Visual Styles after the application has started.
Can the MWF theme be changed after it was first selected?
The alternative would be to select ThemeVisualStyles regardless of whether Visual Styles is currently
enabled, and have it fall back to ThemeWin32Classic whenever Visual Styles is disabled.

      
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list