headers
Jonathan Pobst | 6 Jul 2006 01:59
Gravatar

[PATCH] MWF2 EventHandler Changes

Removes Serializable from EventHandlers for MWF 2.0.

Please review and commit.

Thanks,
Jon


Index: ColumnClickEventHandler.cs
===================================================================
--- ColumnClickEventHandler.cs	(revision 62112)
+++ ColumnClickEventHandler.cs	(working copy)
 <at>  <at>  -29,6 +29,8  <at>  <at> 

 namespace System.Windows.Forms
 {
+#if !NET_2_0
 	[Serializable]
+#endif
 	public delegate void ColumnClickEventHandler (object sender, ColumnClickEventArgs e);
 }
Index: DrawItemEventHandler.cs
===================================================================
--- DrawItemEventHandler.cs	(revision 62112)
+++ DrawItemEventHandler.cs	(working copy)
 <at>  <at>  -27,6 +27,8  <at>  <at> 

 namespace System.Windows.Forms
 {
(Continue reading)

Permalink | Reply | 2 comments |
headers
Dennis Hayes | 6 Jul 2006 04:17
Picon
Favicon

Re: [PATCH] MWF2 EventHandler Changes

Would this break in NET_2_1 or NET_3_0?
Maybe if NET_1_0 OR NET_1_1
 
I am not sure what values are defined for the different versions (is there a NET_1_x?).
But the 3.0 beta frame work is now availible, and it seems this would revert back to 1.x behavour for that version.
 
Thanks,
Dennis



Jonathan Pobst <monkey <at> jpobst.com> wrote:
Removes Serializable from EventHandlers for MWF 2.0.

Please review and commit.

Thanks,
Jon

Index: ColumnClickEventHandler.cs
===================================================================
--- ColumnClickEventHandler.cs (revision 62112)
+++ ColumnClickEventHandler.cs (working copy)
<at> <at> -29,6 +29,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void ColumnClickEventHandler (object sender, ColumnClickEventArgs e);
}
Index: DrawItemEventHandler.cs
===================================================================
--- DrawItemEventHandler.cs (revision 62112)
+++ DrawItemEventHandler.cs (working copy)
<at> <at> -27,6 +27,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void DrawItemEventHandler (object sender, DrawItemEventArgs e);
}
Index: ItemChangedEventHandler.cs
===================================================================
--- ItemChangedEventHandler.cs (revision 62112)
+++ ItemChangedEventHandler.cs (working copy)
<at> <at> -29,6 +29,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void ItemChangedEventHandler (object sender, ItemChangedEventArgs e);
}
Index: ItemCheckEventHandler.cs
===================================================================
--- ItemCheckEventHandler.cs (revision 62112)
+++ ItemCheckEventHandler.cs (working copy)
<at> <at> -29,6 +29,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void ItemCheckEventHandler (object sender, ItemCheckEventArgs e);
}
Index: ItemDragEventHandler.cs
===================================================================
--- ItemDragEventHandler.cs (revision 62112)
+++ ItemDragEventHandler.cs (working copy)
<at> <at> -29,6 +29,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void ItemDragEventHandler (object sender, ItemDragEventArgs e);
}
Index: LabelEditEventHandler.cs
===================================================================
--- LabelEditEventHandler.cs (revision 62112)
+++ LabelEditEventHandler.cs (working copy)
<at> <at> -30,6 +30,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void LabelEditEventHandler (object sender, LabelEditEventArgs e);
}
Index: LinkClickedEventHandler.cs
===================================================================
--- LinkClickedEventHandler.cs (revision 62112)
+++ LinkClickedEventHandler.cs (working copy)
<at> <at> -26,7 +26,9 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void LinkClickedEventHandler (object sender, LinkClickedEventArgs e);
}

Index: LinkLabelLinkClickedEventHandler.cs
===================================================================
--- LinkLabelLinkClickedEventHandler.cs (revision 62112)
+++ LinkLabelLinkClickedEventHandler.cs (working copy)
<at> <at> -33,7 +33,9 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void LinkLabelLinkClickedEventHandler (object sender, LinkLabelLinkClickedEventArgs e);

}
Index: MeasureItemEventHandler.cs
===================================================================
--- MeasureItemEventHandler.cs (revision 62112)
+++ MeasureItemEventHandler.cs (working copy)
<at> <at> -26,6 +26,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void MeasureItemEventHandler (object sender, MeasureItemEventArgs e);
}
\ No newline at end of file
Index: MethodInvoker.cs
===================================================================
--- MethodInvoker.cs (revision 62112)
+++ MethodInvoker.cs (working copy)
<at> <at> -27,6 +27,8 <at> <at>
// COMPLETE

namespace System.Windows.Forms {
+#if !NET_2_0
[Serializable]
+#endif
public delegate void MethodInvoker();
}
Index: PaintEventHandler.cs
===================================================================
--- PaintEventHandler.cs (revision 62112)
+++ PaintEventHandler.cs (working copy)
<at> <at> -29,6 +29,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void PaintEventHandler (object sender, PaintEventArgs e);
}
Index: PropertyTabChangedEventHandler.cs
===================================================================
--- PropertyTabChangedEventHandler.cs (revision 62112)
+++ PropertyTabChangedEventHandler.cs (working copy)
<at> <at> -27,7 +27,9 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void PropertyTabChangedEventHandler(object s, PropertyTabChangedEventArgs e);
}

Index: PropertyValueChangedEventHandler.cs
===================================================================
--- PropertyValueChangedEventHandler.cs (revision 62112)
+++ PropertyValueChangedEventHandler.cs (working copy)
<at> <at> -27,6 +27,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void PropertyValueChangedEventHandler(object s, PropertyValueChangedEventArgs e);
}
Index: SelectedGridItemChangedEventHandler.cs
===================================================================
--- SelectedGridItemChangedEventHandler.cs (revision 62112)
+++ SelectedGridItemChangedEventHandler.cs (working copy)
<at> <at> -27,6 +27,8 <at> <at>

namespace System.Windows.Forms
{
+#if !NET_2_0
[Serializable]
+#endif
public delegate void SelectedGridItemChangedEventHandler(object sender, SelectedGridItemChangedEventArgs e);
}
Index: ToolBarButtonClickEventHandler.cs
===================================================================
--- ToolBarButtonClickEventHandler.cs (revision 62112)
+++ ToolBarButtonClickEventHandler.cs (working copy)
<at> <at> -31,6 +31,8 <at> <at>
// COMPLETE

namespace System.Windows.Forms {
+#if !NET_2_0
[Serializable]
+#endif
public delegate void ToolBarButtonClickEventHandler (object sender, ToolBarButtonClickEventArgs e);
}
_______________________________________________
Mono-winforms-list maillist - Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list

Do you Yahoo!?
Get on board. You're invited to try the new Yahoo! Mail Beta.
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 1 comment |
headers
Atsushi Eno | 6 Jul 2006 04:35

Re: [PATCH] MWF2 EventHandler Changes

Hi,

> Would this break in NET_2_1 or NET_3_0?
>   Maybe if NET_1_0 OR NET_1_1
>    
>   I am not sure what values are defined for the different versions (is there a NET_1_x?).
>   But the 3.0 beta frame work is now availible, and it seems this would revert back to 1.x behavour for that version.

No worries. This patch will work as expected in the future.
When we build 2.0 profile, both NET_1_1 and NET_2_0 are defined in
the compiler options (btw NET_1_1 today does not mean anything special,
since our class libs has long been unable to build without NET_1_1).
When we will build 3.0 in the future, NET_2_0 will be still defined.

Cheers,
Atsushi Eno
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 0 comments |
headers
John Luke | 9 Jul 2006 00:25
Picon

allow using installed cairo in libgdiplus

Hello,

I wanted to see if I could make libgdiplus work with my installed
version of cairo instead of the included one.  The attached is what I
came up with and it seems to work ok.  There is currently one use of
pixman in a few places and one use of cairo_ps_ api that was changed in
the 1.2.0 release that prevent it from compiling against the released
cairo 1.2.

The use of pixman_bits_t seems to come from this:
http://galactus.ximian.com/pipermail/mono-winforms-list/2005-February/001439.html
but shouldn't it be 4 even on 64-bit machines?
If not can we substitute a suitable glib type there?

Here is the relevant part of pixman.h:
/*
* This single define controls the basic size of data manipulated
* by this software; it must be log2(sizeof (pixman_bits_t) * 8)
*/

/* We use a 32-bit size on all platforms, (even those with native 64
* bit types). This is consistent with the code currently in the X
* server, so it goes through much more well-tested code paths, (we
* saw rendering bugs when we tried IC_SHIFT==6 and uint64_t for
* pixman_bits_t on 64-bit platofrms). In addition, Keith says that
* his testing indicates that using 32-bits everywhere is a
* performance win in any case, (presumably due to 32-bit datapaths
* between the processor and the video card).
*/
#ifndef IC_SHIFT
#define IC_SHIFT 5
#define FB_SHIFT IC_SHIFT
typedef uint32_t pixman_bits_t;
#endif
Attachment (system_cairo.patch): text/x-patch, 8 KiB
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 0 comments |
headers
Peter Dennis Bartok | 9 Jul 2006 01:02

Re: allow using installed cairo in libgdiplus

John,

Using a statically linked version of cairo has helped us avoid many problems 
we've had in the past, related to wrong versions of cairo, dependency 
issues, etc. I avoids a cairo dependency on our libgdiplus package, and lets 
people use System.Drawing/WinForms without having to get other 3rd party 
stuff first.

If you're just worried about moving to 1.2, I do have a 1.2 update almost 
ready to check in, it should go into svn on Monday or Tuesday.

Cheers,
  Peter

-----Original Message-----
From: "John Luke" <john.luke <at> gmail.com>
To: <mono-winforms-list <at> lists.ximian.com>
Date: Saturday, 08 July, 2006 16:25
Subject: [Mono-winforms-list] allow using installed cairo in libgdiplus

>Hello,
>
>I wanted to see if I could make libgdiplus work with my installed
>version of cairo instead of the included one.  The attached is what I
>came up with and it seems to work ok.  There is currently one use of
>pixman in a few places and one use of cairo_ps_ api that was changed in
>the 1.2.0 release that prevent it from compiling against the released
>cairo 1.2.
>
>The use of pixman_bits_t seems to come from this:
>http://galactus.ximian.com/pipermail/mono-winforms-list/2005-February/001439.html
>but shouldn't it be 4 even on 64-bit machines?
>If not can we substitute a suitable glib type there?
>
>Here is the relevant part of pixman.h:
>/*
>* This single define controls the basic size of data manipulated
>* by this software; it must be log2(sizeof (pixman_bits_t) * 8)
>*/
>
>/* We use a 32-bit size on all platforms, (even those with native 64
>* bit types). This is consistent with the code currently in the X
>* server, so it goes through much more well-tested code paths, (we
>* saw rendering bugs when we tried IC_SHIFT==6 and uint64_t for
>* pixman_bits_t on 64-bit platofrms). In addition, Keith says that
>* his testing indicates that using 32-bits everywhere is a
>* performance win in any case, (presumably due to 32-bit datapaths
>* between the processor and the video card).
>*/
>#ifndef IC_SHIFT
>#define IC_SHIFT 5
>#define FB_SHIFT IC_SHIFT
>typedef uint32_t pixman_bits_t;
>#endif
> 

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 501 comments |
headers
John Luke | 9 Jul 2006 01:26
Picon

Re: allow using installed cairo in libgdiplus

On Sat, 2006-07-08 at 17:02 -0600, Peter Dennis Bartok wrote:
> John,
> 
> Using a statically linked version of cairo has helped us avoid many problems 
> we've had in the past, related to wrong versions of cairo, dependency 
> issues, etc. I avoids a cairo dependency on our libgdiplus package, and lets 
> people use System.Drawing/WinForms without having to get other 3rd party 
> stuff first.
Well this is more interesting for distributions that already have a usable version installed.
Although, it is reasonable to not want to support it.  Maybe the option
can be enabled with a warning that it is not supported and of course
defaults to the internal version?  If not I'll just keep mine locally,
no big deal.

> If you're just worried about moving to 1.2, I do have a 1.2 update almost 
> ready to check in, it should go into svn on Monday or Tuesday.
Not really, I just wanted to avoid having to build an old version of
cairo when I already have a newer one installed (in addition to see if
any old/internal API was being used).  But that is great to hear.

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 501 comments |
headers
latency | 9 Jul 2006 08:33
Picon
Picon

Compiling SWF && a little Bug in TextBoxBase

Hi there,

first of all, I'm new to Mono. So far the only thing I've done by using Mono 
was a little FooTesting SWF Application (attached to this email) , containing 
only a Label and a Textbox.

However, something odd happend in that App. I tried to show a MessageBox once 
my TextBox has been clicked. But the MessageBox did not appear.

I dug in little deeper and found out, that the Click Event has been redeclared 
in TextBoxBase, but is never fired.

Just out of curiosity I tried to fix the bug myself by commenting out the 
Click Event declaration in TextBoxBase.

But now I can't test my changes because MonoDevelop can't build SWF. (I got 
the whole mcs trunk from SVN and imported the VS2005 Project Files to 
MonoDevelop.) Is there something I'm missing?

Kind Regards,
Valentin S.
Attachment (TextBoxTest.cs): text/x-c++src, 790 bytes
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 0 comments |
headers
Peter Dennis Bartok | 9 Jul 2006 08:43

Re: Compiling SWF && a little Bug in TextBoxBase

Valentin,

The Click event has redeclared in TextBoxBase by Microsoft and we need to 
keep it that way to stay compatible. If we're not firing it in Mono when you 
click the textbox than that's a bug. Would you mind filing it at 
bugzilla.ximian.com (and attach your little sample app which very nicely 
shows the bug). This should be quick to fix.

As for building mcs, to build properly you need both mcs and mono checked 
out and built from svn; after that you can simply "make && make install" 
inside the Managed.Windows.Forms directory if you want to test patches. I've 
never tried using MonoDevelop to build, so I can't be much help there.

Cheers,
  Peter

-----Original Message-----
From: "latency" <latency <at> gmx.de>
To: <mono-winforms-list <at> lists.ximian.com>
Date: Sunday, 09 July, 2006 00:34
Subject: [Mono-winforms-list] Compiling SWF && a little Bug in TextBoxBase

>Hi there,
>
>first of all, I'm new to Mono. So far the only thing I've done by using 
>Mono
>was a little FooTesting SWF Application (attached to this email) , 
>containing
>only a Label and a Textbox.
>
>However, something odd happend in that App. I tried to show a MessageBox 
>once
>my TextBox has been clicked. But the MessageBox did not appear.
>
>I dug in little deeper and found out, that the Click Event has been 
>redeclared
>in TextBoxBase, but is never fired.
>
>Just out of curiosity I tried to fix the bug myself by commenting out the
>Click Event declaration in TextBoxBase.
>
>But now I can't test my changes because MonoDevelop can't build SWF. (I got
>the whole mcs trunk from SVN and imported the VS2005 Project Files to
>MonoDevelop.) Is there something I'm missing?
>
>Kind Regards,
>Valentin S.
> 

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 0 comments |
headers
kstock | 7 Jul 2006 22:32
Picon

DevExpress .net 1.1 components

Hello,
 
was anybody able to run the .net Samples out of the DXperienceEval-6.1.5.exe download.
 
When I tried any of the samples under mono no form was shown.
 
If I should provide more detailed information please ask.
 
Best regards
Karsten
 
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 0 comments |
headers
tut | 10 Jul 2006 18:01
Favicon

DataGrid regression in 1.1.16


Hi!

Does anybody from developers test DataGrid under Mono for windows? 

It does not work correct on Mono 1.1.16 for windows:

1) When i want to insert new record and set focus on last row on the grid
than application terminates immediately (on 1.1.15 it doesn't terminate)

2) Data changing not works: after editing of any DataGrid cell value and
changing focus on other cell or other controll DataGrid loose just-entered
value and replace it by old one.
--

-- 
View this message in context: http://www.nabble.com/DataGrid-regression-in-1.1.16-tf1919268.html#a5254265
Sent from the Mono - WinForms forum at Nabble.com.

_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
Permalink | Reply | 0 comments |

Gmane