Printing prettification patch
Joakim Ziegler <joakim <at> avmaria.com>
2003-06-26 18:18:08 GMT
Attached is a patch to mrproject, which modifies certain aspects of the
look of printed gantt charts. It's the result of trying to deploy Mr.
Project as a replacement for MS Project for simple project management in
the company where I work. We quickly discovered that the printing
functionality was rather useless for us, task names got clipped, and the
gantt charts were way too big, so we got a ton of pages printed, with no
way to adjust it.
I realize that the ideal way to fix this is to make things adjustable at
print time, but I'm sort of short on time here, hence the following
patch, which modifies the default sizes on things to something all
project leaders here at least agreed was much more sane.
The only real functionality it adds is that it makes the width of the
task name column depend on the length of the task names. This part of
the patch is based on Daniel Serpell's patch, which is in bug 552 in
bugzilla, but I made it use the actual indent level of each task instead
of assuming a max indent of three.
The rest of the patch just adjusts font sizes down, adjusts the scale
factor, to make the gantt charts less wide, and adjusts the size of the
milestone symbol up a bit. This change of defaults makes printing
insanely more useful for us, and I believe we are not a special case. In
fact, this patch makes the difference between MrProject being usable or
not for us...
Would you consider applying this patch as a stopgap measure until more
of the print parameters become configurable?
--
The Private Joakim Ziegler - Not Speaking For Anyone But Myself
joakim <at> avmaria.com - http://www.avmaria.com - rdgzt <at> Undernet
http://www.avmaria.com/ - http://www.fix.no/
Index: src/util/mg-print-job.c
===================================================================
RCS file: /cvs/gnome/mrproject/src/util/mg-print-job.c,v
retrieving revision 1.13
diff -u -r1.13 mg-print-job.c
--- src/util/mg-print-job.c 4 Feb 2003 09:19:45 -0000 1.13
+++ src/util/mg-print-job.c 26 Jun 2003 18:16:59 -0000
@@ -213,11 +213,11 @@
priv->header = NULL;
priv->footer = NULL;
- priv->font = gnome_font_find_closest ("Sans Regular", 10.0);
+ priv->font = gnome_font_find_closest ("Sans Regular", 6.0);
priv->font_height = (gnome_font_get_ascender (priv->font) +
gnome_font_get_descender (priv->font));
- priv->bold_font = gnome_font_find_closest ("Sans Bold", 10.0);
+ priv->bold_font = gnome_font_find_closest ("Sans Bold", 6.0);
priv->header_height = 0;
priv->footer_height = 0;
Index: src/views/gantt/mg-gantt-print.c
===================================================================
RCS file: /cvs/gnome/mrproject/src/views/gantt/mg-gantt-print.c,v
retrieving revision 1.18
diff -u -r1.18 mg-gantt-print.c
--- src/views/gantt/mg-gantt-print.c 18 May 2003 19:47:08 -0000 1.18
+++ src/views/gantt/mg-gantt-print.c 26 Jun 2003 18:16:59 -0000
@@ -1264,6 +1264,7 @@
GnomeFont *font;
GList *tasks = NULL, *l;
gint num_tasks;
+ gdouble max_name_width = 0.0;
data = g_new0 (MgGanttPrintData, 1);
@@ -1280,7 +1281,7 @@
* zoom level in the gantt chart, which actually is calculated to have a
* "good feel" :). We scale it width the paper size here though...
*/
- data->f = 500 / pow (2, level - 19) / data->job->width;
+ data->f = 1000 / pow (2, level - 19) / data->job->width;
data->major_unit = mg_scale_conf[level].major_unit;
data->major_format = mg_scale_conf[level].major_format;
@@ -1290,27 +1291,6 @@
font = mg_print_job_get_font (job);
- data->name_x1 = 0;
- data->name_x2 = data->name_x1 + gnome_font_get_width_utf8 (font, "TASKNAMETASKNAME");
-
- data->work_x1 = data->name_x2;
- data->work_x2 = data->work_x1 + gnome_font_get_width_utf8 (font, "WORKW");
-
- data->tree_x1 = 0;
- data->tree_x2 = data->work_x2;
-
- data->row_height = 2 * mg_print_job_get_font_height (job);
-
- data->header_height = 2 * data->row_height;
-
- /* Calculate drawing "constants". */
- data->summary_height = 0.36 * data->row_height;
- data->summary_thick = 0.12 * data->row_height;
- data->summary_slope = 0.28 * data->row_height;
- data->milestone_size = 0.20 * data->row_height;
- data->arrow_height = 0.24 * data->row_height;
- data->arrow_width = 0.16 * data->row_height;
-
data->task_start_coords = g_hash_table_new (NULL, NULL);
data->task_finish_coords = g_hash_table_new (NULL, NULL);
@@ -1332,14 +1312,42 @@
gchar *name;
mrptime finish;
gdouble width;
+ gdouble name_width;
gchar *str;
g_object_get (task, "name", &name, "finish", &finish, NULL);
-
+
+ name_width = gnome_font_get_width_utf8 (font, name) +
+ ptask->depth * INDENT_FACTOR * data->job->x_pad;
+ if (max_name_width < name_width)
+ max_name_width = name_width;
+
gantt_print_get_allocated_resources_string (data, task, &str, &width);
data->finish = MAX (data->finish, finish);/* + width * data->f);*/
}
+
+ data->name_x1 = 0;
+ data->name_x2 = data->name_x1 + max_name_width + gnome_font_get_width_utf8
+ (font, "WW");
+
+ data->work_x1 = data->name_x2;
+ data->work_x2 = data->work_x1 + gnome_font_get_width_utf8 (font, "WORKW");
+
+ data->tree_x1 = 0;
+ data->tree_x2 = data->work_x2;
+
+ data->row_height = 2 * mg_print_job_get_font_height (job);
+
+ data->header_height = 2 * data->row_height;
+
+ /* Calculate drawing "constants". */
+ data->summary_height = 0.36 * data->row_height;
+ data->summary_thick = 0.12 * data->row_height;
+ data->summary_slope = 0.28 * data->row_height;
+ data->milestone_size = 0.40 * data->row_height;
+ data->arrow_height = 0.24 * data->row_height;
+ data->arrow_width = 0.16 * data->row_height;
if (num_tasks > 0) {
data->tasks_per_page_with_header = data->job->height / data->row_height;
_______________________________________________
Mrproject-devel mailing list
Mrproject-devel <at> lists.codefactory.se
http://lists.codefactory.se/cgi-bin/mailman/listinfo/mrproject-devel
RSS Feed