Re: [OSM-dev] mod_tile svn's project variables 1)hardcoded 2)in many files
2010-02-03 00:09:38 GMT
Hi,
for the render_expired.c program (
)..
maximum zoom values all equal 18 and are hardcoded
this namely also concerns the twopow[18] array
thus the following macros give a segfault if all values 18 are replaced by something > 18 ; but it works ok for values <= 18 (tested with 16)
#define TILE_REQUESTED(z,x,y) \
(tile_requested[z][((x)*twopow[z]+(y))/(8*sizeof(int))]>>(((x)*twopow[z]+(y))%(8*sizeof(int))))&0x01
#define SET_TILE_REQUESTED(z,x,y) \
tile_requested[z][((x)*twopow[z]+(y))/(8*sizeof(int))] |= (0x01 << (((x)*twopow[z]+(y))%(8*sizeof(int))));
this expression : tile_requested[z][((x)*twopow[z]+(y))/(8*sizeof(int))] alone has been tested to be enough to trigger a segfault when function pipe's parameter z=30-3=27
I apologize to not be able to dig further...
can someone help remove the segfault if all 18 values are replaced by MAX_ZOOM (<=define included from render_config.h) and MAZ_ZOOM is different from 18 ?
Thanks so much in advance !!
Jonathan-David Schröder
Jonathan-David SCHRODER wrote:The only 2 hardcoded z18 references I could find for renderd/mod_tile
> for our project (Geopard) which does indoor & outdoor mapping, we need
> zoom levels up to 24 or so.
> mod_tile's svn's render_config.h defines a constand #define MAX_ZOOM 18
> (and also MIN_ZOOM)
> but this constant is used in only 2 or so files and the rest of max zoom
> values are hardcoded (just grep for 18 in the svn and you will find them)...
proper were in gen_tile.cpp. The other references are in the python
support scripts, none of which play a crucial role in normal renderd
operation.
Unless you use renderd.py instead of renderd, that is. There is another
hardcoded 18 in there.
I increased my renderd to z19 for haiti related tiles, and that was as
easy as changing those 2 hardcoded '18' occurences and the MAX_ZOOM
define to 19.
--
Lennard
_______________________________________________
dev mailing list
dev <at> openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev
_______________________________________________ dev mailing list dev <at> openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
RSS Feed