headers
David Sheldon | 1 Apr 2006 13:02
Picon

Re: [OSM-dev] java applet reformatted

On Wed, Feb 22, 2006 at 10:22:41AM +0100, Immanuel Scholz wrote:
> Hi,
> 
> 
> >> - Tab size is 4
> >
> > Mine is 8 :p  It's 2 in Processing, which is where the applet originates.
> 
> Okok.. "Indent size is 4".
> 
> But I use spaces anyway. (Most Java editors default the tab size to 4.)

Can we put in the code style that files should be formatted with spaces,
indented at level 4. This will probably reduce confusion here.

Is there a wiki page on Java coding style?

David

--

-- 
"There are two ways to write software. The first is to make it so simple it
obviously has no mistakes, the second is to make it so complex that it has no
obvious mistakes" -- Tony Hoare
Permalink | Reply | 4 comments |
headers
immanuel.scholz | 1 Apr 2006 13:17
Picon
Picon

Re: [OSM-dev] java applet reformatted

Hi,

> Can we put in the code style that files should be formatted with spaces,
> indented at level 4. This will probably reduce confusion here.

No problem with me. But should we really change all the files now?

Ciao, Imi.
Permalink | Reply | 3 comments |
headers
David Sheldon | 1 Apr 2006 13:25
Picon

Re: [OSM-dev] java applet reformatted

On Sat, Apr 01, 2006 at 01:17:37PM +0200, immanuel.scholz <at> gmx.de wrote:
> Hi,
> 
> > Can we put in the code style that files should be formatted with spaces,
> > indented at level 4. This will probably reduce confusion here.
> 
> No problem with me. But should we really change all the files now?

No. Maybe we should just change them when we reformat them, or when we
commit them. This will make the stats for the diffs a little less
accurate but diff -w should help anyone stuck out.

David
--

-- 
UNIX was not designed to stop you from doing stupid things, because that
would also stop you from doing clever things.
		-- Doug Gwyn
Permalink | Reply | 2 comments |
headers
Dan Karran | 2 Apr 2006 17:02
Gravatar

[OSM-dev] Stylesheet update

I've noticed for a while that the CC logo and the map controls on
edit.html were conflicting with each other. Today I finally thought to
look at it and fix it. Making the following changes to style.css
should fix it for now, but only until other elements are changed.
Making them all relative would help with that, but perhaps there was a
reason to keep things absolute?

#mapToolbar {
  position: absolute;
  /*left: 710px;*/
  left: 30px;
  top: 370px;
  border-width: 0;
}

#cclogo {
  width: 150px;
  min-width: 150px;
  margin: 10px;
  padding: 10px;
  left: 0px;
  line-height: 1.2em;
  text-align: Left;
  font-size: 14px;
  font-weight: bold;
  background: #fff;
  top: 510px;
  position: absolute;
}
(Continue reading)

Permalink | Reply | 2 comments |
headers
Mikel Maron | 2 Apr 2006 19:21
Picon
Favicon
Gravatar

Re: [OSM-dev] Stylesheet update

There was no reason to make them absolute beyond getting the page to look correct -- if you can work out better
css you're welcome to commit those changes.

One requirement is that the slippy map and java editor appear in the same location .. so that clicking
between tabs looks fluid. The css needs to work crossbrowser of course (I run windows here, so can check IE
for you if needed). You'll also see that the "Login/Register" link is double underlined in Firefox, and
misaligned in IE .. is there a consistent way to get that line to extend across?

----- Original Message ----
From: Dan Karran <dan <at> karran.net>
To: dev <at> openstreetmap.org
Sent: Sunday, April 2, 2006 4:02:24 PM
Subject: [OSM-dev] Stylesheet update

I've noticed for a while that the CC logo and the map controls on
edit.html were conflicting with each other. Today I finally thought to
look at it and fix it. Making the following changes to style.css
should fix it for now, but only until other elements are changed.
Making them all relative would help with that, but perhaps there was a
reason to keep things absolute?

#mapToolbar {
  position: absolute;
  /*left: 710px;*/
  left: 30px;
  top: 370px;
  border-width: 0;
}

#cclogo {
(Continue reading)

Permalink | Reply | 1 comment |
headers
Dan Karran | 2 Apr 2006 21:12
Gravatar

Re: [OSM-dev] Stylesheet update

Ok, I'll take a bit of a look and see if I can fix those bits up a little.

Cheers,
Dan

On 4/2/06, Mikel Maron <mikel_maron <at> yahoo.com> wrote:
> There was no reason to make them absolute beyond getting the page to look correct -- if you can work out
better css you're welcome to commit those changes.
>
> One requirement is that the slippy map and java editor appear in the same location .. so that clicking
between tabs looks fluid. The css needs to work crossbrowser of course (I run windows here, so can check IE
for you if needed). You'll also see that the "Login/Register" link is double underlined in Firefox, and
misaligned in IE .. is there a consistent way to get that line to extend across?
>
> ----- Original Message ----
> From: Dan Karran <dan <at> karran.net>
> To: dev <at> openstreetmap.org
> Sent: Sunday, April 2, 2006 4:02:24 PM
> Subject: [OSM-dev] Stylesheet update
>
> I've noticed for a while that the CC logo and the map controls on
> edit.html were conflicting with each other. Today I finally thought to
> look at it and fix it. Making the following changes to style.css
> should fix it for now, but only until other elements are changed.
> Making them all relative would help with that, but perhaps there was a
> reason to keep things absolute?
>
>
> #mapToolbar {
>   position: absolute;
(Continue reading)

Permalink | Reply | 0 comments |
headers
immanuel.scholz | 2 Apr 2006 22:44
Picon
Picon

[OSM-dev] onearth-WMS featuring Mercator?

Hi,

does anyone know where I can get a WMS server which delivers mercator 
projected images?

onearth seem to deliver EPSG:4236 only.

Ciao, Imi.
Permalink | Reply | 0 comments |
headers
Petter Reinholdtsen | 2 Apr 2006 23:09

[OSM-dev] [patch] Build and runtime fixes for the applet


Here are a few patches I have in my svn three.  Please commit them to
the official version.

 - Avoid printing long lines in runapplet.sh
 - Add support for passing arguments to the java program
 - Avoid long line in src/org/openstreetmap/processing/OsmApplet.java
 - Make sure required directory gui/ is created by ant if missing.

Index: runapplet.sh
===================================================================
--- runapplet.sh        (revision 954)
+++ runapplet.sh        (working copy)
 <at>  <at>  -7,23 +7,24  <at>  <at> 
     exit 1
 fi

+user="$1"; shift
+pass="$1"; shift

 if [ ! -d ./dist ] ; then
     echo "You must first build the applet using ant"
     nothing=`which ant`
     if [ $? -ne 0 ] ; then
-        echo "It appears you don't have ant installed. Install ant then run ant in the current directory"
+        echo "It appears you don't have ant installed."
+        echo "Install ant then run ant in the current directory"
     fi
     nothing=`which javac`
     if [ $? -ne 0 ] ; then
(Continue reading)

Permalink | Reply | 0 comments |
headers
Petter Reinholdtsen | 2 Apr 2006 23:12

Re: [OSM-dev] java applet reformatted


[David Sheldon]
> No. Maybe we should just change them when we reformat them, or when
> we commit them. This will make the stats for the diffs a little less
> accurate but diff -w should help anyone stuck out.

Is there an elegant way to use diff -w with svn?
Permalink | Reply | 1 comment |
headers
immanuel.scholz | 2 Apr 2006 23:34
Picon
Picon

Re: [OSM-dev] java applet reformatted

On Sunday 02 April 2006 23:12, Petter Reinholdtsen wrote:
> [David Sheldon]
>
> > No. Maybe we should just change them when we reformat them, or when
> > we commit them. This will make the stats for the diffs a little less
> > accurate but diff -w should help anyone stuck out.
>
> Is there an elegant way to use diff -w with svn?

Unfortunatly only an ugly way (instead of "svn diff"):

svn diff --diff-cmd diff -x -w

Ciao, Imi.
Permalink | Reply | 0 comments |

Gmane