For patch submissions and discussion

Pierre Muller | 1 Apr 2011 07:12

Picon

RE: [RFC 1/9] Unify windows specifics into common/windows-hdep files

> > From: "Pierre Muller" <pierre.muller <at> ics-cnrs.unistra.fr>
> > Cc: <gdb-patches <at> sourceware.org>
> > Date: Wed, 30 Mar 2011 23:32:36 +0200
> >
> > > > +#undef _G_SUFFIX
> > >
> > > I think the C Standard says that macros whose name begins with an
> > > underscore and a capital letter are reserved.  Applications should not
> > > use such macros.
> >
> >   But we are also using __USEWIDE before my patch ...
> >  or do you mean that two underscores are OK?
> 
> No, AFAIK macros that begin with two underscores are also reserved.

  But nobody protested for __USEWIDE nor for __PMAX for instance...
But checking gdb directory, it seems that are only a fee macros 
starting with an underscore.

> >   I completely remove __USEWIDE and tried to replace it by this new
> > USE_WIDE_WINAPI.
> >   Or is this __USEWIDE macro used anywhere else than inside GDB code?
> 
> I don't think so, but maybe someone else could tell for sure.
> 
> >   Should I rather call the macro USE_UNICODE_WINAPI
> >  (and USE_ANSI_WINAPI to force ANSI version?)
> 
> I don't think it matters what the macro is called.

(Continue reading)

Jan Kratochvil | 1 Apr 2011 07:25

Picon

Regression: Re: FYI: fix varobj bug with python iterator errors

Hi Tom,

On Thu, 31 Mar 2011 21:58:45 +0200, Tom Tromey wrote:
> I'm checking this in.
[...]
> Built and regtested on x86-64 (compile farm).
[...]
> 2011-03-31  Tom Tromey  <tromey <at> redhat.com>
> 
> 	* varobj.c (update_dynamic_varobj_children): Properly handle
> 	errors from iterator.
> 
> 2011-03-31  Tom Tromey  <tromey <at> redhat.com>
> 
> 	* gdb.python/py-prettyprint.py (exception_flag): New global.
> 	(NoStringContainerPrinter._iterator.next): Check it.
> 	* gdb.python/py-prettyprint.c (main): New variable nstype2.
> 	* gdb.python/py-mi.exp: Set exception_flag and do more tests.

This commit 837e99b31775e6a75a593259738924bf050650d2 has regressions on
{x86_64-m32,i686}-{fedora15,rawhide}-linux-gnu, it still PASSes on
x86_64-{fedora15,rawhide}-linux-gnu, it also still PASSes on
{x86_64,x86_64-m32,i686}-fedora{13,14}-linux-gnu.

Thanks,
Jan

diff -dup -rU9999 pass/gdb.sum fail/gdb.sum
--- pass/gdb.sum	2011-04-01 07:18:38.000000000 +0200
+++ fail/gdb.sum	2011-04-01 07:20:28.000000000 +0200

(Continue reading)

Eli Zaretskii | 1 Apr 2011 10:39

Picon

Re: [RFC 1/9] Unify windows specifics into common/windows-hdep files

> From: "Pierre Muller" <pierre.muller <at> ics-cnrs.unistra.fr>
> Cc: <gdb-patches <at> sourceware.org>
> Date: Fri, 1 Apr 2011 07:12:42 +0200
> 
> > > From: "Pierre Muller" <pierre.muller <at> ics-cnrs.unistra.fr>
> > > Cc: <gdb-patches <at> sourceware.org>
> > > Date: Wed, 30 Mar 2011 23:32:36 +0200
> > >
> > > > > +#undef _G_SUFFIX
> > > >
> > > > I think the C Standard says that macros whose name begins with an
> > > > underscore and a capital letter are reserved.  Applications should not
> > > > use such macros.
> > >
> > >   But we are also using __USEWIDE before my patch ...
> > >  or do you mean that two underscores are OK?
> > 
> > No, AFAIK macros that begin with two underscores are also reserved.
> 
>   But nobody protested for __USEWIDE nor for __PMAX for instance...
> But checking gdb directory, it seems that are only a fee macros 
> starting with an underscore.

Again, I think it's bad practice to use such macros, but that's me.
If no one else cares, you can disregard me on that account.

> > > > > +# define CreateProcess CreateProcessW
> > > > > +# define GetSystemDirectory GetSystemDirectoryW
> > > > > +# define windows_strlen wcslen
> > > >

(Continue reading)

Pierre Muller | 1 Apr 2011 11:23

Picon

RE: [RFC 1/9] Unify windows specifics into common/windows-hdep files


> -----Message d'origine-----
> De : gdb-patches-owner <at> sourceware.org [mailto:gdb-patches-
> owner <at> sourceware.org] De la part de Eli Zaretskii
> Envoyé : vendredi 1 avril 2011 10:39
> À : Pierre Muller
> Cc : gdb-patches <at> sourceware.org
> Objet : Re: [RFC 1/9] Unify windows specifics into common/windows-hdep
files
> 
> > From: "Pierre Muller" <pierre.muller <at> ics-cnrs.unistra.fr>
> > Cc: <gdb-patches <at> sourceware.org>
> > Date: Fri, 1 Apr 2011 07:12:42 +0200
> >
> > > > From: "Pierre Muller" <pierre.muller <at> ics-cnrs.unistra.fr>
> > > > Cc: <gdb-patches <at> sourceware.org>
> > > > Date: Wed, 30 Mar 2011 23:32:36 +0200
> > > >
> > > > > > +#undef _G_SUFFIX
> > > > >
> > > > > I think the C Standard says that macros whose name begins with an
> > > > > underscore and a capital letter are reserved.  Applications should
> not
> > > > > use such macros.
> > > >
> > > >   But we are also using __USEWIDE before my patch ...
> > > >  or do you mean that two underscores are OK?
> > >
> > > No, AFAIK macros that begin with two underscores are also reserved.
> >

(Continue reading)

Ulrich Weigand | 1 Apr 2011 13:58

Picon

Re: [rfc, arm] Always use correct execution state for single-step breakpoints

> gdb/
> 	* arm-tdep.h (arm_insert_single_step_breakpoint): Add prototype.
> 	* arm-tdep.c (arm_override_mode): New global.
> 	(arm_pc_is_thumb): Respect arm_override_mode.  Remove single-step
> 	execution mode heuristics.
> 	(thumb_get_next_pc_raw): Remove INSERT_BKTP argument; always insert
> 	second single-step breakpoint if needed, using
> 	arm_insert_single_step_breakpoint.
> 	(arm_get_next_pc_raw): Remove INSERT_BKTP argument.  Only handle
> 	ARM execution mode, do not call thumb_get_next_pc_raw.
> 	(arm_get_next_pc): Encode execution mode in return value.  Call
> 	either arm_get_next_pc_raw or thumb_get_next_pc_raw.
> 	(arm_insert_single_step_breakpoint): New function.
> 	(arm_software_single_step): Call it.
> 	* arm-linux-tdep.c (arm_linux_sigreturn_return_addr): Add IS_THUMB
> 	argument to return execution mode of sigreturn target.
> 	(arm_linux_syscall_next_pc): Use it.
> 	(arm_linux_copy_svc): Update call.
> 	(arm_linux_software_single_step): Call
> 	arm_insert_single_step_breakpoint.
> 
> gdb/testsuite/
> 	* gdb.arch/thumb-singlestep.S: New file.
> 	* gdb.arch/thumb-singlestep.exp: Likewise.

I've checked this in now.

Bye,
Ulrich

(Continue reading)

Pedro Alves | 1 Apr 2011 17:09

FAIL: gdb.cp/cpexprs.exp: list base::overload(void)

I've been seeing these failures for a long while:

FAIL: gdb.cp/cpexprs.exp: list base::overload(void)
FAIL: gdb.cp/cpexprs.exp: setting breakpoint at base::overload(void)
FAIL: gdb.cp/cpexprs.exp: continue to base::overload(void)

gdb.log shows:

 list base::overload(void)
 the class `base' does not have any method instance named overload(void)
 (gdb) FAIL: gdb.cp/cpexprs.exp: list base::overload(void)

and indeed, base::overload(void) is const:

  // Some overloaded methods
  int overload (void) const { return 0; } // base::overload(void) const
  int overload (int i) const { return 1; } // base::overload(int) const
  int overload (short s) const { return 2; } // base::overload(short) const
  int overload (long l) const { return 3; } // base::overload(long) const
  int overload (char* a) const { return 4; } // base::overload(char*) const
  int overload (base& b) const { return 5; } // base::overload(base&) const

cpexprs.exp test all the other overloads with an explicit "const", but
the (void) one is tested for both const and non-nonst variants:

> # Overloaded methods (all are const -- we try to use the void
> # method with and without specifying "const")

Why is the non-const variant tried and expected to pass?

(Continue reading)

Tom Tromey | 1 Apr 2011 17:21

Picon

Re: [patch] Fix gdb.cp/ovsrch.exp C++ regression-by-.gdb_index

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil <at> redhat.com> writes:

Jan> 2011-03-30  Jan Kratochvil  <jan.kratochvil <at> redhat.com>
Jan> 	* dwarf2read.c (find_slot_in_mapped_hash): New variable back_to,
Jan> 	initialize it.  Delay HASH initialization.  Strip the part after open
Jan> 	parenthesis for languages with qualifiers.  Call do_cleanups.

Looks ok to me.

thanks,
Tom

Pedro Alves | 1 Apr 2011 17:23

Fix build (was: Re: [rfc, arm] Always use correct execution state for single-step breakpoints)

On Friday 01 April 2011 12:58:44, Ulrich Weigand wrote:
> > gdb/
> >       * arm-tdep.h (arm_insert_single_step_breakpoint): Add prototype.

This broke arm-bsd or --enable-targets=all builds:

In file included from ../../src/gdb/armnbsd-tdep.c:26:
../../src/gdb/arm-tdep.h:315: error: ‘struct address_space’ declared inside parameter list
../../src/gdb/arm-tdep.h:315: error: its scope is only this definition or declaration, which is
probably not what you want

I've applied the obvious fix below.

--

-- 
Pedro Alves

2011-04-01  Pedro Alves  <pedro <at> codesourcery.com>

	gdb/
	* arm-tdep.h (struct address_space): Add forward declaration.

---
 gdb/arm-tdep.h |    1 +
 1 file changed, 1 insertion(+)

Index: src/gdb/arm-tdep.h
===================================================================
--- src.orig/gdb/arm-tdep.h	2011-04-01 15:08:25.000000000 +0100
+++ src/gdb/arm-tdep.h	2011-04-01 15:29:30.899770002 +0100
 <at>  <at>  -23,6 +23,7  <at>  <at>

(Continue reading)

Ulrich Weigand | 1 Apr 2011 17:41

Picon

Re: Fix build (was: Re: [rfc, arm] Always use correct execution state for single-step breakpoints)

Pedro Alves wrote:
> On Friday 01 April 2011 12:58:44, Ulrich Weigand wrote:
> > > gdb/
> > >       * arm-tdep.h (arm_insert_single_step_breakpoint): Add prototype.
> 
> This broke arm-bsd or --enable-targets=3Dall builds:

Oops, sorry for that.

> I've applied the obvious fix below.

Thanks!

Bye,
Ulrich

--

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand <at> de.ibm.com

Thiago Jung Bauermann | 1 Apr 2011 17:44

Picon

Re: [RFC] Cleanup breakpoint_re_set_one

Hi,

On Mon, 2011-03-21 at 18:14 -0300, Thiago Jung Bauermann wrote:
> Tested with no regressions on ppc-linux and ppc64-linux. WDYT?

This is a refreshed version of the patch, which applies on
today's CVS HEAD.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center

2011-04-01  Thiago Jung Bauermann  <bauerman <at> br.ibm.com>

	* breakpoint.c (addr_string_to_sals): Cleanup logic of the
	conditon expressions in the error handling code.

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 3b1367b..6d7c234 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
 <at>  <at>  -10979,33 +10979,26  <at>  <at>  addr_string_to_sals (struct breakpoint *b, char *addr_string, int *found)
 	sals = decode_line_1 (&s, 1, (struct symtab *) NULL, 0,
 			      NULL, &not_found);
     }
-  if (e.reason < 0)
-    {
-      int not_found_and_ok = 0;
-      /* For pending breakpoints, it's expected that parsing will
-	 fail until the right shared library is loaded.  User has

(Continue reading)

Group

gmane.comp.gdb.patches.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 58

Articles in period: 578

April 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH] Fix wp-replication.exp for targets that provide only 1 hw watc (24 May 2013)
[commit] New board file fission-dwp.exp (24 May 2013)
[commit] Handle no dwo files for cc-with-tweaks.sh -p. (24 May 2013)
Small patch to enable build of gdb-7.6 for GNU/Hurd (23 May 2013)
Exit code of exited inferiors (22 May 2013)
[PATCH] Revised display-linkage-name (22 May 2013)
[PATCH 1/7] PR gdb/15224 "set history filename" to by immediately conv (22 May 2013)
[PATCH 2/7] [PR gdb/15224] Unify interactivity tests to use input_from (22 May 2013)
New ARI warning Wed May 22 01:51:06 UTC 2013 in -D 2013-05-22-gmt (22 May 2013)
[RFC] Support temporary breakpoints in runto_main. (22 May 2013)
[patch] Fix wp-replication.exp on llvm (22 May 2013)
[patch] Fix crash in svr4_clear_so (22 May 2013)
[PATCH] dwarf2read.c: Don't assume uint32_t is unsigned int on all hos (21 May 2013)
[PATCH] common/filestuff.c: No sockets on DJGPP. (21 May 2013)
[PATCH] [readline] Fix !djgpp x djgpp canadian builds. (21 May 2013)
[PATCH] New board file remote-stdio-gdbserver.exp (21 May 2013)
[patch] Convert uiout->levels to a vector (21 May 2013)
[RFA/Doco] Document new /system-gdbinit area (21 May 2013)
RFC: fix ref counting in gdbpy_selected_inferior (20 May 2013)
RFC: another Python refcounting fix (20 May 2013)
[OB COMMITTED] Add missing empty line after var declarations in handle (20 May 2013)

Archives

906	May 2013
895	April 2013
1127	March 2013
773	February 2013
778	January 2013
844	December 2012
964	November 2012
570	October 2012
715	September 2012
907	August 2012
826	July 2012
870	June 2012
1111	May 2012
1091	April 2012
1088	March 2012
748	February 2012
1021	January 2012
924	December 2011
859	November 2011
824	October 2011
576	September 2011
680	August 2011
833	July 2011
504	June 2011
712	May 2011
570	April 2011
1236	March 2011
945	February 2011
603	January 2011
572	December 2010
512	November 2010
408	October 2010
525	September 2010
587	August 2010
610	July 2010
702	June 2010
699	May 2010
1027	April 2010
1123	March 2010
709	February 2010
661	January 2010
479	December 2009
610	November 2009
710	October 2009
977	September 2009
592	August 2009
777	July 2009
903	June 2009
677	May 2009
832	April 2009
711	March 2009
507	February 2009
547	January 2009
476	December 2008
731	November 2008
724	October 2008
595	September 2008
712	August 2008
589	July 2008
599	June 2008
779	May 2008
716	April 2008
516	March 2008
504	February 2008
884	January 2008
489	December 2007
573	November 2007
880	October 2007
431	September 2007
549	August 2007
345	July 2007
547	June 2007
449	May 2007
424	April 2007
384	March 2007
387	February 2007
630	January 2007
426	December 2006
425	November 2006
325	October 2006
219	September 2006
230	August 2006
443	July 2006
419	June 2006
484	May 2006
399	April 2006
392	March 2006
514	February 2006
495	January 2006
323	December 2005
515	November 2005
237	October 2005
294	September 2005
264	August 2005
243	July 2005
397	June 2005
653	May 2005
462	April 2005
399	March 2005
303	February 2005
312	January 2005
451	December 2004
542	November 2004
562	October 2004
498	September 2004
791	August 2004
565	July 2004
702	June 2004
799	May 2004
726	April 2004
776	March 2004
907	February 2004
785	January 2004
543	December 2003
631	November 2003
901	October 2003
672	September 2003
553	August 2003
569	July 2003
886	June 2003
602	May 2003
556	April 2003
620	March 2003
833	February 2003
854	January 2003
773	December 2002
769	November 2002
621	October 2002
789	September 2002
1071	August 2002
640	July 2002
593	June 2002
1058	May 2002
146	April 2002
1	October 2001

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template