headers
Joel Brobecker | 1 Dec 2009 19:58
Favicon

Re: [PATCH] sim/h8300 different result some addressing

> > > +2009-11-23  Yoshinori Sato <ysato <at> users.sourceforge.jp>
> > > +	* compile.c(fetch_1): Fix pre-dec, pre-inc, post-dec and post-inc.
> > > +	Index registers not masked memory areas.
> > > +	Only simply increment or decrement.
> > > +	* compile.c(store_1): Ditto.

OK.

> This CPU instruction manual is here.
> http://documentation.renesas.com/eng/products/mpumcu/rej09b0139_h8s2600.pdf

I do appreciate being pointed to the documentation, and I learnt
a new syntax I hadn't seen before. But when I say I will trust you
on something, I really mean it. So feel free to commit when I approve
a patch based on this.

--

-- 
Joel
Permalink | Reply | 2 comments |
headers
Maciej W. Rozycki | 1 Dec 2009 20:53

Re: RFC: Fix "break *EXP thread NUM"

On Wed, 25 Nov 2009, Daniel Jacobowitz wrote:

> > Meanwhile, here's a patch that handles "t" and "task".  I talked to
> > Andrew about this, and I still think we can get away without "+N" and
> > "-N"; they're only accepted by an accident of strtol.
> 
> I have checked this in.

 While we are at it -- it may be worth thinking about propagating thread 
information associated with breakpoints and watchpoints down to the 
respective backends.  Some processors (like the MIPS 34K multi-threaded 
core) supports thread qualification for execution and data breakpoints in 
hardware and debug stubs would be eager to make use of that for 
performance gain.  Has it been considered before?

  Maciej
Permalink | Reply | 1 comment |
headers
Daniel Jacobowitz | 1 Dec 2009 21:03

Re: RFC: Fix "break *EXP thread NUM"

On Tue, Dec 01, 2009 at 07:53:37PM +0000, Maciej W. Rozycki wrote:
>  While we are at it -- it may be worth thinking about propagating thread 
> information associated with breakpoints and watchpoints down to the 
> respective backends.  Some processors (like the MIPS 34K multi-threaded 
> core) supports thread qualification for execution and data breakpoints in 
> hardware and debug stubs would be eager to make use of that for 
> performance gain.  Has it been considered before?

It's been discussed before, but no one has ever sat down to do the
work.

--

-- 
Daniel Jacobowitz
CodeSourcery
Permalink | Reply | 0 comments |
headers
Daniel Jacobowitz | 1 Dec 2009 21:09

Re: Ping Re: Fix Solaris gcore / shared libraries interaction

On Sat, Nov 28, 2009 at 08:11:51PM +0000, Joseph S. Myers wrote:
> Ping.  This patch 
> <http://sourceware.org/ml/gdb-patches/2009-11/msg00454.html> is pending 
> review.

This patch is OK.

--

-- 
Daniel Jacobowitz
CodeSourcery
Permalink | Reply | 0 comments |
headers
Tom Tromey | 1 Dec 2009 21:45
Picon
Favicon

Re: [patch] testcase: Fix spurious structs.exp FAILs

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil <at> redhat.com> writes:

Jan> gdb/testsuite/
Jan> 2009-11-29  Jan Kratochvil  <jan.kratochvil <at> redhat.com>
Jan> 	Fix spurious false FAILs.
Jan> 	* gdb.base/structs.c (chartest): New.
Jan> 	(main): Fill-in chartest.
Jan> 	* gdb.base/structs.exp (anychar_re, first): New.
Jan> 	(start_structs_test): Import global anychar_re and first.
Jan> 	New gdb_test call "set print elements 300; ${testfile}"
Jan> 	(start_structs_test <$first>): New block.
Jan> 	(any): Import global anychar_re.  New variable ac.  Use ${ac}.

Ok.

Tom
Permalink | Reply | 1 comment |
headers
Tom Tromey | 1 Dec 2009 21:51
Picon
Favicon

Re: [python][patch] Add is_base_class attribute to fields.

>>>>> "Phil" == Phil Muldoon <pmuldoon <at> redhat.com> writes:

Phil> Later I fixed a bug/added tests to capture a regression this
Phil> functionality caused.
Phil> http://sourceware.org/ml/archer/2009-q4/msg00016.html?

The tests are nice but they don't actually check the is_base_class field.
Could you add a test to do that?

Other than that I think the code bits are ok.  It needs a doc review.

Phil> +# Run a command in GDB, and report a failure if a Python exception is
Phil> thrown.

Your mailer seems to have wrapped the patch.

Tom
Permalink | Reply | 5 comments |
headers
Phil Muldoon | 1 Dec 2009 22:13
Picon
Favicon

Re: [python][patch] Add is_base_class attribute to fields.

On 12/01/2009 08:51 PM, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon<pmuldoon <at> redhat.com>  writes:
>
> Phil>  Later I fixed a bug/added tests to capture a regression this
> Phil>  functionality caused.
> Phil>  http://sourceware.org/ml/archer/2009-q4/msg00016.html?
>
> The tests are nice but they don't actually check the is_base_class field.
> Could you add a test to do that?

Sure, I'll add a test. The tests I added were testing a regression 
(#10805) for non C++ inferiors accessing fields, but were seg-fault'ing 
on the C++ specific parts of is_base_class (That was my contribution). 
But I take your point. The added tests should be pretty simple!

>
> Other than that I think the code bits are ok.  It needs a doc review.
>
> Phil>  +# Run a command in GDB, and report a failure if a Python exception is
> Phil>  thrown.
>
> Your mailer seems to have wrapped the patch.

Apologies. I just upgraded from F11 -> F12, and this is an in-line 
patch, something I don't normally do. I'll fix the relevant regressive 
Thunderbird bits for next time.

Cheers,

Phil
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ralf Wildenhues | 1 Dec 2009 22:40
Picon
Picon

Sync from upstream Libtool

In conjunction with
<http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01749.html>
I'd like to sync from git Libtool to binutils and gdb.  OK?

I've built binutils-gdb on x86_64-unknown-linux-gnu and tested
with no regressions.  The attached patch contains only the non-
generated changes.

Thanks,
Ralf

ChangeLog:
2009-12-01  Ralf Wildenhues  <Ralf.Wildenhues <at> gmx.de>

	* libtool.m4: Sync from git Libtool.
	* ltmain.sh: Likewise.
	* ltoptions.m4: Likewise.
	* ltversion.m4: Likewise.
	* lt~obsolete.m4: Likewise.

sim/iq2000/ChangeLog:
2009-12-01  Ralf Wildenhues  <Ralf.Wildenhues <at> gmx.de>

	* configure: Regenerate.

sim/d10v/ChangeLog:
2009-12-01  Ralf Wildenhues  <Ralf.Wildenhues <at> gmx.de>

	* configure: Regenerate.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tom Tromey | 1 Dec 2009 23:15
Picon
Favicon

FYI: fix typo in documentation

A user on irc pointed out a typo in a footnote.

I'm checking in this fix as obvious.

Tom

2009-12-01  Tom Tromey  <tromey <at> redhat.com>

	* gdb.texinfo (Reverse Execution): Fix typo.

Index: gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.644
diff -u -r1.644 gdb.texinfo
--- gdb.texinfo	25 Nov 2009 20:43:29 -0000	1.644
+++ gdb.texinfo	1 Dec 2009 22:13:43 -0000
 <at>  <at>  -5356,7 +5356,7  <at>  <at> 
 to the caller of that function,  <at> emph{before} the function was called,
 just as the normal  <at> code{next} command would take you from the last 
 line of a function back to its return to its caller
- <at> footnote{Unles the code is too heavily optimized.}.
+ <at> footnote{Unless the code is too heavily optimized.}.

  <at> kindex reverse-nexti
  <at> kindex rni  <at> r{( <at> code{reverse-nexti})}
Permalink | Reply | 0 comments |
headers
Tom Tromey | 1 Dec 2009 23:26
Picon
Favicon

Re: [RFA] let record_resume fail immediately on error

>>>>> ">" == Hui Zhu <teawater <at> gmail.com> writes:

>> What about following change:
>> Change record_message to record_message (struct regcache *regcache,
>> enum target_signal signal)
[...]

>> Do you think it's OK?

I think that addresses my complaints.  Thanks.

Tom
Permalink | Reply | 5 comments |

Gmane