headers
Tom Tromey | 1 Jul 2009 04:26
Picon
Favicon

Re: [RFA] Fix too many "no debugging symbols found" warnings.

>>>>> "Doug" == Doug Evans <dje <at> google.com> writes:

Doug> Righto.  I took Tom's email as approval of the patch, his only concern
Doug> was to wait to let people comment on the output.

Yes, that was my intent.

Tom
Permalink | Reply | 0 comments |
headers
paawan oza | 1 Jul 2009 05:01
Picon
Favicon

Re: Submition of i386.record.floating.point.patch


Hi,
I am bit relieved to see humble explanation from your side.
I was not aware of the things which you have mentioned. 
As I am excited about contribution, I sounded bit hurrying : )
I am sorry for any inconvenience caused.
I will made sure that the test which testes the patch, goes into gdb testsuite.
Regards,
Oza.

--- On Wed, 7/1/09, Michael Snyder <msnyder <at> vmware.com> wrote:

> From: Michael Snyder <msnyder <at> vmware.com>
> Subject: Re: Submition of i386.record.floating.point.patch
> To: "paawan oza" <paawan1982 <at> yahoo.com>, gdb-patches <at> sourceware.org
> Date: Wednesday, July 1, 2009, 12:20 AM
> paawan oza wrote:
> > Hi,
> > I have been waiting long for the first patch to go.
> > I have bee trying hard to give explanations and
> include review comments if any.
> > I request, please review the patch and provide your
> acceptance.
> > It would be nice to see myself contributing in
> reversible as much as possible.
> > 
> > the questions asked by Hui, have already been
> clarified.
> > please see the below mail.
> >
(Continue reading)

Permalink | Reply | 24 comments |
headers
Eli Zaretskii | 1 Jul 2009 05:03
Picon

Re: [RFA] NEWS entry for recent gdbserver additions

> Date: Tue, 30 Jun 2009 14:36:18 -0700 (PDT)
> From: dje <at> google.com (Doug Evans)
> 
> Hi.
> Forgot NEWS entries for these.
> 
> Ok to check in?

Yes, thanks.
Permalink | Reply | 0 comments |
headers
Eli Zaretskii | 1 Jul 2009 05:13
Picon

Re: [RFA] Fix too many "no debugging symbols found" warnings.

> Date: Tue, 30 Jun 2009 14:49:25 -0700
> From: Doug Evans <dje <at> google.com>
> Cc: Tom Tromey <tromey <at> redhat.com>, gdb-patches <gdb-patches <at> sourceware.org>,
>         Pedro Alves <pedro <at> codesourcery.com>
> 
> Eli, are the docs ok?

The text is okay, but I'm not sure it is accurate wrt the implementation.

> +The  <at> code{set print symbol-loading-warnings} command allows you to enable or
> +disable printing of warning messages when  <at> value{GDBN} implicitly loads symbols
> +for files.

This text seems to say that we will print a warning when symbols are
loaded ``implicitly'', whatever that means.  But in fact, aren't the
warnings issued for files that have _no_ debugging symbols at all?
Permalink | Reply | 16 comments |
headers
Doug Evans | 1 Jul 2009 05:47
Picon
Favicon

Re: [RFA] Fix too many "no debugging symbols found" warnings.

On Tue, Jun 30, 2009 at 8:13 PM, Eli Zaretskii<eliz <at> gnu.org> wrote:
>> Date: Tue, 30 Jun 2009 14:49:25 -0700
>> From: Doug Evans <dje <at> google.com>
>> Cc: Tom Tromey <tromey <at> redhat.com>, gdb-patches <gdb-patches <at> sourceware.org>,
>>         Pedro Alves <pedro <at> codesourcery.com>
>>
>> Eli, are the docs ok?
>
> The text is okay, but I'm not sure it is accurate wrt the implementation.
>
>> +The  <at> code{set print symbol-loading-warnings} command allows you to enable or
>> +disable printing of warning messages when  <at> value{GDBN} implicitly loads symbols
>> +for files.
>
> This text seems to say that we will print a warning when symbols are
> loaded ``implicitly'', whatever that means.  But in fact, aren't the
> warnings issued for files that have _no_ debugging symbols at all?

s/implicitly loads symbols for files/tries to load symbols for a file
and finds the file has no symbols/
?
Permalink | Reply | 15 comments |
headers
Hui Zhu | 1 Jul 2009 07:53
Picon
Gravatar

Re: i386.record.floating.point.patch : with more testing and assurity

About this patch, I say my idea again, I told in
http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html
 <at>  <at>  -145,7 +145,22  <at>  <at> 
   I386_ES_REGNUM,		/* %es */
   I386_FS_REGNUM,		/* %fs */
   I386_GS_REGNUM,		/* %gs */
-  I386_ST0_REGNUM		/* %st(0) */
+  I386_ST0_REGNUM,		/* %st(0) */
+  I386_ST1_REGNUM,		/* %st(1) */
+  I386_ST2_REGNUM,		/* %st(2) */
+  I386_ST3_REGNUM,		/* %st(3) */
+  I386_ST4_REGNUM,		/* %st(4) */
+  I386_ST5_REGNUM,		/* %st(5) */
+  I386_ST6_REGNUM,		/* %st(6) */
+  I386_ST7_REGNUM,		/* %st(7) */
+  I386_FCTRL,			/* floating point env regs : FCTRL-FOP */	
+  I386_FSTAT,
+  I386_FTAG,			
+  I386_FISEG,
+  I386_FIOFF,
+  I386_FOSEG,
+  I386_FOOFF,
+  I386_FOP
 };

You are working on make prec x86 support fp insn, not to extend the fp
function of i386 (If you want, you can make a special patch for it).

Hui
(Continue reading)

Permalink | Reply | 0 comments |
headers
Pierre Muller | 1 Jul 2009 10:34
Picon
Picon

RE: [RFC] add h/w breakpoints to x86-linux gdbserver

  Doug, I had a small problem applying your patch,
and, of course, I wanted to extend it to also work 
on win32 gdbserver.

  For the test, I propose below another scheme:
run the test for all targets and accept also
the answer "No hardware breakpoint support for this target"
unless the target_info gdb,hardware_breakpoints is set,
in which case a failure is also issued on that answer.

Pierre Muller
Pascal language support maintainer for GDB

2009-07-01  Doug Evans  <dje <at> google.com>
	Pierre Muller  <muller <at> ics.u-strasbg.fr>

	Add h/w breakpoints to x86-linux and i386-win32 gdbserver.
	* i386-low.h (i386_low_insert_hw_breakpoint): Declare.
	(i386_low_remove_hw_breakpoint): Declare.
	* i386-low.c (i386_low_insert_hw_breakpoint): New function.
	(i386_low_remove_hw_breakpoint): New function.
	* linux-x86-low.c (x86_insert_point): Handle h/w breakpoint packets.
	(x86_remove_point): Ditto.
	* win32-386-low.c (i386_insert_point): Handle h/w breakpoint
packets.
	(i386_remove_point): Ditto.

	* gdb.base/hbreak.exp: New file.
	* gdb.base/hbreak.c: New file.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tristan Gingold | 1 Jul 2009 12:17
Favicon

Re: RFA: (testsuite): make darwin as untested in bigcore.exp


On Jun 29, 2009, at 5:55 PM, Joel Brobecker wrote:

>> 2009-06-29  Tristan Gingold  <gingold <at> adacore.com>
>>
>> 	* gdb.base/bigcore.exp: Make darwin untested.
>
> This looks OK to me, please go ahead and commit.

Thanks (to you & Mark).

Committed.
Permalink | Reply | 0 comments |
headers
Jan Kratochvil | 1 Jul 2009 14:06
Picon
Favicon

[patch] testsuite: Fix multiple runs in parallel on a single host [Re: RFC: parallelize "make check"]

On Mon, 29 Jun 2009 23:16:57 +0200, Jan Kratochvil wrote:
> On Mon, 29 Jun 2009 20:05:10 +0200, Tom Tromey wrote:
> >     gdb.base/watchpoint.exp
(This is a FSF GDB HEAD problem watchpoints are not distributed across threads.)

> >     gdb.mi/mi-file-transfer.exp, gdb.server/file-transfer.exp,

These + others get fixed by the patch below.

>  Running ../../../gdb/testsuite/gdb.server/file-transfer.exp ...
> -PASS: gdb.server/file-transfer.exp: put binary file
> -PASS: gdb.server/file-transfer.exp: get binary file
...
> +ERROR: tcl error sourcing ../../../gdb/testsuite/gdb.server/file-transfer.exp.
> +ERROR: : spawn id exp18 not open
> +    while executing
> +"expect_background -nobrace -i exp18 full_buffer { } eof {
...

It normally mostly always happens with multiple parallel testsuite runs on the
same host.  Now with the parallel check there is also a (low probability) it
would bite even during a single testsuite parallel run.

Regression tested on FSF GDB HEAD on {x86_64,i686}-fedora-linux-gnu.

Thanks,
Jan

gdb/testsuite/
2009-07-01  Jan Kratochvil  <jan.kratochvil <at> redhat.com>
(Continue reading)

Permalink | Reply | 2 comments |
headers
Nick Roberts | 1 Jul 2009 15:13
Picon

[mi] -stack-list-arguments --simple-values

 > This patch makes -stack-list-arguments --simple-values work.
 > It looks like --simple-values (and friends) were accepted for
 > -stack-list-locals, but not for -stack-list-arguments. While
 > the utility of such human friendly spelling is unclear, for
 > a machine interface, it's even more confusing having 1/2
 > of relevant commands accept it.

It's not immediately clear from the manual that SHOW-VALUES from
-stack-list-arguments and PRINT-VALUES from -stack-list-locals are related.
-stack-list-arguments takes three arguments while -stack-list-locals only
takes -one.  I think it would be nice to have one command,
-stack-list-locals-and-args say, that lists both the locals and the arguments
of the current frame:

  The `-stack-list-locals-and-args' Command
  --------------------------------

  Synopsis
  ........

  -stack-list-locals-and-args PRINT-VALUES

     Display the local variable and argument names for the selected frame.
  If PRINT-VALUES is 0 or `--no-values', print only the names of the
  variables; if it is 1 or `--all-values', print also their values; and
  if it is 2 or `--simple-values', print the name, type and value for
  simple data types and the name and type for arrays, structures and
  unions.  In this last case, a frontend can immediately display the
  value of simple data types and create variable objects for other data
  types when the user wishes to explore their values in more detail.
(Continue reading)

Permalink | Reply | 10 comments |

Gmane