Daniel Jacobowitz | 1 Jun 03:00 2007

Re: [rfc] [1/6] Remove macro CALL_DUMMY_LOCATION

On Thu, May 31, 2007 at 02:43:08PM -0700, Jim Blandy wrote:
> Sheesh.  (I did search the archives, but apparently not well enough.)
> Could we put Markus on the Write After Approval list, with a note
> about this?  Say:

It should be about IBM in general, not about Markus; I would prefer
not to list people without write access, and it's not specific to him.

--

-- 
Daniel Jacobowitz
CodeSourcery

Markus Deuling | 1 Jun 13:39 2007
Picon

[rfc] [0/9] Remove macros from gdbarch.sh

Hello,

this is the next series of 9 patches to get rid of the macros in gdbarch.sh. 

The following macros are replaced by this patches:

* REGISTER_NAME
* GET_LONGJMP_TARGET / GET_LONGJMP_TARGET_P
* POINTER_TO_ADDRESS / ADDRESS_TO_POINTER
* INNER_THAN
* FRAME_RED_ZONE_SIZE
* {ELF,COFF}_MAKE_MSYMBOL_SPECIAL
* FRAME_ARGS_SKIP, FRAME_NUM_ARGS and FRAME_NUM_ARGS_P
* CANNOT_SET_BREAKPOINT / HAVE_NONSTEPPABLE_WATCHPOINT
* FETCH_POINTER_ARGUMENT

I tested this patchset by running gdb_mbuild.sh and run the testsuite on x86. The testsuite showed no regressions.

I'd appreciate any comments to this patches. Thank you very much in advance.

Regards,
Markus 

--

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling <at> de.ibm.com

Markus Deuling | 1 Jun 13:39 2007
Picon

[rfc] [2/9] Remove macros GET_LONGJMP_TARGET and GET_LONGJMP_TARGET_P

Hello,

this patch removes GET_LONGJMP_TARGET and GET_LONGJMP_TARGET_P macros from gdbarch.sh

ChangeLog:

	* gdbarch.sh (GET_LONGJMP_TARGET): Replace by gdbarch_get_longjmp_target.
	* infrun.c (handle_inferior_event): Likewise.
	* gdbarch.sh (GET_LONGJMP_TARGET_P): Replace by
	gdbarch_get_longjmp_target_p.
	* breakpoint.c (breakpoint_re_set): Likewise.
	* infrun.c (handle_inferior_event): Likewise.
	* gdbarch.c, gdbarch.h: Regenerate.

Is this ok to commit?

Regards,
Markus 

--

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling <at> de.ibm.com

diff -urN src/gdb/breakpoint.c dev/gdb/breakpoint.c
--- src/gdb/breakpoint.c	2007-05-11 22:01:31.000000000 +0200
+++ dev/gdb/breakpoint.c	2007-05-23 07:32:26.000000000 +0200
 <at>  <at>  -7472,7 +7472,7  <at>  <at> 
(Continue reading)

Markus Deuling | 1 Jun 13:39 2007
Picon

[rfc] [3/9] Remove adress conversion macros

Hello,

this patch removes POINTER_TO_ADDRESS and ADDRESS_TO_POINTER macros from gdbarch.sh

ChangeLog:

	* gdbarch.sh (ADDRESS_TO_POINTER): Replace by
	gdbarch_address_to_pointer.
	* findvar.c (store_typed_address): Likewise.
	* gdbtypes.c (make_pointer_type): Likewise (comment).
	* procfs.c (procfs_address_to_host_pointer): Likewise.
	* std-regs.c (value_of_builtin_frame_reg): Likewise.
	(value_of_builtin_frame_fp_reg): Likewise.
	(value_of_builtin_frame_pc_reg): Likewise.
	* utils.c (paddress): Likewise (comment).
	* gdbarch.sh (POINTER_TO_ADDRESS): Replace by
	gdbarch_pointer_to_address.
	* findvar.c (extract_typed_address): Likewise.
	* gdbtypes.c (make_pointer_type): Likewise (comment).
	* valops.c (value_cast): Likewise (comment).
	* gdbarch.c, gdbarch.h: Regenerate.

Is this ok to commit?

Regards,
Markus 

--

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
(Continue reading)

Markus Deuling | 1 Jun 13:39 2007
Picon

[rfc] [1/9] Remove macro REGISTER_NAME

Hello,

this patch removes REGISTER_NAME macro from gdbarch.sh

ChangeLog:

	* gdbarch.sh (REGISTER_NAME): Replace by gdbarch_register_name.
	* tracepoint.c (scope_info): Likewise.
	* target.c (debug_print_register): Likewise.
	* stack.c (frame_info): Likewise.
	* sh-tdep.c (sh_register_reggroup_p): Likewise.
	* sh64-tdep.c (sh64_do_fp_register,sh64_do_register)
	(sh64_media_print_registers_info)
	(sh64_compact_print_registers_info): Likewise.
	* rs6000-tdep.c (rs6000_register_reggroup_p): Likewise.
	* remote-sim.c (gdbsim_fetch_register): Likewise.
	* remote.c (packet_reg): Likewise (comment).
	* reggroups.c (default_register_reggroup_p): Likewise.
	* regcache.c (regcache_dump): Likewise.
	* printcmd.c (address_info): Likewise.
	* ppc-linux-nat.c (fetch_register,store_register): Likewise.
	* mt-dep.c (mt_registers_info): Likewise.
	* mn10300-tdep.c (mn10300_dwarf2_reg_to_regnum): Likewise (comment).
	* mips-tdep.c (mips_register_reggroup_p,mips_read_fp_register_single)
	(mips_read_fp_register_double,mips_print_fp_register)
	(mips_print_register,print_gp_register_row,mips_print_registers_info)
	(mips_register_sim_regno): Likewise.
	* m68klinux-nat.c (regmap,fetch_register,store_register): Likewise.
	* inf-ptrace.c (inf_ptrace_fetch_register)
	(inf_ptrace_store_register): Likewise.
(Continue reading)

Markus Deuling | 1 Jun 13:39 2007
Picon

[rfc] [4/9] Remove macro INNER_THAN

Hello,

this patch removes INNER_THAN macro from gdbarch.sh

ChangeLog:

	* gdbarch.sh (INNER_THAN): Replace by gdbarch_inner_than.
	* infcall.c (call_function_by_hand): Likewise.
	* gcore.c (derive_stack_segment): Likewise.
	* frame.c (frame_id_inner): Likewise.
	* arch-utils.c (core_addr_lessthan): Likewise (comment).
	* ada-lang.c (ensure_lval): Likewise.
	* gdbarch.c, gdbarch.h: Regenerate.

Is this ok to commit?

Regards,
Markus 

--

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling <at> de.ibm.com

diff -urN src/gdb/ada-lang.c dev/gdb/ada-lang.c
--- src/gdb/ada-lang.c	2007-03-29 23:57:01.000000000 +0200
+++ dev/gdb/ada-lang.c	2007-05-23 06:09:47.000000000 +0200
 <at>  <at>  -3634,7 +3634,7  <at>  <at> 
(Continue reading)

Markus Deuling | 1 Jun 13:39 2007
Picon

[rfc] [5/9] Remove macro FRAME_RED_ZONE_SIZE

Hello,

this patch removes FRAME_RED_ZONE_SIZE macro from gdbarch.sh

ChangeLog:

	* gdbarch.sh (FRAME_RED_ZONE_SIZE): Replace by
	gdbarch_frame_red_zone_size.
	* gdbarch.c, gdbarch.h: Regenerate.

Is this ok to commit?

Regards,
Markus 

--

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling <at> de.ibm.com

diff -urN src/gdb/gdbarch.c dev/gdb/gdbarch.c
--- src/gdb/gdbarch.c	2007-05-14 17:16:57.000000000 +0200
+++ dev/gdb/gdbarch.c	2007-05-29 12:00:03.000000000 +0200
 <at>  <at>  -1073,11 +1073,6  <at>  <at> 
   fprintf_unfiltered (file,
                       "gdbarch_dump: frame_num_args = <0x%lx>\n",
                       (long) current_gdbarch->frame_num_args);
-#ifdef FRAME_RED_ZONE_SIZE
(Continue reading)

Markus Deuling | 1 Jun 13:39 2007
Picon

[rfc] [6/9] Remove macros {ELF,COFF}_MAKE_MSYMBOL_SPECIAL

Hello,

this patch removes ELF_MAKE_MSYMBOL_SPECIAL and COFF_MAKE_MSYMBOL_SPECIAL macros from gdbarch.sh

ChangeLog:

	* gdbarch.sh (COFF_MAKE_MSYMBOL_SPECIAL): Replace by
	gdbarch_coff_make_msymbol_special.
	* coffread.c (coff_symtab_read): Likewise.
	* gdbarch.sh (ELF_MAKE_MSYMBOL_SPECIAL): Replace by
	gdbarch_elf_make_msymbol_special.
	* elfread.c (elf_symtab_read): Likewise.
	* mips-tdep.c (mips_elf_make_msymbol_special): Likewise (comment).
	* sh64-tdep.c (MSYMBOL_IS_SPECIAL): Likewise (comment).
	* gdbarch.c, gdbarch.h: Regenerate.

Is this ok to commit?

Regards,
Markus 

--

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling <at> de.ibm.com

diff -urN src/gdb/coffread.c dev/gdb/coffread.c
--- src/gdb/coffread.c	2007-01-09 18:58:50.000000000 +0100
(Continue reading)

Markus Deuling | 1 Jun 13:40 2007
Picon

[rfc] [8/9] Remove macros CANNOT_SET_BREAKPOINT and HAVE_NONSTEPPABLE_WATCHPOINT

Hello,

this patch removes CANNOT_SET_BREAKPOINT and HAVE_NONSTEPPABLE_WATCHPOINT macros from gdbarch.sh

ChangeLog:

	* gdbarch.sh (HAVE_NONSTEPPABLE_WATCHPOINT): Replace by
	gdbarch_have_nonsteppable_watchpoint.
	* infrun.c (handle_inferior_event,adjust_pc_after_break): Likewiseo.
	* gdbarch.sh (CANNOT_STEP_BREAKPOINT): Replace by
	gdbarch_cannot_step_breakpoint.
	* infrun.c (resume): Likewise.
	* gdbarch.c, gdbarch.h: Regenerate.

Is this ok to commit?

Regards,
Markus 

--

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling <at> de.ibm.com

diff -urN src/gdb/gdbarch.c dev/gdb/gdbarch.c
--- src/gdb/gdbarch.c	2007-05-14 17:16:57.000000000 +0200
+++ dev/gdb/gdbarch.c	2007-05-22 05:45:43.000000000 +0200
 <at>  <at>  -776,11 +776,6  <at>  <at> 
(Continue reading)

Markus Deuling | 1 Jun 13:39 2007
Picon

[rfc] [7/9] Remove macros FRAME_ARGS_SKIP, FRAME_NUM_ARGS and FRAME_NUM_ARGS_P

Hello,

this patch removes FRAME_ARGS_SKIP, FRAME_NUM_ARGS and FRAME_NUM_ARGS_P macro from gdbarch.sh

ChangeLog:

	* gdbarch.sh (FRAME_ARGS_SKIP): Replace by gdbarch_frame_args_skip.
	* stack.c (print_frame_args): Likewise.
	* gdbarch.sh (FRAME_NUM_ARGS): Replace by gdbarch_frame_num_args.
	* stack.c (print_args_stub,frame_info): Likewise.
	* gdbarch.sh (FRAME_NUM_ARGS_P): Replace by gdbarch_frame_num_args_p.
	* stack.c (print_args_stub,frame_info): Likewise.
	* gdbarch.c, gdbarch.h: Regenerate.

Is this ok to commit?

Regards,
Markus 

--

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling <at> de.ibm.com

diff -urN src/gdb/gdbarch.c dev/gdb/gdbarch.c
--- src/gdb/gdbarch.c	2007-05-14 17:16:57.000000000 +0200
+++ dev/gdb/gdbarch.c	2007-05-24 06:05:40.000000000 +0200
 <at>  <at>  -1047,29 +1047,12  <at>  <at> 
(Continue reading)


Gmane