headers
Paul Gilliam | 1 Sep 2005 02:29
Picon
Favicon

Re: fix "too much information" bug w/ "info vector" on PowerPC

Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in ppc-tdep.h
are over 80 columns and 
real ugly.

Here, for your consideration, are two patches to change that:  one uses a short-lived macro
(ppc-tdep.patch) and the other uses a
typedef (newest.patch).

-=# Paul #=-
Attachment (ppc-tdep.patch): text/x-diff, 2600 bytes
Attachment (newest.patch): text/x-diff, 35 KiB
Permalink | Reply | 5 comments |
headers
Bob Rossi | 1 Sep 2005 02:52

Re: MI testsuite to use PTY for inferior

On Mon, Aug 29, 2005 at 10:52:03PM -0400, Daniel Jacobowitz wrote:
> On Fri, Aug 19, 2005 at 06:27:21PM -0400, Bob Rossi wrote:
> > > Funny thing is that if I run mi-console.exp alone, it usually
> > > (although not always) succeeds.
> > > 
> > > Attached are a gdb.log for a failing run and a passing run.
> > 
> > OK, I've tracked down why mi-console.exp breaks. Also, I can reproduce
> > it. The problem is slightly difficult to fix because of race conditions
> > so I was hoping to get some advice from people who might have had
> > similar experience with the testsuite.
> 
> Nice job tracking this down.

Hi Daniel,

The solution you sent in gave me an idea that might work out. It's
pretty simple. First look at the patch with it's comment,

Index: gdb/testsuite/ChangeLog
+	* lib/mi-support.exp (mi_gdb_test): Change -re to not be anchored.

Index: gdb/testsuite/lib/mi-support.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v
retrieving revision 1.30
diff -u -r1.30 mi-support.exp
--- gdb/testsuite/lib/mi-support.exp	9 Aug 2005 19:00:16 -0000	1.30
+++ gdb/testsuite/lib/mi-support.exp	1 Sep 2005 00:46:01 -0000
 <at>  <at>  -659,7 +659,15  <at>  <at>
(Continue reading)

Permalink | Reply | 4 comments |
headers
Dave Korn | 1 Sep 2005 12:29
Favicon

[PATCH PING] RE: [PATCH] Your patch from 20050512 b0rked on cygwin!

----Original Message----
>From: Dave Korn
>Sent: 17 August 2005 17:39

  Ping CGF?  HEAD doesn't build on cygwin.

http://sources.redhat.com/ml/gdb-patches/2005-08/msg00198.html

Also, the change log entry got wrapped.  Reformatted.

2005-08-17  Dave Korn  <dave.korn <at> artimi.com>

	* win32-nat.c (solib_address): Rename from this ...
	(win32_nat_solib_address): ... to this, to avoid clash with solib.c
	(child_solib_loaded_library_pathname, child_clear_solibs)
	(dll_symbol_command): Likewise rename to ...
	(win32_nat_child_solib_loaded_library_pathname)
	(win32_nat_child_clear_solibs, win32_nat_dll_symbol_command): ...
	these, and all call sites adjusted.

	* config/i386/tm-cygwin.h (SOLIB_ADD, SOLIB_LOADED_LIBRARY_PATHNAME)
	(CLEAR_SOLIB, ADD_SHARED_SYMBOL_FILES, PC_SOLIB):  Add 'win32_nat_'
	prefix to all symbols to match renamed functions in win32-nat.c.

    cheers,
      DaveK
--

-- 
Can't think of a witty .sigline today....
(Continue reading)

Permalink | Reply | 0 comments |
headers
Richard Earnshaw | 1 Sep 2005 14:57
Picon
Favicon

[PATCH] Remove deprecated_push_arguments call on arm-linux

This patch deletes the deprecated use of push_arguments from the
arm-linux configuration.  Analysis has shown that because of the way
call_function_by_hand is implemented this function hasn't been used
since the ARM code was changed to use push_dummy_call.  In fact, testing
with push_dummy_call disabled on arm-linux shows worse test results, so
I've just gone ahead and deleted all the now-dead code.

I think this was the last known use of DEPRECATED_PUSH_ARGUMENTS.

R.

2005-09-01  Richard Earnshaw  <richard.earnshaw <at> arm.com>

	* arm-linux-tdep.c (arm_linux_push_arguments): Delete.
	(arm_linux_init_abi): Don't register it.
Attachment (alt.patch): text/x-patch, 6705 bytes
Permalink | Reply | 0 comments |
headers
Paul Gilliam | 1 Sep 2005 20:11
Picon
Favicon

[commit] fix "too much information" bug w/ "info vector" on PowerPC

Thank you all for you help and advice.  Here is the patch I just committed:

20050901  Paul Gilliam  <pgilliam <at> us.ibm.com>

        * ppc-tdep.h (struct gdbarch_tdep): Better explanation of using
        -1 for nonexistant registers.
        * rs6000-tdep.c (rs6000_register_reggroup_p): Don't assume that
        tdep->ppc_vr0_regnum and tdep->ppc_ev0_regnum are not -1.

Index: ppc-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/ppc-tdep.h,v
retrieving revision 1.46
diff -a -u -r1.46 ppc-tdep.h
--- ppc-tdep.h	25 May 2005 03:12:13 -0000	1.46
+++ ppc-tdep.h	1 Sep 2005 17:56:58 -0000
 <at>  <at>  -152,26 +152,33  <at>  <at> 
     int ppc_ctr_regnum;		/* Count register */
     int ppc_xer_regnum;		/* Integer exception register */

-    /* On PPC and RS6000 variants that have no floating-point
-       registers, the next two members will be -1.  */
+    /* Not all PPC and RS6000 variants will have the registers
+       represented below.  A -1 is used to indicate that the register
+       is not present in this variant.  */
+
+    /* Floating-point registers.  */
     int ppc_fp0_regnum;         /* floating-point register 0 */
-    int ppc_fpscr_regnum;	/* Floating point status and condition
-    				   register */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mark Kettenis | 2 Sep 2005 00:11
Picon
Picon
Favicon

Re: MI testsuite to use PTY for inferior

> Date: Wed, 31 Aug 2005 20:52:00 -0400
> From: Bob Rossi <bob <at> brasko.net>
> 
> Index: gdb/testsuite/lib/mi-support.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v
> retrieving revision 1.30
> diff -u -r1.30 mi-support.exp
> --- gdb/testsuite/lib/mi-support.exp	9 Aug 2005 19:00:16 -0000	1.30
> +++ gdb/testsuite/lib/mi-support.exp	1 Sep 2005 00:46:01 -0000
>  <at>  <at>  -659,7 +659,15  <at>  <at> 
>  	    gdb_start
>  	    set result -1
>  	}
> -	 -re "\[\r\n\]*($pattern)\[\r\n\]+$mi_gdb_prompt\[ \]*$" {
> +	 -re "\[\r\n\]*($pattern)\[\r\n\]+$mi_gdb_prompt\[ \]*" {
> +	    # NOTE, there is no trailing anchor because with GDB/MI, 
> +	    # asynchronous responses can happen at any point, causing more 
> +	    # data to be available.  Normally an anchor is used to make 
> +	    # sure the end of the output is matched, however, $mi_gdb_prompt 
> +	    # is just as good of an anchor since mi_gdb_test is meant to 
> +	    # match a single mi output command. If a second GDB/MI output 
> +	    # response is sent, it will be in the buffer for the next 
> +	    # time mi_gdb_test is called.
>  	    if ![string match "" $message] then {
>  		pass "$message"
>  	    }
> 
> Basically, this passes the mi-console.exp testcase if the 'sleep 1' is
> there or not. Also, it didn't break any testcases. It changes
(Continue reading)

Permalink | Reply | 3 comments |
headers
Jim Blandy | 2 Sep 2005 01:06
Picon
Favicon

Re: fix "too much information" bug w/ "info vector" on PowerPC

Paul Gilliam <pgilliam <at> us.ibm.com> writes:

> Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in ppc-tdep.h
are over 80 columns and 
> real ugly.
>
> Here, for your consideration, are two patches to change that:  one uses a short-lived macro
(ppc-tdep.patch) and the other uses a
> typedef (newest.patch).

If I were to use a typedef, I'd put it in gdbarch.h and call it
gdb_retval_convention_t; there's nothing special about ppc-tdep.h's
needs.

The following is also legal C, Emacs-friendly, and gdb_indent.sh-friendly:

enum return_value_convention (ppc_sysv_abi_return_value
                              (struct gdbarch *gdbarch,
                               struct type *valtype,
                               struct regcache *regcache,
                               gdb_byte *readbuf,
                               const gdb_byte *writebuf));

I used this once before, but Mark Kettenis declared it "weird" or
something and asked me to take it out.  :) Be that as it may, I think
it's better than the macro or the local typedef.
Permalink | Reply | 4 comments |
headers
Bob Rossi | 2 Sep 2005 01:51

Re: MI testsuite to use PTY for inferior

> Fixes the problems in mi-console.exp, but I still see the following:
> 
> 403-exec-continue
> 403^running
> (gdb) 
> FAIL: gdb.mi/mi-syn-frame.exp: testing exec continue
> 403*stopped
> (gdb) 
> 404-stack-list-frames 0 0
> 404^done,stack=[frame={level="0",addr="0x1c0006c8",func="main",file="../../../..
> /src/gdb/gdb/testsuite/gdb.mi/mi-syn-frame.c",fullname="/home/kettenis/src/gdb/g
> db/testsuite/gdb.mi/mi-syn-frame.c",line="14"}]
> (gdb) 
> PASS: gdb.mi/mi-syn-frame.exp: list stack frames
> 
> Seems the attached patch solves those though.
> 
> Mark

O, great find Mark! I couldn't reproduce this, but now I see why the
testcase is failing. It's also a case where multiple MI output commands
were being matched in a single mi_gdb_test command.

I wonder how my changes effected the testsuite to cause these problems?
I'll take a look.

Thanks a lot!
Bob Rossi
(Continue reading)

Permalink | Reply | 0 comments |
headers
Daniel Jacobowitz | 2 Sep 2005 02:55

Re: fix "too much information" bug w/ "info vector" on PowerPC

On Thu, Sep 01, 2005 at 04:06:08PM -0700, Jim Blandy wrote:
> Paul Gilliam <pgilliam <at> us.ibm.com> writes:
> 
> > Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in
ppc-tdep.h are over 80 columns and 
> > real ugly.
> >
> > Here, for your consideration, are two patches to change that:  one uses a short-lived macro
(ppc-tdep.patch) and the other uses a
> > typedef (newest.patch).
> 
> If I were to use a typedef, I'd put it in gdbarch.h and call it
> gdb_retval_convention_t; there's nothing special about ppc-tdep.h's
> needs.
> 
> The following is also legal C, Emacs-friendly, and gdb_indent.sh-friendly:
> 
> enum return_value_convention (ppc_sysv_abi_return_value
>                               (struct gdbarch *gdbarch,
>                                struct type *valtype,
>                                struct regcache *regcache,
>                                gdb_byte *readbuf,
>                                const gdb_byte *writebuf));
> 
> I used this once before, but Mark Kettenis declared it "weird" or
> something and asked me to take it out.  :) Be that as it may, I think
> it's better than the macro or the local typedef.

It is weird :-P
(Continue reading)

Permalink | Reply | 3 comments |
headers
Paul Gilliam | 2 Sep 2005 16:25
Picon
Favicon

Re: fix "too much information" bug w/ "info vector" on PowerPC

On Thursday 01 September 2005 17:55, Daniel Jacobowitz wrote:
> On Thu, Sep 01, 2005 at 04:06:08PM -0700, Jim Blandy wrote:
> > Paul Gilliam <pgilliam <at> us.ibm.com> writes:
> > 
> > > Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in
ppc-tdep.h are over 80 columns and 
> > > real ugly.
> > >
> > > Here, for your consideration, are two patches to change that:  one uses a short-lived macro
(ppc-tdep.patch) and the other uses a
> > > typedef (newest.patch).
> > 
> > If I were to use a typedef, I'd put it in gdbarch.h and call it
> > gdb_retval_convention_t; there's nothing special about ppc-tdep.h's
> > needs.
> > 
> > The following is also legal C, Emacs-friendly, and gdb_indent.sh-friendly:
> > 
> > enum return_value_convention (ppc_sysv_abi_return_value
> >                               (struct gdbarch *gdbarch,
> >                                struct type *valtype,
> >                                struct regcache *regcache,
> >                                gdb_byte *readbuf,
> >                                const gdb_byte *writebuf));
> > 
> > I used this once before, but Mark Kettenis declared it "weird" or
> > something and asked me to take it out.  :) Be that as it may, I think
> > it's better than the macro or the local typedef.
> 
> It is weird :-P
(Continue reading)

Permalink | Reply | 0 comments |

Gmane