headers
Mark Kettenis | 1 Jul 2002 11:14
Picon

[PATCH] i386 Solaris multi-arch tweaks

A straightforward multi-arch patch.

Committed.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis <at> gnu.org>

	* config/i386/tm-i386sol2.h (COERCE_FLOAT_TO_DOUBLE): Removed.
	* i386-sol2-tdep.c (i386_sol2_init_abi): Adjust for the removal of
	this macro.  Include "value.h".

Index: i386-sol2-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-sol2-tdep.c,v
retrieving revision 1.2
diff -u -r1.2 i386-sol2-tdep.c
--- i386-sol2-tdep.c 15 Jun 2002 18:49:52 -0000 1.2
+++ i386-sol2-tdep.c 1 Jul 2002 09:00:51 -0000
 <at>  <at>  -19,6 +19,7  <at>  <at> 
    Boston, MA 02111-1307, USA.  */

 #include "defs.h"
+#include "value.h"

 #include "i386-tdep.h"

 <at>  <at>  -45,6 +46,10  <at>  <at> 
   set_gdbarch_pc_in_sigtramp (gdbarch, i386_sol2_pc_in_sigtramp);
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mark Kettenis | 1 Jul 2002 11:57
Picon

[PATCH] Remove some dead wood from i386bsd-tdep.c

Subject says it all.

Committed.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis <at> gnu.org>

	* i386bsd-tdep.c (i386bsd_frame_saved_pc): Removed.

Index: i386bsd-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386bsd-tdep.c,v
retrieving revision 1.3
diff -u -r1.3 i386bsd-tdep.c
--- i386bsd-tdep.c 30 Jun 2002 14:43:23 -0000 1.3
+++ i386bsd-tdep.c 1 Jul 2002 09:37:58 -0000
 <at>  <at>  -71,17 +71,6  <at>  <at> 
   return read_memory_unsigned_integer (addr + sc_pc_offset, 4);
 }

-/* Return the saved program counter for FRAME.  */
-
-static CORE_ADDR
-i386bsd_frame_saved_pc (struct frame_info *frame)
-{
-  if (frame->signal_handler_caller)
-    return i386bsd_sigtramp_saved_pc (frame);
-
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mark Kettenis | 1 Jul 2002 12:21
Picon

[PATCH] Make several functions in i386tdep.c static

Most functions in i386-tdep.c don't need to be exported anymore.

Committed.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis <at> gnu.org>

	* i386-tdep.c (i386_frameless_function_invocation,
	i386_frame_num_args, i386_frame_init_saved_regs,
	i386_skip_prologue, i386_push_dummy_frame, i386_fix_call_dummy,
	i386_pop_frame, i386_push_arguments, i386_store_struct_return,
	i386_extract_return_value, i386_store_return_value,
	i386_extract_struct_value_address, i386_register_virtual_type,
	i386_register_convertible, i386_register_convert_to_virtual,
	i386_register_convert_to_raw, i386_svr4_sigtramp_saved_pc,
	i386_go32_init_abi, i386_nw_init_abi, i386_gdbarch_init): Make
	static.

Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.66
diff -u -p -r1.66 i386-tdep.c
--- i386-tdep.c 17 Jun 2002 23:32:30 -0000 1.66
+++ i386-tdep.c 1 Jul 2002 10:16:11 -0000
 <at>  <at>  -472,7 +472,7  <at>  <at>  i386_frame_chain (struct frame_info *fra
    not have a from on the stack associated with it.  If it does not,
    return non-zero, otherwise return zero.  */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Joern Rennecke | 1 Jul 2002 15:54

Unreviewed patches

Wed Jun 12 13:20:51 2002  J"orn Rennecke <joern.rennecke <at> superh.com>

include/gdb:
        * sim-sh.h: Add enum constants for sh[1-4], sh3e, sh3?-dsp.
sim/sh:
        * Makefile (interp.o): Depend on $(srcroot)/include/gdb/sim-sh.h.
        * interp.c: Include "gdb/sim-sh.h".
        (sim_store_register, sim_fetch_register): Use constants defined there.

http://sources.redhat.com/ml/gdb-patches/2002-06/msg00185.html

Thu Jun 13 23:20:33 2002  J"orn Rennecke <joern.rennecke <at> superh.com>

sim/sh64:
        * arch.c, arch.h, cpu.c, cpu.h, cpuall.h, decode-compact.c: Regenerate.
        * decode-compact.h, decode-media.c, decode-media.h: Likewise.
        * defs-compact.h, defs-media.h, sem-compact-switch.c: Likewise.
        * sem-compact.c, sem-media-switch.c, sem-media.c, sh-desc.c: Likewise.
        * sh-desc.h, sh-opc.h: Likewise.

http://sources.redhat.com/ml/gdb-patches/2002-06/msg00490.html

--

-- 
--------------------------
SuperH
2430 Aztec West / Almondsbury / BRISTOL / BS32 4AQ
T:+44 1454 462330
Permalink | Reply | 13 comments |
headers
Elena Zannoni | 1 Jul 2002 17:46
Picon
Favicon

Re: Unreviewed patches

Joern Rennecke writes:
 > Wed Jun 12 13:20:51 2002  J"orn Rennecke <joern.rennecke <at> superh.com>
 > 
 > include/gdb:
 >         * sim-sh.h: Add enum constants for sh[1-4], sh3e, sh3?-dsp.

Yes, sorry for the delay.

Is there any real reason to not just have one enum, which included the
dsp registers as well? I mean, if the simulator didn't reuse register
numbers for FP regs and DPS regs, then you could get rid of this ugly
code in interp.c:

    else case 44:
      if (target_dsp)
	RE = val;
    else case 45: case 46: case 47: case 48: case 49: case 50:
[...]
    case 26:
      val = target_dsp ? A0 : FI (1);
      break;
[...]
etc. etc.

And with that you could get rid of the target_dsp variable.

 > sim/sh:
 >         * Makefile (interp.o): Depend on $(srcroot)/include/gdb/sim-sh.h.
 >         * interp.c: Include "gdb/sim-sh.h".
 >         (sim_store_register, sim_fetch_register): Use constants defined there.
(Continue reading)

Permalink | Reply | 12 comments |
headers
Nathanael Nerode | 1 Jul 2002 17:57
Picon

[patch] toplevel Makefile.in: remove more references to building emacs

Committed to gcc as obvious, cced to dj to put into src. :-)

2002-07-01  Nathanael Nerode <neroden <at> twcny.rr.com>

	* Makefile.in: Eliminate references to building emacs.

Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/Makefile.in,v
retrieving revision 1.104
diff -u -r1.104 Makefile.in
--- Makefile.in	19 Jun 2002 23:06:05 -0000	1.104
+++ Makefile.in	1 Jul 2002 15:55:54 -0000
 <at>  <at>  -747,8 +747,6  <at>  <at> 
 # This is a list of the targets for all of the modules which are compiled
 # using $(X11_FLAGS_TO_PASS).
 ALL_X11_MODULES = \
-	all-emacs \
-	all-emacs19 \
 	all-gdb \
 	all-expect \
 	all-guile \
 <at>  <at>  -759,7 +757,6  <at>  <at> 
 # This is a list of the check targets for all of the modules which are
 # compiled using $(X11_FLAGS_TO_PASS).
 CHECK_X11_MODULES = \
-	check-emacs \
 	check-gdb \
 	check-guile \
 	check-expect \
(Continue reading)

Permalink | Reply | 0 comments |
headers
Joern Rennecke | 1 Jul 2002 19:10

Re: Unreviewed patches

Elena Zannoni wrote:
> 
> Joern Rennecke writes:
>  > Wed Jun 12 13:20:51 2002  J"orn Rennecke <joern.rennecke <at> superh.com>
>  >
>  > include/gdb:
>  >         * sim-sh.h: Add enum constants for sh[1-4], sh3e, sh3?-dsp.
> 
> Yes, sorry for the delay.
> 
> Is there any real reason to not just have one enum, which included the
> dsp registers as well?

Yes.  The values are supposed to stay the same, to retain compatibility.
Besides, you would need to re-design parts of the simulator to remove
the overlaps.

> 	                 I mean, if the simulator didn't reuse register
> numbers for FP regs and DPS regs, then you could get rid of this ugly
> code in interp.c:
> 
>     else case 44:
>       if (target_dsp)
>         RE = val;
>     else case 45: case 46: case 47: case 48: case 49: case 50:
> [...]
>     case 26:
>       val = target_dsp ? A0 : FI (1);
>       break;
> [...]
(Continue reading)

Permalink | Reply | 11 comments |
headers
Tom Tromey | 1 Jul 2002 21:10
Picon
Favicon

RFA: Convert to add_setshow_cmd

This patch changes gdb to use add_setshow_cmd everywhere it used to
use add_show_from_set.  This patch actually consists of several
different parts.  I couldn't think of a simple way to separate the
parts that didn't involve a lot of redundant work on my part.  I've
already done several passes over the source; the thought of more is
unpalatable.  Though more are in my future :-(

* Add a new `print doc' argument to add_setshow_cmd.
  This is used to format the `show foo' output

* Add a corresponding field to struct cmd_list_element

* Update test suite to reflect (minor) changes to gdb's output

* Removed set_verbose function.  It was easier to remove than to fix,
  and anyway the joke is stale now.

* Added add_setshow_enum_cmd, updated all callers

* Added argument to add_setshow_auto_boolean_cmd and
  add_setshow_boolean_cmd.  This is the `print doc' argument as with
  add_setshow_cmd.  Updated all callers.

In some of the appended, all the strings in a given file are marked.
I can try to back out that part of the patch if you'd prefer to review
those changes separately.

This runs the gdb test suite on my box (x86 Red Hat Linux 7.3) with no
regressions.  It also compiles with -Werror enabled.  I've only built
the native configuration.
(Continue reading)

Permalink | Reply | 1 comment |
headers
Aaron J. Grier | 1 Jul 2002 21:20
Favicon

write_register_bytes() confusion

I'm in the middle of bringing BDM for m68k support into current gdb, and
while I have fixed the most blatant calling convention changes (pid
changing to pid_t, etc) write_register_bytes() in regcache has got me
horribly confused.

not to mention all this m68k craziness happening elsewhere.  ;)

in v1.61 of valops.c (which appears to be current) there is the snippet:

write_register_bytes (VALUE_ADDRESS (toval) + VALUE_OFFSET (toval),
                      VALUE_CONTENTS (fromval), TYPE_LENGTH (type));

I'm writing a register -- it seems in my case this should be:

write_register_bytes (VALUE_REGNO (toval), VALUE_CONTENTS (fromval), 1);

the 1 of course is machine dependent

what I'm seeing is the register number getting completely thrashed on
the way through.

yet all calls to write_register_bytes are using VALUE_ADDRESS?

insane.  I'm starting to think I need to back off -current and just
stick with gdb-5.0...

--

-- 
  Aaron J. Grier  |   Frye Electronics, Tigard, OR   |  aaron <at> frye.com
(Continue reading)

Permalink | Reply | 1 comment |
headers
Nathanael Nerode | 1 Jul 2002 21:56
Picon

[patch] clean up config-ml.in

config-ml.in isn't called from the top level and therefore never has to deal
with being invoked by Cygnus configure.  This also eliminates a theoretical
problem: if an autoconf 'configure' script was passed no arguments, and used
config-ml.in, config-ml.in would decide that Cygnus configure was invoking it.

Committed to gcc as obvious.  Forwarded to dj for src. :-)

2002-07-01  Nathanael Nerode  <neroden <at> gcc.gnu.org>

	* config-ml.in: Eliminate references to Cygnus configure.

Index: config-ml.in
===================================================================
RCS file: /cvs/gcc/gcc/config-ml.in,v
retrieving revision 1.22
diff -u -r1.22 config-ml.in
--- config-ml.in	31 May 2002 19:30:52 -0000	1.22
+++ config-ml.in	1 Jul 2002 19:53:41 -0000
 <at>  <at>  -64,11 +64,6  <at>  <at> 
 # newlib.  It is up to each target to turn on multilib support for the other
 # libraries as desired.

-# We have to handle being invoked by both Cygnus configure and Autoconf.
-#
-# Cygnus configure incoming variables:
-# srcdir, subdir, host, arguments
-#
 # Autoconf incoming variables:
 # srcdir, host, ac_configure_args
 #
(Continue reading)

Permalink | Reply | 0 comments |

Gmane