headers
Kevin Buettner | 1 May 2002 01:37
Picon
Favicon

[PATCH] rs6000-tdep.c: Add fpscr comment

I've just committed the patch below.

	* rs6000-tdep.c: Added comment describing how fpscr register
	numbers were chosen.

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.62
diff -u -p -r1.62 rs6000-tdep.c
--- rs6000-tdep.c	30 Apr 2002 00:26:43 -0000	1.62
+++ rs6000-tdep.c	30 Apr 2002 23:34:38 -0000
 <at>  <at>  -2026,7 +2026,21  <at>  <at>  rs6000_convert_from_func_ptr_addr (CORE_

    Most of these register groups aren't anything formal.  I arrived at
    them by looking at the registers that occurred in more than one
-   processor. */
+   processor.
+   
+   Note: kevinb/2002-04-30: Support for the fpscr register was added
+   during April, 2002.  Slot 70 is being used for PowerPC and slot 71
+   for Power.  For PowerPC, slot 70 was unused and was already in the
+   PPC_UISA_SPRS which is ideally where fpscr should go.  For Power,
+   slot 70 was being used for "mq", so the next available slot (71)
+   was chosen.  It would have been nice to be able to make the
+   register numbers the same across processor cores, but this wasn't
+   possible without either 1) renumbering some registers for some
+   processors or 2) assigning fpscr to a really high slot that's
+   larger than any current register number.  Doing (1) is bad because
+   existing stubs would break.  Doing (2) is undesirable because it
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michael Snyder | 1 May 2002 02:18
Picon

[PATCH] Fix thinko on last arm check-in.

2002-04-30  Michael Snyder  <msnyder <at> redhat.com>

	* arm-tdep.c (arm_skip_prologue): Fix thinko; two lines
	should have been removed as part of 4/24 change.

Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.55
diff -p -r1.55 arm-tdep.c
*** arm-tdep.c	24 Apr 2002 21:22:06 -0000	1.55
--- arm-tdep.c	1 May 2002 00:28:23 -0000
*************** arm_skip_prologue (CORE_ADDR pc)
*** 460,467 ****
        inst = read_memory_integer (skip_pc, 4);
      }

-   skip_pc += 4;
-   inst = read_memory_integer (skip_pc, 4);
    if ((inst & 0xfffffff0) == 0xe92d0000)	/* stmfd sp!,{a1,a2,a3,a4} */
      {
        skip_pc += 4;
--- 460,465 ----
Permalink | Reply | 1 comment |
headers
Michael Snyder | 1 May 2002 02:46
Picon

[PATCH] Whitespace diddling...

2002-04-30  Michael Snyder  <msnyder <at> redhat.com>

	* arm-tdep.c: Whitespace clean-ups.

Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.56
diff -p -r1.56 arm-tdep.c
*** arm-tdep.c	1 May 2002 00:30:02 -0000	1.56
--- arm-tdep.c	1 May 2002 00:56:26 -0000
***************
*** 93,100 ****
  #define MSYMBOL_SIZE(msym)				\
  	((long) MSYMBOL_INFO (msym) & 0x7fffffff)

! /* This table matches the indicees assigned to enum arm_abi.  Keep
!    them in sync.  */

  static const char * const arm_abi_names[] =
  {
--- 93,100 ----
  #define MSYMBOL_SIZE(msym)				\
  	((long) MSYMBOL_INFO (msym) & 0x7fffffff)

! /* This table matches the indicees assigned to enum arm_abi. 
!    Keep them in sync.  */

  static const char * const arm_abi_names[] =
  {
(Continue reading)

Permalink | Reply | 1 comment |
headers
Michael Elizabeth Chastain | 1 May 2002 03:20

[patch/commit] merge add_filename_language fix to 5.2 branch

This patch is working fine in mainline.  I'm committing it to the 5.2 branch.

I tested gdb 5.2 before and after to check the effectiveness of the fix.
I also regression tested this on my native i686-pc-linux-gnu testbed.

I got interested in this because I'm cleaning up old PR's.  This bug
was reported to us in PR gdb/172 in July 2001 -- including the appropriate
fix!

Michael C

2002-04-30  Michael Chastain  <mec <at> shout.net>

	Merge from trunk.  This also fixes PR gdb/172.

	2002-04-25  Pierre Muller  <muller <at> ics.u-strasbg.fr>

	Fix PR gdb/508.
	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.

Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.54
diff -c -3 -p -r1.54 symfile.c
*** symfile.c	27 Feb 2002 01:40:36 -0000	1.54
--- symfile.c	1 May 2002 01:15:37 -0000
*************** add_filename_language (char *ext, enum l
*** 1806,1813 ****
    if (fl_table_next >= fl_table_size)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andrew Cagney | 1 May 2002 02:07
Picon

Re: [RFA/RFC] Multi-arch CPLUS_MARKER

FYI,

Two things puzzle me about this patch.  First, and more important is this:

>  <at>  <at>  -2176,6 +2181,7  <at>  <at>  gdbarch_update_p (struct gdbarch_info in
>  	    current_gdbarch = new_gdbarch;
>  	    swapin_gdbarch_swap (new_gdbarch);
>  	    architecture_changed_event ();
> +	    set_cplus_marker_for_demangling (CPLUS_MARKER);
>  	    return 1;
>  	  }
>        }

- it needs to be done before architecture_changed_event()

- more importantly, if it is needed, I think something else is going 
wrong.  Eventually there is going to be more than one architecture 
active and at that point a mechanism like the above simply won't work :-(

Looking at libiberty, the value is entered into a global table.  Should, 
instead, gdb call into functions like cplus_demangle_opname() function 
with an explicit cplus_marker[] table?

----

> +  /* CPLUS_MARKER must be computed at runtime */
> +  char vptr_name[] = { '_', 'v', 'p', 't', 'r', CPLUS_MARKER, '\0'};
> +  char vb_name[] = {'_', 'v', 'b', CPLUS_MARKER, '\0'};

> +  /* CPLUS_MARKER must be computed at runtime */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andrew Cagney | 1 May 2002 05:15
Picon

Re: [rfa:cris] Remove that ``current_gdbarch''

> 2002-04-20  Andrew Cagney  <ac131313 <at> redhat.com>
> 
> 	* cris-tdep.c (cris_gdbarch_init): Use arches instead of
> 	current_gdbarch.
> 

Got an ok from Orjan, so I've checked it in.  (Also played with it a bit 
more using `set/show cris-abi' and `maint print architecture, looks ok).

Andrew
Permalink | Reply | 0 comments |
headers
Fred Fish | 1 May 2002 15:23

Re: [RFA] Remove dependency on load address of environ

> I proofread this patch and it looks correct to me, no problems found.
> I have not tested it though.

Peter Schauer found one problem with it, an sbrk not protected by HAVE_SBRK.
Here is a revised patch.

-Fred

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.2546
diff -c -p -r1.2546 ChangeLog
*** ChangeLog	1 May 2002 03:14:05 -0000	1.2546
--- ChangeLog	1 May 2002 13:15:46 -0000
***************
*** 56,61 ****
--- 56,72 ----
  	(ppc_sysv_abi_push_arguments): Handle vector parameters.
  	* ppc-tdep.h (ppc_sysv_abi_broken_use_struct_convention): Export.

+ 2002-04-26  Fred Fish  <fnf <at> redhat.com>
+ 
+ 	* main.c (display_space_base): Add global variable.
+ 	(main): Initialize display_space_base by calling sbrk.
+ 
+ 	* main.c (captured_main): Add display_space_base decl, remove environ
+ 	decl and reference, remove lim variable, use display_space_base.
+ 	* top.c (command_loop): Ditto.
+ 	* event-top.c (command_handler): Ditto.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Elena Zannoni | 1 May 2002 15:53
Picon
Favicon

Re: [RFA] Remove dependency on load address of environ

Fred Fish writes:
 > > I proofread this patch and it looks correct to me, no problems found.
 > > I have not tested it though.
 > 
 > Peter Schauer found one problem with it, an sbrk not protected by HAVE_SBRK.

Ah, I see, in main().

 > Here is a revised patch.
 > 

Looks reasonable. 

Elena

 > -Fred
 > 
 > Index: ChangeLog
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/ChangeLog,v
 > retrieving revision 1.2546
 > diff -c -p -r1.2546 ChangeLog
 > *** ChangeLog	1 May 2002 03:14:05 -0000	1.2546
 > --- ChangeLog	1 May 2002 13:15:46 -0000
 > ***************
 > *** 56,61 ****
 > --- 56,72 ----
 >   	(ppc_sysv_abi_push_arguments): Handle vector parameters.
 >   	* ppc-tdep.h (ppc_sysv_abi_broken_use_struct_convention): Export.
 >
(Continue reading)

Permalink | Reply | 1 comment |
headers
Andrew Cagney | 1 May 2002 16:13
Picon

Re: [RFC] Ada Support Plan

> Evening all. I got the copyright assignment forms back from the FSF
> today. :)
> 
> So I've been thinking about how to go about feeding the patches to the
> list, and basically came up with this:
> 
> 1. patches to files that the ada-* files need (I *think* this is a
> no-op, but I'm checking atm).

I'm not sure.  See below.

> 2. patches for the ada-* files and Makefile.in
> 
> 3. patches for enabling ada support in the internals
> 
> 4. patches to "set lang ada" and detect when to go into ada mode.
> 
> Does this seem reasonable? Is there a better way of doing it?

Have a look at what Petr Sorfa proposed for f95. My take on his strategy 
is to first get something that compiles and vagely works into the FSF 
repository and then, using that as a starting / discussion / reference 
point, integrate the more intrusive changes.

I think you're proposing the same strategy.

Andrew
Permalink | Reply | 1 comment |
headers
Fred Fish | 1 May 2002 16:08

Re: [RFA] Remove dependency on load address of environ

> Looks reasonable. 

OK, I'll take that as approval.  :-)

I'll wait a couple days for any objections to surface and then go
ahead and check it in if there aren't any.

-Fred
Permalink | Reply | 0 comments |

Gmane