headers
cgd | 25 Apr 2002 18:18
Favicon

Re: which patches to review

At Thu, 25 Apr 2002 14:04:30 +0000 (UTC), "Andrew Cagney" wrote:
> David, to (possibly re-iterate) some previous suggestions:
> 
> > If you post a new patch, start a new thread.
> > If you superseed a patch, clearly withdraw the old patch.
> 
> This makes life easier for everyone and is accepted pratice on this list.

My personal practice, which i've found helpful in the past, is to keep
a list of patches i've submitted, keep track of their status, and
occasionally send a ping msg containing the list of unreviewed patches
that have gone "too long" w/o approval or rejection.

Like it or not, even in the best circumstances things _do_ get lost,
dropped, overlooked, or otherwise ignored occasionally.  That's
especially true when volunteers are doing the reviewing, and the
volunteers are busy.

I've found that it also helps me keep track of my own outstanding
patches when _I_ get really busy and distracted for a month at a
time...  8-)

(my personal cutoff for 'too long' tends to be '2 weeks to a month, or
whenever after a longer period i remember to look at my outstanding
patches page.'  8-)

chris
Permalink | Reply | 0 comments |
headers
Pierre Muller | 25 Apr 2002 18:27
Picon
Picon

Re: [RFA] Fix bug report #508

At 18:04 25/04/2002 , Daniel Jacobowitz a écrit:
>On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
> > This is a fix (allmost obvious) to
> > the  bug report #508.
> > 
> > 
> > ChangeLog entry:
> > 
> > 2002-04-25  Pierre Muller  <muller <at> ics.u-strasbg.fr>
> > 
> >       * symfile.c (add_filename_language): Fix wrong xrealloc size argument.
>
>I'd call this obvious, actually.  Please commit it (but add 'Fix PR
>gdb/508' above '* symfile.c' in your changelog).
Done.

Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller <at> ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
Permalink | Reply | 0 comments |
headers
Pierre Muller | 25 Apr 2002 18:31
Picon
Picon

Re: [RFA] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in f-lang.c

At 17:27 25/04/2002 , Andrew Cagney a écrit:
>>2002-04-24  Pierre Muller  <ics.u-strasbg.fr>
>>* f-lang.c (get_bf_for_fcn): Replace fprintf (stderr,...
>>         with fprintf_unfiltered (gdb_stderr,....
>
>Looks ok.
Committed.

Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller <at> ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
Permalink | Reply | 0 comments |
headers
Pierre Muller | 25 Apr 2002 18:33
Picon
Picon

Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c

At 17:38 25/04/2002 , Andrew Cagney a écrit:
>>On Wed, Apr 24, 2002 at 11:50:40AM -0700, Michael Snyder wrote:
>>
>>>Daniel Jacobowitz wrote:
>>
>>> > > On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote:
>>
>>> > > This is a second of the files that I listed in
>>> > > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html
>>> > > as still having direct uses of stderr.
>>> > >
>>> > > I did not fix a 80 char overflow, because I didn't find a good way to do it:
>>> > > If I try to align the string "Psymtab for %s already read in.  Shouldn't happen.\n"
>>> > > with gdb_stderr, I still get an overflow, how show I indent the args then?
>>> > > Should I break the string constant?
>>
>>> > > Yes, I'd recommend:
>>> > > -      fprintf (stderr, "Psymtab for %s already read in.  Shouldn't happen.\n",
>>> > +      fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in.  "
>>> > "Shouldn't happen.\n",
>
>The other is the more traditional:
>
>         ..... "\
>Psymtab for ......\n\
>.......\n"
>
>(the ``\'' at the end of the line is needed.
>
>>>
(Continue reading)

Permalink | Reply | 2 comments |
headers
Pierre Muller | 25 Apr 2002 18:34
Picon
Picon

Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in remote*.c

At 17:50 25/04/2002 , Andrew Cagney a écrit:
>>This is one of the files that I listed in
>>http://sources.redhat.com/ml/gdb/2002-02/msg00212.html
>>as still having direct uses of stderr.
>>   I don't even know if this is correct,
>>because I don't know if the gdb_std???
>>should be used in these files.
>
>It should be used everywhere, so yes it is fine.
>
>>remote-array.c seems to also use gdb_stdout
>>so that one should be correct.
>
>Yes.
>
>(Eventually GDB needs to audit all its error/output messages and decide which should go where.  That,
however, is a separate problem.  Probably something to do if/when i18n occures.)
>
>>remote-es.c has no other reference to gdb_std???
>>variables, so here it could well be an error to do that change.
>>Idem for remote-os9k.c and remote-st.c.
>
>These can also also be changed.  gdb_stderr is defined in defs.h, so it is visible.

Can I commit the whole together then?

Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
(Continue reading)

Permalink | Reply | 4 comments |
headers
Elena Zannoni | 25 Apr 2002 18:41
Picon
Favicon

Re: [RFA] Fix bug report #508

Daniel Jacobowitz writes:
 > On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
 > > This is a fix (allmost obvious) to
 > > the  bug report #508.
 > > 
 > > 
 > > ChangeLog entry:
 > > 
 > > 2002-04-25  Pierre Muller  <muller <at> ics.u-strasbg.fr>
 > > 
 > > 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.
 > 
 > I'd call this obvious, actually.  Please commit it (but add 'Fix PR
 > gdb/508' above '* symfile.c' in your changelog).

Thanks Daniel,
yes, please commit it.

Elena

 > 
 > > $ cvs diff -u -p -N symfile.c
 > > Index: symfile.c
 > > ===================================================================
 > > RCS file: /cvs/src/src/gdb/symfile.c,v
 > > retrieving revision 1.59
 > > diff -u -p -r1.59 symfile.c
 > > --- symfile.c   22 Apr 2002 10:19:35 -0000      1.59
 > > +++ symfile.c   24 Apr 2002 22:24:14 -0000
 > >  <at>  <at>  -1831,8 +1831,9  <at>  <at>  add_filename_language (char *ext, enum l
(Continue reading)

Permalink | Reply | 0 comments |
headers
Pierre Muller | 25 Apr 2002 18:46
Picon
Picon

[RFA]Use prev_lexptr in *-exp.y

At 17:30 25/04/2002 , Andrew Cagney a écrit:
>>2002-04-25  Pierre Muller  <muller <at> ics.u-strasbg.fr>
>>* p-exp.y: Also use new prev_lexptr variable
>>         to improve error reporting. Based on Michael Snyder
>>         2002-04-24 dated patch to c-exp.y.
>
>Nice.  Can I suggest creating bug report so we know that the others should be done.

This is more work than fixing them directly!

So what about that:

ChangeLog entry:

2002-04-25  Pierre Muller  <muller <at> ics.u-strasbg.fr>
         * f-exp.y: Also use new prev_lexptr variable
         to improve error reporting. Based on Michael Snyder
         2002-04-24 dated patch to c-exp.y.
         * jv-exp.y: Likewise.
         * m2-exp.y: Likewise.

Index: f-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/f-exp.y,v
retrieving revision 1.5
diff -u -p -r1.5 f-exp.y
--- f-exp.y     6 Mar 2001 08:21:07 -0000       1.5
+++ f-exp.y     25 Apr 2002 16:45:29 -0000
 <at>  <at>  -924,7 +924,9  <at>  <at>  yylex ()
    char *tokstart;
(Continue reading)

Permalink | Reply | 5 comments |
headers
Pierre Muller | 25 Apr 2002 18:49
Picon
Picon

Re: [RFA] Fix bug report #508

At 18:41 25/04/2002 , Elena Zannoni a écrit:
>Daniel Jacobowitz writes:
>  > On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
>  > > This is a fix (allmost obvious) to
>  > > the  bug report #508.
>  > > 
>  > > 
>  > > ChangeLog entry:
>  > > 
>  > > 2002-04-25  Pierre Muller  <muller <at> ics.u-strasbg.fr>
>  > > 
>  > >    * symfile.c (add_filename_language): Fix wrong xrealloc size argument.
>  > 
>  > I'd call this obvious, actually.  Please commit it (but add 'Fix PR
>  > gdb/508' above '* symfile.c' in your changelog).
>
>Thanks Daniel,
>yes, please commit it.

I already did, I hope I was not too fast here...

How do I change the status of the bug report?

Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller <at> ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
(Continue reading)

Permalink | Reply | 1 comment |
headers
Elena Zannoni | 25 Apr 2002 18:55
Picon
Favicon

Re: [RFA] Fix bug report #508

Pierre Muller writes:
 > At 18:41 25/04/2002 , Elena Zannoni a écrit:
 > >Daniel Jacobowitz writes:
 > >  > On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
 > >  > > This is a fix (allmost obvious) to
 > >  > > the  bug report #508.
 > >  > > 
 > >  > > 
 > >  > > ChangeLog entry:
 > >  > > 
 > >  > > 2002-04-25  Pierre Muller  <muller <at> ics.u-strasbg.fr>
 > >  > > 
 > >  > >    * symfile.c (add_filename_language): Fix wrong xrealloc size argument.
 > >  > 
 > >  > I'd call this obvious, actually.  Please commit it (but add 'Fix PR
 > >  > gdb/508' above '* symfile.c' in your changelog).
 > >
 > >Thanks Daniel,
 > >yes, please commit it.
 > 
 > I already did, I hope I was not too fast here...
 > 
 > How do I change the status of the bug report?
 > 

I usually log into gnats and change the state of the PR to closed.
http://sources.redhat.com/cgi-bin/gnatsweb.pl?database=gdb&user=guest&password=guest&cmd=query

(use the 'login again' button at the top to log in)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andrew Cagney | 25 Apr 2002 19:16
Picon

Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c

> (Pierre, yes, ok with a tweak).
> 
> Sorry, but I din't understand which version of the
> modification I should use here...

Either is acceptable and either works.  (Personally, it really doesn't 
worry me :-)  I suspect danielJ slightly prefers the ISO C form, so 
perhaps go with that.

Andrew
Permalink | Reply | 1 comment |

Gmane