Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5]

Daniel Jacobowitz wrote:
> On Thu, Mar 20, 2003 at 05:13:40PM -0500, Andrew Cagney wrote:
> 
>>>>
>>>>Would it be possible to make the cplus_demangle() method part of the 
>>>>language vector?  That way code like the patch below could be reduced to:
>>>>
>>>>	/* Return demangled language symbol, or NULL.  */
>>>>	language_demangle (current_language, arg);
>>>>
>>>>This would in turn allow Adam to just add an equivalent objc_demangle() 
>>>>method to the objc language vector, and hence eliminate the need to 
>>>>always link in objc-lang.c.
>>>
>>As well as then?  The places where objc is adding calls to the demangler 
>>the language is known.
> 
> 
> My gut reaction is that it's just clutter until we decide how to solve
> the problem of not knowing demanglings.  But it'll do for now.  I'd
> like a comment along the lines of:
> 
> /* FIXME: sometimes the demangler is invoked when we don't know the
>    language, so we can't use this everywhere.  */
> 

Here's my crack at doing this

[commit] d10v doesn't need FP_REGNUM

Hello,

There is no reason for the d10v to set FP_REGNUM.  In fact, once the 
d10v's frame ID stack address is pointing at the wrong place, it causes 
certain failures.

committed,
Andrew

2003-03-30  Andrew Cagney  <cagney <at> redhat.com>

	* d10v-tdep.c: Replace _FP_REGNUM and FP_REGNUM with
	D10V_FP_REGNUM.
	(d10v_gdbarch_init): Do not set fp_regnum.

Index: d10v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d10v-tdep.c,v
retrieving revision 1.94
diff -u -r1.94 d10v-tdep.c
--- d10v-tdep.c	30 Mar 2003 00:09:40 -0000	1.94
+++ d10v-tdep.c	31 Mar 2003 02:34:54 -0000
 <at>  <at>  -68,7 +68,7  <at>  <at> 
   {
     R0_REGNUM = 0,
     R3_REGNUM = 3,
-    _FP_REGNUM = 11,
+    D10V_FP_REGNUM = 11,
     LR_REGNUM = 13,

[framebase branch] Make d10v's frame ID constant

Hello,

This patch changes the d10v so that its frame id is constant.  Part of 
this means stopping a prologue analysis at the frame's current instruction.

It also converts two FRAME_ARGS_ADDRESS() methods to 
get_frame_args_address().

committed to the framebase branch,
Andrew

2003-03-30  Andrew Cagney  <cagney <at> redhat.com>

	* findvar.c (read_var_value): Use get_frame_args_address.
	
	* d10v-tdep.c (d10v_gdbarch_init): Do not set fp_regnum.
	(D10V_FP_REGNUM): Rename _FP_REGNUM and FP_REGNUM.
	(struct d10v_unwind_cache): Add the fields "prev_sp" and
	"this_func".  Update comment for base.
	(d10v_frame_unwind_cache): Set "prev_sp" and "this_func".
	(d10v_frame_this_id): Use the previous frame's inner most stack
	address and this frame's func address for the frame ID.  Use
	frame_id_build.  Don't analyze beyond the current instruction.

Index: d10v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d10v-tdep.c,v
retrieving revision 1.90.2.2
diff -u -r1.90.2.2 d10v-tdep.c

Re: Adding -file-list-exec-source-file command to GDB/MI

> 
> Sure, I'll look into that. I would also like to add the extra field to
> -break-list. Does that make sense to everyone else?

Does to me.

Re: [RFA/ping] new GDB/MI command: -symbol-info-linetable

Hello,

> I unfortunately do not have a valid FSF assignement on file, yet.
> I have sent my application to the FSF, and I am waiting for the papers
> to arrive by mail.

First, I am pleased to announce that I now have an FSF assignment
on file.

Could a maintainer review  the following change that I submitted
sometime ago, please? I also noted that somebody else (Bob Rossi)
found this new (MI) function useful.

> 2003-03-09  Thierry Schneider  <tpschneider1 <at> yahoo.com>
> 
>         * mi-main.c (mi_cmd_symbol_info_linetable): New function.
>         * mi-cmds.h (mi_cmd_symbol_info_linetable): Add declaration.
>         * mi-cmds.c (mi_cmds): Add entry for new MI command.
>         * gdbmi.texinfo (GDB/MI Symbol Query): Add documentation for
>         new MI command.
> 
> 2003-03-09  Thierry Schneider  <tpschneider1 <at> yahoo.com>
> 
>         * mi1-linetable.exp: New file.

The message quoted above is at:
     http://sources.redhat.com/ml/gdb-patches/2003-03/msg00208.html

Thank you,
--

-- 

Re: [commit] Fix set $ev0.vec_f[0] = 1

> PS: Elena's e500 tests, that I just posted, tickle this bug.
> 
> 
> This patch is the same as the unreviewed pending/973 from Klee, by the
> way.  He also fixed a related comment; should that go in too?

Ah, I've checked this in.

Andrew

2003-03-30  Andrew Cagney  <cagney <at> redhat.com>

         2002-11-10 Klee Dienes <kdienes <at> apple.com>
         * value.h (struct value): Update comment.

  --- value.h    2002/10/15 03:32:35     1.20
+++ value.h    2002/11/10 22:40:39
 <at>  <at>  -127,9 +127,7  <at>  <at> 
          list.  */
       struct value *next;

-    /* Register number if the value is from a register.  Is not kept
-       if you take a field of a structure that is stored in a
-       register.  Shouldn't it be?  */
+    /* Register number if the value is from a register.  */
       short regno;
       /* If zero, contents of this value are in the contents field.
          If nonzero, contents are in inferior memory at address

Re: Adding -file-list-exec-source-file command to GDB/MI

> This change essentially adds the command -file-list-exec-source-file to
> the mi commands.
> 
> * mi-cmd-file.c:    Added file to implement mi file commands.
> * mi-cmds.c:        Added -file-list-exec-source-file command.
> * mi-cmds.h:        Added -file-list-exec-source-file to proto list.
> * doc/gdb.texinfo:  Document -file-list-exec-source-file.

> * mi-file.exp:      Added testcase to test -file-list-exec-source-file.

I've attached a slightly tweaked version.  It was checking for the path 
to the executable instead of the source file (separate build / config 
directories is the norm) (I'm also not sure what would happen if the 
configure contained a relative path but worry about that when someone 
notices 

> +  <at> subheading The  <at> code{-file-list-exec-source-file} Command
> +  <at> findex -file-list-exec-source-file
> + 
> +  <at> subsubheading Synopsis
> + 
> +  <at> smallexample
> +  -file-list-exec-source-file

Can you please expand this to include sample output vis:

(gdb)
111-file-list-exec-source-file
111^done,line="23",file="/home/scratch/GDB/src/gdb/testsuite/gdb.mi/basics.c"
(gdb)

Re: [patch rfc] Delete CALL_DUMMY_P

> Date: Sat, 29 Mar 2003 15:05:08 -0500
> From: Andrew Cagney <ac131313 <at> redhat.com>
> 
> All architectures (I think there was once one) that didn't support=20
> inferior function calls have been either obsoleted or deleted.  Hence=20
> CALL_DUMMY_P is always one, and gdb always supports inferior function=20
> calls.  This deletes the architecture method that indicated the lack of=20
> inferior function call support.

Okay for the manual's patch.

Re: [patch rfc] TARGET_WRITE_SP -> DEPRECATED_DUMMY_WRITE_SP

> Date: Fri, 28 Mar 2003 10:56:17 -0500
> From: Andrew Cagney <ac131313 <at> redhat.com>
> 
> The attached patch replaces TARGET_WRITE_SP with=20
> DEPRECATED_DUMMY_WRITE_SP.  Instead of providing this method, an=20
> architecture is expected to update the stack pointer as part of creating=20
> the fake call-frame (in push_dummy_call()).

The manual patch is okay with me.

Re: Adding -file-list-exec-source-file command to GDB/MI

On Sun, Mar 30, 2003 at 11:22:03PM -0500, Andrew Cagney wrote:
> > 
> > Sure, I'll look into that. I would also like to add the extra field to
> > -break-list. Does that make sense to everyone else?
> 
> Does to me.

Ah, I see why this has never been an issue at Apple.  We control
the compiler, and -gstabs+ is the default debug output.  This means
that we have the compilation directory at the start of each file,
e.g. (the file /tmp/e/f/a.c compiled from /tmp/e)

        .stabs  "/tmp/e/",100,0,0,.Ltext0
        .stabs  "f/a.c",100,0,0,.Ltext0

And we have a modification to MI in our gdb which includes that
directory in things like stack-list-frames.  Here's the Apple gdb
output when
stopped:

-stack-list-frames
^done,stack=[frame={level="0",addr="0x00001dc8",fp="0xbffffca0",func="foo",file="f/a.c",line="3",dir="/tmp/e/"}, [...]

And here's the FSF gdb:

-stack-list-frames
^done,stack=[frame={level="0 ",addr="0x0804830f",func="foo",file="f/a.c",line="3"}, [...]

The other difference is the addition of FP here -- our UI uses the
PC and FP to uniquely identify stack frames so it won't re-fetch