freeradius developer list

Wang Tinggong | 1 Feb 2010 10:51

[PATCH] radiusd.h: fix error "expected specifier-qualifier-list before 'RADCLIENT' "

Signed-off-by: Wang Tinggong <wangtinggong <at> gmail.com>
---
 src/include/radiusd.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/include/radiusd.h b/src/include/radiusd.h
index 8ec5bbb..486cbe0 100644
--- a/src/include/radiusd.h
+++ b/src/include/radiusd.h
 <at>  <at>  -104,9 +104,6  <at>  <at>  typedef struct auth_req REQUEST;

 typedef struct radclient_list RADCLIENT_LIST;

-#include <freeradius-devel/smodule.h>
-
-
 /*
  *	See util.c
  */
 <at>  <at>  -153,6 +150,7  <at>  <at>  typedef struct radclient {
 #endif
 } RADCLIENT;

+#include <freeradius-devel/smodule.h>

 /*
  *	For listening on multiple IP's and ports.
--

-- 
1.6.0.6
-

(Continue reading)

headers

Wang Tinggong | 1 Feb 2010 10:52

[PATCH] event.c: eliminate warning "‘maxfd’ may be used uninitialized"

Signed-off-by: Wang Tinggong <wangtinggong <at> gmail.com>
---
 src/lib/event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/event.c b/src/lib/event.c
index 84a928b..6f91661 100644
--- a/src/lib/event.c
+++ b/src/lib/event.c
 <at>  <at>  -322,13 +322,13  <at>  <at>  int fr_event_loop(fr_event_list_t *el)
 	el->exit = 0;
 	el->dispatch = 1;
 	el->changed = 1;
+	maxfd = 0;

 	while (!el->exit) {
 		/*
 		 *	Cache the list of FD's to watch.
 		 */
 		if (el->changed) {
-			maxfd = 0;
 			FD_ZERO(&master_fds);
 			
 			for (i = 0; i < el->max_readers; i++) {
--

-- 
1.6.0.6
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

(Continue reading)

headers

Wang Tinggong | 1 Feb 2010 10:53

[PATCH] tcp.c: elimiate warining "format '%ld', but argument has type 'ssize_t'

Signed-off-by: Wang Tinggong <wangtinggong <at> gmail.com>
---
 src/lib/tcp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/tcp.c b/src/lib/tcp.c
index 2f0946b..4a691c1 100644
--- a/src/lib/tcp.c
+++ b/src/lib/tcp.c
 <at>  <at>  -323,7 +323,7  <at>  <at>  int fr_tcp_read_packet(RADIUS_PACKET *packet, int flags)
 			DEBUG("rad_recv: Packet from %s code=%d",
 			      buffer, packet->code);
 		}
-		DEBUG(", id=%d, length=%ld\n", packet->id, packet->data_len);
+		DEBUG(", id=%d, length=%d\n", packet->id, packet->data_len);
 	}

 	return 1;		/* done reading the packet */
--

-- 
1.6.0.6
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

headers

Alan DeKok | 1 Feb 2010 11:02

Re: [PATCH] radiusd.h: fix error "expected specifier-qualifier-list before 'RADCLIENT' "

  Please do not CC me on messages to this list.  I already subscribe.
Getting two copies of the same message is annoying.

  Alan DeKok.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

headers

WANG Tinggong | 1 Feb 2010 11:06

git tree build error

hi all,

i got the latest freeRadius tree from git://git.freeradius.org/freeradius-server.git , and i try to
compile it under these steps:
	1. ./configure
	2. make
after that, i encountered an error:
In file included from /home/wtg/develop/freeradius-server/src/freeradius-devel/radiusd.h:154,
                 from frs_acct.c:30:
/home/wtg/develop/freeradius-server/src/freeradius-devel/smodule.h:146: error: expected
specifier-qualifier-list before ‘fr_tcp_radius_t’

git-log says after commit e04b62, fr_tcp_radius_t structure and API are deleted, but it still stay in 
src/main/listen.c
src/include/smodule.h

is it a bug?

-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

headers

Alex Massover | 1 Feb 2010 11:11

freeradius-client sequence file replacement

Hello,

I made a patch that adds fast locking mechanisms instead of seq file for freeradius-client.

This patch is based on putting the sequence number in the shared memory. Two approaches used to do a mutual exclusion for shared memory:

a) GCC builtin atomic memory access (only on Intel)

b) POSIX named semaphore

Fallback:

c) If nothing of the above available it fallbacks to a sequence file locks.

Originally I did it against radiusclient-ng, but looks that freeradius-client is a correct place. The patch works for freeradius-client 1.1.6 as well.

Here’s a patch and more detailed description:

http://developer.berlios.de/patch/?func=detailpatch&patch_id=2810&group_id=1208

--

Best Regards,

Alex Massover

VoIP R&D TL

Jajah Inc.

This mail was sent via Mail-SeCure System.

-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

headers

Alex Massover | 1 Feb 2010 11:25

freeradius-client rc_avpair_log() function

Hi,

AFAIU, rc_avpair_log() function in freeradius-client is not thread-safe, it uses a shared buffer (rh->ppbuf).

So one can’t have shared rc_handle if calling to rc_avpair_log() from different threads.

Please tell me if that’s correct and I’ll make a simple patch changing:

rc_avpair_log(rc_handle *rh, VALUE_PAIR *pair)

to

rc_avpair_log(rc_handle *rh, VALUE_PAIR *pair, char *buf, size_t l)

This way a caller will provide a non-shared buffer.

--

Best Regards,

Alex Massover

VoIP R&D TL

Jajah Inc.

This mail was sent via Mail-SeCure System.

-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

headers

Alan Buxey | 1 Feb 2010 11:24

Re: git tree build error

Hi,

> git-log says after commit e04b62, fr_tcp_radius_t structure and API are deleted, but it still stay in 
> src/main/listen.c
> src/include/smodule.h

I recall that you've submitted some patches for these files - in which case you have
local copies of those files that you have played with and are therefore locked
and so you wont get new versions - you need to use the tools in GIT to make
our own branch for your work....

ie download a fresh GIT copy and you'll get the new versions of those...

alan
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

headers

Alan DeKok | 1 Feb 2010 11:29

Re: freeradius-client rc_avpair_log() function

Alex Massover wrote:
> Please tell me if that’s correct and I’ll make a simple patch changing:
>  
> rc_avpair_log(rc_handle *rh, VALUE_PAIR *pair)
> 
> to
> 
> rc_avpair_log(rc_handle *rh, VALUE_PAIR *pair, char *buf, size_t l)

  That's a good idea, thanks.

  Alan DeKok.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

headers

Alan DeKok | 1 Feb 2010 11:36

Re: freeradius-client sequence file replacement

Alex Massover wrote:
> I made a patch that adds fast locking mechanisms instead of seq file for
> freeradius-client.

  OK... I just re-read the original code, and boggled a bit.  Using a
file for a sequence number is completely wrong.  There is just no need.

  I'd suggest two patches:

 1) replace "seq_nbr" in the code with "id".  The field is NOT a
    sequence number.  it's a random id.  The ONLY requirement
    is that it's unique until the outgoing packet times out,
    or a reply is received.

 2) replace the rc_get_seqnbr() with a function that tracks 256
    allocated IDs, and allocates a free one.  Also update
    rc_check_reply() to mark the "id" as free.

  This will be *enormously* faster than using a file or shared memory.

  The array of 256 Ids needs to be unique per source port.  But it can
be shared across child threads.  It does NOT need to be shared across
multiple processes.

  The main server code does it a little differently.  See
src/lib/packet.c for a number of functions that track/allocate/free
packet Ids.

  Alan DeKok.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

129	May 2013
101	April 2013
132	March 2013
180	February 2013
90	January 2013
166	December 2012
104	November 2012
135	October 2012
146	September 2012
61	August 2012
19	July 2012
50	June 2012
44	May 2012
25	April 2012
12	March 2012
78	February 2012
99	January 2012
9	December 2011
96	November 2011
128	October 2011
69	September 2011
69	August 2011
90	July 2011
104	June 2011
99	May 2011
38	April 2011
69	March 2011
17	February 2011
52	January 2011
41	December 2010
64	November 2010
18	October 2010
46	September 2010
44	August 2010
31	July 2010
52	June 2010
45	May 2010
66	April 2010
28	March 2010
113	February 2010
19	January 2010
67	December 2009
30	November 2009
53	October 2009
103	September 2009
122	August 2009
55	July 2009
36	June 2009
64	May 2009
81	April 2009
98	March 2009
85	February 2009
79	January 2009
22	December 2008
26	November 2008
51	October 2008
60	September 2008
53	August 2008
53	July 2008
44	June 2008
50	May 2008
63	April 2008
60	March 2008
43	February 2008
93	January 2008
57	December 2007
111	November 2007
84	October 2007
107	September 2007
142	August 2007
236	July 2007
77	June 2007
211	May 2007
95	April 2007
119	March 2007
116	February 2007
114	January 2007
36	December 2006
114	November 2006
90	October 2006
146	September 2006
196	August 2006
88	July 2006
100	June 2006
90	May 2006
115	April 2006
92	March 2006
114	February 2006
195	January 2006
86	December 2005
101	November 2005
101	October 2005
150	September 2005
162	August 2005
79	July 2005
106	June 2005
144	May 2005
112	April 2005
171	March 2005
99	February 2005
80	January 2005
8	December 2004

Mon	Tue	Wed	Thu	Fri	Sat	Sun

1	2	3	4	5	6	7
8	9	10	11	12	13	14
15	16	17	18	19	20	21
22	23	24	25	26	27	28