1 Apr 2012 05:31
1 Apr 2012 12:51
Re: [PATCH] drm/i915: Add a dual link lvds quirk for MacBook Pro 8, 2
Chris Wilson <chris <at> chris-wilson.co.uk>
2012-04-01 10:51:19 GMT
2012-04-01 10:51:19 GMT
On Tue, 27 Mar 2012 09:18:20 +0200, Daniel Vetter <daniel.vetter <at> ffwll.ch> wrote: > When booting with EFI, Apple botched this one up. > > Tested-by: Austin Lund <austin.lund <at> gmail.com> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=42842 > Signed-Off-by: Daniel Vetter <daniel.vetter <at> ffwll.ch> I'm not impressed, but it seems to be a sad reality of the world. I think the ident is both too lax and too specific. The Core i7 moniker would seem to exclude the i5 processors Apple also uses, and the Pro range is wide enough that there might be a model with a single-link LVDS. I'm not sure if this will fix one machine only to break others. Wider testing required. -Chris -- -- Chris Wilson, Intel Open Source Technology Centre
1 Apr 2012 13:16
[PATCH 1/2] drm/i915: make quirks more verbose
Daniel Vetter <daniel.vetter <at> ffwll.ch>
2012-04-01 11:16:49 GMT
2012-04-01 11:16:49 GMT
And add informational dmesg output where it does not yet exist.
In case a quirk matches too much, this information is crucial for
debugging such a bug report.
Signed-Off-by: Daniel Vetter <daniel.vetter <at> ffwll.ch>
---
drivers/gpu/drm/i915/intel_crt.c | 2 +-
drivers/gpu/drm/i915/intel_display.c | 4 +++-
drivers/gpu/drm/i915/intel_lvds.c | 4 ++--
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index d54d232..70b0f1a 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
<at> <at> -545,7 +545,7 <at> <at> static const struct drm_encoder_funcs intel_crt_enc_funcs = {
static int __init intel_no_crt_dmi_callback(const struct dmi_system_id *id)
{
- DRM_DEBUG_KMS("Skipping CRT initialization for %s\n", id->ident);
+ DRM_INFO("Skipping CRT initialization for %s\n", id->ident);
return 1;
}
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 09f7be6..5baa896 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
<at> <at> -9362,7 +9362,7 <at> <at> static void quirk_pipea_force(struct drm_device *dev)
(Continue reading)
1 Apr 2012 13:16
[PATCH 2/2] drm/i915: Add a dual link lvds quirk for MacBook Pro 8, 2
Daniel Vetter <daniel.vetter <at> ffwll.ch>
2012-04-01 11:16:50 GMT
2012-04-01 11:16:50 GMT
When booting with EFI, Apple botched this one up. v2: Switch the quirk dmesg output to DRM_INFO. Tested-by: Austin Lund <austin.lund <at> gmail.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=42842 Signed-Off-by: Daniel Vetter <daniel.vetter <at> ffwll.ch> --- drivers/gpu/drm/i915/intel_display.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 5baa896..516e701 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c <at> <at> -24,6 +24,7 <at> <at> * Eric Anholt <eric <at> anholt.net> */ +#include <linux/dmi.h> #include <linux/cpufreq.h> #include <linux/module.h> #include <linux/input.h> <at> <at> -418,6 +419,24 <at> <at> static void vlv_init_dpio(struct drm_device *dev) POSTING_READ(DPIO_CTL); } +static int intel_dual_link_lvds_callback(const struct dmi_system_id *id) +{ + DRM_DEBUG_KMS("Forcing lvds to dual link mode on %s\n", id->ident);(Continue reading)
1 Apr 2012 13:19
Re: [PATCH 1/2] drm/i915: make quirks more verbose
Chris Wilson <chris <at> chris-wilson.co.uk>
2012-04-01 11:19:05 GMT
2012-04-01 11:19:05 GMT
On Sun, 1 Apr 2012 13:16:49 +0200, Daniel Vetter <daniel.vetter <at> ffwll.ch> wrote: > And add informational dmesg output where it does not yet exist. > > In case a quirk matches too much, this information is crucial for > debugging such a bug report. > > Signed-Off-by: Daniel Vetter <daniel.vetter <at> ffwll.ch> Like. Reviewed-by: Chris Wilson <chris <at> chris-wilson.co.uk> -Chris -- -- Chris Wilson, Intel Open Source Technology Centre
1 Apr 2012 13:19
Re: [PATCH 2/2] drm/i915: Add a dual link lvds quirk for MacBook Pro 8, 2
Chris Wilson <chris <at> chris-wilson.co.uk>
2012-04-01 11:19:58 GMT
2012-04-01 11:19:58 GMT
On Sun, 1 Apr 2012 13:16:50 +0200, Daniel Vetter <daniel.vetter <at> ffwll.ch> wrote: > When booting with EFI, Apple botched this one up. > > v2: Switch the quirk dmesg output to DRM_INFO. > > Tested-by: Austin Lund <austin.lund <at> gmail.com> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=42842 > Signed-Off-by: Daniel Vetter <daniel.vetter <at> ffwll.ch> New changelog, old patch. :) -Chris -- -- Chris Wilson, Intel Open Source Technology Centre
1 Apr 2012 13:38
[PATCH] drm/i915: Add a dual link lvds quirk for MacBook Pro 8, 2
Daniel Vetter <daniel.vetter <at> ffwll.ch>
2012-04-01 11:38:50 GMT
2012-04-01 11:38:50 GMT
When booting with EFI, Apple botched this one up. v2: Switch the quirk dmesg output to DRM_INFO. v3: Actually git add the new things ... Tested-by: Austin Lund <austin.lund <at> gmail.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=42842 Signed-Off-by: Daniel Vetter <daniel.vetter <at> ffwll.ch> --- drivers/gpu/drm/i915/intel_display.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 5baa896..3abebb5 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c <at> <at> -24,6 +24,7 <at> <at> * Eric Anholt <eric <at> anholt.net> */ +#include <linux/dmi.h> #include <linux/cpufreq.h> #include <linux/module.h> #include <linux/input.h> <at> <at> -418,6 +419,24 <at> <at> static void vlv_init_dpio(struct drm_device *dev) POSTING_READ(DPIO_CTL); } +static int intel_dual_link_lvds_callback(const struct dmi_system_id *id) +{(Continue reading)
1 Apr 2012 16:08
Re: [PATCH] drm/i915: Add a dual link lvds quirk for MacBook Pro 8, 2
Chris Wilson <chris <at> chris-wilson.co.uk>
2012-04-01 14:08:36 GMT
2012-04-01 14:08:36 GMT
On Sun, 1 Apr 2012 13:38:50 +0200, Daniel Vetter <daniel.vetter <at> ffwll.ch> wrote: > When booting with EFI, Apple botched this one up. > > v2: Switch the quirk dmesg output to DRM_INFO. > v3: Actually git add the new things ... > > Tested-by: Austin Lund <austin.lund <at> gmail.com> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=42842 > Signed-Off-by: Daniel Vetter <daniel.vetter <at> ffwll.ch> Having discussed this with Daniel on irc, MacBookPro8,2 seems to be as much information as we have available, so Acked-by: Chris Wilson <chris <at> chris-wilson.co.uk> Hopefully nobody gets caught out by this, but for anybody so unfortunate we should be able to spot the regression in the logs quickly. -Chris -- -- Chris Wilson, Intel Open Source Technology Centre
2 Apr 2012 01:00
Hangcheck does not work on SNB?
Lukas Hejtmanek <xhejtman <at> ics.muni.cz>
2012-04-01 23:00:46 GMT
2012-04-01 23:00:46 GMT
Hello, should the hangcheck mechanism work on Sandy Bridge when XVideo causes GPU to hang? I can repeatedly hang GPU playing video for at least 1 hour continuously. Mouse cursor moves but nothing else. However, I got no message from kernel that GPU hung. The notebook is alive except graphics. -- -- Lukáš Hejtmánek
2 Apr 2012 09:32
Re: Hangcheck does not work on SNB?
Chris Wilson <chris <at> chris-wilson.co.uk>
2012-04-02 07:32:50 GMT
2012-04-02 07:32:50 GMT
On Mon, 2 Apr 2012 01:00:46 +0200, Lukas Hejtmanek <xhejtman <at> ics.muni.cz> wrote: > Hello, > > should the hangcheck mechanism work on Sandy Bridge when XVideo causes GPU to > hang? I can repeatedly hang GPU playing video for at least 1 hour > continuously. Mouse cursor moves but nothing else. > > However, I got no message from kernel that GPU hung. The notebook is alive > except graphics. Even after you stop the video? All it sounds like so far is that it is no longer rendering video frames. Also check your Xorg.log and video player for diagnostics. -Chris -- -- Chris Wilson, Intel Open Source Technology Centre
RSS Feed