Benoit Grégoire | 15 Jan 2004 03:04
Picon
Picon

Some activity and a new LibOfx

Hi everyone,

I finally got around to doing some code cleanup.  This should hopefully finish 
stabilizing the 0.6 series, and give a good starting point for new 
development.

Libofx 0.6.x has been branched off (libofx-0-6-branch).  Source-incompatible 
changes in HEAD are now allowed.  I would like to thank  
Ryan P Bobko of QHacc who just contributed a callback registry.  I haven't yet 
had time to look at it (but will very shortly), as these code cleanup had to 
be done before we could branch.

So LibOfx 0.6.6 has just been released:
	-Important code cleanup in the parsing code. The parser should be much more 
independent of OpenSP default settings.  Should get rid of "end tag for 
"MEMO" omitted, but OMITTAG NO was specified" type messages and many other 
parser failures.
	-The very old OpenSP 1.3.1 will probably no longuer work.  
	-Fix an infinite loop in some circumstances while the library was searching 
for a parent statement for a transaction.  Would mostly manifest on complex 
investments transactions.  Thanks to stephen.a.prior A T ntlworld.ie for the 
catch.
	-Implement displaying file line numbers in the error output.  Note that data 
won't be valid if the message occurs before the file is opened.

If someone still used OpenSP 1.3.x, i'd like to know (just for the record) if 
it still works (it probably won't).

Happy new year,
--

-- 
(Continue reading)

Benoit Grégoire | 15 Jan 2004 05:47
Picon
Picon

A few Ofx fixes

Hello everyone,

I finally got around to doing some code cleanup and releasing a new LibOfx.  
This should hopefully solve many problems, and make the rest much easier to 
debug.  I also just branched off, so major new features can begin to be 
coded.

I still don't have much time to spend on LibOfx, but with the recent offers to 
help from various parties forboth GnuCash and LibOfx, I will do my best to do 
some more coding.

So here the NEWS file:
LibOfx 0.6.6:
	-Important code cleanup in the parsing code. The parser should be much more 
independent of OpenSP default settings.  Should get rid of "end tag for 
"MEMO" omitted, but OMITTAG NO was specified" type messages and many other 
parser failures.
	-The very old OpenSP 1.3.1 will probably no longuer work.  
	-Fix an infinite loop in some circumstances while the library was searching 
for a parent statement for a transaction.  Would mostly manifest on complex 
investments transactions.  Thanks to stephen.a.prior A T ntlworld.ie for the 
catch.
	-Implement displaying file line numbers in the error output.  Note that data 
won't be valid if the message occurs before the file is opened.

If someone still used OpenSP 1.3.x, i'd like to know (just for the record) if 
it still works (it probably won't).

Happy new year,
--

-- 
(Continue reading)

Derek Atkins | 15 Jan 2004 05:56
Picon
Favicon

Re: A few Ofx fixes

Benoit Grégoire <bock <at> step.polymtl.ca> writes:

[snip]

Nice work on the upgrades, and congrats on the bug fixes....

> If someone still used OpenSP 1.3.x, i'd like to know (just for the record) if 
> it still works (it probably won't).

Unfortunately RH9 ships OpenSP 1.3.4 (at least according to
/usr/include/sp/lib/version.h).  I can't check Fedora at the moment,
but it ships openjade-1.3.2 -- not sure what OpenSP that means, RH9
has openjade-1.3.1.

I think dropping support for 1.3.4 would alientate a bunch of
users....  I'll try to test 0.6.6 and see if it still works on this
system.

> Happy new year,
> -- 
> Benoit Grégoire, http://step.polymtl.ca/~bock/

-derek

--

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord <at> MIT.EDU                        PGP key available
(Continue reading)

Stephen Walton | 15 Jan 2004 18:07
Favicon

Re: A few Ofx fixes

On Wed, 2004-01-14 at 20:56, Derek Atkins wrote:

> Unfortunately RH9 ships OpenSP 1.3.4 (at least according to
> /usr/include/sp/lib/version.h).  I can't check Fedora at the moment,
> but it ships openjade-1.3.2 -- not sure what OpenSP that means, RH9
> has openjade-1.3.1.

Fedora seems to have OpenSP 1.5.  At least, there is a subdirectory
called /usr/share/doc/openjade-1.3.2/OpenSP-1.5.

--

-- 
Stephen Walton <stephen.walton <at> csun.edu>
Dept. of Physics & Astronomy, Cal State Northridge

-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
Derek Atkins | 15 Jan 2004 18:12
Picon
Favicon

Re: A few Ofx fixes

Good to know.  So it's pretty much just RH9...

-derek

Stephen Walton <stephen.walton <at> csun.edu> writes:

> On Wed, 2004-01-14 at 20:56, Derek Atkins wrote:
>
>> Unfortunately RH9 ships OpenSP 1.3.4 (at least according to
>> /usr/include/sp/lib/version.h).  I can't check Fedora at the moment,
>> but it ships openjade-1.3.2 -- not sure what OpenSP that means, RH9
>> has openjade-1.3.1.
>
> Fedora seems to have OpenSP 1.5.  At least, there is a subdirectory
> called /usr/share/doc/openjade-1.3.2/OpenSP-1.5.
>
> -- 
> Stephen Walton <stephen.walton <at> csun.edu>
> Dept. of Physics & Astronomy, Cal State Northridge
>
> _______________________________________________
> gnucash-user mailing list
> gnucash-user <at> lists.gnucash.org
> http://www.gnucash.org/cgi-bin/mailman/listinfo/gnucash-user
>
>

--

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
(Continue reading)

ryan p bobko | 18 Jan 2004 16:35

Re: Some activity and a new LibOfx

Hi Everyone,
I'm not sure what the procedure is for applying patches, so I thought I'd give 
a quick heads-up on the work I've been doing on the library before committing 
anything. I've included a patch in this email that extends the callback 
registry a bit, but it also changes the prototypes of the various callback 
functions.

Quick background: I'm a C++ developer, and I'd like to be able to use libOFX 
in a class I've built with as little reliance on global variables as 
possible. I just want to be able to assign arbitrary callbacks to the events 
that get thrown.

To accomplish this, I added the callback registry, but that really only got me 
halfway there. I also need to be able to specify the instance of my object 
that can handle the callback, so I added a void * for each function pointer 
in the registry, and changed the prototypes of the functions to accept a void 
* in addition to the Ofx data structure they each receive. I changed the 
ofx_container_* files to pass the void * from the registry to the callback as 
the first argument. This way, not only can the callbacks handle data, they 
can use it to change particular structures/classes/other functions.

If there are no objections, I'd like to commit these changes. I'm open to 
other ideas on accomplishing my goal, too.

ry

On Wednesday 14 January 2004 21:04, Benoit Grégoire wrote:
> Hi everyone,
>
> I finally got around to doing some code cleanup.  This should hopefully
(Continue reading)

Benoit Grégoire | 18 Jan 2004 23:50
Picon
Picon

Callbacks (Was: Some activity and a new LibOfx)

On Sunday 18 January 2004 10:35, ryan p bobko wrote:
> Hi Everyone,
> I'm not sure what the procedure is for applying patches, so I thought I'd
> give a quick heads-up on the work I've been doing on the library before
> committing anything. I've included a patch in this email that extends the
> callback registry a bit, but it also changes the prototypes of the various
> callback functions.

As there is no CVS commit mailing list (anyone know how to set one up an 
sourceforge?), the "procedure" is to write good Changelog entries (not just 
in CVS, in the ChangeLog file also) and to send a email here if the change is 
significant.  A pach isn't needed unless the focus of your message if for 
people to review the changes.

> Quick background: I'm a C++ developer, and I'd like to be able to use
> libOFX in a class I've built with as little reliance on global variables as
> possible. I just want to be able to assign arbitrary callbacks to the
> events that get thrown.
>
> To accomplish this, I added the callback registry, but that really only got
> me halfway there. I also need to be able to specify the instance of my
> object that can handle the callback, so I added a void * for each function
> pointer in the registry, and changed the prototypes of the functions to
> accept a void * in addition to the Ofx data structure they each receive. I
> changed the ofx_container_* files to pass the void * from the registry to
> the callback as the first argument. This way, not only can the callbacks
> handle data, they can use it to change particular structures/classes/other
> functions.
>
> If there are no objections, I'd like to commit these changes. I'm open to
(Continue reading)

ryan p bobko | 20 Jan 2004 14:05

Re: Callbacks (Was: Some activity and a new LibOfx)

All right, I've committed the changes. The changes are significant, so here's 
a brief introduction. 

The CallbackRegistry structure has been expanded to include a void pointer for 
each callback function. The ofx_prep_cb function has also been expanded to 
include arguments for setting that void *, but these arguments can be null if 
desired. When the callback is executed, the void * from the registry is sent 
as the second argument. This allows a user to pass arbitrary information to 
the recipient of the callback, as well as the ofx data that was previously 
sent.

I also made the suggested changes below. I named the arguments XXX_data where 
XXX is status, security, et. al. I hope that's okay.

ry

On Sunday 18 January 2004 17:50, Benoit Grégoire wrote:
> On Sunday 18 January 2004 10:35, ryan p bobko wrote:
> > Hi Everyone,
> > I'm not sure what the procedure is for applying patches, so I thought I'd
> > give a quick heads-up on the work I've been doing on the library before
> > committing anything. I've included a patch in this email that extends the
> > callback registry a bit, but it also changes the prototypes of the
> > various callback functions.
>
> As there is no CVS commit mailing list (anyone know how to set one up an
> sourceforge?), the "procedure" is to write good Changelog entries (not just
> in CVS, in the ChangeLog file also) and to send a email here if the change
> is significant.  A pach isn't needed unless the focus of your message if
> for people to review the changes.
(Continue reading)


Gmane