1 Jun 2007 05:32
PARTIAL TAKE 965537 - xfsprogs AC_TYPE_U32 broken by defining HAVE___U32_T instead of HAVE___U32
Tim Shimmin <tes <at> sgi.com>
2007-06-01 03:32:33 GMT
2007-06-01 03:32:33 GMT
s/HAVE___U32_T/HAVE___U32/g Thanks to Eric Sandeen for finding this. Date: Fri Jun 1 13:31:17 AEST 2007 Workarea: chook.melbourne.sgi.com:/build/tes/xfs-cmds Inspected by: sandeen <at> sandeen.net The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/xfs-cmds/master-melb Modid: master-melb:xfs-cmds:28754a xfsprogs/doc/CHANGES - 1.240 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsprogs/doc/CHANGES.diff?r1=text&tr1=1.240&r2=text&tr2=1.239&f=h xfsprogs/aclocal.m4 - 1.26 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsprogs/aclocal.m4.diff?r1=text&tr1=1.26&r2=text&tr2=1.25&f=h xfsprogs/m4/package_types.m4 - 1.4 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsprogs/m4/package_types.m4.diff?r1=text&tr1=1.4&r2=text&tr2=1.3&f=h - s/HAVE___U32_T/HAVE___U32/g Thanks to Eric Sandeen for finding this.
>> (Such as xfsdump as Michal mentioned)
>> On Sep/2002, Nathan changed a bunch of them to use v1.
>> xfsprogs-2.3.0 (03 September 2002)
>> - Several changes to geometry ioctl callers which will make
>> the tools useable on older kernel versions too.
>> So he did this so that new tools would work on the older kernels which
>> didn't support the new geom version.
>> So I guess we are stuck with v1 now.
>
> Not necessarily - we could change the tools to use v4, and if that
> didn't exist, then try v1. That way we don't need to support v1 in
> linux, and the tools still run on old kernels.....
>
The problem with that is the old tools won't run on new kernels.
If you get a new kernel and use an old xfsdump then you are out of luck.
Not sure if we want to require people to bump up to new userspace for this.
--Tim
RSS Feed