nilfs_cleanerd won't start for root filesystem

Hi list,

I've upgraded kernel to v3.5 and udev to v182. Now nilfs_cleanerd won't start 
for root filesystem, even when executed by hand. Attach'd strace output and 
/proc/mounts. It seems the problem is there's no /dev/root symlink anymore.

My root fs is /dev/sda3, command line:
# strace -f -o a.log -s 128 nilfs_cleanerd /dev/sda3

# nilfs_cleanerd-bin --version
nilfs_cleanerd-bin (nilfs-utils 2.1.4)

--

-- 
dexen deVries

[[[↓][→]]]

"all dichotomies are either true or false" is a true paradox because it's 
paradoxical only if it is a paradox ;)

rootfs / rootfs rw 0 0
/dev/root / nilfs2 rw,relatime 0 0
devtmpfs /dev devtmpfs rw,relatime,size=3015980k,nr_inodes=753995,mode=755 0 0
proc /proc proc rw,relatime 0 0
sysfs /sys sysfs rw,relatime 0 0
tmpfs /run tmpfs rw,relatime,mode=755 0 0
devpts /dev/pts devpts rw,relatime,gid=5,mode=620 0 0
cgroup /sys/fs/cgroup cgroup rw,relatime,blkio,memory,cpuacct,cpu 0 0
fusectl /sys/fs/fuse/connections fusectl rw,relatime 0 0

Re: nilfs_cleanerd won't start for root filesystem

On Wed, Aug 01, 2012 at 09:21:11AM +0200, dexen deVries wrote:
> Hi list,
> 
> I've upgraded kernel to v3.5 and udev to v182. Now nilfs_cleanerd won't start 
> for root filesystem, even when executed by hand. Attach'd strace output and 
> /proc/mounts. It seems the problem is there's no /dev/root symlink anymore.

Got similar issue [1] few days ago.

[1] http://www.mail-archive.com/linux-nilfs-u79uwXL29TY76Z2rM5mHXA <at> public.gmane.org/msg01186.html

Piotr Szymaniak.
--

-- 
Zaczalem pic przez pewna kobiete. A ja jej nawet nie podziekowalem.
  -- William Claude Dunkinfield

Re: nilfs_cleanerd won't start for root filesystem

Hi Piotr,

On Wednesday 01 of August 2012 11:00:28 you wrote:
> Got similar issue [1] few days ago.
> 
> [1] http://www.mail-archive.com/linux-nilfs-u79uwXL29TY76Z2rM5mHXA <at> public.gmane.org/msg01186.html

quick recap, have you gotten any solution better than creating /dev/root 
symlink by hand? 

btw., greetings from poland 

cheers,
--

-- 
dexen deVries

[[[↓][→]]]

"all dichotomies are either true or false" is a true paradox because it's 
paradoxical only if it is a paradox ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: nilfs_cleanerd won't start for root filesystem

On Wed, Aug 01, 2012 at 11:32:58AM +0200, dexen deVries wrote:
> Hi Piotr,
> 
> 
> On Wednesday 01 of August 2012 11:00:28 you wrote:
> > Got similar issue [1] few days ago.
> > 
> > [1] http://www.mail-archive.com/linux-nilfs-u79uwXL29TY76Z2rM5mHXA <at> public.gmane.org/msg01186.html
> 
> quick recap, have you gotten any solution better than creating /dev/root 
> symlink by hand? 

udev downgrade... Looks like there are also other things broken by
missing /dev/root [1] [2] [3] (a least in Gentoo Linux).

[1] https://bugs.gentoo.org/381761
[2] https://bugs.gentoo.org/427818
[3] https://bugs.gentoo.org/390519

Piotr Szymaniak.

Re: nilfs_cleanerd won't start for root filesystem

On Wed, 1 Aug 2012 13:19:21 +0200, Piotr Szymaniak
<szarpaj@...> wrote:
> On Wed, Aug 01, 2012 at 11:32:58AM +0200, dexen deVries wrote:
> > Hi Piotr,
> > 
> > 
> > On Wednesday 01 of August 2012 11:00:28 you wrote:
> > > Got similar issue [1] few days ago.
> > > 
> > > [1] http://www.mail-archive.com/linux-nilfs-u79uwXL29TY76Z2rM5mHXA <at> public.gmane.org/msg01186.html
> > 
> > quick recap, have you gotten any solution better than creating /dev/root 
> > symlink by hand? 
> 
> udev downgrade... Looks like there are also other things broken by
> missing /dev/root [1] [2] [3] (a least in Gentoo Linux).
> 
> [1] https://bugs.gentoo.org/381761
> [2] https://bugs.gentoo.org/427818
> [3] https://bugs.gentoo.org/390519
> 
> 
> Piotr Szymaniak.

How about the following workaround?

# ln -s /dev/≤your-root-partition> /lib/udev/devices/root
# reboot

Ryusuke Konishi

Re: nilfs_cleanerd won't start for root filesystem

On Wed, Aug 01, 2012 at 08:34:17PM +0900, Ryusuke Konishi wrote:
> *snip*
> 
> How about the following workaround?
> 
> # ln -s /dev/≤your-root-partition> /lib/udev/devices/root
> # reboot

My udev installation is missing /lib/udev/devices dir. Maybe that's also
distribution specific?

As a workaround I just modified my cleanerd starter script [1] to check
if /dev/root exists and, if it is missing, create proper /dev/root symlink
to ${TARGETDISK} before nilfs_cleanerd is started.

PS Is there some "proper" way to start nilfs_cleanerd on rootfs? Or
every way is good as far as it works fine? (my solution is missing the
gcpid=foo)

[1] http://www.mail-archive.com/linux-nilfs-u79uwXL29TY76Z2rM5mHXA <at> public.gmane.org/msg01195.html

Piotr Szymaniak.

Re: nilfs_cleanerd won't start for root filesystem

Hi,
On Thu, 2 Aug 2012 11:23:06 +0200, Piotr Szymaniak wrote:
> On Wed, Aug 01, 2012 at 08:34:17PM +0900, Ryusuke Konishi wrote:
> > *snip*
> > 
> > How about the following workaround?
> > 
> > # ln -s /dev/≤your-root-partition> /lib/udev/devices/root
> > # reboot
> 
> My udev installation is missing /lib/udev/devices dir. Maybe that's also
> distribution specific?

Ah, udev-182 and earlier provided this feature, but now it seems to be
obsolete, so support of the feature seems to depend on effort of each
distro.

> As a workaround I just modified my cleanerd starter script [1] to check
> if /dev/root exists and, if it is missing, create proper /dev/root symlink
> to ${TARGETDISK} before nilfs_cleanerd is started.
> 
> PS Is there some "proper" way to start nilfs_cleanerd on rootfs? Or
> every way is good as far as it works fine? (my solution is missing the
> gcpid=foo)

You can refect the gcpid attribute just by doing remount instead of
invoking cleanerd manually.

 # mount -t nilfs2 -o remount <device> <mountpoint>

[PATCH v2 0/7] nilfs-utils: fsck: add skeleton of fsck.nilfs2

Hi,

This patch set adds skeleton of fsck.nilfs2 utility into nilfs-utils 
package. Currently, fsck.nilfs2 only try to check presence of primary 
and secondary superblocks. It checks magic signature and CRC checksum in 
superblock.

v1->v2
* Coding style was reworked (checkpatch.pl script).
* libfsck.la library was added (print routines + raw ops with disk).
* nilfs.h - several constants and function declarations was added.
* ismounted.c - check_mount() function is reworked for checking on RO 
mount.
* sb.c - nilfs_sb_is_valid() function is reworked; 
nilfs_sb_read_unchecked() was added.
* fsck_message.h, fsck_message.def, fsck_raw_ops.h are moved into 
include folder.
* fsck_message.c, fsck_raw_ops.c are moved into lib folder.
* Superblocks are read by means of library function 
nilfs_sb_read_unchecked().
* Superblocks are checked by means of library function 
nilfs_sb_is_valid().
* fsck_debug() identifies reported function by means of __func__ macro.

With the best regards,
Vyacheslav Dubeyko.
--
  configure.ac        |    3 +-
  include/Makefile.am |    2 +-
  include/nilfs.h     |   15 ++++

[PATCH v2 1/7] nilfs-utils: fsck: integrate skeleton of fsck.nilfs2 utility into nilfs-utils package

Hi,

This patch integrates skeleton of fsck.nilfs2 utility into nilfs-utils 
package.

With the best regards,
Vyacheslav Dubeyko.
--
 From: Vyacheslav Dubeyko <slava@...>
Subject: [PATCH v2 1/7] nilfs-utils: fsck: integrate skeleton of 
fsck.nilfs2 utility into nilfs-utils package

This patch integrates skeleton of fsck.nilfs2 utility into nilfs-utils 
package.

Signed-off-by: Vyacheslav Dubeyko <slava@...>
---
diff --git a/configure.ac b/configure.ac
index c2bcf4c..0d1a2d1 100644
--- a/configure.ac
+++ b/configure.ac
 <at>  <at>  -167,5 +167,6  <at>  <at>  AC_CONFIG_FILES([Makefile
                  sbin/mount/Makefile
                  sbin/nilfs-tune/Makefile
                  sbin/nilfs-clean/Makefile
-                sbin/nilfs-resize/Makefile])
+                sbin/nilfs-resize/Makefile
+                sbin/fsck/Makefile])
  AC_OUTPUT
diff --git a/sbin/Makefile.am b/sbin/Makefile.am

[PATCH v2 2/7] nilfs-utils: fsck: add libfsck.la library into nilfs-utils package

Hi,

This patch adds libfsck.la library into nilfs-utils package. The 
library has purpose to encapsulate common functionality of fsck.

With the best regards,
Vyacheslav Dubeyko.
--
 From: Vyacheslav Dubeyko <slava@...>
Subject: [PATCH v2 2/7] nilfs-utils: fsck: add libfsck.la library into 
nilfs-utils package

This patch adds libfsck.la library into nilfs-utils package. The 
library has purpose to encapsulate common functionality of fsck.

Signed-off-by: Vyacheslav Dubeyko <slava@...>
---
diff --git a/include/Makefile.am b/include/Makefile.am
index 1b6d812..668c6d4 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
 <at>  <at>  -3,4 +3,4  <at>  <at> 
  include_HEADERS = nilfs.h nilfs2_fs.h nilfs_cleaner.h
  noinst_HEADERS = realpath.h nls.h cno.h nilfs_feature.h \
         vector.h nilfs_gc.h cnoconv.h cleaner_msg.h cleaner_exec.h \
-       pathnames.h
+       pathnames.h fsck_messages.h fsck_messages.def fsck_raw_ops.h
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 11d17f3..82245ed 100644
--- a/lib/Makefile.am