[PATCH] NILFS2: remove references to long gone super operations

Re: [PATCH] NILFS2: remove references to long gone super operations

Hi Fernando,
On Wed, 04 Jul 2012 19:10:36 +0900, Fernando Luis Vazquez Cao wrote:
> Subject: NILFS2: remove references to long gone super operations
> 
> From: Fernando Luis Vazquez Cao <fernando@...>
> 
> ->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove
> refereces to them in the NTFS code. Noticed while cleaning up the fsfreeze
> mess.
> 
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@...>

Thanks.  I'll grab this up.

Ryusuke Konishi

> ---
> 
> diff -urNp linux-3.5-rc5-orig/fs/nilfs2/super.c linux-3.5-rc5/fs/nilfs2/super.c
> --- linux-3.5-rc5-orig/fs/nilfs2/super.c	2012-05-21 07:29:13.000000000 +0900
> +++ linux-3.5-rc5/fs/nilfs2/super.c	2012-07-04 19:04:48.863112670 +0900
>  <at>  <at>  -677,7 +677,6  <at>  <at>  static const struct super_operations nil
>  	.destroy_inode  = nilfs_destroy_inode,
>  	.dirty_inode    = nilfs_dirty_inode,
>  	/* .write_inode    = nilfs_write_inode, */
> -	/* .put_inode      = nilfs_put_inode, */
>  	/* .drop_inode	  = nilfs_drop_inode, */
>  	.evict_inode    = nilfs_evict_inode,
>  	.put_super      = nilfs_put_super,
>  <at>  <at>  -685,8 +684,6  <at>  <at>  static const struct super_operations nil

[ANNOUNCE] NILFS utils 2.1.4 release

nilfs-utils-2.1.4 was released on:

 http://www.nilfs.org/en/download.html

Main changes from nilfs-utils-2.1.3 are as follows:

 * umount.nilfs2: use binary exponential backoff for waiting for
   cleanerd's shutdown in order to speed up "umount".  Previously,
   umount.nilfs2 took one or more seconds.  This shortens the time to
   milli-seconds order.

 * mount.nilfs2: fix wrong error handling in a mount routine; this
   fixes the bug that "gcpid=" attribute was not updated properly in
   the mtab file when cleanerd restarted after a rw->ro or a rw->rw
   remount.  The bug was causing busy errors of successive unmount
   because of mismatch of the cleanerd's process id.

 * nilfs-resize: do not use sync() system call.  This reduces
   unnecessary disk io resulting from system-wide synchronizations.

 * nilfs-resize: fix early give-up of fs-shrinking.

 * mount.nilfs2 (non-libmount version): support context, fscontext,
   defcontext, and rootcontext SELinux mount options.  This feature is
   optional, which is applied only when "--with-selinux" new
   configuration option is specified.  Note that these options are
   already supported in another mount.nilfs2 using libmount.

Please see the following changelog for details:

Nilfs2 kernel tree location

Hi,
Can anyone please tell me the location of nilfs2 kernel tree.
I checked in the Maintainers file in linux kernel. It said the location
is git git://git.kernel.org/pub/scm/linux/kernel/git/ryusuke/nilfs2.git
which is not existing.

Please let me know where the latest development to nilfs2 are checked in.

Thanks in advance.

Vibi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Nilfs2 kernel tree location

Hi,
2012/7/7 vibi sreenivasan:
> Hi,
> Can anyone please tell me the location of nilfs2 kernel tree.
> I checked in the Maintainers file in linux kernel. It said the location
> is git git://git.kernel.org/pub/scm/linux/kernel/git/ryusuke/nilfs2.git
> which is not existing.
>
> Please let me know where the latest development to nilfs2 are checked in.

Sorry for the inconvenience.

  git://github.com/konis/nilfs2.git

is the current tree, but the development of  the kernel code is
not so active now because I don't have enough time these days.

The git tree in the kernel.org should be restored.  It's another
to do for me.

Thanks,
Ryusuke Konishi

> Thanks in advance.
>
> Vibi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo@...
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

nilfs2 weird issue - snapshots are gone, cleanerd not running

Hi.

I've upgraded nilfs-utils (running Gentoo) on 29 july. Today I ran out
of space on my / and found that nilfs_cleanerd isn't working. When I
start it from the command line it exits instantly. Also, all previous
checkpoints on / (also on two other mountpoints on different machine)
are gone.

What I did? Downgraded nilfs-utils to 2.1.1, remounted mountpoints. On
the second machine it's runnig fine (cleaned _all_ checkpoints), on the
first one with disk space issue it exits just like 2.1.3.

Here are some fs details. Machine with disk space issues, rootfs:
    CNO        DATE     TIME  MODE  FLG     NBLKINC       ICNT
 147688  2012-07-09 08:38:14   cp    -        11075     242915
 147689  2012-07-09 08:38:14   cp    -           60     242895
(…)
 148999  2012-07-09 09:13:46   cp    -           60     242888
 149000  2012-07-09 09:19:45   cp    -           44     242888

Filesystem      Size  Used Avail Use% Mounted on
rootfs           24G   13G   11G  56% /

mount shows:
/dev/sda2 on / type nilfs2 (rw,noatime,nodiratime,gcpid=15356)

There's no nilfs_cleanerd with pid 15356.

Second machine rootfs:
   CNO        DATE     TIME  MODE  FLG     NBLKINC       ICNT

Re: nilfs2 weird issue - snapshots are gone, cleanerd not running

Hi Piotr,

Does system journals on your machines contain any interested details
about reported issue? Could you try to extract some error or warning
messages from system journal?

Thanks,
Vyacheslav Dubeyko.

On Mon, 2012-07-09 at 09:33 +0200, Piotr Szymaniak wrote:
> Hi.
> 
> I've upgraded nilfs-utils (running Gentoo) on 29 july. Today I ran out
> of space on my / and found that nilfs_cleanerd isn't working. When I
> start it from the command line it exits instantly. Also, all previous
> checkpoints on / (also on two other mountpoints on different machine)
> are gone.
> 
> What I did? Downgraded nilfs-utils to 2.1.1, remounted mountpoints. On
> the second machine it's runnig fine (cleaned _all_ checkpoints), on the
> first one with disk space issue it exits just like 2.1.3.
> 
> Here are some fs details. Machine with disk space issues, rootfs:
>     CNO        DATE     TIME  MODE  FLG     NBLKINC       ICNT
>  147688  2012-07-09 08:38:14   cp    -        11075     242915
>  147689  2012-07-09 08:38:14   cp    -           60     242895
> (…)
>  148999  2012-07-09 09:13:46   cp    -           60     242888
>  149000  2012-07-09 09:19:45   cp    -           44     242888
> 

Re: nilfs2 weird issue - snapshots are gone, cleanerd not running

On Monday 09 of July 2012 09:33:00 you wrote:
>(...)
> Where to go from this point? How to debug nilfs_cleanerd issue?

using strace -f  on the nilfs_cleanerd should give you a clue what causes the 
exit. it may exit if can't connect to syslogd.

if `lscp' reports no checkpoints, try `lscp -a' -- should show even minor 
checkpoints (which are checkpoints created by GC, AFAIK).

--

-- 
dexen deVries

[[[↓][→]]]

"all dichotomies are either true or false" is a true paradox because it's 
paradoxical only if it is a paradox ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: nilfs2 weird issue - snapshots are gone, cleanerd not running

Hi,

On Mon, 2012-07-09 at 11:33 +0200, dexen deVries wrote:
> using strace -f  on the nilfs_cleanerd should give you a clue what causes the 
> exit. it may exit if can't connect to syslogd.

I think that strace can generate many information.  Maybe, firstly,
it makes sense to increase verbosity level of nilfs_cleanerd to debug
level (please, see log_priority parameters in nilfs_cleanerd.conf).

With the best regards,
Vyacheslav Dubeyko.

--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: nilfs2 weird issue - snapshots are gone, cleanerd not running

Hi Piotr,

Does your nilfs_cleanerd.conf file contains any special values of
configuration parameters? Could you publish content of your
nilfs_cleanerd.conf file?

Thanks,
Vyacheslav Dubeyko.

On Mon, 2012-07-09 at 11:41 +0200, Piotr Szymaniak wrote:
> On Mon, Jul 09, 2012 at 01:28:32PM +0400, Vyacheslav Dubeyko wrote:
> > Hi Piotr,
> > 
> > Does system journals on your machines contain any interested details
> > about reported issue? Could you try to extract some error or warning
> > messages from system journal?
> 
> If by journals you mean logs then no. I'm only able to find some like
> this:
> Jul  3 10:32:45 wloczykij nilfs_cleanerd[1434]: resume (clean check)
> Jul  3 10:41:37 wloczykij nilfs_cleanerd[1434]: pause (clean check)
> 
> That's all about nilfs in the last week and current log has only
manual
> runs related to those operation described before.
> 
> Piotr Szymaniak.

--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in