Andrea Gelmini | 1 Aug 15:36 2009
Picon

Re: Crash...

2009/7/29 Ryusuke Konishi <ryusuke@...>:
> Could you test if the patch makes a difference for the same file ?

Well,
   I used this:
   git://git.kernel.org/pub/scm/linux/kernel/git/ryusuke/nilfs2.git
(branch fixes)

   I stressed it a lot, and it works perfectly.
   In a few days I will test the 2048 block size, too (even I guess
it's not necessary).

Thanks a lot for your work,
Andrea
Andrea Gelmini | 1 Aug 15:39 2009
Picon

Re: Crash...

2009/7/27 Jiro SEKIBA <jir@...>:
> Can you reproduce the bug without using lvm volume?

Hi,
   to trigger the ops I had to write a file >4G.
   Anyway, with latest Ryusuke's patch, I had no problem at all, even
with nilfs on top of MD+LVM.

Thanks a lot,
Andrea
Ryusuke Konishi | 1 Aug 15:56 2009
Picon

Re: Crash...

On Sat, 1 Aug 2009 15:36:22 +0200, Andrea Gelmini wrote:
> 2009/7/29 Ryusuke Konishi <ryusuke@...>:
> > Could you test if the patch makes a difference for the same file ?
> 
> Well,
>    I used this:
>    git://git.kernel.org/pub/scm/linux/kernel/git/ryusuke/nilfs2.git
> (branch fixes)
> 
>    I stressed it a lot, and it works perfectly.
>    In a few days I will test the 2048 block size, too (even I guess
> it's not necessary).
> 
> Thanks a lot for your work,
> Andrea

Thanks for your response.
I will send the fix to Linus for the next -rc release.

Thanks,
Ryusuke Konishi
Jiro SEKIBA | 2 Aug 09:58 2009
Picon

Re: Crash...

Hi,

At Sat, 1 Aug 2009 15:39:17 +0200,
Andrea Gelmini wrote:
> 
> 2009/7/27 Jiro SEKIBA <jir@...>:
> > Can you reproduce the bug without using lvm volume?
> 
> Hi,
>    to trigger the ops I had to write a file >4G.

nhhh, I rsynced lots of DVD images, so some of those must have been >4G.

>    Anyway, with latest Ryusuke's patch, I had no problem at all, even
> with nilfs on top of MD+LVM.

That is good news, good news anyway

thanks

regards,
--

-- 
Jiro SEKIBA <jir@...>
McColgan Weispfenning | 2 Aug 18:06 2009

[SPAM] axiology distemper

HOME MISSIONARY UNION. President--Mrs. F. Eggert, The Hill, Portland. Secretary--Mrs. D. D. Clarke,
112.45; Charleston, S. C., 291.20; Greenwood, S. C., 80.39; Knoxville, Tenn., 42.35; Memphis, Tenn., 540.90; Nashville, Tenn., 514.98; Grandview, Tenn., 56.65; Pleasant Hill, Tenn., 101.55; Albany, Ga., 71.25; Andersonville, Ga., 9.25; Atl
SISSIPPI, 35.40. Hermanville, Miss. B. Blackburn, _for Tougaloo U._, 5. Jackson, Miss Mary J. Gibson, _for furnishing r
y notice

Women's U

. Bristol, First, quarterly, 50. Bristol, First, special, 20. Cheshire, "A Friend," 1. Collin

Se. The school just closed the thir






., Clothing, _for Blowing Rock, N. C._ Evanston, Fir st, (6.50 of which _for Fisk U._), 99. Farmington

Highly prized, is shown from the fact that during the past years more students than ca29; North, C. E., 1.40. Slaterville, 13. CONN 9.25. Oroville, Chinese M. O., 2.50; Annual Memb., 13.50. Petaluma, Chinese M. O., 2.75

ing questions, explaine exercises were quite up to the avN, Ill., College, S. 5; Mrs. Carrie B. Kennedy, 1. * * * * * RECEIPTS FOR JULY, 1898.

us then help yoke, First, Clot issued a message in which it declared its deep interest in all efforts for the advancement of moral

. Ten years ago an attempt at a night entertainment was almost the orderly methods of the lawFul gathering of many prominent educators. It represented twelve states, the District of Columbia, seven religious bodies and a number of sch

and to uphold the supremaR S. A., Fisk U._, 10. Fitchburg, Rollstone, 8.54 Y George Parker Thompson, Executor, 20. VERMONT, $905.27--of which from Estate, $258.75 Bennington, "A Friend," 2. Burlington, L. B. S., _for Frei

H. G. Blake, G. A. R. Post, _for Flag, Grand View Inst._, 10. Oberlin, Second, 19.95. Oberlin, Mutual Benefit Ass'n, Clothing, and 4; Miss Nancy Squire, 2.25, _for Skyland Inst., Blowing Rock, N. C._ Toledo, W. M. U., _for S. A., Talladega C._, 10. Wakeman, Second, 3. INDIANA, $10.00. WOMAN'S HOME MISSIONARY UNION OF INDIANA, by Mrs. W

nal Hou
as to taking back seats at t
S MOUNTAIN, N. C., 122 ENFIELD, N. C., 124 BLOWING ROCK, N. C., 125 THOMASVILLE, GA

9.42. North Benni

ase and co
daughters," 35. Westmoreland

10. Hart, Fir

on. Rev. Geo. W. Moore
shop has been opened for work, and
even on the sly.

ty of our
F. R. Marvin, 3.10. WOMAN
ristianization of near
e. A varied program of e

Nging at all the sessions, they also rendered a special programme of their mu
hed. And it was no small g

Aurora, New England, Corban Ass'n, Clothing, _for Blowing Rock, N. C
Am, Trin., 25.92. Wellesley, 71.47. West

S attending our elections were not due solely to ignorant colored men, b
, W. J. Dickinson, 20. Tallmadge, S., 20.20. Wakeman, Rev. Jesse
STIANITY AND CI n

periodicals and occasional papers may be correctly mailed. FORM OF A BEQUEST. "
. ASS'N, by Mrs. J. H. Denison, Tre
Head, Miss._, 10. Buffalo, Park Side M. E. Ch.,
s gazing, with the p
imary problems o


Ratification. So far as the enlightened sentiment
small number failed of pro
to stop over that e



_______________________________________________
users mailing list
users@...
https://www.nilfs.org/mailman/listinfo/users
Ryusuke Konishi | 2 Aug 15:23 2009
Picon

[PATCH] nilfs2: fix missing unlock in error path of nilfs_mdt_write_page


I found a mutex leak while looking into a kernel oops detected in
shrink_page_list().

Here is a bugfix of the problem. I'll send it to the next -rc along
with other fixes.

Regards,
Ryusuke Konishi
--
From: Ryusuke Konishi <konishi.ryusuke@...>

nilfs2: fix missing unlock in error path of nilfs_mdt_write_page

This adds a missing unlock of nilfs->ns_writer_mutex in
nilfs_mdt_write_page() function.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@...>
---
 fs/nilfs2/mdt.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/nilfs2/mdt.c b/fs/nilfs2/mdt.c
index 3d3ddb3..2dfd477 100644
--- a/fs/nilfs2/mdt.c
+++ b/fs/nilfs2/mdt.c
 <at>  <at>  -412,8 +412,10  <at>  <at>  nilfs_mdt_write_page(struct page *page, struct writeback_control *wbc)
 		return 0; /* Do not request flush for shadow page cache */
 	if (!sb) {
 		writer = nilfs_get_writer(NILFS_MDT(inode)->mi_nilfs);
-		if (!writer)
+		if (!writer) {
+			nilfs_put_writer(NILFS_MDT(inode)->mi_nilfs);
 			return -EROFS;
+		}
 		sb = writer->s_super;
 	}

--

-- 
1.6.3.4
Ryusuke Konishi | 3 Aug 19:53 2009
Picon

Re: nilfs-utils in Fedora now

Hi,
On Thu, 30 Jul 2009 18:23:18 -0500, Eric Sandeen <sandeen@...> wrote:
> I have nilfs-utils in Fedora now, for F11 and rawhide.  It'll take a
> little while for things to get out to the repos, but if anyone is using
> nilfs on Fedora, hopefully this'll make things a little easier or
> convenient.
>
> For F11 it's headed to the testing repo, for now.
>
> Thanks,
> -Eric

Thank you for letting us know this!  I hope your work really helps
nilfs users of fedora to make things easy hereafter.

BTW, is there any plan on adding the kernel code of nilfs to extra
packages for fedora 12 or the later?

Thanks,
Ryusuke Konishi
Eric Sandeen | 3 Aug 20:03 2009
Picon

Re: nilfs-utils in Fedora now

Ryusuke Konishi wrote:
> Hi,
> On Thu, 30 Jul 2009 18:23:18 -0500, Eric Sandeen <sandeen@...> wrote:
>> I have nilfs-utils in Fedora now, for F11 and rawhide.  It'll take a
>> little while for things to get out to the repos, but if anyone is using
>> nilfs on Fedora, hopefully this'll make things a little easier or
>> convenient.
>>
>> For F11 it's headed to the testing repo, for now.
>>
>> Thanks,
>> -Eric
> 
> Thank you for letting us know this!  I hope your work really helps
> nilfs users of fedora to make things easy hereafter.
> 
> BTW, is there any plan on adding the kernel code of nilfs to extra
> packages for fedora 12 or the later?

Do you mean like a kmod rpm for updated nilfs kernel code that is not
yet upstream?  No, Fedora doesn't allow kmods in the official
repositories.  But nilfs is already configured on in F11 and F12, so
nilfs.ko is already there in the kernel rpm.

Or maybe I misunderstand you question?

-Eric

> Thanks,
> Ryusuke Konishi
Ryusuke Konishi | 3 Aug 21:10 2009
Picon

Re: proper name for userspace package?

On Thu, 30 Jul 2009 20:36:28 +0200, Daniel Baumann wrote:
> Ryusuke Konishi wrote:
> >> The tarball is "nilfs-utils" but debian has "nilfs2-tools" - is there a
> >> preference, or is this a debian convention that caused the rename?
> 
> it's my own aim to get some sort of uniformity with package names in
> debian, so that we have $filesystem-tools for new packages. new means
> basically almost anything after e2fsutils.

Thanks.  I felt this implicitly, and now I get it straight from you.

> actually, i should rename it from nilfs2-tools to nilfs-tools.
> unfortunately, in debian we have a quite stupid thing called NEW queue
> which make such a simple rename have a penalty of 4 to 8 weeks of
> waiting until ftp-masters unblock it. but i still might do that at some
> point (unless Ryusuke dislikes it ;).

Well, I don't mind either.  I'm accountable for part of the confusion
especially for the version number ;)

"nilfs-tools" sounds simpler. Umm, actually it would be better in the
long term because the nilfs package already has versions related to
the filesystem version (e.g. -2.x.y).  At least I don't have any
reason to object to the rename.

I just realized that ocfs2-tools package has versions 1.x.y.

Thanks,
Ryusuke Konishi
Ryusuke Konishi | 3 Aug 21:20 2009
Picon

Re: nilfs-utils in Fedora now

On Mon, 03 Aug 2009 13:03:51 -0500, Eric Sandeen <sandeen@...> wrote:
> Ryusuke Konishi wrote:
> > Hi,
> > On Thu, 30 Jul 2009 18:23:18 -0500, Eric Sandeen
<sandeen@...> wrote:
> >> I have nilfs-utils in Fedora now, for F11 and rawhide.  It'll take a
> >> little while for things to get out to the repos, but if anyone is using
> >> nilfs on Fedora, hopefully this'll make things a little easier or
> >> convenient.
> >>
> >> For F11 it's headed to the testing repo, for now.
> >>
> >> Thanks,
> >> -Eric
> > 
> > Thank you for letting us know this!  I hope your work really helps
> > nilfs users of fedora to make things easy hereafter.
> > 
> > BTW, is there any plan on adding the kernel code of nilfs to extra
> > packages for fedora 12 or the later?
> 
> Do you mean like a kmod rpm for updated nilfs kernel code that is not
> yet upstream?  No, Fedora doesn't allow kmods in the official
> repositories.
>
> But nilfs is already configured on in F11 and F12, so
> nilfs.ko is already there in the kernel rpm.

Oh, Really?

I was misunderstanding about the basic point.  So, soon nilfs will be
fully available in fedora 11 and 12.  Great!

Thanks,
Ryusuke Konishi

Gmane