Thomas Weber | 15 Mar 21:55 2010
Picon

[PATCH 0/4] Some typo fixing

I have fixed some typos.

Thomas Weber (4):
  Fix typo: [Ss]ytem => [Ss]ystem
  Fix typo: udpate => update
  Fix typo: paramters => parameters
  Fix typo: orginal => original

 Documentation/cgroups/cgroups.txt               |    2 +-
 Documentation/kbuild/kconfig.txt                |    2 +-
 Documentation/sysfs-rules.txt                   |    2 +-
 Documentation/trace/events.txt                  |    8 ++++----
 drivers/acpi/osl.c                              |    4 ++--
 drivers/ata/ata_piix.c                          |    2 +-
 drivers/firewire/ohci.c                         |    2 +-
 drivers/gpu/drm/drm_bufs.c                      |    2 +-
 drivers/infiniband/hw/ipath/ipath_iba6110.c     |    2 +-
 drivers/infiniband/hw/ipath/ipath_iba6120.c     |    4 ++--
 drivers/infiniband/hw/ipath/ipath_iba7220.c     |    2 +-
 drivers/isdn/hisax/hfc4s8s_l1.c                 |    2 +-
 drivers/macintosh/windfarm_pm81.c               |    2 +-
 drivers/media/dvb/dvb-usb/friio-fe.c            |    2 +-
 drivers/net/smsc911x.c                          |    4 ++--
 drivers/pci/hotplug/cpqphp_core.c               |    2 +-
 drivers/pci/pci.c                               |    2 +-
 drivers/ps3/ps3-sys-manager.c                   |    2 +-
 drivers/regulator/core.c                        |    2 +-
 drivers/s390/char/sclp_cpi_sys.c                |    2 +-
 drivers/scsi/bfa/include/defs/bfa_defs_cee.h    |    2 +-
 drivers/scsi/bfa/include/defs/bfa_defs_status.h |    4 ++--
(Continue reading)

Jiri Kosina | 16 Mar 11:32 2010
Picon

Re: [PATCH 0/4] Some typo fixing

On Mon, 15 Mar 2010, Randy Dunlap wrote:

> > I have fixed some typos.
> 
> Acked-by: Randy Dunlap <rdunlap <at> xenotime.net>
> 
> Jiri, can you merge these, please, unless someone objects (?).

Yes, I will take it, thanks. A couple comments though:

- [important!] Thomas, it's not necessary to CC zillions of people on such 
  patches. Just submit them to trivial <at> kernel.org (and eventually CC 
  lkml), and that's it. I believe many people might get annoyed by this.
- I will not be applying the drivers/staging hunks. Staging patches are 
  moving target, the code is changing quickly (including complete 
  drops/rewrites) so we'll likely be getting conflicts there. I will 
  reroute them to Greg.
- I will fold all the patches into one. We don't need one commit per one 
  specific typo.

--

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
(Continue reading)

Randy Dunlap | 15 Mar 22:09 2010
Picon

Re: [PATCH 0/4] Some typo fixing

On 03/15/10 13:55, Thomas Weber wrote:
> I have fixed some typos.

Acked-by: Randy Dunlap <rdunlap <at> xenotime.net>

Jiri, can you merge these, please, unless someone objects (?).

> Thomas Weber (4):
>   Fix typo: [Ss]ytem => [Ss]ystem
>   Fix typo: udpate => update
>   Fix typo: paramters => parameters
>   Fix typo: orginal => original
> 
>  Documentation/cgroups/cgroups.txt               |    2 +-
>  Documentation/kbuild/kconfig.txt                |    2 +-
>  Documentation/sysfs-rules.txt                   |    2 +-
>  Documentation/trace/events.txt                  |    8 ++++----
>  drivers/acpi/osl.c                              |    4 ++--
>  drivers/ata/ata_piix.c                          |    2 +-
>  drivers/firewire/ohci.c                         |    2 +-
>  drivers/gpu/drm/drm_bufs.c                      |    2 +-
>  drivers/infiniband/hw/ipath/ipath_iba6110.c     |    2 +-
>  drivers/infiniband/hw/ipath/ipath_iba6120.c     |    4 ++--
>  drivers/infiniband/hw/ipath/ipath_iba7220.c     |    2 +-
>  drivers/isdn/hisax/hfc4s8s_l1.c                 |    2 +-
>  drivers/macintosh/windfarm_pm81.c               |    2 +-
>  drivers/media/dvb/dvb-usb/friio-fe.c            |    2 +-
>  drivers/net/smsc911x.c                          |    4 ++--
>  drivers/pci/hotplug/cpqphp_core.c               |    2 +-
>  drivers/pci/pci.c                               |    2 +-
(Continue reading)

Aleksey Cheusov | 24 Mar 11:23 2010
Picon

JFS crash: stack trace

Hi, on my system where I use JFS I got the following. On saturday this
fs was checked using 'fsck.jfs -f' and finally said that fs is clean.

kernel: 2.6.26-bpo.2-686 from Debian's backports.org

jfsutils: 1.1.11

Any clue?

Mar 24 06:39:05 syn-proc4 kernel: [65682.636130] BUG at fs/jfs/jfs_txnmgr.c:669 assert(last)
Mar 24 06:39:05 syn-proc4 kernel: [65682.636178] ------------[ cut here ]------------
Mar 24 06:39:05 syn-proc4 kernel: [65682.636194] kernel BUG at fs/jfs/jfs_txnmgr.c:669!
Mar 24 06:39:05 syn-proc4 kernel: [65682.636210] invalid opcode: 0000 [#1] SMP 
Mar 24 06:39:05 syn-proc4 kernel: [65682.636227] Modules linked in: nfsd auth_rpcgss exportfs ac
battery nfs lockd nfs_acl sunrpc jfs nls_base dm_snapshot dm_mirror dm_log dm_mod sbp2 loop evdev
snd_cs4232 snd_opl3_lib snd_hwdep snd_cs4231_lib snd_mpu401 snd_mpu401_uart snd_rawmidi psmouse
snd_seq_device serio_raw i2c_nforce2 parport_pc k8temp button snd_hda_intel parport i2c_core
pcspkr snd_pcm snd_timer snd soundcore snd_page_alloc ext3 jbd mbcache sd_mod amd74xx sata_nv
ide_core ohci1394 forcedeth ieee1394 ata_generic libata scsi_mod dock ohci_hcd ehci_hcd usbcore
thermal processor fan thermal_sys
Mar 24 06:39:05 syn-proc4 kernel: [65682.636403] 
Mar 24 06:39:05 syn-proc4 kernel: [65682.636416] Pid: 31446, comm: pdflush Not tainted
(2.6.26-bpo.2-vserver-686-bigmem #1)
Mar 24 06:39:05 syn-proc4 kernel: [65682.636444] EIP: 0060:[<f8d276c3>] EFLAGS: 00010292 CPU: 1
Mar 24 06:39:05 syn-proc4 kernel: [65682.636471] EIP is at txLock+0x113/0x4de [jfs]
Mar 24 06:39:05 syn-proc4 kernel: [65682.636487] EAX: 0000003e EBX: 00000008 ECX: 00000000 EDX: 00000082
Mar 24 06:39:05 syn-proc4 kernel: [65682.636505] ESI: f716daf8 EDI: f8dec200 EBP: f8dec000 ESP: e3f19da8
Mar 24 06:39:05 syn-proc4 kernel: [65682.636522]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
Mar 24 06:39:05 syn-proc4 kernel: [65682.636539] Process pdflush (pid: 31446, ti=e3f18000
task=f78808e0 task.ti=e3f18000)
(Continue reading)

Cheusov Aleksey | 26 Mar 10:43 2010
Picon

Re: JFS crash: stack trace

Mar 24 06:39:05 syn-proc4 kernel: [65682.636659] Call Trace:
Mar 24 06:39:05 syn-proc4 kernel: [65682.636690]  [<f8d17478>] diWrite+0x16d/0x4a2 [jfs]
Mar 24 06:39:05 syn-proc4 kernel: [65682.636721]  [<c0121355>] __wake_up+0x29/0x39
Mar 24 06:39:05 syn-proc4 kernel: [65682.636744]  [<f8d260a6>] txCommit+0x18d/0xecc [jfs]
Mar 24 06:39:05 syn-proc4 kernel: [65682.636770]  [<c016b2c7>] write_cache_pages+0x231/0x279
Mar 24 06:39:05 syn-proc4 kernel: [65682.636790]  [<c016ad5d>] __writepage+0x0/0x21
Mar 24 06:39:05 syn-proc4 kernel: [65682.636808]  [<c01f3ea2>] __next_cpu+0x12/0x21
Mar 24 06:39:05 syn-proc4 kernel: [65682.636830]  [<f8d25d5c>] txBegin+0x25/0x1e2 [jfs]
Mar 24 06:39:05 syn-proc4 kernel: [65682.636858]  [<f8d0d0d9>] jfs_commit_inode+0x9e/0xde [jfs]
Mar 24 06:39:05 syn-proc4 kernel: [65682.636883]  [<f8d0d328>] jfs_write_inode+0x2d/0x3b [jfs]
Mar 24 06:39:05 syn-proc4 kernel: [65682.636905]  [<c01a1120>] __writeback_single_inode+0x15a/0x251
 
Ok. Even more problems. I tried to remount this fs in read-only but 'mount -o remount,ro /my/mountpoint'
command hadnged up. I rebooted machine, upgrade jfsutils to the latest version 1.1.4 and tried to fsck it.
Here is the output:

# sudo fsck.jfs -f /dev/sdb3
fsck.jfs version 1.1.14, 06-Apr-2009
processing started: 3/25/2010 19.17.30
The current device is:  /dev/sdb3
Block size in bytes:  4096
Filesystem size in blocks:  363779876
**Phase 0 - Replay Journal Log
**Phase 1 - Check Blocks, Files/Directories, and  Directory Entries
Insufficient dynamic storage available for required workspace (1,6).  CANNOT CONTINUE
.......|.
#

This files system contains huge amount of files, hundreds of thousands of them, maybe millions,
and huge amount of hard links. Can this be a problem for JFS and fsck.jfs?

--
Best regards, Aleksey Cheusov.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Jfs-discussion mailing list
Jfs-discussion <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jfs-discussion
Dave Kleikamp | 26 Mar 13:52 2010
Picon

Re: JFS crash: stack trace

On Fri, 2010-03-26 at 11:43 +0200, Cheusov Aleksey wrote:
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636659] Call Trace:
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636690]  [<f8d17478>]
>         diWrite+0x16d/0x4a2 [jfs]
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636721]  [<c0121355>]
>         __wake_up+0x29/0x39
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636744]  [<f8d260a6>]
>         txCommit+0x18d/0xecc [jfs]
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636770]  [<c016b2c7>]
>         write_cache_pages+0x231/0x279
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636790]  [<c016ad5d>]
>         __writepage+0x0/0x21
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636808]  [<c01f3ea2>]
>         __next_cpu+0x12/0x21
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636830]  [<f8d25d5c>]
>         txBegin+0x25/0x1e2 [jfs]
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636858]  [<f8d0d0d9>]
>         jfs_commit_inode+0x9e/0xde [jfs]
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636883]  [<f8d0d328>]
>         jfs_write_inode+0x2d/0x3b [jfs]
>         Mar 24 06:39:05 syn-proc4 kernel: [65682.636905]  [<c01a1120>]
>         __writeback_single_inode+0x15a/0x251

I have no idea what caused the trap.  It happens in stable code that
hasn't been changed in ages.  It could be due to a memory corruption bug
somewhere else in the kernel, either somewhere else in jfs or elsewhere.
Otherwise, it's something really subtle that I haven't seen before.

> Ok. Even more problems. I tried to remount this fs in read-only but
> 'mount -o remount,ro /my/mountpoint'
> command hadnged up.

If you hadn't rebooted, that isn't surprising.  The trap killed this
thread, probably holding locks, that would lock up further operations on
this file system.

>  I rebooted machine, upgrade jfsutils to the latest version 1.1.4 and
> tried to fsck it.
> Here is the output:
> 
> # sudo fsck.jfs -f /dev/sdb3
> fsck.jfs version 1.1.14, 06-Apr-2009
> processing started: 3/25/2010 19.17.30
> The current device is:  /dev/sdb3
> Block size in bytes:  4096
> Filesystem size in blocks:  363779876
> **Phase 0 - Replay Journal Log
> **Phase 1 - Check Blocks, Files/Directories, and  Directory Entries
> Insufficient dynamic storage available for required workspace (1,6).
> CANNOT CONTINUE
> .......|.
> #

It couldn't allocate enough memory.  It seems odd since you said that
you ran version 1.1.11 recently.  I don't know what would have changed
that would consume any more memory.  Maybe more inodes have been created
since the last attempt?  Is it possible to add some more swap space and
try again?
> 
> This files system contains huge amount of files, hundreds of thousands
> of them, maybe millions,
> and huge amount of hard links. Can this be a problem for JFS and
> fsck.jfs?

Have you tried mounting read-only after the reboot?  That's not the best
solution, but at least you may be able to recover the data.

Shaggy
--

-- 
David Kleikamp
IBM Linux Technology Center

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
Cheusov Aleksey | 27 Mar 12:36 2010
Picon

Re: JFS crash: stack trace

I have no idea what caused the trap.  It happens in stable code that
hasn't been changed in ages.  It could be due to a memory corruption bug
somewhere else in the kernel, either somewhere else in jfs or elsewhere.
Otherwise, it's something really subtle that I haven't seen before.

Ok, can vserver affect JFS's stability and in general what kernel[s] you can
recommend for use with JFS?

This fs contains  69955977 files and hardlinks. Can it change something?


It couldn't allocate enough memory.  It seems odd since you said that
you ran version 1.1.11 recently.  I don't know what would have changed
that would consume any more memory.  Maybe more inodes have been created
since the last attempt?

See above. Almost 70mln of files. And yes, since last 'fsck.jfs -f', more inodes and more files
were created during nightly backup.
 
 Is it possible to add some more swap space and
try again?

This machine have almost 5Gb of swap. Is this not enough for fixing 1.5Tb disk partition?

Have you tried mounting read-only after the reboot?  That's not the best
solution, but at least you may be able to recover the data.

This is actually a backup disk.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Jfs-discussion mailing list
Jfs-discussion <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jfs-discussion
Dave Kleikamp | 29 Mar 21:49 2010
Picon

Re: JFS crash: stack trace

On Sat, 2010-03-27 at 13:36 +0200, Cheusov Aleksey wrote:
>         I have no idea what caused the trap.  It happens in stable
>         code that
>         hasn't been changed in ages.  It could be due to a memory
>         corruption bug
>         somewhere else in the kernel, either somewhere else in jfs or
>         elsewhere.
>         Otherwise, it's something really subtle that I haven't seen
>         before.
> 
> Ok, can vserver affect JFS's stability and in general what kernel[s]
> you can
> recommend for use with JFS?

I don't know of any reason that vserver would hurt JFS.  The code itself
has been stable for a number of years now, and not much has changed, so
I don't wouldn't recommend one kernel over another.  "Stable" here has
more to do with the fact that it hasn't changed much, rather than that
the code is rock-solid.  There have been some elusive bugs reported that
nobody has completely figured out.
> 
> This fs contains  69955977 files and hardlinks. Can it change
> something?

Can what change what?
>         
>         It couldn't allocate enough memory.  It seems odd since you
>         said that
>         you ran version 1.1.11 recently.  I don't know what would have
>         changed
>         that would consume any more memory.  Maybe more inodes have
>         been created
>         since the last attempt?
> 
> See above. Almost 70mln of files. And yes, since last 'fsck.jfs -f',
> more inodes and more files
> were created during nightly backup.

> 
>          Is it possible to add some more swap space and
>         try again?
> 
> This machine have almost 5Gb of swap. Is this not enough for fixing
> 1.5Tb disk partition?

If I calculated it right, it looks like jfs_fsck needs 192 bytes per
inode (file or directory).  So 70 million files would require over 10
GB.  How much main memory does the machine have?  I'm assuming a 64-bit
executable, since a 32-bit binary doesn't have the address space for the
job.
> 
>         Have you tried mounting read-only after the reboot?  That's
>         not the best
>         solution, but at least you may be able to recover the data.
> 
> This is actually a backup disk.

So worst case is to blow it away and recreate it.  :-/

Shaggy
> 
--

-- 
David Kleikamp
IBM Linux Technology Center

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

Gmane