headers
H. Peter Anvin | 1 Jul 2010 01:27
Favicon

Re: [PATCH 0/3] Extended file stat functions [ver #2]

On 06/30/2010 04:15 PM, David Howells wrote:
> 
> gcc for 32-bit platforms can handle 64-bit numbers.  gcc doesn't handle 128-bit
> numbers.
> 

gcc for 64-bit platforms does handle 128-bit numbers, but I don't think
it does on 32-bit platforms.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
David Howells | 1 Jul 2010 02:15
Picon
Favicon

Re: [PATCH 0/3] Extended file stat functions [ver #2]

H. Peter Anvin <hpa <at> zytor.com> wrote:

> gcc for 64-bit platforms does handle 128-bit numbers, but I don't think
> it does on 32-bit platforms.

How do you specify them?  If I say "long long long" gcc moans that it can't
support it on x86_64.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 1 comment |
headers
Peter Pan | 1 Jul 2010 03:56
Picon

Re: [PATCH] ext2:delete misused ext2_free_blocks

On 07/01/2010 06:57 AM, Dan Carpenter wrote:
> On Wed, Jun 30, 2010 at 06:21:27PM +0800, Peter Pan wrote:
>    
>> if ext2_new_blocks returns error, no blocks need to be freed.
>>
>>      
> Hi Peter,
>
> Your patch isn't right.  The original code is OK as is.
>
> Are you seeing a kernel panic?  Perhaps we can help you fix it.
>    
Oh, I know that the original code is good now.
I didn't see a kernel panic, thank you for your guide.
> regards,
> dan carpenter
>
>    
>> Signed-off-by: Peter Pan<wppan <at> redflag-linux.com>
>> ---
>>   fs/ext2/inode.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
>> index 3675088..f858847 100644
>> --- a/fs/ext2/inode.c
>> +++ b/fs/ext2/inode.c
>>  <at>  <at>  -385,6 +385,8  <at>  <at>  static int ext2_alloc_blocks(struct inode *inode,
>>   	ext2_fsblk_t current_block = 0;
>>   	int ret = 0;
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla-daemon | 1 Jul 2010 07:04

[Bug 16019] Resume from hibernate corrupts ext4

https://bugzilla.kernel.org/show_bug.cgi?id=16019

--- Comment #38 from Klaus Lichtenwalder <lichtenwalder <at> acm.org>  2010-07-01 05:04:30 ---
I don'r know whether this is related, but one in a while I have a lockup of the
X server. I can move the mouse, and switch to the tty consoles, and log in, but
for a working X I have to reboot. Yesterday I saw in dmesg:
[drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer elapsed... GPU hung
render error detected, EIR: 0x00000000
[drm:i915_do_wait_request] *ERROR* i915_do_wait_request returns -5 (awaiting
302900 at 302900)

Klaus

--

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Greg KH | 1 Jul 2010 19:27
Picon

[15/23] ext4: Fix file fragmentation during large file write.

2.6.27-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Aneesh Kumar K.V <aneesh.kumar <at> linux.vnet.ibm.com>

commit 22208dedbd7626e5fc4339c417f8d24cc21f79d7 upstream.

The range_cyclic writeback mode uses the address_space writeback_index
as the start index for writeback.  With delayed allocation we were
updating writeback_index wrongly resulting in highly fragmented file.
This patch reduces the number of extents reduced from 4000 to 27 for a
3GB file.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar <at> linux.vnet.ibm.com>
Signed-off-by: Theodore Ts'o <tytso <at> mit.edu>
[dev <at> jaysonking.com: Some changed lines from the original version of this patch were dropped, since they
were rolled up with another cherry-picked patch applied to 2.6.27.y earlier.]
[dev <at> jaysonking.com: Use of wbc->no_nrwrite_index_update was dropped, since
write_cache_pages_da() implies it.]
Signed-off-by: Jayson R. King <dev <at> jaysonking.com>
Signed-off-by: Greg Kroah-Hartman <gregkh <at> suse.de>

---
 fs/ext4/inode.c |   79 ++++++++++++++++++++++++++++++++------------------------
 1 file changed, 46 insertions(+), 33 deletions(-)

--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
 <at>  <at>  -1721,7 +1721,11  <at>  <at>  static int mpage_da_submit_io(struct mpa
(Continue reading)

Permalink | Reply | 0 comments |
headers
David Howells | 2 Jul 2010 01:57
Picon
Favicon

[PATCH 1/3] xstat: Add a pair of system calls to make extended file stats available [ver #4]

Add a pair of system calls to make extended file stats available, including
file creation time, inode version and data version where available through the
underlying filesystem.

[This depends on the previously posted pair of patches to (a) constify a number
 of syscall string and buffer arguments and (b) rearrange AFS's use of
 i_version and i_generation].

The following structures are defined for their use:

	struct xstat_parameters {
		unsigned long long	request_mask;
	};

	struct xstat_dev {
		unsigned int		major, minor;
	};

	struct xstat_time {
		unsigned long long	tv_sec, tv_nsec;
	};

	struct xstat {
		unsigned int		st_mode;
		unsigned int		st_nlink;
		unsigned int		st_uid;
		unsigned int		st_gid;
		struct xstat_dev	st_rdev;
		struct xstat_dev	st_dev;
		struct xstat_time	st_atime;
(Continue reading)

Permalink | Reply | 8 comments |
headers
Dmitry Monakhov | 2 Jul 2010 09:41
Favicon
Gravatar

Re: Updated ext4 quota design document

tytso <at> mit.edu writes:

> On Tue, Jun 22, 2010 at 10:29:27PM +0200, Jan Kara wrote:
>>   With metadata which get journaled it should be quite easy. JBD already
>> must know before you go and modify buffer contents - that's why
>> journal_get_write_access and friends exist. It also makes sure that your
>> data cannot be modified from the moment the buffer enters commit upto the
>> moment the commit is finished. So you can use buffer commit hook to compute
>> and store block checksum safely.
>
> True, but we're also interested in making sure this feature can be
> used in the non-journal case as well....
Q:What is use case for that non-journal quota ?
A: ASAIU answer will "GFS chunkservers"
Are any chances that quota will be consistent with real space usage
after any failure? Currently difference may be huge.
BTW: ASAIU that it is not safe to use unclean fs in nojournal mode
without explicit e2fsck.  And ASAIU that is the reason why nojournal
users use replication or any other redundancy mechanism to protect
data and just throw away broken data after any failure on a single node.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
David Howells | 2 Jul 2010 16:35
Picon
Favicon

Re: [PATCH 1/3] xstat: Add a pair of system calls to make extended file stats available [ver #4]

Nick Piggin <npiggin <at> suse.de> wrote:

> > Add a pair of system calls to make extended file stats available,
> > including file creation time, inode version and data version where
> > available through the underlying filesystem.
> 
> Can you describe the expected atomicity requirements for the requests,
> please?

As for stat(), lstat() and fstat().

David
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Andreas Dilger | 2 Jul 2010 17:49
Picon

Re: [PATCH] Add a pair of system calls to make extended file stats available [ver #3]

On 2010-07-01, at 23:36, Michael Kerrisk wrote:
> * Include information from the "inode_info" structure, most notably
> i_flags, but perhaps other info as well.

This one is actually pretty interesting, though instead of exporting the i_flags directly (the S_*
flags), it would be much better to export the FS_*_FL values.  The FS_*_FL values (e.g. FS_IMMUTABLE_FL)
are already exposed to userspace via FS_IOC_{GET,SET}FLAGS and are stored on disk in ext2/3/4, so are
guaranteed never to change.  The S_* flags DO in fact change between kernel releases.

Cheers, Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Mike Snitzer | 2 Jul 2010 19:50
Picon
Favicon

Re: [PATCH 3/4] Support discard for multiple devices

On Fri, Jul 02 2010 at 11:19am -0400,
Mikulas Patocka <mpatocka <at> redhat.com> wrote:

> Support discard for multiple devices
> 
> The previous code supported discards only if there was one underlying device.
> (i.e. multiple linear targets pointing to the same device would support
> discards, multiple linear targets pointing to different devices wouldn't).
> 
> This restriction is not necessary, so this patch removes it.
> 
> As we checked, barrier+discard requests are handled by the barrier thread,
> so it's safe to use these requests on devices with multiple underlying devices.
> 
> Signed-off-by: Mikulas Patocka <mpatocka <at> redhat.com>
> 
> ---
>  drivers/md/dm-table.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> Index: linux-2.6.35-rc3-fast/drivers/md/dm-table.c
> ===================================================================
> --- linux-2.6.35-rc3-fast.orig/drivers/md/dm-table.c	2010-07-02 16:05:22.000000000 +0200
> +++ linux-2.6.35-rc3-fast/drivers/md/dm-table.c	2010-07-02 16:07:45.000000000 +0200
>  <at>  <at>  -911,12 +911,6  <at>  <at>  int dm_table_complete(struct dm_table *t
>  	int r = 0;
>  	unsigned int leaf_nodes;
>  
> -	/*
> -	 * We only support discards if there is exactly one underlying device.
(Continue reading)

Permalink | Reply | 0 comments |

Gmane