headers
Theodore Tso | 1 Jan 2008 19:01
Picon
Picon
Favicon

What's in e2fsprogs.git (stable)

Lots of old (and new) bugs that had been hanging around Sourcefroge
and Debian bug trackers have been fixed.  In addition, yesterday I
released 1.40.4 of e2fsprogs.

* The 'maint' branch has these fixes since the last announcement.

Theodore Ts'o (29):
  uuidd: Use /var/lib/libuuid instead of /var/run/uuidd
  libuuid: When starting uuidd, use waitpid() to reap the zombie
      process
  libuuid: Only try to start the uuidd daemon a limited number of
      times
  debian: Add a dependency on libuuid1 to the uuid-runtime package
  Add #define needed for Hurd ioctl definitions
  libuuid: Fix bug which caused uuidd to fail if sizeof(int) !=
      sizeof(int *)
  uuidd: Avoid race conditions to that only one uuidd is started
  Update Vietnamese translation from the Translation Project
  Convert use of ext2fs_get_mem to ext2fs_get_array for overflow
      detection
  Fix build failure on non-Linux/non-Hurd/non-Masix systems
  Add --disable-tls configure option
  Add --disable-uuidd configure option
  debian: Do not use TLS or uuidd when building the bootfloppy udeb's
  Test for sys/syscall.h in configure to fix dietlibc build problem
  Fix build error in blkid/tst_types.c when using diet libc
  debian: build the e2fsck-static package so it works on 2.4 kernels
  debian: Use useradd and groupadd in favor of adduser
  Update dependencies in lib/uuid/Makefile.in
  debian: Fix the document ID in comerr_dev.doc-base
(Continue reading)

Permalink | Reply | 24 comments |
headers
Adrian Bunk | 2 Jan 2008 02:32

[2.6.24 patch] let EXT4DEV_FS depend on BROKEN

It might make sense to offer ext4 in -mm and even in early -rc kernels, 
but I've already seen people using ext4 simply because a stable kernel 
offered it - and that's definitely not intended.

Anyone who _really_ wants to test ext4 should anyway be able to do the 
trivial change of removing the "depends on BROKEN" line.

Signed-off-by: Adrian Bunk <bunk <at> kernel.org>

---
f778e1d046a3554ca15b8637afd0ffbf4790801c 
diff --git a/fs/Kconfig b/fs/Kconfig
index 487236c..d850725 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
 <at>  <at>  -138,7 +138,7  <at>  <at>  config EXT3_FS_SECURITY

 config EXT4DEV_FS
 	tristate "Ext4dev/ext4 extended fs support development (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
+	depends on BROKEN
 	select JBD2
 	select CRC16
 	help

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
(Continue reading)

Permalink | Reply | 20 comments |
headers
Andreas Dilger | 2 Jan 2008 18:41
Picon

Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

On Jan 02, 2008  03:32 +0200, Adrian Bunk wrote:
> It might make sense to offer ext4 in -mm and even in early -rc kernels, 
> but I've already seen people using ext4 simply because a stable kernel 
> offered it - and that's definitely not intended.
> 
> Anyone who _really_ wants to test ext4 should anyway be able to do the 
> trivial change of removing the "depends on BROKEN" line.
> 
> Signed-off-by: Adrian Bunk <bunk <at> kernel.org>
> 
>  <at>  <at>  -138,7 +138,7  <at>  <at>  config EXT3_FS_SECURITY
>  
>  config EXT4DEV_FS
>  	tristate "Ext4dev/ext4 extended fs support development (EXPERIMENTAL)"
> -	depends on EXPERIMENTAL
> +	depends on BROKEN
>  	select JBD2
>  	select CRC16
>  	help

Isn't CONFIG_EXPERIMENTAL enough?

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
Permalink | Reply | 10 comments |
headers
Diego Calleja | 2 Jan 2008 19:26
Picon

Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

El Wed, 2 Jan 2008 03:32:18 +0200, Adrian Bunk <bunk <at> kernel.org> escribió:

> It might make sense to offer ext4 in -mm and even in early -rc kernels, 
> but I've already seen people using ext4 simply because a stable kernel 
> offered it - and that's definitely not intended.

But isn't that the whole purpose of having ext4 snapshots in the stable kernel - to
allow people to try it?
Permalink | Reply | 6 comments |
headers
Adrian Bunk | 2 Jan 2008 20:51

Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

On Wed, Jan 02, 2008 at 10:41:57AM -0700, Andreas Dilger wrote:
> On Jan 02, 2008  03:32 +0200, Adrian Bunk wrote:
> > It might make sense to offer ext4 in -mm and even in early -rc kernels, 
> > but I've already seen people using ext4 simply because a stable kernel 
> > offered it - and that's definitely not intended.
> > 
> > Anyone who _really_ wants to test ext4 should anyway be able to do the 
> > trivial change of removing the "depends on BROKEN" line.
> > 
> > Signed-off-by: Adrian Bunk <bunk <at> kernel.org>
> > 
> >  <at>  <at>  -138,7 +138,7  <at>  <at>  config EXT3_FS_SECURITY
> >  
> >  config EXT4DEV_FS
> >  	tristate "Ext4dev/ext4 extended fs support development (EXPERIMENTAL)"
> > -	depends on EXPERIMENTAL
> > +	depends on BROKEN
> >  	select JBD2
> >  	select CRC16
> >  	help
> 
> Isn't CONFIG_EXPERIMENTAL enough?

Most people and all distributions use CONFIG_EXPERIMENTAL=y simply 
because too many options (including options required for hardware 
support) depend on it.

Compare e.g.:
- "Marvell SATA support (HIGHLY EXPERIMENTAL)"
- "Provide NFSv4 client support (EXPERIMENTAL)"
(Continue reading)

Permalink | Reply | 6 comments |
headers
Eric Sandeen | 2 Jan 2008 21:01
Picon
Favicon
Gravatar

[PATCH] UPDATED: types fixup for mballoc

Eric Sandeen wrote:
> Eric Sandeen wrote:
>   
>> I ran into a potential overflow in ext4_mb_scan_aligned, 
>> and went looking for others in mballoc.  This patch hits a 
>> few spots, compile-tested only at this point, comments welcome.
>>
>> This patch:
>>
>>     
>
> ... introduces a 64-bit divide.  Oops... will fix that up & resend.
>
>   
Took a while to get back to this :)  But just used do_div return value
for remainder instead of modulo (which would have been a 64-bit modulo)

There's another do_div trick, and a bitwise round-up in there too,
now that there are more 64-bit containers...  Anyway, patch follows.

-------------

I ran into a potential overflow in ext4_mb_scan_aligned, 
and went looking for others in mballoc.  This patch hits a 
few spots, compile-tested only at this point, comments welcome.

This patch:

changes fe_len to an int, I don't think we need it to be a long,
looking at how it's used (should it be a grpblk_t?)  Also change
(Continue reading)

Permalink | Reply | 7 comments |
headers
Josef Bacik | 2 Jan 2008 21:16
Picon
Favicon

[PATCH] e2fsprogs: add minimal resize size option

Hello,

People wishing to make live usb disks and such are looking for a way to get the
minimum resize size for an ext fs in blocks so that they can just resize their
image to that size and do with it what they will.  This patch adds that
functionality, just pass -m option and it calculates the minimum number of
blocks the fs can be resized to.  Comments welcome, I was learning the ext disk
layout while writing this so if I've done something stupid/overly complicated
please point it out :), I've commented abundantly so hopefully my madness will
make sense.  Thank you,

Josef

diff --git a/resize/main.c b/resize/main.c
index 7c1d0c1..2f2887a 100644
--- a/resize/main.c
+++ b/resize/main.c
 <at>  <at>  -36,7 +36,7  <at>  <at>  char *program_name, *device_name, *io_options;

 static void usage (char *prog)
 {
-	fprintf (stderr, _("Usage: %s [-d debug_flags] [-f] [-F] [-p] "
+	fprintf (stderr, _("Usage: %s [-d debug_flags] [-f] [-F] [-m] [-p] "
 			   "device [new_size]\n\n"), prog);

 	exit (1);
 <at>  <at>  -183,7 +183,7  <at>  <at>  int main (int argc, char ** argv)
 	if (argc && *argv)
 		program_name = *argv;
(Continue reading)

Permalink | Reply | 3 comments |
headers
Alan Cox | 2 Jan 2008 21:40
Picon

Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

On Wed, 2 Jan 2008 10:41:57 -0700
Andreas Dilger <adilger <at> sun.com> wrote:

> On Jan 02, 2008  03:32 +0200, Adrian Bunk wrote:
> > It might make sense to offer ext4 in -mm and even in early -rc kernels, 
> > but I've already seen people using ext4 simply because a stable kernel 
> > offered it - and that's definitely not intended.
> > 
> > Anyone who _really_ wants to test ext4 should anyway be able to do the 
> > trivial change of removing the "depends on BROKEN" line.
> > 
> > Signed-off-by: Adrian Bunk <bunk <at> kernel.org>
> > 
> >  <at>  <at>  -138,7 +138,7  <at>  <at>  config EXT3_FS_SECURITY
> >  
> >  config EXT4DEV_FS
> >  	tristate "Ext4dev/ext4 extended fs support development (EXPERIMENTAL)"
> > -	depends on EXPERIMENTAL
> > +	depends on BROKEN
> >  	select JBD2
> >  	select CRC16
> >  	help
> 
> Isn't CONFIG_EXPERIMENTAL enough?

Of course it is - Adrian is however trying to remove CONFIG_EXPERIMENTAL
and reality is getting in his way again
Permalink | Reply | 0 comments |
headers
Adrian Bunk | 2 Jan 2008 22:16

Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

On Wed, Jan 02, 2008 at 07:26:29PM +0100, Diego Calleja wrote:
> El Wed, 2 Jan 2008 03:32:18 +0200, Adrian Bunk <bunk <at> kernel.org> escribió:
> 
> > It might make sense to offer ext4 in -mm and even in early -rc kernels, 
> > but I've already seen people using ext4 simply because a stable kernel 
> > offered it - and that's definitely not intended.
> 
> But isn't that the whole purpose of having ext4 snapshots in the stable kernel - to
> allow people to try it?

ext4 has quite an unusual development model for kernel code, other 
code in the state of ext4 is usually only in -mm and not in stable 
kernels.

Stable kernels are mainly meant for usage, not for trying stuff.
And although I see a point in perhaps shipping some not-yet-perfect 
device drivers for otherwise unsupported hardware or some
not-yet-perfect filesystems required for accessing foreign
(non-Linux) filesystems, I don't see any point in offering a
WIP Linux-only filesystem in stable kernels.

cu
Adrian

--

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
(Continue reading)

Permalink | Reply | 4 comments |
headers
Alan Cox | 2 Jan 2008 22:21
Picon

Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

> Stable kernels are mainly meant for usage, not for trying stuff.

You appear to be reinventing history in your attempt to justify removing
CONFIG_EXPERIMENTAL.

> And although I see a point in perhaps shipping some not-yet-perfect 
> device drivers for otherwise unsupported hardware or some
> not-yet-perfect filesystems required for accessing foreign
> (non-Linux) filesystems, I don't see any point in offering a
> WIP Linux-only filesystem in stable kernels.

So that people can use it and test it. Most people don't run -mm or GIT.

Alan
Permalink | Reply | 0 comments |

Gmane