Mingming Cao | 1 Dec 01:17 2007
Picon

Re: [patch 1/8] ext4: fix MB_DEBUG format warnings

Hi Andrew,

Thanks for resending the patches. The first three patches in this series
were missed in the ext4 patch queue, the rest of them are already queued
there.  They are all in ext4 patch queue now. I will check other ext4
patches you plan to merge to mm tree and get them sync in ext4 tree.

http://repo.or.cz/w/ext4-patch-queue.git
git://repo.or.cz/ext4-patch-queue.git

Regards,
Mingming
On Thu, 2007-11-29 at 12:52 -0800, akpm <at> linux-foundation.org wrote:
> From: Eric Sandeen <sandeen <at> redhat.com>
> 
> (applies at end of current ext4 patch series)
> 
> Fix a slew of compile warnings from mismatched format specifiers
> when MB_DEBUG is turned on.
> 
> Signed-off-by: Eric Sandeen <sandeen <at> redhat.com>
> Signed-off-by: Andrew Morton <akpm <at> linux-foundation.org>
> ---
> 
>  fs/ext4/mballoc.c |   20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff -puN fs/ext4/mballoc.c~ext4-fix-mb_debug-format-warnings fs/ext4/mballoc.c
> --- a/fs/ext4/mballoc.c~ext4-fix-mb_debug-format-warnings
> +++ a/fs/ext4/mballoc.c
(Continue reading)

Andrew Morton | 1 Dec 01:22 2007

Re: [patch 1/8] ext4: fix MB_DEBUG format warnings

On Fri, 30 Nov 2007 16:17:32 -0800
Mingming Cao <cmm <at> us.ibm.com> wrote:

> Thanks for resending the patches. The first three patches in this series
> were missed in the ext4 patch queue, the rest of them are already queued
> there.  They are all in ext4 patch queue now. I will check other ext4
> patches you plan to merge to mm tree and get them sync in ext4 tree.
> 
> http://repo.or.cz/w/ext4-patch-queue.git
> git://repo.or.cz/ext4-patch-queue.git

What's all this about?  I've always been pulling
ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/ext4-patches/LATEST/broken-out/
(and continuously fixing the same rejects each time).

Mingming Cao | 1 Dec 02:20 2007
Picon

Re: [patch 1/8] ext4: fix MB_DEBUG format warnings

On Fri, 2007-11-30 at 16:22 -0800, Andrew Morton wrote:
> On Fri, 30 Nov 2007 16:17:32 -0800
> Mingming Cao <cmm <at> us.ibm.com> wrote:
> 
> > Thanks for resending the patches. The first three patches in this series
> > were missed in the ext4 patch queue, the rest of them are already queued
> > there.  They are all in ext4 patch queue now. I will check other ext4
> > patches you plan to merge to mm tree and get them sync in ext4 tree.
> > 
> > http://repo.or.cz/w/ext4-patch-queue.git
> > git://repo.or.cz/ext4-patch-queue.git
> 
> What's all this about?  
That is the latest ext4 patch queue ( quilt format patches, not full
ext4 source tree).

> I've always been pulling
> ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/ext4-patches/LATEST/broken-out/
> (and continuously fixing the same rejects each time).
> 
> 
Ted periodically pull patches from the latest ext4 patch queue on
repo.or.cz, after they had survive fs tests, then, release the ext4
patches on kernel.org (the one you pulled from). I believe Ted is on
vacation now.....

Mingming

Mingming Cao | 1 Dec 02:22 2007
Picon

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

On Fri, 2007-11-30 at 17:08 -0600, Eric Sandeen wrote:
> Mingming Cao wrote:
> > [PATCH] jbd2 stats through procfs
> > 
> > The patch below updates the jbd stats patch to 2.6.20/jbd2.
> > The initial patch was posted by Alex Tomas in December 2005
> > (http://marc.info/?l=linux-ext4&m=113538565128617&w=2).
> > It provides statistics via procfs such as transaction lifetime and size.
> > 
> > [ This probably should be rewritten to use debugfs?   -- Ted]
> > 
> > Signed-off-by: Johann Lombardi <johann.lombardi <at> bull.net>
> 
> I've started going through this one to clean it up to the point where it
> can go forward.  It's been sitting at the top of the unstable portion of
> the patch queue for long enough, I think :)
> 
Thanks!

> I've converted the msecs to jiffies until the user boundary, changed the
> union #defines as suggested by Andrew, and various other little issues etc.
> 
> Remaining to do is a generic time-difference calculator (instead of
> jbd2_time_diff), and looking into whether it should be made a config
> option; I tend to think it should, but it's fairly well sprinkled
> through the code, so I'll see how well that works.
> 
> Also did we ever decided if this should go to debugfs?
> 

(Continue reading)

Theodore Tso | 1 Dec 13:10 2007
Picon

Re: Coverity testing freely available

On Fri, Nov 30, 2007 at 04:53:20PM -0600, Eric Sandeen wrote:
> Andreas Dilger wrote:
> > Hi,
> > I've recently found scan.coverity.com, which allows OSS-licensed projects
> > to be run under Coverity to find defects available in the code.  I think
> > that e2fsprogs should be included there, even if some people run e2fsprogs
> > under Coverity separately.  This allows the e2fsprogs developers to find
> > and fix the bugs more easily.
> >
> 
> I don't see e2fsprogs on the website yet.  Anyone care if I go ahead &
> ask that e2fsprogs be included?

I tried sending e-mail to Coverity on July 16th, and never got a
reply.  Feel free to give it a try....

						- Ted
Theodore Tso | 1 Dec 13:11 2007
Picon

Re: [PATCH] fix check_mntent_file() to pass mode for open(O_CREAT)

On Thu, Nov 08, 2007 at 06:20:15PM -0700, Andreas Dilger wrote:
> On my FC8 install, ismounted.c fails to build because open(O_CREAT) is
> used without passing a mode.  The following trivial patch fixes it.
> 
> Signed-off-by: Andreas Dilger <adilger <at> dilger.ca>

Thanks, applied.

						- Ted
Theodore Tso | 1 Dec 13:08 2007
Picon
Picon

Re: [PATCH] Fix bug in ext2fs_unlink

On Tue, Nov 27, 2007 at 06:03:06PM +0100, Jan Kara wrote:
>   Hi,
> 
>   the patch below fixes a bug in ext2fs_unlink() I came across when testing
> my changes to e2fsprogs for 64KB blocksize support... Please apply.

Thanks, applied.

						- Ted
Aneesh Kumar K.V | 3 Dec 11:25 2007
Picon

[RFC][PATCH 2/3] ext4: Convert truncate_mutex to read write semaphore.

We are currently taking the truncate_mutex for every read. This would have
performance impact on large CPU configuration. Convert the lock to read write
semaphore and take read lock when we are trying to read the file.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar <at> linux.vnet.ibm.com>
---
 fs/ext4/balloc.c          |    2 +-
 fs/ext4/extents.c         |    8 ++++----
 fs/ext4/file.c            |    4 ++--
 fs/ext4/inode.c           |   36 ++++++++++++++++++++++++++++++------
 fs/ext4/ioctl.c           |    4 ++--
 fs/ext4/super.c           |    2 +-
 include/linux/ext4_fs.h   |   22 +++-------------------
 include/linux/ext4_fs_i.h |    6 +++---
 8 files changed, 46 insertions(+), 38 deletions(-)

diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 71ee95e..4eca63d 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
 <at>  <at>  -463,7 +463,7  <at>  <at>  static inline int rsv_is_empty(struct ext4_reserve_window *rsv)
  * when setting the reservation window size through ioctl before the file
  * is open for write (needs block allocation).
  *
- * Needs truncate_mutex protection prior to call this function.
+ * Needs down_write(i_data_sem) protection prior to call this function.
  */
 void ext4_init_block_alloc_info(struct inode *inode)
 {
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
(Continue reading)

Aneesh Kumar K.V | 3 Dec 11:25 2007
Picon

[RFC] truncate_mutex read write semaphore conversion

The below patchset is NOT for patch queue. I am posting it here to get
feedback regarding the approach and what test I need to run to make sure we
are not breaking any locking rules.

I have run dbench, ffsb, fsstress, fs_di, fs_inode, fsx_linux . Bonnie
didn't run completely. In the automated setup i had it didn't save any
logs to find out what went wrong. I will be looking into this

Aneesh Kumar K.V | 3 Dec 11:25 2007
Picon

[RFC][PATCH 1/3] ext4: Make ext4_get_blocks_wrap take the truncate_mutex early.

When doing a migrate from ext3 to ext4 inode we need to make sure the test
for inode type and walking inode data happens inside  lock. To make this
happen move truncate_mutex early before checking the i_flags.

This actually should enable us to remove the verify_chain().

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar <at> linux.vnet.ibm.com>
---
 fs/ext4/extents.c       |    7 +++--
 fs/ext4/inode.c         |   69 +++++-----------------------------------------
 include/linux/ext4_fs.h |   12 ++++++--
 3 files changed, 21 insertions(+), 67 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 8528774..9dd4746 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
 <at>  <at>  -2225,6 +2225,10  <at>  <at>  out:
 	return err ? err : allocated;
 }

+/*
+ * Need to be called with
+ * mutex_lock(&EXT4_I(inode)->truncate_mutex);
+ */
 int ext4_ext_get_blocks(handle_t *handle, struct inode *inode,
 			ext4_fsblk_t iblock,
 			unsigned long max_blocks, struct buffer_head *bh_result,
 <at>  <at>  -2240,7 +2244,6  <at>  <at>  int ext4_ext_get_blocks(handle_t *handle, struct inode *inode,
 	__clear_bit(BH_New, &bh_result->b_state);
(Continue reading)


Gmane