headers
Saugata Das | 16 May 17:30

[RFC 1/3] block: Context support

From: Saugata Das <saugata.das <at> linaro.org>

On eMMC and UFS devices there is a new feature of setting context with each
read or write. The idea is to classify the data from different files and
apply the realibility on the complete file instead of individual writes,
which helps in performance. A new address space operation has been a added
to get the context from file system and set up the bi_context field in bio.
Then we need to ensure that bio from different contexts are not merged. The
context is then passed to the underlying driver as part of the read or write
request. Since the number of MMC contexts is limited, multiple file system
contexts are mapped to single MMC context.

Signed-off-by: Saugata Das <saugata.das <at> linaro.org>
---
 block/blk-core.c            |    1 +
 block/blk-merge.c           |    3 +++
 fs/mpage.c                  |   12 ++++++++++++
 include/linux/blk_types.h   |    1 +
 include/linux/blkdev.h      |    1 +
 include/linux/buffer_head.h |    2 ++
 include/linux/fs.h          |    1 +
 7 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 1f61b74..274e05d 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1309,6 +1309,7 @@ void init_request_from_bio(struct request *req, struct bio *bio)
 	req->errors = 0;
 	req->__sector = bio->bi_sector;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Tao Ma | 16 May 10:50

[PATCH] e2fsck: Let end_blk to be the maximum value of u32.

From: Tao Ma <boyu.mt <at> taobao.com>

Now we can use fallocate to create a large file while keep the size
to be small. It will cause the e2fsck complain about it. The test
script is simple and I have pasted it here.

DEVICE=/dev/sdb1
mount -t ext4 $DEVICE /mnt/ext4
for((i=0;i<10;i++))do fallocate -n -o $[$i*8192] -l 4096 /mnt/ext4/a;done
umount $DEVICE
e2fsck -fn $DEVICE

The error message will be like this:
e2fsck 1.42.3 (14-May-2012)
Pass 1: Checking inodes, blocks, and sizes
Inode 12 has zero length extent
	(invalid logical block 0, physical block 32775)
Clear? no

Inode 12, i_blocks is 88, should be 0.  Fix? no

Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
Block bitmap differences:  -(8231--8232) -(32770--32778)
Fix? no

Now actually the end_blk can be any value which is less than
u32, so make end_blk be the maximum value of u32.
(Continue reading)

Permalink | Reply | 3 comments |
headers
Tao Ma | 16 May 10:49

[PATCH] ext4: Protect group inode free counting with group lock.

From: Tao Ma <boyu.mt <at> taobao.com>

Now when we set the group inode free count, we don't have a proper
group lock so that multiple threads may decrease the inode free
count at the same time. And e2fsck will complain something like:

Free inodes count wrong for group #1 (1, counted=0).
Fix? no

Free inodes count wrong for group #2 (3, counted=0).
Fix? no

Directories count wrong for group #2 (780, counted=779).
Fix? no

Free inodes count wrong for group #3 (2272, counted=2273).
Fix? no

So this patch try to protect it with the ext4_lock_group.

btw, it is found by xfstests test case 269 and I have run it 100
times and the error in e2fsck doesn't show up again.

Cc: Theodore Ts'o <tytso <at> mit.edu>
Signed-off-by: Tao Ma <boyu.mt <at> taobao.com>
---
 fs/ext4/ialloc.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
(Continue reading)

Permalink | Reply | 7 comments |
headers
Theodore Ts'o | 15 May 04:23
Picon
Picon
Favicon
Gravatar

Release of e2fsprogs 1.42.3

Hi all,

I've released e2fsprogs 1.42.3 in all of the usual places; it's tagged
in the git trees on git.kernel.org, github, and sourceforge, and
available for ftp at:

ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/e2fsprogs/v1.42.3

and

http://prdownloads.sourceforge.net/e2fsprogs/e2fsprogs-1.42.3.tar.gz

The release notes are attached below

                                                - Ted

E2fsprogs 1.42.3 (May 14, 2012)
===============================

Fix a bug in the Unix I/O manager which could cause corruption of file
systems with more than 16TB when e2fsprogs is compiled in 32-bit mode
(i.e., when unsigned long is 32-bits).  Also fix a bug which caused
dumpe2fs to incorrectly display block numbers > 32-bits.

Improve the support for integrated quota files (where quota is a first
class supported feature using hidden files in the ext4 file system).
Previously the quota file was getting rewritten even when it was not
necessary, and e2fsck would erroneously try to hide quota files which
were already hidden.
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla-daemon | 14 May 17:06

[Bug 15231] kernel BUG at fs/ext4/inode.c:1852!

https://bugzilla.kernel.org/show_bug.cgi?id=15231

Alan <alan <at> lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan <at> lxorguk.ukuu.org.uk
         Resolution|                            |UNREPRODUCIBLE

--

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
bugzilla-daemon | 14 May 17:06

[Bug 15231] kernel BUG at fs/ext4/inode.c:1852!

https://bugzilla.kernel.org/show_bug.cgi?id=15231

Alan <alan <at> lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
dan rhodes | 14 May 06:31
Picon

HP TONERS Cartridge

Can  you  send  me  the pricing  and  availablity  of this  product

 LASER JET PRINT CARTRIDGE, (OEM ONLY)
 HP LASER JET PRINT CARTRIDGE
 1Q6000A (OEM ONLY)
 2. HEWC9730A (30A) (OEM ONLY)
 3. HEWC9731A (31A) (OEM ONLY)
 4. Q5942A (42A)(OEM ONLY)
 5. HP Q7551A (51A)(OEM ONLY)
 6. HP Q3964A (64A) BLACK  COULOUR ONLY (OEM ONLY)
 7  HP    Q7553A 53A)  OEM ONLY
 8 NEW & USED, COMPUTERS  NOTEBOOK
9 USB  FLASH  DRIVES

 The mode of our  payment  is   with  our visa, master
 cards

Hope  to  read  from  you  asap
DAN RHODES
CA 90703

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Wang Sheng-Hui | 14 May 09:15
Picon

[PATCH] ext2: cleanup the comment for ext2_export_ops

ext2_export_ops gets more valued fields, not get_parent only.
Clean up the comment.

Signed-off-by: Wang Sheng-Hui <shhuiw <at> gmail.com>
---
 fs/ext2/super.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index e1025c7..640b4c6 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
 /* Yes, most of these are left as NULL!!
  * A NULL value implies the default, which works with ext2-like file
  * systems, but can be improved upon.
- * Currently only get_parent is required.
  */
 static const struct export_operations ext2_export_ops = {
 	.fh_to_dentry = ext2_fh_to_dentry,
--

-- 
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 3 comments |
headers
eric | 14 May 06:14
Favicon

Dedicated server rental

Dear Sir/Madam,

Please see below our Server Rental Package,

HKD1980/month + one-time setup fee HKD2000

Dell? PowerEdge? Enterprise Rack Mount Server
-          Intel(R) Xeon(R) E3-1220 Processor (3.10GHz, 8M Cache, Turbo, 4C/4T, 80W)
-          4GB RAM, 1x4GB, 1333MHz, DDR-3, Single Ranked UDIMMs
-          500GB, 3.5", SATA II x 1 Enterprise Hard Disk
-          Remote KVM (iDRAC6 Enterprise)
-          8x SATA slim DVD-ROM Drive 
-          Dell OpenManage
-          Broadcom 5716 dual-port Gigabit Ethernet without TOE enabled
-          Dell BMC Info Mod

Software Specification
-     CentOS 5/6 Linux Operating System

Data Center Facilities
-          1Gbps Share Internet Connectivity with 10/BASE-T
-          One IP Addresses Allocation
-          Un-interruptible Power Supply (UPS) backed up by private diesel generator
-          FM200 gas¡Vbased fire suppression system
-          24x7 CRAC Air Conditioning and Humidity Control
-          24x7 Security Control

Should you have any query, please feel free to contact me. Thanks.

Best,
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dan Carpenter | 13 May 20:43
Picon
Favicon

dereference before check in ext4_move_extents()

Hi, going through some static checker warnings and reporting bugs.
These were introduced a long time ago.

The patch 748de6736c1e: "ext4: online defrag -- Add EXT4_IOC_MOVE_EXT 
ioctl" from Jun 17, 2009, leads to the following Smatch complaint:

fs/ext4/move_extent.c:1381 ext4_move_extents()
	 warn: variable dereferenced before check 'holecheck_path' (see line 1292)

fs/ext4/move_extent.c
  1291			ext_prev = ext_cur;
  1292			last_extent = mext_next_extent(orig_inode, holecheck_path,
                                                                   ^^^^^^^^^^^^^^
Dereferenced unconditionally inside the mext_next_extent() function.

  1293							&ext_cur);
  1294			if (last_extent < 0) {
  1295				ret1 = last_extent;
  1296				break;
  1297			}

	[snip]

  1376			double_down_write_data_sem(orig_inode, donor_inode);
  1377			if (ret1 < 0)
  1378				break;
  1379	
  1380			/* Decrease buffer counter */
  1381			if (holecheck_path)
                            ^^^^^^^^^^^^^^
(Continue reading)

Permalink | Reply | 4 comments |
headers
Dan Carpenter | 13 May 16:41
Picon
Favicon

[patch] ext4: potential NULL dereference on error

The ext4_get_group_desc() function returns NULL on error, and
ext4_free_inodes_count() function dereferences it without checking.
There is a check on the next line, but it's too late.

Signed-off-by: Dan Carpenter <dan.carpenter <at> oracle.com>
---
Static checker fix.

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index a044a9b..1526f33 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -389,7 +389,7 @@ static int find_group_orlov(struct super_block *sb, struct inode *parent,
 	struct ext4_sb_info *sbi = EXT4_SB(sb);
 	ext4_group_t real_ngroups = ext4_get_groups_count(sb);
 	int inodes_per_group = EXT4_INODES_PER_GROUP(sb);
-	unsigned int freei, avefreei, grp_free;
+	unsigned int freei, avefreei;
 	ext4_fsblk_t freeb, avefreec;
 	unsigned int ndirs;
 	int max_dirs, min_inodes;
@@ -399,6 +399,7 @@ static int find_group_orlov(struct super_block *sb, struct inode *parent,
 	struct orlov_stats stats;
 	int flex_size = ext4_flex_bg_size(sbi);
 	struct dx_hash_info hinfo;
+	unsigned int grp_free = 0;

 	ngroups = real_ngroups;
 	if (flex_size > 1) {
@@ -508,7 +509,8 @@ fallback_retry:
(Continue reading)

Permalink | Reply | 4 comments |

Gmane