Brett Stone-Gross via RT | 1 Aug 2010 15:28
Picon
Favicon

[openssl.org #2313] [PATCH] rsa_oaep.c additional error checking for EVP_DIGEST function calls in PKCS1_MGF1

Hi,  we would like to submit this patch that adds additional error checking for the PKCS1_MGF1 function that
makes calls to EVP_DIGEST functions, and does not check any of the return values.

Regards,
-Brett

Hi,  we would like to submit this patch that adds additional error checking for the PKCS1_MGF1 function that makes calls to EVP_DIGEST functions, and does not check any of the return values.

 

Regards,

-Brett

 

Attachment (rsa_oaep.patch): application/octet-stream, 882 bytes
Ladar Levison | 1 Aug 2010 15:46
Gravatar

RE: ECIES for openssl

>
> I have implemented ECIES (Elliptic Curve Integrated Encryption Scheme)
> for OpenSSL. The code include ASN.1 encoding compatible with SEC1:
> Elliptic Curve Cryptography version 2.0
> (http://www.secg.org/download/aid-780/sec1-v2.pdf), X9.63 KDF, OpenSSL
> ERR mechanism.
>
>    

Hi Zhi,

I'm investigating the possibility of updating my piecemeal ECIES 
implementation that currently builds on libgcrypt to use OpenSSL 
instead, since I already rely heavily on OpenSSL for SSL/TLS and its 
ciphers. I was hoping you could send me your ECIES code as a starting 
point?

TIA,
Ladar

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org

Markus Hofer | 2 Aug 2010 11:08
Picon
Picon

Building openssl without RSA,DSA,DH errors - bug?

Hi

I already mentioned this in the opensssl-users maling list. Is it possible to build openssl without RSA,DA
and DH support? Doing so i got erros like

 ./config --prefix=/home_vie/mhofer/tmp_opensslscratch 
 --openssldir=/home_vie/mhofer/tmp_opensslscratch/openssl no-threads no-zlib 
 no-shared no-bf no-cast no-des no-md2 no-mdc2 no-rc2 no-rc4 no-rc5 no-rsa 
 no-dsa no-dh; make depend; make

 the build crashes with:

 gcc -I.. -I../.. -I../../include -DDSO_DLFCN -DHAVE_DLFCN_H -march=pentium 
 -DL_ENDIAN -DTERMIO -O3 -fomit-frame-pointer -Wall 
 -DOPENSSL_BN_ASM_PART_WORDS -DOPENSSL_IA32_SSE2 -DSHA1_ASM -DMD5_ASM 
 -DRMD160_ASM -DAES_ASM   -c -o eng_cnf.o eng_cnf.c
> gcc -I.. -I../.. -I../../include -DDSO_DLFCN -DHAVE_DLFCN_H -march=pentium 
 -DL_ENDIAN -DTERMIO -O3 -fomit-frame-pointer -Wall 
 -DOPENSSL_BN_ASM_PART_WORDS -DOPENSSL_IA32_SSE2 -DSHA1_ASM -DMD5_ASM 
 -DRMD160_ASM -DAES_ASM   -c -o eng_dyn.o eng_dyn.c
 gcc -I.. -I../.. -I../../include -DDSO_DLFCN -DHAVE_DLFCN_H -march=pentium 
 -DL_ENDIAN -DTERMIO -O3 -fomit-frame-pointer -Wall 
-DOPENSSL_BN_ASM_PART_WORDS -DOPENSSL_IA32_SSE2 -DSHA1_ASM -DMD5_ASM 
-DRMD160_ASM -DAES_ASM   -c -o eng_cryptodev.o eng_cryptodev.c
 In file included from eng_cryptodev.c:33:
 ../../include/openssl/dsa.h:71:2: error: #error DSA is disabled.
 In file included from eng_cryptodev.c:34:
 ../../include/openssl/rsa.h:74:2: error: #error RSA is disabled.
 In file included from eng_cryptodev.c:35:
 ../../include/openssl/dh.h:65:3: error: #error DH is disabled.
(Continue reading)

Johnson, Donald K | 2 Aug 2010 20:36
Picon
Favicon

Engine support for enabling Intel Atom Security (SEP) processor

Hello,
I am starting to work on development of an openssl engine
to enable access to the security processor, for Intel Atom
chipsets.

Is this the right forum for asking design questions, and
submitting patches?

Thank you,

Don Johnson
Ultra-Mobility Group
Intel Corporation
Office: 503-712-9898
donald.k.johnson <at> intel.com

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org

Patrick Patterson | 2 Aug 2010 20:52

Re: how to disable weak SSL ciphers?

On July 30, 2010 10:21:06 pm Robert Feldman -X (robfeldm - Protingent Staffing 
at Cisco) wrote:
> Nessus and " openssl ciphers -v 'ALL:eNULL'" detect the following weak
> SSL ciphers on my test server:
> 
> 
> 
> NULL-SHA                SSLv3 Kx=RSA      Au=RSA  Enc=None      Mac=SHA1
> 
> NULL-MD5                SSLv3 Kx=RSA      Au=RSA  Enc=None      Mac=MD5
> 
> 
> 
> What configure options do I specify to rebuild openssl to compile out
> these weak SSL ciphers?
> 
> Specifying no-md5 should disable required ciphers such as RC4-MD5, which
> I do not want to do.
> 
> Is there an openssl config file or runtime tool to disable all ciphers
> with Enc=None?
> 
Don't rebuild OpenSSL - configure your application to only use ciphers that 
comply with whatever security requirements you have. If this is Apache, you 
can do this fairly simply by using the SSLCipherSuite httpd.conf directive. If 
you wrote the application, then prior to accepting any connections, use the  
SSL_CTX_set_cipher_list() function to set everything up the way you want.

Have fun!

(Continue reading)

Jeff Davey | 3 Aug 2010 00:09
Picon

OpenSSL 0.9.8o compile error with no-comp option

Using ./config no-comp I get a symbol not found:

lib/openssl/scons-lib/libcrypto.a(err_all.o): In function `ERR_load_crypto_strings':
err_all.c:(.text+0x8f): undefined reference to `ERR_load_COMP_strings'
collect2: ld returned 1 exit status


Here's a patch to fix it:
--- openssl-0.9.8o/crypto/err/err_all.c 2009-08-09 07:51:56.000000000 -0700
+++ openssl/crypto/err/err_all.c  2010-08-02 15:04:32.000000000 -0700
<at> <at> -158,6 +158,8 <at> <at>
 #ifndef OPENSSL_NO_JPAKE
        ERR_load_JPAKE_strings();
 #endif
+#ifndef OPENSSL_NO_COMP
        ERR_load_COMP_strings();
 #endif
+#endif
        }

aerowolf | 3 Aug 2010 05:17
Picon

Re: how to disable weak SSL ciphers?

You need '!aNULL:!eNULL:!LOW:!SSLv2:!EXPORT:!EXPORT56:FIPS:MEDIUM:HIGH: <at> STRENGTH" as the
argument to SSL_CTX_set_cipher_list().

You can't get rid of MD5, as *everything* requires it.  If you get rid of it, TLS v1.0 won't work, SSLv3 won't
work, and I don't even know about the TLS v1.1 stuff that's going into (appropriately) OpenSSL v1.1 (and
backported to v1.0.1).

(Can we get TLS v1.2 in v1.2, and then start numbering based on the version of the protocol it speaks? ;) )

-Kyle H

On Mon, Aug 2, 2010 at 11:52 AM, Patrick Patterson <ppatterson <at> carillonis.com> wrote:
> On July 30, 2010 10:21:06 pm Robert Feldman -X (robfeldm - Protingent Staffing
> at Cisco) wrote:
>> Nessus and " openssl ciphers -v 'ALL:eNULL'" detect the following weak
>> SSL ciphers on my test server:
>>
>>
>>
>> NULL-SHA                SSLv3 Kx=RSA      Au=RSA  Enc=None      Mac=SHA1
>>
>> NULL-MD5                SSLv3 Kx=RSA      Au=RSA  Enc=None      Mac=MD5
>>
>>
>>
>> What configure options do I specify to rebuild openssl to compile out
>> these weak SSL ciphers?
>>
>> Specifying no-md5 should disable required ciphers such as RC4-MD5, which
>> I do not want to do.
>>
>> Is there an openssl config file or runtime tool to disable all ciphers
>> with Enc=None?
>>
> Don't rebuild OpenSSL - configure your application to only use ciphers that
> comply with whatever security requirements you have. If this is Apache, you
> can do this fairly simply by using the SSLCipherSuite httpd.conf directive. If
> you wrote the application, then prior to accepting any connections, use the
> SSL_CTX_set_cipher_list() function to set everything up the way you want.
>
> Have fun!
>
> --
> Patrick Patterson
> President and Chief PKI Architect,
> Carillon Information Security Inc.
> http://www.carillon.ca

> ______________________________________________________________________
> OpenSSL Project                                 http://www.openssl.org

> Development Mailing List                       openssl-dev <at> openssl.org
> Automated List Manager                           majordomo <at> openssl.org
>

Attachment (smime.p7s): application/pkcs7-signature, 3930 bytes
Darryl Miles | 3 Aug 2010 12:52

Re: Engine support for enabling Intel Atom Security (SEP) processor

Johnson, Donald K wrote:
> Is this the right forum for asking design questions, and
> submitting patches?

Sure.

Patches are prefered to be submitted with ticket at RT 
http://www.openssl.org/support/rt.html  (even if documentation still 
says to use the mailing-list).

Can you cite any online references for the "SEP" and the scope of things 
you are looking into ?  (I have an interest in the MeeGo project myself)

Which things describe what "SEP" is ?

  * SIMD optimizations (AES instructions, OpenSSL asm optimizations)
  * Trusted Execution Technology (TPM/TXT)
  * Hardware asynchronous crypto offloading/coprocessor (OpenSSL Engine)
  * Something else

Darryl
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org

Tim Cloud | 3 Aug 2010 14:53

RE: how to disable weak SSL ciphers?

So, I have a question for this group as well, but it's in regards to this same issue.
What if you didn't write the application, and using the SSLCipherSuite is not an option as it's not running Apache?
Can someone just compile the FIPS compliant version of OpenSSL which should only allow strong ciphers?

Timothy Cloud
MSPRC Database Manager
Chickasaw Nation Industries

-----Original Message-----
From: owner-openssl-dev <at> openssl.org [mailto:owner-openssl-dev <at> openssl.org] On Behalf Of Patrick Patterson
Sent: Monday, August 02, 2010 1:52 PM
To: openssl-dev <at> openssl.org
Subject: Re: how to disable weak SSL ciphers?

On July 30, 2010 10:21:06 pm Robert Feldman -X (robfeldm - Protingent Staffing 
at Cisco) wrote:
> Nessus and " openssl ciphers -v 'ALL:eNULL'" detect the following weak
> SSL ciphers on my test server:
> 
> 
> 
> NULL-SHA                SSLv3 Kx=RSA      Au=RSA  Enc=None      Mac=SHA1
> 
> NULL-MD5                SSLv3 Kx=RSA      Au=RSA  Enc=None      Mac=MD5
> 
> 
> 
> What configure options do I specify to rebuild openssl to compile out
> these weak SSL ciphers?
> 
> Specifying no-md5 should disable required ciphers such as RC4-MD5, which
> I do not want to do.
> 
> Is there an openssl config file or runtime tool to disable all ciphers
> with Enc=None?
> 
Don't rebuild OpenSSL - configure your application to only use ciphers that 
comply with whatever security requirements you have. If this is Apache, you 
can do this fairly simply by using the SSLCipherSuite httpd.conf directive. If 
you wrote the application, then prior to accepting any connections, use the  
SSL_CTX_set_cipher_list() function to set everything up the way you want.

Have fun!

-- 
Patrick Patterson
President and Chief PKI Architect,
Carillon Information Security Inc.
http://www.carillon.ca
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org

---------------------------------------------------------------------
CONFIDENTIALITY NOTICE
This e-mail is intended for the sole use of the individual(s) to whom it is addressed, and may contain
information that is privileged, confidential and exempt from disclosure under applicable law.  You are
hereby notified that any dissemination, duplication, or distribution of this transmission by someone
other than the intended addressee or its designated agent is strictly prohibited.  If you receive this
e-mail in error, please notify me immediately by replying to this e-mail.

---------------------------------------------------------------------

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org

Johnson, Donald K | 3 Aug 2010 20:10
Picon
Favicon

RE: Engine support for enabling Intel Atom Security (SEP) processor

>-----Original Message-----
>From: Darryl Miles [mailto:darryl-mailinglists <at> netbauds.net]
>Sent: Tuesday, August 03, 2010 3:52 AM
>To: openssl-dev <at> openssl.org
>Cc: Johnson, Donald K
>Subject: Re: [openssl-dev] Engine support for enabling Intel
>Atom Security (SEP) processor
>
>Johnson, Donald K wrote:
>> Is this the right forum for asking design questions, and
>> submitting patches?
>
>Sure.
>
>Patches are prefered to be submitted with ticket at RT
>http://www.openssl.org/support/rt.html  (even if
>documentation still
>says to use the mailing-list).
>
>
>Can you cite any online references for the "SEP" and the
>scope of things
>you are looking into ?  (I have an interest in the MeeGo
>project myself)
>
>
>Which things describe what "SEP" is ?
>
>  * SIMD optimizations (AES instructions, OpenSSL asm
>optimizations)
>  * Trusted Execution Technology (TPM/TXT)
>  * Hardware asynchronous crypto offloading/coprocessor
>(OpenSSL Engine)
>  * Something else
>
There isn't a lot of online information at this time.
The product name is: Intel Smart & Secure Technology (Intel S&ST).
A very brief high level description is in this Intel Atom Processor
fact sheet:

http://download.intel.com/pressroom/kits/atom/z6xx/pdf/Fact_Sheet_Intel_Atom_Processor_Platform.pdf

The S&ST component is part of the Intel Platform Controller Hub (PCH) MP20.

Don J.
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org


Gmane