headers
Bodo Moeller via RT | 1 Feb 2009 02:18
Picon
Favicon

[openssl.org #1831] PATCH: openssl rand -hex

> [djm <at> mindrot.org - Fr. 30. Jan. 2009, 11:52:17]:

> This patch adds a -hex option to the rand app. E.g.
> 
> $ openssl rand -hex 8
> d203552d5eb39e76

What is the rationale of not having a newline at the end?  It's text,
after all?

Bodo

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 6 comments |
headers
Damien Miller | 1 Feb 2009 09:13
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex

On Sun, 1 Feb 2009, Bodo Moeller via RT wrote:

> > [djm <at> mindrot.org - Fr. 30. Jan. 2009, 11:52:17]:
> 
> > This patch adds a -hex option to the rand app. E.g.
> > 
> > $ openssl rand -hex 8
> > d203552d5eb39e76
> 
> What is the rationale of not having a newline at the end?  It's text,
> after all?

no rationale, just an oversight.

-d
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 5 comments |
headers
(Damien Miller) via RT | 1 Feb 2009 08:19
Picon
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex

On Sun, 1 Feb 2009, Bodo Moeller via RT wrote:

> > [djm <at> mindrot.org - Fr. 30. Jan. 2009, 11:52:17]:
> 
> > This patch adds a -hex option to the rand app. E.g.
> > 
> > $ openssl rand -hex 8
> > d203552d5eb39e76
> 
> What is the rationale of not having a newline at the end?  It's text,
> after all?

no rationale, just an oversight.

-d

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 0 comments |
headers
Bodo Moeller | 1 Feb 2009 18:53
Picon
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex

>> What is the rationale of not having a newline at the end?  It's text,
>> after all?
>
> no rationale, just an oversight.
>

So ... I was going to add the newline while working on the patch, but  
then it occurred to me as you said this comes from OpenBSD CVS I might  
be breaking something there.  No risk then?

Bodo

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 3 comments |
headers
Bodo Moeller via RT | 1 Feb 2009 18:04
Picon
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex

>> What is the rationale of not having a newline at the end?  It's text,
>> after all?
>
> no rationale, just an oversight.
>

So ... I was going to add the newline while working on the patch, but  
then it occurred to me as you said this comes from OpenBSD CVS I might  
be breaking something there.  No risk then?

Bodo

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 2 comments |
headers
Damien Miller | 1 Feb 2009 19:10
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex


On Sun, 1 Feb 2009, Bodo Moeller via RT wrote:

> >> What is the rationale of not having a newline at the end?  It's text,
> >> after all?
> >
> > no rationale, just an oversight.
> >
> 
> So ... I was going to add the newline while working on the patch, but  
> then it occurred to me as you said this comes from OpenBSD CVS I might  
> be breaking something there.  No risk then?

we'll cope ;) 

-d
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 1 comment |
headers
(Damien Miller) via RT | 1 Feb 2009 18:15
Picon
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex


On Sun, 1 Feb 2009, Bodo Moeller via RT wrote:

> >> What is the rationale of not having a newline at the end?  It's text,
> >> after all?
> >
> > no rationale, just an oversight.
> >
> 
> So ... I was going to add the newline while working on the patch, but  
> then it occurred to me as you said this comes from OpenBSD CVS I might  
> be breaking something there.  No risk then?

we'll cope ;) 

-d

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 0 comments |
headers
Bodo Moeller via RT | 1 Feb 2009 19:29
Picon
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex

> we'll cope ;)

Here's my version of the patch.  Let me know if it looks OK for you.

Bodo

Index: CHANGES
===================================================================
RCS file: /e/openssl/cvs/openssl/CHANGES,v
retrieving revision 1.1468
diff -u -r1.1468 CHANGES
--- CHANGES	28 Jan 2009 12:54:51 -0000	1.1468
+++ CHANGES	1 Feb 2009 17:48:03 -0000
 <at>  <at>  -745,6 +745,9  <at>  <at> 

  Changes between 0.9.8j and 0.9.8k  [xx XXX xxxx]

+  *) New -hex option for openssl rand.
+     [Matthieu Herrb]
+
   *) Print out UTF8String and NumericString when parsing ASN1.
      [Steve Henson]

Index: apps/rand.c
===================================================================
RCS file: /e/openssl/cvs/openssl/apps/rand.c,v
retrieving revision 1.20
diff -u -r1.20 rand.c
--- apps/rand.c	12 Aug 2007 17:44:27 -0000	1.20
+++ apps/rand.c	1 Feb 2009 17:48:05 -0000
(Continue reading)

Permalink | Reply | 2 comments |
headers
Damien Miller | 1 Feb 2009 20:51
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex

On Sun, 1 Feb 2009, Bodo Moeller via RT wrote:

> > we'll cope ;)
> 
> Here's my version of the patch.  Let me know if it looks OK for you.

looks good to me

-d
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 1 comment |
headers
(Damien Miller) via RT | 1 Feb 2009 23:36
Picon
Favicon

Re: [openssl.org #1831] PATCH: openssl rand -hex

On Sun, 1 Feb 2009, Bodo Moeller via RT wrote:

> > we'll cope ;)
> 
> Here's my version of the patch.  Let me know if it looks OK for you.

looks good to me

-d

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org
Permalink | Reply | 0 comments |

Gmane