[PATCH 1/2] comctl32/treeview: Clean up winproc a bit, move parameter check to handlers

Changelog:
    - clean up winproc a bit, move parameter check to handlers

[PATCH 2/2] comctl32/treeview: Simplify WM_CHAR handler

Changelog:
    - simplify WM_CHAR handler

[PATCH 4/5] dsound: Add support for OpenAL IDirectSoundCaptureBuffer, try 2

Ticking timer is missing, so this doesn't do much till next commit
---
With the fixes suggested by chris

From 4cdf3ce0abf1b4b1a40e96781abd584f12220692 Mon Sep 17 00:00:00 2001
From: Maarten Lankhorst <m.b.lankhorst <at> gmail.com>
Date: Mon, 30 Nov 2009 22:18:55 +0100
Subject: [PATCH 4/5] dsound: Add support for OpenAL IDirectSoundCaptureBuffer

Ticking timer is missing, so this doesn't do much till next commit
---
 dlls/dsound/capture.c |  413 ++++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 411 insertions(+), 2 deletions(-)

diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c
index f9d8975..f67d2a6 100644
--- a/dlls/dsound/capture.c
+++ b/dlls/dsound/capture.c
 <at>  <at>  -47,19 +47,408  <at>  <at>  HRESULT DSOUND_CaptureCreate(REFIID riid, IDirectSoundCapture **cap)

 #ifdef HAVE_OPENAL

+typedef struct DSCBuffer DSCBuffer;
+
 typedef struct DSCImpl
 {
     const IDirectSoundCaptureVtbl *lpVtbl;
     LONG ref;

[PATCH] cryptnet: Added a potentially missing NULL ptr check (Coverity)

Hi,

We check pRevPara for NULL earlier, so we should also check it here.

Ciao, Marcus
---
 dlls/cryptnet/cryptnet_main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/cryptnet/cryptnet_main.c b/dlls/cryptnet/cryptnet_main.c
index afae942..34bbc58 100644
--- a/dlls/cryptnet/cryptnet_main.c
+++ b/dlls/cryptnet/cryptnet_main.c
 <at>  <at>  -1616,7 +1616,8  <at>  <at>  BOOL WINAPI CertDllVerifyRevocation(DWORD dwEncodingType, DWORD dwRevType,
                      NULL);
                     if (dwFlags & CERT_VERIFY_CACHE_ONLY_BASED_REVOCATION)
                         retrievalFlags |= CRYPT_CACHE_ONLY_RETRIEVAL;
-                    if (dwFlags & CERT_VERIFY_REV_ACCUMULATIVE_TIMEOUT_FLAG &&
+                    if ((dwFlags & CERT_VERIFY_REV_ACCUMULATIVE_TIMEOUT_FLAG) &&
+                     pRevPara &&
                      pRevPara->cbSize >= offsetof(CERT_REVOCATION_PARA,
                      dwUrlRetrievalTimeout) + sizeof(DWORD))
                     {
--

-- 
1.5.6

[PATCH] dbghelp: Check wImageName for NULL (Coverity)

Hi,

wImageName can be NULL in here, so check and handle it.

Ciao, Marcus
---
 dlls/dbghelp/module.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c
index a6778e7..1920dca 100644
--- a/dlls/dbghelp/module.c
+++ b/dlls/dbghelp/module.c
 <at>  <at>  -534,6 +534,7  <at>  <at>  DWORD64 WINAPI  SymLoadModuleExW(HANDLE hProcess, HANDLE hFile, PCWSTR wImageNam

     if (Flags & SLMFLAG_VIRTUAL)
     {
+        if (!wImageName) return FALSE;
         module = module_new(pcs, wImageName, module_get_type_by_name(wImageName),
                             TRUE, (DWORD)BaseOfDll, SizeOfDll, 0, 0);
         if (!module) return FALSE;
 <at>  <at>  -594,7 +595,8  <at>  <at>  DWORD64 WINAPI  SymLoadModuleExW(HANDLE hProcess, HANDLE hFile, PCWSTR wImageNam
      */
     if (wModuleName)
         module_set_module(module, wModuleName);
-    lstrcpynW(module->module.ImageName, wImageName,
+    if (wImageName)
+        lstrcpynW(module->module.ImageName, wImageName,
               sizeof(module->module.ImageName) / sizeof(WCHAR));

[PATCH 1/5] ntdll: Fix the FileAllInformation info size.

---
 dlls/ntdll/file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
index 32e5f93..71c8cba 100644
--- a/dlls/ntdll/file.c
+++ b/dlls/ntdll/file.c
 <at>  <at>  -1679,7 +1679,7  <at>  <at>  NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, PIO_STATUS_BLOCK io,
         sizeof(FILE_FULL_EA_INFORMATION),              /* FileFullEaInformation */
         sizeof(FILE_MODE_INFORMATION),                 /* FileModeInformation */
         sizeof(FILE_ALIGNMENT_INFORMATION),            /* FileAlignmentInformation */
-        sizeof(FILE_ALL_INFORMATION)-sizeof(WCHAR),    /* FileAllInformation */
+        sizeof(FILE_ALL_INFORMATION),                  /* FileAllInformation */
         sizeof(FILE_ALLOCATION_INFORMATION),           /* FileAllocationInformation */
         sizeof(FILE_END_OF_FILE_INFORMATION),          /* FileEndOfFileInformation */
         0,                                             /* FileAlternateNameInformation */
--

-- 
1.6.4.4

[PATCH 2/5] ntdll: Also return name information for FileAllInformation.

---
 dlls/ntdll/file.c |   64 ++++++++++++++++++++++++++++++----------------------
 1 files changed, 37 insertions(+), 27 deletions(-)

diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
index 71c8cba..a43291e 100644
--- a/dlls/ntdll/file.c
+++ b/dlls/ntdll/file.c
 <at>  <at>  -1639,6 +1639,33  <at>  <at>  static NTSTATUS server_get_unix_name( HANDLE handle, ANSI_STRING *unix_name )
     return ret;
 }

+static NTSTATUS fill_name_info( const ANSI_STRING *unix_name, FILE_NAME_INFORMATION *info, LONG
*name_len )
+{
+    UNICODE_STRING nt_name;
+    NTSTATUS status;
+
+    if (!(status = wine_unix_to_nt_file_name( unix_name, &nt_name )))
+    {
+        const WCHAR *ptr = nt_name.Buffer;
+        const WCHAR *end = ptr + (nt_name.Length / sizeof(WCHAR));
+
+        /* Skip the volume mount point. */
+        while (ptr != end && *ptr == '\\') ++ptr;
+        while (ptr != end && *ptr != '\\') ++ptr;
+        while (ptr != end && *ptr == '\\') ++ptr;
+        while (ptr != end && *ptr != '\\') ++ptr;
+
+        info->FileNameLength = (end - ptr) * sizeof(WCHAR);

[PATCH 3/5] ntdll/tests: Add some tests for FileAllInformation name information.

This is essentially a copy of test_file_name_information().
---
 dlls/ntdll/tests/file.c |  141 +++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 141 insertions(+), 0 deletions(-)

diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c
index 8eff7d3..129444a 100644
--- a/dlls/ntdll/tests/file.c
+++ b/dlls/ntdll/tests/file.c
 <at>  <at>  -1075,6 +1075,146  <at>  <at>  static void test_file_name_information(void)
     HeapFree( GetProcessHeap(), 0, file_name );
 }

+static void test_file_all_name_information(void)
+{
+    WCHAR *file_name, *volume_prefix, *expected;
+    FILE_ALL_INFORMATION *info;
+    ULONG old_redir = 1, tmp;
+    UINT file_name_size;
+    IO_STATUS_BLOCK io;
+    UINT info_size;
+    HRESULT hr;
+    HANDLE h;
+    UINT len;
+
+    /* GetVolumePathName is not present before w2k */
+    if (!pGetVolumePathNameW) {
+        win_skip("GetVolumePathNameW not found\n");
+        return;
+    }

[PATCH 4/5] d3d8: Return D3DERR_INVALIDCALL when trying to delete an invalid pixel shader.

It appears this is fixed on Vista/Win7 to be consistent with
DeleteVertexShader(). Match the more consistent behaviour of Vista/Win7 and
mark the previous behaviour as broken.
---
 dlls/d3d8/device.c       |    2 +-
 dlls/d3d8/tests/device.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c
index 450a5ff..f390691 100644
--- a/dlls/d3d8/device.c
+++ b/dlls/d3d8/device.c
 <at>  <at>  -2316,7 +2316,7  <at>  <at>  static HRESULT WINAPI
IDirect3DDevice8Impl_DeletePixelShader(LPDIRECT3DDEVICE8 i
     {
         WARN("Invalid handle (%#x) passed.\n", pShader);
         wined3d_mutex_unlock();
-        return D3D_OK;
+        return D3DERR_INVALIDCALL;
     }

     IWineD3DDevice_GetPixelShader(This->WineD3DDevice, &cur);
diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c
index 900fbb7..5e1f523 100644
--- a/dlls/d3d8/tests/device.c
+++ b/dlls/d3d8/tests/device.c
 <at>  <at>  -1084,9 +1084,9  <at>  <at>  static void test_shader(void)

         /* Check for double delete. */
         hr = IDirect3DDevice8_DeletePixelShader(pDevice, hPixelShader2);

[PATCH 5/5] d3d9/tests: Trace the viewport in clear_test().

There are some failures in this test on Win7 that appear to be related to the
initial viewport. Perhaps this trace will help narrow it down.
---
 dlls/d3d9/tests/visual.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c
index b871ad7..18a69c6 100644
--- a/dlls/d3d9/tests/visual.c
+++ b/dlls/d3d9/tests/visual.c
 <at>  <at>  -495,6 +495,9  <at>  <at>  static void clear_test(IDirect3DDevice9 *device)
     hr = IDirect3DDevice9_GetViewport(device, &old_vp);
     ok(hr == D3D_OK, "IDirect3DDevice9_GetViewport failed with %08x\n", hr);

+    trace("viewport: X %u, Y %u, W %u, H %u, MinZ %.8e, MaxZ %.8e.\n",
+            old_vp.X, old_vp.Y, old_vp.Width, old_vp.Height, old_vp.MinZ, old_vp.MaxZ);
+
     vp.X = 160;
     vp.Y = 120;
     vp.Width = 160;
--

-- 
1.6.4.4