headers
Jin Guojie | 1 Dec 2010 04:10
Picon

[patch] MIPS Initial support of Godson-3a multicore CPU

Aurelien,
  Attached is a patch for Godson-3a CPU support.
  Godson-3a is a newly developed MIPS-III like, multicore CPU by ICT, China.
  For you review. Any comment is welcomed.

Jin Guojie
www.loongson.cn
Attachment (0001-MIPS-Initial-support-of-Godson-3a-multicore-CPU.patch): application/octet-stream, 16 KiB
Permalink | Reply | 1 comment |
headers
Serge Hallyn | 1 Dec 2010 04:39

[Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

At last!  I was able to reproduce this using a copy of fedora 1 from

http://archive.kernel.org/fedora-
archive/fedora/linux/core/1/i386/iso/yarrow-i386-disc1.iso

This would segfault before completing install from disc 1 more than 50%
of the time.  With the qemu-kvm from -proposed, I've not been able to
get it to segfault.

-- 
KVM segmentation fault, using SCSI+writeback and linux 2.4 guest
https://bugs.launchpad.net/bugs/595438
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in Kernel Virtual Machine: Confirmed
Status in QEMU: Fix Committed
Status in qemu-kvm: Fix Released
Status in “qemu-kvm” package in Ubuntu: Fix Released
Status in “qemu-kvm” source package in Lucid: Fix Committed
Status in “qemu-kvm” package in Debian: Fix Released

Bug description:
I Use Ubuntu 32 bit 10.04 with standard KVM.
I have Intel E7600   <at>  3.06GHz processor with VMX

In this system I Run:
LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/sbin:/sbin:/bin
QEMU_AUDIO_DRV=none /usr/bin/kvm -M pc-0.12 -enable-kvm -m 256 -smp 1 -name spamsender -uuid
b9cacd5e-08f7-41fd-78c8-89cec59af881 -chardev
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jason Wang | 1 Dec 2010 06:45
Picon
Favicon

[PATCHv3 4/6] virtio-net: stop/start bh when appropriate

Michael S. Tsirkin writes:
 > Avoid sending out packets, and modifying
 > device state, when VM is stopped.
 > Add assert statements to verify this does not happen.
 > 
 > Avoid scheduling bh when vhost-net is started.
 > 
 > Stop bh when driver disabled bus mastering
 > (we must not access memory after this).
 > 
 > Signed-off-by: Michael S. Tsirkin <mst <at> redhat.com>
 > 

There's no need to disable it bh we call qemu_aio_flush() after
vm_state_notify() in do_vm_stop(). And for timer, looks like every device should
stop its timer in vm state change handler, not only for virtio-net?

 > ---
 > 
 > Respinning just this one patch:
 > virtio-net: stop/start bh on vm start/stop
 > 
 > it turns out under kvm vcpu can be running after vm stop
 > notifier callbacks are done. And it makes sense: vcpu is
 > just another device, so we should not
 > depend on the order of vmstate notifiers.
 > The state callback is thus a request for device to avoid changing state
 > of other devices, not a guarantee that other devices
 > will not send requests to it.
 >
(Continue reading)

Permalink | Reply | 12 comments |
headers
Amit Shah | 1 Dec 2010 10:54
Picon
Favicon

[PATCH v8 1/7] virtio-console: Factor out common init between console and generic ports

The initialisation for generic ports and console ports is similar.
Factor out the parts that are the same in a different function that can
be called from each of the initfns.

Signed-off-by: Amit Shah <amit.shah <at> redhat.com>
---
 hw/virtio-console.c |   31 ++++++++++++++-----------------
 1 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index caea11f..d7fe68b 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
 <at>  <at>  -58,24 +58,28  <at>  <at>  static void chr_event(void *opaque, int event)
     }
 }

-/* Virtio Console Ports */
-static int virtconsole_initfn(VirtIOSerialDevice *dev)
+static int generic_port_init(VirtConsole *vcon, VirtIOSerialDevice *dev)
 {
-    VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, &dev->qdev);
-    VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
-
-    port->info = dev->info;
-
-    port->is_console = true;
+    vcon->port.info = dev->info;

     if (vcon->chr) {
(Continue reading)

Permalink | Reply | 0 comments |
headers
Amit Shah | 1 Dec 2010 10:54
Picon
Favicon

[PATCH v8 7/7] virtio-console: Enable port throttling when chardev is slow to consume data

When a chardev indicates it can't accept more data, we tell the
virtio-serial code to stop sending us any more data till we tell
otherwise.  This helps in guests continuing to run normally while the vq
keeps getting full and eventually the guest stops queueing more data.
As soon as the chardev indicates it can accept more data, start pushing!

Signed-off-by: Amit Shah <amit.shah <at> redhat.com>
---
 hw/virtio-console.c |   17 ++++++++++++++++-
 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 749ed59..ec85ad5 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
 <at>  <at>  -18,13 +18,27  <at>  <at>  typedef struct VirtConsole {
     CharDriverState *chr;
 } VirtConsole;

+/*
+ * Callback function that's called from chardevs when backend becomes
+ * writable.
+ */
+static void chr_write_unblocked(void *opaque)
+{
+    VirtConsole *vcon = opaque;
+
+    virtio_serial_throttle_port(&vcon->port, false);
+}
(Continue reading)

Permalink | Reply | 15 comments |
headers
Michael S. Tsirkin | 1 Dec 2010 07:02
Picon
Favicon

Re: [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote:
> Michael S. Tsirkin writes:
>  > Avoid sending out packets, and modifying
>  > device state, when VM is stopped.
>  > Add assert statements to verify this does not happen.
>  > 
>  > Avoid scheduling bh when vhost-net is started.
>  > 
>  > Stop bh when driver disabled bus mastering
>  > (we must not access memory after this).
>  > 
>  > Signed-off-by: Michael S. Tsirkin <mst <at> redhat.com>
>  > 
> 
> There's no need to disable it bh we call qemu_aio_flush() after
> vm_state_notify() in do_vm_stop(). And for timer, looks like every device should
> stop its timer in vm state change handler, not only for virtio-net?

BTW I fixed some typos. Here a fixed version.
Jason, could you review/test please?

virtio-net: stop/start bh when appropriate

Avoid sending out packets, and modifying
memory, when VM is stopped.
Add assert statements to verify this does not happen.

Avoid scheduling bh when vhost-net is started.

Stop bh when driver disabled bus mastering
(Continue reading)

Permalink | Reply | 9 comments |
headers
Alexander Graf | 1 Dec 2010 11:25
Picon

Re: [PATCH] xen: Restrict build to x86 targets


On 01.12.2010, at 11:21, Anthony PERARD wrote:

> On Mon, 29 Nov 2010, Alexander Graf wrote:
> 
>> 
>> On 29.11.2010, at 15:27, Jan Kiszka wrote:
>> 
>>> Am 29.11.2010 15:15, Alexander Graf wrote:
>>>> 
>>>> On 29.11.2010, at 13:44, Jan Kiszka wrote:
>>>> 
>>>>> Am 29.11.2010 13:40, Alexander Graf wrote:
>>>>>> 
>>>>>> On 29.11.2010, at 13:30, Jan Kiszka wrote:
>>>>>> 
>>>>>>> Am 29.11.2010 13:24, Alexander Graf wrote:
>>>>>>>> 
>>>>>>>> On 28.11.2010, at 16:59, Jan Kiszka wrote:
>>>>>>>> 
>>>>>>>>> From: Jan Kiszka <jan.kiszka <at> siemens.com>
>>>>>>>>> 
>>>>>>>>> Xen target bits in qemu are intended for x86. Let the build system
>>>>>>>>> reflect this and avoid useless building/linking for other targets.
>>>>>>>> 
>>>>>>>> Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target
usually defines the guest. The piece you marked as _HOST are target specific.
>>>>>>> 
>>>>>>> At least so far, the HOST part is build once for all targets into the
>>>>>>> host backend library. As this step injected CONFIG_XEN into all target
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jason Wang | 1 Dec 2010 07:17
Picon
Favicon

Re: [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

Michael S. Tsirkin writes:
 > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote:
 > > Michael S. Tsirkin writes:
 > >  > Avoid sending out packets, and modifying
 > >  > device state, when VM is stopped.
 > >  > Add assert statements to verify this does not happen.
 > >  > 
 > >  > Avoid scheduling bh when vhost-net is started.
 > >  > 
 > >  > Stop bh when driver disabled bus mastering
 > >  > (we must not access memory after this).
 > >  > 
 > >  > Signed-off-by: Michael S. Tsirkin <mst <at> redhat.com>
 > >  > 
 > > 
 > > There's no need to disable it bh we call qemu_aio_flush() after
 > > vm_state_notify() in do_vm_stop(). And for timer, looks like every device should
 > > stop its timer in vm state change handler, not only for virtio-net?
 > 
 > BTW I fixed some typos. Here a fixed version.
 > Jason, could you review/test please?
 > 

Sure.

 > virtio-net: stop/start bh when appropriate
 > 
 > Avoid sending out packets, and modifying
 > memory, when VM is stopped.
 > Add assert statements to verify this does not happen.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dustin Kirkland | 1 Dec 2010 07:33
Picon
Gravatar

Re: [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

Fedora1?  Seriously?  :-P

-- 
KVM segmentation fault, using SCSI+writeback and linux 2.4 guest
https://bugs.launchpad.net/bugs/595438
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in Kernel Virtual Machine: Confirmed
Status in QEMU: Fix Committed
Status in qemu-kvm: Fix Released
Status in “qemu-kvm” package in Ubuntu: Fix Released
Status in “qemu-kvm” source package in Lucid: Fix Committed
Status in “qemu-kvm” package in Debian: Fix Released

Bug description:
I Use Ubuntu 32 bit 10.04 with standard KVM.
I have Intel E7600   <at>  3.06GHz processor with VMX

In this system I Run:
LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/sbin:/sbin:/bin
QEMU_AUDIO_DRV=none /usr/bin/kvm -M pc-0.12 -enable-kvm -m 256 -smp 1 -name spamsender -uuid
b9cacd5e-08f7-41fd-78c8-89cec59af881 -chardev
socket,id=monitor,path=/var/lib/libvirt/qemu/spamsender.monitor,server,nowait -monitor
chardev:monitor -boot d -drive
file=/mnt/megadiff/cdiso_400_130.iso,if=ide,media=cdrom,index=2 -drive
file=/home/mmarkk/spamsender2.img,if=scsi,index=0,format=qcow2,cache=writeback -net
nic,macaddr=00:00:00:00:00:00,vlan=0,name=nic.0 -net tap,vlan=0,name=tap.0 -chardev
pty,id=serial0 -serial chardev:serial0 -parallel none -usb -vnc 127.0.0.1:0 -vga cirrus
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stefan Hajnoczi | 1 Dec 2010 10:35
Picon
Gravatar

Re: [PATCH] Convert fprintf() to error_request(): virtio-9p

On Tue, Nov 30, 2010 at 9:52 AM, Sanchit Garg
<sancgarg <at> linux.vnet.ibm.com> wrote:
>  <at>  <at>  -3707,19 +3708,19  <at>  <at>  VirtIODevice *virtio_9p_init(DeviceState *dev, V9fsConf *conf)
>         s->ctx.fs_sm = SM_NONE;
>         s->ctx.xops = none_xattr_ops;
>     } else {
> -        fprintf(stderr, "Default to security_model=none. You may want"
> +        error_report("Default to security_model=none. You may want"
>                 " enable advanced security model using "
>                 "security option:\n\t security_model=passthrough \n\t "
> -                "security_model=mapped\n");
> +                "security_model=mapped");
>         s->ctx.fs_sm = SM_NONE;
>         s->ctx.xops = none_xattr_ops;
>     }

It would be safer to avoid embedded \n\t.  Although I can't find
anything prohibiting it in the source, no other place does this.
Program output is easier to handle when constrained to one message per
line.  Security issues arise when unfiltered inputs are logged *and*
linebreaks are allowed because malicious input can inject fake log
lines.  Let's avoid getting into the habit.

Looks good otherwise.

Stefan
Permalink | Reply | 3 comments |

Gmane