Isaku Yamahata | 1 Nov 03:17 2010
Picon

Re: [Qemu-devel] [PATCH 1/2] Minimal RAM API support

On Fri, Oct 29, 2010 at 10:39:03AM -0600, Alex Williamson wrote:
> This adds a minimum chunk of Anthony's RAM API support so that we
> can identify actual VM RAM versus all the other things that make
> use of qemu_ram_alloc.
> 
> Signed-off-by: Alex Williamson <alex.williamson <at> redhat.com>
> ---
> 
>  Makefile.target |    1 +
>  cpu-common.h    |    2 +
>  memory.c        |   82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  memory.h        |   23 +++++++++++++++
>  4 files changed, 108 insertions(+), 0 deletions(-)
>  create mode 100644 memory.c
>  create mode 100644 memory.h
> 
> diff --git a/Makefile.target b/Makefile.target
> index c48cbcc..e4e2eb4 100644
> --- a/Makefile.target
> +++ b/Makefile.target
>  <at>  <at>  -175,6 +175,7  <at>  <at>  obj-$(CONFIG_VIRTFS) += virtio-9p.o
>  obj-y += rwhandler.o
>  obj-$(CONFIG_KVM) += kvm.o kvm-all.o
>  obj-$(CONFIG_NO_KVM) += kvm-stub.o
> +obj-y += memory.o
>  LIBS+=-lz
>  
>  QEMU_CFLAGS += $(VNC_TLS_CFLAGS)
> diff --git a/cpu-common.h b/cpu-common.h
> index a543b5d..6aa2738 100644
(Continue reading)

TeLeMan | 1 Nov 03:24 2010
Picon

Re: [PATCH 4/4] target-xxx: Use fprintf_function (format checking)

On Sat, Oct 23, 2010 at 05:03, Stefan Weil <weil <at> mail.berlios.de> wrote:
>     int eflags, i, nb;
>  <at>  <at>  -335,9 +333,11  <at>  <at>  void cpu_dump_state(CPUState *env, FILE *f,
>                     (uint32_t)env->cr[2],
>                     (uint32_t)env->cr[3],
>                     (uint32_t)env->cr[4]);
> -        for(i = 0; i < 4; i++)
> -            cpu_fprintf(f, "DR%d=%08x ", i, env->dr[i]);
> -        cpu_fprintf(f, "\nDR6=%08x DR7=%08x\n", env->dr[6], env->dr[7]);
> +        for(i = 0; i < 4; i++) {
> +            cpu_fprintf(f, "DR%d=" TARGET_FMT_lx " ", i, env->dr[i]);
> +        }
> +        cpu_fprintf(f, "\nDR6=" TARGET_FMT_lx " DR7=" TARGET_FMT_lx "\n",
> +                    env->dr[6], env->dr[7]);
>     }
I think this patch is not right. Outputting 64bits data is not
necessary on 32bits mode.

Alex Williamson | 1 Nov 03:32 2010
Picon

Re: [Qemu-devel] [PATCH 1/2] Minimal RAM API support

On Sun, Oct 31, 2010 at 8:17 PM, Isaku Yamahata <yamahata <at> valinux.co.jp> wrote:
> On Fri, Oct 29, 2010 at 10:39:03AM -0600, Alex Williamson wrote:
>> This adds a minimum chunk of Anthony's RAM API support so that we
>> can identify actual VM RAM versus all the other things that make
>> use of qemu_ram_alloc.
>>
>> Signed-off-by: Alex Williamson <alex.williamson <at> redhat.com>
>> ---
>>
>>  Makefile.target |    1 +
>>  cpu-common.h    |    2 +
>>  memory.c        |   82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  memory.h        |   23 +++++++++++++++
>>  4 files changed, 108 insertions(+), 0 deletions(-)
>>  create mode 100644 memory.c
>>  create mode 100644 memory.h
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index c48cbcc..e4e2eb4 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>>  <at>  <at>  -175,6 +175,7  <at>  <at>  obj-$(CONFIG_VIRTFS) += virtio-9p.o
>>  obj-y += rwhandler.o
>>  obj-$(CONFIG_KVM) += kvm.o kvm-all.o
>>  obj-$(CONFIG_NO_KVM) += kvm-stub.o
>> +obj-y += memory.o
>>  LIBS+=-lz
>>
>>  QEMU_CFLAGS += $(VNC_TLS_CFLAGS)
>> diff --git a/cpu-common.h b/cpu-common.h
(Continue reading)

Alex Williamson | 1 Nov 04:54 2010
Picon

Re: [PATCH] APIC/IOAPIC EOI callback

On Fri, 2010-10-29 at 14:19 -0500, Anthony Liguori wrote:
> On 10/29/2010 12:56 PM, Alex Williamson wrote:
> > For device assignment, we need to know when the VM writes an end
> > of interrupt to the APIC, which allows us to re-enable interrupts
> > on the physical device.  Add a new wrapper for ioapic generated
> > interrupts with a callback on eoi and create an interface for
> > drivers to be notified on eoi.
> >
> > Signed-off-by: Alex Williamson<alex.williamson <at> redhat.com>
> > ---
> >
> > Note that the notifier and notifier_enabled eoi_client fields aren't
> > used here yet.  I'll send an RFC patch showing how we make use of
> > these with the proposed KVM_EOI_EVENTFD patches.
> >
> >   hw/apic.c   |   18 ++++++++++++++++--
> >   hw/apic.h   |    4 ++++
> >   hw/ioapic.c |   38 ++++++++++++++++++++++++++++++++++++--
> >   hw/pc.h     |   16 +++++++++++++++-
> >   4 files changed, 71 insertions(+), 5 deletions(-)
> >
> > diff --git a/hw/apic.c b/hw/apic.c
> > index 63d62c7..a24117b 100644
> > --- a/hw/apic.c
> > +++ b/hw/apic.c
> >  <at>  <at>  -22,6 +22,7  <at>  <at> 
> >   #include "host-utils.h"
> >   #include "sysbus.h"
> >   #include "trace.h"
> > +#include "pc.h"
(Continue reading)

Stefan Weil | 1 Nov 08:05 2010
Picon

Re: [PATCH 4/4] target-xxx: Use fprintf_function (format checking)

Am 01.11.2010 03:24, schrieb TeLeMan:
> On Sat, Oct 23, 2010 at 05:03, Stefan Weil <weil <at> mail.berlios.de> wrote:
>>     int eflags, i, nb;
>>  <at>  <at>  -335,9 +333,11  <at>  <at>  void cpu_dump_state(CPUState *env, FILE *f,
>>                     (uint32_t)env->cr[2],
>>                     (uint32_t)env->cr[3],
>>                     (uint32_t)env->cr[4]);
>> -        for(i = 0; i < 4; i++)
>> -            cpu_fprintf(f, "DR%d=%08x ", i, env->dr[i]);
>> -        cpu_fprintf(f, "\nDR6=%08x DR7=%08x\n", env->dr[6], env->dr[7]);
>> +        for(i = 0; i < 4; i++) {
>> +            cpu_fprintf(f, "DR%d=" TARGET_FMT_lx " ", i, env->dr[i]);
>> +        }
>> +        cpu_fprintf(f, "\nDR6=" TARGET_FMT_lx " DR7=" TARGET_FMT_lx 
>> "\n",
>> +                    env->dr[6], env->dr[7]);
>>     }
> I think this patch is not right. Outputting 64bits data is not
> necessary on 32bits mode.

Do you speak of 32 bit hosts or 32 bit targets?

dr is of type target_ulong, so its size depends on the target's
word size. TARGET_FMT_lx is the correct format specifier
for target_ulong.

What would you propose?

Cheers,
Stefan
(Continue reading)

Gleb Natapov | 1 Nov 08:53 2010
Picon

Re: [PATCHv2 0/8 RFC] boot order specification

On Sun, Oct 31, 2010 at 06:25:53PM -0400, Kevin O'Connor wrote:
> On Sun, Oct 31, 2010 at 01:40:01PM +0200, Gleb Natapov wrote:
> > This is current sate of the patch series for people to comment on.
> > I tried to use open firmware naming scheme to specify device path names.
> > 
> > The patch series produce names like these:
> > for pci machine:
> > /pci <at> i0cf8/pci-isa-bridge <at> 1/fdc <at> 03f1/floppy <at> 0
> > /pci <at> i0cf8/pci-isa-bridge <at> 1/fdc <at> 03f1/floppy <at> 1
> > /pci <at> i0cf8/ata <at> 1,1/ata-disk <at> 1:0
> > /pci <at> i0cf8/ata <at> 1,1/ata-disk <at> 1:1
> > /pci <at> i0cf8/virtio-blk <at> 3/virtio-disk <at> 0
> > /pci <at> i0cf8/ethernet <at> 4/ethernet-phy <at> 0
> > /pci <at> i0cf8/ethernet <at> 5/ethernet-phy <at> 0
> > 
> > for isa machine:
> > adding '/isa/fdc <at> 03f1/floppy <at> 0' at index 2
> > adding '/isa/fdc <at> 03f1/floppy <at> 1' at index 1
> > adding '/isa/ata <at> 0170/ata-disk <at> 0:0' at index 0
> > adding '/isa/ata <at> 0170/ata-disk <at> 0:1' at index 3
> 
> Hi Gleb,
> 
> How will USB drives be identified?
> 
USB bus has Open Firmware binding. I haven't look at the spec yet, but it
should be easy.

> I'm not sure how SeaBIOS will be able to line up something like
> "/pci <at> i0cf8/ethernet <at> 4/ethernet-phy <at> 0" to an optionrom BEV.  Also, if
(Continue reading)

TeLeMan | 1 Nov 10:50 2010
Picon

Re: [PATCH 4/4] target-xxx: Use fprintf_function (format checking)

--
SUN OF A BEACH

On Mon, Nov 1, 2010 at 15:05, Stefan Weil <weil <at> mail.berlios.de> wrote:
> Am 01.11.2010 03:24, schrieb TeLeMan:
>>
>> On Sat, Oct 23, 2010 at 05:03, Stefan Weil <weil <at> mail.berlios.de> wrote:
>>>
>>>    int eflags, i, nb;
>>>  <at>  <at>  -335,9 +333,11  <at>  <at>  void cpu_dump_state(CPUState *env, FILE *f,
>>>                    (uint32_t)env->cr[2],
>>>                    (uint32_t)env->cr[3],
>>>                    (uint32_t)env->cr[4]);
>>> -        for(i = 0; i < 4; i++)
>>> -            cpu_fprintf(f, "DR%d=%08x ", i, env->dr[i]);
>>> -        cpu_fprintf(f, "\nDR6=%08x DR7=%08x\n", env->dr[6], env->dr[7]);
>>> +        for(i = 0; i < 4; i++) {
>>> +            cpu_fprintf(f, "DR%d=" TARGET_FMT_lx " ", i, env->dr[i]);
>>> +        }
>>> +        cpu_fprintf(f, "\nDR6=" TARGET_FMT_lx " DR7=" TARGET_FMT_lx
>>> "\n",
>>> +                    env->dr[6], env->dr[7]);
>>>    }
>>
>> I think this patch is not right. Outputting 64bits data is not
>> necessary on 32bits mode.
>
> Do you speak of 32 bit hosts or 32 bit targets?
32bit mode of x64

(Continue reading)

Paolo Bonzini | 1 Nov 11:14 2010
Picon

Re: [PATCH 4/4] target-xxx: Use fprintf_function (format checking)

On 11/01/2010 10:50 AM, TeLeMan wrote:
>>> I think this patch is not right. Outputting 64bits data is not
>>> necessary on 32bits mode.
>>
>> Do you speak of 32 bit hosts or 32 bit targets?
>
> 32bit mode of x64

There is no such thing as a 32 bit host on x64, only 64-bit hosts that 
haven't turned on long mode.  So printing 64 bits is correct for those.

Paolo

Paolo Bonzini | 1 Nov 11:20 2010
Picon

Re: [PATCH 4/4] target-xxx: Use fprintf_function (format checking)

On 11/01/2010 11:14 AM, Paolo Bonzini wrote:
> There is no such thing as a 32 bit host on x64, only 64-bit hosts that
                                      ^^^^                     ^^^^^

guests

> haven't turned on long mode.  So printing 64 bits is correct for those.

Michael S. Tsirkin | 1 Nov 11:25 2010
Picon

[PATCH] qemu: stop polling non-system fds on vmstop

We should not run any devices while the VM is stopped:
DMA into memory while VM is stopped makes it
hard to debug migration (consequitive saves
result in different files);  Sending while vm is stopped
has an even worse effect as it confuses the bridges
so that they do not know where to send packets.

The following patch addresses this by splitting device and system
io handlers into separate lists. Device handlers are stopped
on vmstop, system handlers keep running.

Signed-off-by: Michael S. Tsirkin <mst <at> redhat.com>
---
 aio.c            |   32 +++++++++++--
 cmd.c            |    8 ++--
 cpus.c           |    2 +-
 migration-exec.c |    4 +-
 migration-fd.c   |    4 +-
 migration-tcp.c  |    8 ++--
 migration-unix.c |    8 ++--
 migration.c      |    8 ++--
 qemu-aio.h       |    7 +++
 qemu-char.h      |    5 ++
 qemu-kvm.c       |    2 +-
 qemu-tool.c      |    9 ++++
 vl.c             |  136 +++++++++++++++++++++++++++++++++++-------------------
 13 files changed, 160 insertions(+), 73 deletions(-)

diff --git a/aio.c b/aio.c
index 2f08655..0d50c87 100644
(Continue reading)


Gmane