Aurelien Jarno | 1 Nov 2008 01:53

[5584] qemu-char: include hw/baum.h

Revision: 5584
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5584
Author:   aurel32
Date:     2008-11-01 00:53:09 +0000 (Sat, 01 Nov 2008)

Log Message:
-----------
qemu-char: include hw/baum.h

Fix a warning introduced in r5580 when brlapi is enabled.

Signed-off-by: Aurelien Jarno <aurelien <at> aurel32.net>

Modified Paths:
--------------
    trunk/qemu-char.c

Modified: trunk/qemu-char.c
===================================================================
--- trunk/qemu-char.c	2008-10-31 20:34:40 UTC (rev 5583)
+++ trunk/qemu-char.c	2008-11-01 00:53:09 UTC (rev 5584)
 <at>  <at>  -28,6 +28,8  <at>  <at> 
 #include "qemu-timer.h"
 #include "qemu-char.h"
 #include "block.h"
+#include "hw/usb.h"
+#include "hw/baum.h"

 #include <unistd.h>
 #include <fcntl.h>
(Continue reading)

Aurelien Jarno | 1 Nov 2008 01:53

[5585] Malta & OMAP: add a name to char devices

Revision: 5585
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5585
Author:   aurel32
Date:     2008-11-01 00:53:19 +0000 (Sat, 01 Nov 2008)

Log Message:
-----------
Malta & OMAP: add a name to char devices

(fixes regression introduced by r5575)

Signed-off-by: Aurelien Jarno <aurelien <at> aurel32.net>

Modified Paths:
--------------
    trunk/hw/mips_malta.c
    trunk/hw/omap1.c
    trunk/hw/omap2.c

Modified: trunk/hw/mips_malta.c
===================================================================
--- trunk/hw/mips_malta.c	2008-11-01 00:53:09 UTC (rev 5584)
+++ trunk/hw/mips_malta.c	2008-11-01 00:53:19 UTC (rev 5585)
 <at>  <at>  -435,7 +435,7  <at>  <at> 
     cpu_register_physical_memory(base, 0x900, malta);
     cpu_register_physical_memory(base + 0xa00, 0x100000 - 0xa00, malta);

-    s->display = qemu_chr_open("vc:320x200");
+    s->display = qemu_chr_open("fpga", "vc:320x200");
     qemu_chr_printf(s->display, "\e[HMalta LEDBAR\r\n");
(Continue reading)

Aurelien Jarno | 1 Nov 2008 01:54

[5590] target-ppc: convert arithmetic functions to TCG

Revision: 5590
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5590
Author:   aurel32
Date:     2008-11-01 00:54:12 +0000 (Sat, 01 Nov 2008)

Log Message:
-----------
target-ppc: convert arithmetic functions to TCG

Signed-off-by: Aurelien Jarno <aurelien <at> aurel32.net>

Modified Paths:
--------------
    trunk/target-ppc/helper.h
    trunk/target-ppc/op.c
    trunk/target-ppc/op_helper.c
    trunk/target-ppc/op_helper.h
    trunk/target-ppc/translate.c

Modified: trunk/target-ppc/helper.h
===================================================================
--- trunk/target-ppc/helper.h	2008-11-01 00:53:59 UTC (rev 5589)
+++ trunk/target-ppc/helper.h	2008-11-01 00:54:12 UTC (rev 5590)
 <at>  <at>  -8,6 +8,12  <at>  <at> 
 DEF_HELPER(uint32_t, helper_load_cr, (void))
 DEF_HELPER(void, helper_store_cr, (target_ulong, uint32_t))
 
+#if defined(TARGET_PPC64)
+DEF_HELPER(uint64_t, helper_mulhd, (uint64_t, uint64_t))
+DEF_HELPER(uint64_t, helper_mulhdu, (uint64_t, uint64_t))
(Continue reading)

Aurelien Jarno | 1 Nov 2008 01:54

[5589] target-ppc: xer access prototypes no more used & implemented

Revision: 5589
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5589
Author:   aurel32
Date:     2008-11-01 00:53:59 +0000 (Sat, 01 Nov 2008)

Log Message:
-----------
target-ppc: xer access prototypes no more used & implemented

Revision 5500 of the qemu repository removed all code using
ppc_load_xer & ppc_store_xer as well as their implementation.

Another patch fixes it's usage in kvm-userspace for powerpc, but I think
that header can now be cleaned up, therefore this patch to qemu-devel.

Signed-off-by: Christian Ehrhardt <ehrhardt <at> linux.vnet.ibm.com>
Signed-off-by: Aurelien Jarno <aurelien <at> aurel32.net>

Revision Links:
--------------
    http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5500

Modified Paths:
--------------
    trunk/target-ppc/cpu.h

Modified: trunk/target-ppc/cpu.h
===================================================================
--- trunk/target-ppc/cpu.h	2008-11-01 00:53:48 UTC (rev 5588)
+++ trunk/target-ppc/cpu.h	2008-11-01 00:53:59 UTC (rev 5589)
(Continue reading)

Aurelien Jarno | 1 Nov 2008 01:54

[5591] target-ppc: convert 405 MAC instructions to TCG

Revision: 5591
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5591
Author:   aurel32
Date:     2008-11-01 00:54:23 +0000 (Sat, 01 Nov 2008)

Log Message:
-----------
target-ppc: convert 405 MAC instructions to TCG

Signed-off-by: Aurelien Jarno <aurelien <at> aurel32.net>

Modified Paths:
--------------
    trunk/target-ppc/op.c
    trunk/target-ppc/op_helper.c
    trunk/target-ppc/op_helper.h
    trunk/target-ppc/translate.c

Modified: trunk/target-ppc/op.c
===================================================================
--- trunk/target-ppc/op.c	2008-11-01 00:54:12 UTC (rev 5590)
+++ trunk/target-ppc/op.c	2008-11-01 00:54:23 UTC (rev 5591)
 <at>  <at>  -326,34 +326,6  <at>  <at> 
     RETURN();
 }

-/***                           Integer arithmetic                          ***/
-/* add */
-void OPPROTO op_check_addo (void)
-{
(Continue reading)

Aurelien Jarno | 1 Nov 2008 01:54

[5592] target-ppc: optimize popcntb

Revision: 5592
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5592
Author:   aurel32
Date:     2008-11-01 00:54:33 +0000 (Sat, 01 Nov 2008)

Log Message:
-----------
target-ppc: optimize popcntb

Suggested by Andrzej Zaborowski.

Signed-off-by: Aurelien Jarno <aurelien <at> aurel32.net>

Modified Paths:
--------------
    trunk/target-ppc/op_helper.c

Modified: trunk/target-ppc/op_helper.c
===================================================================
--- trunk/target-ppc/op_helper.c	2008-11-01 00:54:23 UTC (rev 5591)
+++ trunk/target-ppc/op_helper.c	2008-11-01 00:54:33 UTC (rev 5592)
 <at>  <at>  -222,25 +222,19  <at>  <at> 

 target_ulong helper_popcntb (target_ulong val)
 {
-    uint32_t ret;
-    int i;
-
-    ret = 0;
-    for (i = 0; i < 32; i += 8)
(Continue reading)

Aurelien Jarno | 1 Nov 2008 01:53

[5587] CVE-2008-4539: fix a heap overflow in Cirrus emulation

Revision: 5587
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5587
Author:   aurel32
Date:     2008-11-01 00:53:39 +0000 (Sat, 01 Nov 2008)

Log Message:
-----------
CVE-2008-4539: fix a heap overflow in Cirrus emulation

The code in hw/cirrus_vga.c has changed a lot between CVE-2007-1320 has
been announced and the patch has been applied. As a consequence it has
wrongly applied and QEMU is still vulnerable to this bug if using VNC.

(noticed by Jan Niehusmann)

Signed-off-by: Aurelien Jarno <aurelien <at> aurel32.net>

Modified Paths:
--------------
    trunk/hw/cirrus_vga.c

Modified: trunk/hw/cirrus_vga.c
===================================================================
--- trunk/hw/cirrus_vga.c	2008-11-01 00:53:30 UTC (rev 5586)
+++ trunk/hw/cirrus_vga.c	2008-11-01 00:53:39 UTC (rev 5587)
 <at>  <at>  -785,15 +785,14  <at>  <at> 

 static int cirrus_bitblt_videotovideo_copy(CirrusVGAState * s)
 {
+    if (BLTUNSAFE(s))
(Continue reading)

Aurelien Jarno | 1 Nov 2008 02:00

Re: [PATCH 1/3] qemu: ppc: define maximum SMP limit as 1 for Bamboo

On Tue, Oct 28, 2008 at 10:08:20AM +0100, ehrhardt <at> linux.vnet.ibm.com wrote:
> From: Christian Ehrhardt <ehrhardt <at> linux.vnet.ibm.com>
> 
> Fix for qemu runtime error. Full error message:
> Number of SMP cpus requested (1), exceeds max cpus supported by machine `bamboo' (0)

The default max number of CPU has been set to 1 in revision 5566, so
this patch is not necessary anymore.

> Signed-off-by: Christian Ehrhardt <ehrhardt <at> linux.vnet.ibm.com>
> Signed-off-by: Hollis Blanchard <hollisb <at> us.ibm.com>
> ---
> 
> [diffstat]
>  ppc440_bamboo.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> [diff]
> diff --git a/qemu/hw/ppc440_bamboo.c b/qemu/hw/ppc440_bamboo.c
> --- a/qemu/hw/ppc440_bamboo.c
> +++ b/qemu/hw/ppc440_bamboo.c
>  <at>  <at>  -203,7 +203,8  <at>  <at>  void bamboo_init(ram_addr_t ram_size, in
>  }
> 
>  QEMUMachine bamboo_machine = {
> -	"bamboo",
> -	"bamboo",
> -	bamboo_init,
> +	.name = "bamboo",
> +	.desc = "bamboo",
(Continue reading)

Aurelien Jarno | 1 Nov 2008 01:53

[5586] target-cris: access to TCG variables through GET_TCGV()

Revision: 5586
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5586
Author:   aurel32
Date:     2008-11-01 00:53:30 +0000 (Sat, 01 Nov 2008)

Log Message:
-----------
target-cris: access to TCG variables through GET_TCGV()

Fix build with DEBUG_TCGV enabled.

Signed-off-by: Aurelien Jarno <aurelien <at> aurel32.net>

Modified Paths:
--------------
    trunk/target-cris/translate.c

Modified: trunk/target-cris/translate.c
===================================================================
--- trunk/target-cris/translate.c	2008-11-01 00:53:19 UTC (rev 5585)
+++ trunk/target-cris/translate.c	2008-11-01 00:53:30 UTC (rev 5586)
 <at>  <at>  -951,7 +951,7  <at>  <at> 
 			tcg_gen_andi_tl(d, d, ~0xffff);
 		tcg_gen_or_tl(d, d, tmp);
 	}
-	if (tmp != d)
+	if (GET_TCGV(tmp) != GET_TCGV(d))
 		tcg_temp_free(tmp);
 }

(Continue reading)

Aurelien Jarno | 1 Nov 2008 01:54

Re: [5506] target-ppc: convert logical instructions to TCG

On Thu, Oct 30, 2008 at 04:10:55AM +0100, andrzej zaborowski wrote:
> Hi,
> 
> 2008/10/21 Aurelien Jarno <aurelien <at> aurel32.net>:
> > -void do_popcntb (void)
> > +target_ulong helper_popcntb (target_ulong val)
> >  {
> >     uint32_t ret;
> >     int i;
> >
> >     ret = 0;
> >     for (i = 0; i < 32; i += 8)
> > -        ret |= ctpop8((T0 >> i) & 0xFF) << i;
> > -    T0 = ret;
> > +        ret |= ctpop8((val >> i) & 0xFF) << i;
> > +    return ret;
> >  }
> >
> >  #if defined(TARGET_PPC64)
> > -void do_popcntb_64 (void)
> > +target_ulong helper_popcntb_64 (target_ulong val)
> >  {
> >     uint64_t ret;
> >     int i;
> >
> >     ret = 0;
> >     for (i = 0; i < 64; i += 8)
> > -        ret |= ctpop8((T0 >> i) & 0xFF) << i;
> > -    T0 = ret;
> > +        ret |= ctpop8((val >> i) & 0xFF) << i;
(Continue reading)


Gmane