zhang bo | 25 Apr 08:10 2015

[libvirt] [PATCH] typo: fix typo error in virLXCControllerSetupResourceLimits

iff -> if
rather then -> rather than

Signed-off-by: YueWenyuan <yuewenyuan <at> huawei.com>
---
 src/lxc/lxc_controller.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index e144c2d..7ad9d50 100644
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
 <at>  <at>  -745,9 +745,9  <at>  <at>  static int virLXCControllerSetupResourceLimits(virLXCControllerPtr ctrl)

     if (mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
         virCgroupControllerAvailable(VIR_CGROUP_CONTROLLER_CPUSET)) {
-        /* Use virNuma* API iff necessary. Once set and child is exec()-ed,
+        /* Use virNuma* API if necessary. Once set and child is exec()-ed,
          * there's no way for us to change it. Rely on cgroups (if available
-         * and enabled in the config) rather then virNuma*. */
+         * and enabled in the config) rather than virNuma*. */
         VIR_DEBUG("Relying on CGroups for memory binding");
     } else {

--

-- 
1.7.12.4

Jim Fehlig | 24 Apr 22:35 2015

[libvirt] [PATCH] libxl: initialize sdl.opengl defbool in libxlMakeVfb

Commit bf32462b missed initializing sdl.opengl.  Without the
initialization, libvirtd will be terminated by an assert from libxl:

Assertion `!libxl_defbool_is_default(db)' failed.

Reported-by: Olaf Hering <olaf <at> aepfle.de>
Signed-off-by: Jim Fehlig <jfehlig <at> suse.com>
---

Perhaps bending the "trivial rule" a bit, but this patch is trivial
and should have been included in bf32462b.  I simply forgot to
add initialization of sdl.opengl before pushing bf32462b.  I'll push
this fix shortly.

 src/libxl/libxl_conf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 55bd21b..53f327b 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
 <at>  <at>  -1243,6 +1243,7  <at>  <at>  libxlMakeVfb(virPortAllocatorPtr graphicsports,
         case VIR_DOMAIN_GRAPHICS_TYPE_SDL:
             libxl_defbool_set(&x_vfb->sdl.enable, 1);
             libxl_defbool_set(&x_vfb->vnc.enable, 0);
+            libxl_defbool_set(&x_vfb->sdl.opengl, 0);
             if (VIR_STRDUP(x_vfb->sdl.display, l_vfb->data.sdl.display) < 0)
                 return -1;
             if (VIR_STRDUP(x_vfb->sdl.xauthority, l_vfb->data.sdl.xauth) < 0)
--

-- 
(Continue reading)

VHPC 15 | 24 Apr 21:33 2015
Picon

[libvirt] CfP Virtualization in High-Performance Cloud Computing Workshop (VHPC '15)



=================================================================

CALL FOR PAPERS


10th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '15)


held in conjunction with Euro-Par 2015, August 24-28, Vienna, Austria


(Springer LNCS)

=================================================================


Date: August 25, 2015

Workshop URL: http://vhpc.org


Paper Submission Deadline: May 22, 2015



CALL FOR PAPERS


Virtualization technologies constitute a key enabling factor for flexible resource

management in modern data centers, cloud environments, and increasingly in

HPC as well. Providers need to dynamically manage complex infrastructures in a

seamless fashion for varying workloads and hosted applications, independently of

the customers deploying software or users submitting highly dynamic and

heterogeneous workloads. Thanks to virtualization, we have the ability to manage

vast computing and networking resources dynamically and close to the marginal

cost of providing the services, which is unprecedented in the history of scientific

and commercial computing.



Docker et al. OS-level virtualization, with its capability to isolate multiple user-space

environments allows for their co-existence within the same OS kernel. It

promises to provide many of the advantages of machine virtualization with high
levels of responsiveness and performance; coupled with lightweight OSs it forms a

potent architecture with promise to become a mainstream environment

for HPC workloads.


Machine virtualization, with its capability to enable consolidation of multiple

under-utilized servers with heterogeneous software and operating systems (OSes),

and its capability to live-migrate a fully operating virtual machine (VM) with a very

short downtime, enables novel and dynamic ways to manage physical servers;

I/O Virtualization allows physical network adapters to take traffic from multiple VMs;

network virtualization, with its capability to create logical network overlays that

are independent of the underlying physical topology and IP addressing, provides

the fundamental ground on top of which evolved network services can be realized

with an unprecedented level of dynamicity and flexibility; These technologies

have to be inter-mixed and integrated in an intelligent way, to support

workloads that are increasingly demanding in terms of absolute performance,

responsiveness and interactivity, and have to respect well-specified Service-

Level Agreements (SLAs), as needed for industrial-grade provided services.


The Workshop on Virtualization in High-Performance Cloud Computing (VHPC)

aims to bring together researchers and industrial practitioners facing the challenges

posed by virtualization in order to foster discussion, collaboration, mutual exchange

of knowledge and experience, enabling research to ultimately provide novel

solutions for virtualized computing systems of tomorrow.


The workshop will be one day in length, composed of 20 min paper presentations,

each followed by 10 min discussion sections, and lightning talks, limited to 5

minutes. Presentations may be accompanied by interactive demonstrations.


TOPICS


Topics of interest include, but are not limited to:


- Virtualization in supercomputing environments, HPC clusters, cloud HPC and grids

- OS-level virtualization including container runtimes (Docker, rkt et al.)

- Lightweight compute node operating systems/VMMs

- Optimizations of virtual machine monitor platforms, hypervisors and

- Hypervisor and network virtualization QoS and SLAs

- Cloud based network and system management for SDN and NFV

- Management, deployment and monitoring of virtualized environments

- Performance measurement, modelling and monitoring of virtualized/cloud workloads

- Programming models for virtualized environments

- Cloud reliability, fault-tolerance, high-availability and security

- Heterogeneous virtualized environments, virtualized accelerators, GPUs and co-processors

- Optimized communication libraries/protocols in the cloud and for HPC in the cloud

- Topology management and optimization for distributed virtualized applications

- Cluster provisioning in the cloud and cloud bursting

- Adaptation of emerging HPC technologies (high performance networks, RDMA, etc..)

- I/O and storage virtualization, virtualization aware file systems

- Job scheduling/control/policy in virtualized environments

- Checkpointing and migration of VM-based large compute jobs

- Cloud frameworks and APIs

- Energy-efficient / power-aware virtualization



Important Dates


April 29, 2015 - Abstract registration

May 22, 2015 - Full paper submission

June 19, 2015 - Acceptance notification

October 2, 2015 - Camera-ready version due


August 25, 2015 - Workshop Date



TPC


CHAIR


Michael Alexander (chair), TU Wien, Austria

Anastassios Nanos (co-chair), NTUA, Greece

Balazs Gerofi (co-chair), RIKEN Advanced Institute for Computational Science, Japan



PROGRAM COMMITTEE

Stergios Anastasiadis, University of Ioannina, Greece

Costas Bekas, IBM Zurich Research Laboratory, Switzerland

Jakob Blomer, CERN

Ron Brightwell, Sandia National Laboratories, USA

Roberto Canonico, University of Napoli Federico II, Italy

Julian Chesterfield, OnApp, UK

Patrick Dreher, MIT, USA

William Gardner, University of Guelph, Canada

Kyle Hale, Northwestern University, USA

Marcus Hardt, Karlsruhe Institute of Technology, Germany

Iftekhar Hussain, Infinera, USA

Krishna Kant, Temple University, USA

Eiji Kawai, National Institute of Information and Communications Technology, Japan

Romeo Kinzler, IBM, Switzerland

Kornilios Kourtis, ETH, Switzerland

Nectarios Koziris, National Technical University of Athens, Greece

Massimo Lamanna, CERN

Che-Rung Roger Lee, National Tsing Hua University, Taiwan

William Magato, University of Cincinnati, USA

Helge Meinhard, CERN

Jean-Marc Menaud, Ecole des Mines de Nantes France

Christine Morin, INRIA, France

Amer Qouneh, University of Florida, USA

Seetharami Seelam, IBM Watson Research Center, USA

Josh Simons, VMWare, USA

Borja Sotomayor, University of Chicago, USA

Kurt Tutschku, Blekinge Institute of Technology, Sweden

Yasuhiro Watashiba, Osaka University, Japan

Chao-Tung Yang, Tunghai University, Taiwan



PAPER SUBMISSION-PUBLICATION


Papers submitted to the workshop will be reviewed by at least two

members of the program committee and external reviewers. Submissions

should include abstract, key words, the e-mail address of the

corresponding author, and must not exceed 10 pages, including tables

and figures at a main font size no smaller than 11 point. Submission

of a paper should be regarded as a commitment that, should the paper

be accepted, at least one of the authors will register and attend the

conference to present the work.


Accepted papers will be published in the Springer LNCS series - the

format must be according to the Springer LNCS Style. Initial

submissions are in PDF; authors of accepted papers will be requested

to provide source files.


Format Guidelines:

http://www.springer.de/comp/lncs/authors.html


Submission Link:

https://easychair.org/conferences/?conf=europar2015ws


GENERAL INFORMATION


The workshop is one day in length and will be held in conjunction with
Euro-Par 2015, 24-28 August, Vienna, Austria


<div><div dir="ltr">
<br class=""><br><p dir="ltr"><span>=================================================================</span></p>
<p dir="ltr"><span>CALL FOR PAPERS </span></p>
<br><p dir="ltr"><span>10th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '15)</span></p>
<br><p dir="ltr"><span>held in conjunction with Euro-Par 2015, August 24-28, Vienna, Austria</span></p>
<br><p dir="ltr"><span>(Springer LNCS)</span></p>
<p dir="ltr"><span>=================================================================</span></p>
<br><p dir="ltr"><span>Date: August 25, 2015</span></p>
<p dir="ltr"><span>Workshop URL: </span><a href="http://vhpc.org/"><span>http://vhpc.org</span></a></p>
<br><p dir="ltr"><span>Paper Submission Deadline: May 22, 2015</span></p>
<br><br><p dir="ltr"><span>CALL FOR PAPERS</span></p>
<br><p dir="ltr"><span>Virtualization technologies constitute a key enabling factor for flexible resource</span></p>
<p dir="ltr"><span>management in modern data centers, </span><span>cloud environments, and increasingly in </span></p>
<p dir="ltr"><span>HPC as well.</span><span> Providers need to dynamically manage complex infrastructures in a</span></p>
<p dir="ltr"><span>seamless fashion for varying workloads and hosted applications, independently of</span></p>
<p dir="ltr"><span>the customers deploying software or users submitting highly dynamic and</span></p>
<p dir="ltr"><span>heterogeneous workloads. Thanks to virtualization, we have the ability to manage</span></p>
<p dir="ltr"><span>vast computing and networking resources dynamically and close to the marginal</span></p>
<p dir="ltr"><span>cost of providing the services, which is unprecedented in the history of scientific</span></p>
<p dir="ltr"><span>and commercial computing. </span></p>
<br><br><p dir="ltr"><span>Docker et al. OS-level virtualization, with its capability to isolate multiple user-space</span></p>
<p dir="ltr"><span>environments allows for their co-existence within the same OS kernel. It</span></p>
<p dir="ltr"><span>promises to provide many of the advantages of machine virtualization with high</span><span><br class=""></span><span>levels of responsiveness and performance; coupled with lightweight OSs it forms a </span></p>
<p dir="ltr"><span>potent architecture with promise to become a mainstream environment </span></p>
<p dir="ltr"><span>for HPC workloads. </span></p>
<br><p dir="ltr"><span>Machine virtualization, with its capability to enable consolidation of multiple</span></p>
<p dir="ltr"><span>under-utilized servers with heterogeneous software and operating systems (OSes),</span></p>
<p dir="ltr"><span>and its capability to live-migrate a fully operating virtual machine (VM) with a very</span></p>
<p dir="ltr"><span>short downtime, enables novel and dynamic ways to manage physical servers;</span><span><br class=""><br class=""></span></p>
<p dir="ltr"><span>I/O Virtualization allows physical network adapters to take traffic from multiple VMs; </span></p>
<p dir="ltr"><span>network virtualization, with its capability to create logical network overlays that</span></p>
<p dir="ltr"><span>are independent of the underlying physical topology and IP addressing, provides</span></p>
<p dir="ltr"><span>the fundamental ground on top of which evolved network services can be realized</span></p>
<p dir="ltr"><span>with an unprecedented level of dynamicity and flexibility; These technologies</span></p>
<p dir="ltr"><span>have to be inter-mixed and integrated in an intelligent way, to support</span></p>
<p dir="ltr"><span>workloads that are increasingly demanding in terms of absolute performance,</span></p>
<p dir="ltr"><span>responsiveness and interactivity, and have to respect well-specified Service-</span></p>
<p dir="ltr"><span>Level Agreements (SLAs), as needed for industrial-grade provided services.</span></p>
<br><p dir="ltr"><span>The Workshop on Virtualization in High-Performance Cloud Computing (VHPC)</span></p>
<p dir="ltr"><span>aims to bring together researchers and industrial practitioners facing the challenges</span></p>
<p dir="ltr"><span>posed by virtualization in order to foster discussion, collaboration, mutual exchange</span></p>
<p dir="ltr"><span>of knowledge and experience, enabling research to ultimately provide novel</span></p>
<p dir="ltr"><span>solutions for virtualized computing systems of tomorrow.</span></p>
<br><p dir="ltr"><span>The workshop will be one day in length, composed of 20 min paper presentations,</span></p>
<p dir="ltr"><span>each followed by 10 min discussion sections, and lightning talks, limited to 5</span></p>
<p dir="ltr"><span>minutes. Presentations may be accompanied by interactive demonstrations.</span></p>
<br><p dir="ltr"><span>TOPICS</span></p>
<br><p dir="ltr"><span>Topics of interest include, but are not limited to:</span></p>
<br><p dir="ltr"><span>- Virtualization in supercomputing environments, HPC clusters, cloud HPC and grids </span></p>
<p dir="ltr"><span>- OS-level virtualization including container runtimes (Docker, rkt et al.) </span></p>
<p dir="ltr"><span>- Lightweight compute node operating systems/VMMs</span></p>
<p dir="ltr"><span>- Optimizations of virtual machine monitor platforms, hypervisors and </span></p>
<p dir="ltr"><span>- Hypervisor and network virtualization QoS and SLAs</span></p>
<p dir="ltr"><span>- Cloud based network and system management for SDN and NFV</span></p>
<p dir="ltr"><span>- Management, deployment and monitoring of virtualized environments</span></p>
<p dir="ltr"><span>- Performance measurement, modelling and monitoring of virtualized/cloud workloads</span></p>
<p dir="ltr"><span>- </span><span>Programming models for virtualized environments</span></p>
<p dir="ltr"><span>- Cloud reliability, fault-tolerance, high-availability and security</span></p>
<p dir="ltr"><span>- Heterogeneous virtualized environments, virtualized accelerators, GPUs and co-processors </span></p>
<p dir="ltr"><span>- Optimized communication libraries/protocols in the cloud and for HPC in the cloud</span></p>
<p dir="ltr"><span>- Topology management and optimization for distributed virtualized applications</span></p>
<p dir="ltr"><span>- Cluster provisioning in the cloud and cloud bursting</span></p>
<p dir="ltr"><span>- Adaptation of emerging HPC technologies (high performance networks, RDMA, etc..)</span></p>
<p dir="ltr"><span>- I/O and storage virtualization, virtualization aware file systems</span></p>
<p dir="ltr"><span>- Job scheduling/control/policy in virtualized environments</span></p>
<p dir="ltr"><span>- Checkpointing and migration of VM-based large compute jobs</span></p>
<p dir="ltr"><span>- Cloud frameworks and APIs</span></p>
<p dir="ltr"><span>- Energy-efficient / power-aware virtualization</span></p>
<br><br><p dir="ltr"><span>Important Dates</span></p>
<br><p dir="ltr"><span>April 29, 2015 - Abstract registration</span></p>
<p dir="ltr"><span>May 22, 2015 - Full paper submission</span></p>
<p dir="ltr"><span>June 19, 2015 - Acceptance notification</span></p>
<p dir="ltr"><span>October 2, 2015 - Camera-ready version due</span></p>
<br><p dir="ltr"><span>August 25, 2015 - Workshop Date</span></p>
<br><br><p dir="ltr"><span>TPC</span></p>
<br><p dir="ltr"><span>CHAIR</span></p>
<br><p dir="ltr"><span>Michael Alexander (chair), TU Wien, Austria</span></p>
<p dir="ltr"><span>Anastassios Nanos (co-chair), NTUA, Greece</span></p>
<p dir="ltr"><span>Balazs Gerofi (co-chair), RIKEN Advanced Institute for Computational Science, Japan</span></p>
<br><br><p dir="ltr"><span>PROGRAM COMMITTEE </span></p>
<p dir="ltr"><span>Stergios Anastasiadis, University of Ioannina, Greece</span></p>
<p dir="ltr"><span>Costas Bekas, IBM Zurich Research Laboratory, Switzerland</span></p>
<p dir="ltr"><span>Jakob Blomer, CERN</span></p>
<p dir="ltr"><span>Ron Brightwell, Sandia National Laboratories, USA</span></p>
<p dir="ltr"><span>Roberto Canonico, University of Napoli Federico II, Italy</span></p>
<p dir="ltr"><span>Julian Chesterfield, OnApp, UK</span></p>
<p dir="ltr"><span>Patrick Dreher, MIT, USA</span></p>
<p dir="ltr"><span>William Gardner, University of Guelph, Canada</span></p>
<p dir="ltr"><span>Kyle Hale, Northwestern University, USA</span></p>
<p dir="ltr"><span>Marcus Hardt, Karlsruhe Institute of Technology, Germany</span></p>
<p dir="ltr"><span>Iftekhar Hussain, Infinera, USA</span></p>
<p dir="ltr"><span>Krishna Kant, Temple University, USA</span></p>
<p dir="ltr"><span>Eiji Kawai, National Institute of Information and Communications Technology, Japan</span></p>
<p dir="ltr"><span>Romeo Kinzler, IBM, Switzerland</span></p>
<p dir="ltr"><span>Kornilios Kourtis, ETH, Switzerland</span></p>
<p dir="ltr"><span>Nectarios Koziris, National Technical University of Athens, Greece</span></p>
<p dir="ltr"><span>Massimo Lamanna, CERN</span></p>
<p dir="ltr"><span>Che-Rung Roger Lee, National Tsing Hua University, Taiwan</span></p>
<p dir="ltr"><span>William Magato, University of Cincinnati, USA</span></p>
<p dir="ltr"><span>Helge Meinhard, CERN</span></p>
<p dir="ltr"><span>Jean-Marc Menaud, Ecole des Mines de Nantes France</span></p>
<p dir="ltr"><span>Christine Morin, INRIA, France</span></p>
<p dir="ltr"><span>Amer Qouneh, University of Florida, USA</span></p>
<p dir="ltr"><span>Seetharami Seelam, IBM Watson Research Center, USA</span></p>
<p dir="ltr"><span>Josh Simons, VMWare, USA</span></p>
<p dir="ltr"><span>Borja Sotomayor, University of Chicago, USA</span></p>
<p dir="ltr"><span>Kurt Tutschku, Blekinge Institute of Technology, Sweden</span></p>
<p dir="ltr"><span>Yasuhiro Watashiba, Osaka University, Japan</span></p>
<p dir="ltr"><span>Chao-Tung Yang, Tunghai University, Taiwan</span></p>
<br><br><p dir="ltr"><span>PAPER SUBMISSION-PUBLICATION</span></p>
<br><p dir="ltr"><span>Papers submitted to the workshop will be reviewed by at least two</span></p>
<p dir="ltr"><span>members of the program committee and external reviewers. Submissions</span></p>
<p dir="ltr"><span>should include abstract, key words, the e-mail address of the</span></p>
<p dir="ltr"><span>corresponding author, and must not exceed 10 pages, including tables</span></p>
<p dir="ltr"><span>and figures at a main font size no smaller than 11 point. Submission</span></p>
<p dir="ltr"><span>of a paper should be regarded as a commitment that, should the paper</span></p>
<p dir="ltr"><span>be accepted, at least one of the authors will register and attend the</span></p>
<p dir="ltr"><span>conference to present the work.</span></p>
<br><p dir="ltr"><span>Accepted papers will be published in the Springer LNCS series - the</span></p>
<p dir="ltr"><span>format must be according to the Springer LNCS Style. Initial</span></p>
<p dir="ltr"><span>submissions are in PDF; authors of accepted papers will be requested</span></p>
<p dir="ltr"><span>to provide source files.</span></p>
<br><p dir="ltr"><span>Format Guidelines:</span></p>
<p dir="ltr"><span><a href="http://www.springer.de/comp/lncs/authors.html">http://www.springer.de/comp/lncs/authors.html</a></span></p>
<br><p dir="ltr"><span>Submission Link:</span></p>
<p dir="ltr"><a href="https://easychair.org/conferences/?conf=europar2015ws"><span>https://easychair.org/conferences/?conf=europar2015ws</span></a></p>
<br><p dir="ltr"><span>GENERAL INFORMATION</span></p>
<br><p dir="ltr"><span>The workshop is one day in length and will be held in conjunction with</span><span><br class=""></span><span>Euro-Par 2015, 24-28 August, Vienna, Austria</span></p>
<div><span><br></span></div>
</div></div>
John Ferlan | 24 Apr 20:02 2015
Picon

[libvirt] [PATCH] storage: Resolve Coverity UNINIT

commit id '1e13eff4' didn't init found when changed from a bool to
an int in virStoragePoolFCRefreshThread and Coverity...

Signed-off-by: John Ferlan <jferlan <at> redhat.com>
---
 src/storage/storage_backend_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backend_scsi.c
index f381ddb..e6c8bb5 100644
--- a/src/storage/storage_backend_scsi.c
+++ b/src/storage/storage_backend_scsi.c
 <at>  <at>  -581,7 +581,7  <at>  <at>  virStoragePoolFCRefreshThread(void *opaque)
     const char *name = cbdata->name;
     virStoragePoolObjPtr pool = cbdata->pool;
     unsigned int host;
-    int found;
+    int found = 0;
     int tries = 2;

     do {
--

-- 
2.1.0

Roman Bogorodskiy | 24 Apr 18:55 2015
Picon

[libvirt] [PATCH] bhyve: fix build in tests

Commit ca32929 caused build errors in bhyvexml2argvtest.c because of
some undefined variables.

Pushing under the build breaker rule.
---
 tests/bhyvexml2argvtest.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c
index 1cce2aa..1c7bc31 100644
--- a/tests/bhyvexml2argvtest.c
+++ b/tests/bhyvexml2argvtest.c
 <at>  <at>  -19,7 +19,6  <at>  <at>  static int testCompareXMLToArgvFiles(const char *xml,
                                      const char *ldcmdline,
                                      const char *dmcmdline)
 {
-    int len;
     char *actualargv = NULL, *actualld = NULL, *actualdm = NULL;
     virDomainDefPtr vmdef = NULL;
     virDomainObj vm;
 <at>  <at>  -59,9 +58,6  <at>  <at>  static int testCompareXMLToArgvFiles(const char *xml,
     if (virtTestCompareToFile(actualld, ldcmdline) < 0)
         goto out;

-    if (virtTestCompareToFile(formatted, xml) < 0)
-        goto out;
-
     if (virFileExists(dmcmdline) || actualdm) {
         if (virtTestCompareToFile(actualdm, dmcmdline) < 0)
             goto out;
--

-- 
2.3.5

John Ferlan | 24 Apr 18:05 2015
Picon

[libvirt] [PATCH v5 00/10] Implement Add/Del IOThreads

v4 here:
http://www.redhat.com/archives/libvir-list/2015-April/msg01008.html

I was asked to post a complete series by Peter, so rather than repeat
v5 changes described here:

http://www.redhat.com/archives/libvir-list/2015-April/msg01192.html

John Ferlan (10):
  conf: Add new domain XML element 'iothreadids'
  qemu: Use domain iothreadids to IOThread's 'thread_id'
  conf: Move virDomainPinIsDuplicate and make static
  Move iothreadspin information into iothreadids
  conf: Adjust the iothreadsched expectations
  Implement virDomainAddIOThread and virDomainDelIOThread
  remote: Add support for AddIOThread and DelIOThread
  domain: Introduce virDomainIOThreadSchedDelId
  qemu: Add support to Add/Delete IOThreads
  virsh: Add iothreadadd and iothreaddel commands

 docs/formatdomain.html.in                          |  56 ++-
 docs/schemas/domaincommon.rng                      |  12 +
 include/libvirt/libvirt-domain.h                   |   6 +
 src/conf/domain_audit.c                            |   9 +
 src/conf/domain_audit.h                            |   6 +
 src/conf/domain_conf.c                             | 359 ++++++++++++---
 src/conf/domain_conf.h                             |  27 +-
 src/driver-hypervisor.h                            |  12 +
 src/libvirt-domain.c                               | 118 +++++
 src/libvirt_private.syms                           |   7 +-
 src/libvirt_public.syms                            |   6 +
 src/qemu/qemu_cgroup.c                             |  34 +-
 src/qemu/qemu_command.c                            |  38 +-
 src/qemu/qemu_command.h                            |   3 +
 src/qemu/qemu_domain.c                             |  36 --
 src/qemu/qemu_domain.h                             |   3 -
 src/qemu/qemu_driver.c                             | 486 +++++++++++++++++----
 src/qemu/qemu_process.c                            |  43 +-
 src/remote/remote_driver.c                         |   2 +
 src/remote/remote_protocol.x                       |  30 +-
 src/remote_protocol-structs                        |  12 +
 .../qemuxml2argv-cputune-iothreadsched-toomuch.xml |   3 +-
 .../qemuxml2argv-iothreads-ids-partial.args        |  10 +
 .../qemuxml2argv-iothreads-ids-partial.xml         |  33 ++
 .../qemuxml2argv-iothreads-ids.args                |   8 +
 .../qemuxml2argv-iothreads-ids.xml                 |  33 ++
 tests/qemuxml2argvtest.c                           |   2 +
 .../qemuxml2xmlout-cputune-iothreads.xml           |   2 +-
 tests/qemuxml2xmltest.c                            |   2 +
 tools/virsh-domain.c                               | 164 +++++++
 tools/virsh.pod                                    |  31 ++
 31 files changed, 1333 insertions(+), 260 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.xml

--

-- 
2.1.0

Olaf Hering | 24 Apr 18:01 2015
Picon

[libvirt] [PATCH] libxl: remove duplicate check for pci subsystem type

Both attach and detach functions get called only if the type matches.

Signed-off-by: Olaf Hering <olaf <at> aepfle.de>
Cc: Jim Fehlig <jfehlig <at> suse.com>
---
 src/libxl/libxl_driver.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index d76efda..f915f91 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
 <at>  <at>  -2901,9 +2901,6  <at>  <at>  libxlDomainAttachHostPCIDevice(libxlDriverPrivatePtr driver,

     libxl_device_pci_init(&pcidev);

-    if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
-        goto cleanup;
-
     if (virDomainHostdevFind(vm->def, hostdev, &found) >= 0) {
         virReportError(VIR_ERR_OPERATION_FAILED,
                        _("target pci device %.4x:%.2x:%.2x.%.1x already exists"),
 <at>  <at>  -3239,9 +3236,6  <at>  <at>  libxlDomainDetachHostPCIDevice(libxlDriverPrivatePtr driver,

     libxl_device_pci_init(&pcidev);

-    if (subsys->type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
-        goto cleanup;
-
     idx = virDomainHostdevFind(vm->def, hostdev, &detach);
     if (idx < 0) {
         virReportError(VIR_ERR_OPERATION_FAILED,

Peter Krempa | 24 Apr 16:52 2015
Picon

[libvirt] [PATCH 0/5] qemu: Connect to guest agent after channel hotplug

Clean up some parts of the agent code, fix a recently added bug and add support
for guest agent hotplug, all this while removing more lines than adding.

Peter Krempa (5):
  qemu: agent: Reuse virJSONValueObjectCreateVArgs in
    qemuAgentMakeCommand
  qemu: Fix domain object leak in qemuDomainInterfaceAddresses
  qemu: Reuse qemuDomainAgentAvailable in qemuDomainInterfaceAddresses
  qemu: agent: Differentiate errors when the agent channel was
    hotplugged
  qemu: Connect to guest agent after channel hotplug

 src/qemu/qemu_agent.c   | 73 ++-----------------------------------------------
 src/qemu/qemu_domain.c  | 45 +++++++++++++++++++++++++++---
 src/qemu/qemu_domain.h  |  2 ++
 src/qemu/qemu_driver.c  | 56 +++++++++++++++++++++----------------
 src/qemu/qemu_process.c | 22 +--------------
 src/qemu/qemu_process.h |  2 ++
 6 files changed, 81 insertions(+), 119 deletions(-)

--

-- 
2.3.5

Maros Zatko | 24 Apr 14:38 2015
Picon

[libvirt] [PATCH] qemu: detect-zeroes feature for drives

This patch adds support for detect-zeroes feature in QEMU. It's intented to be
used by libguestfs in virt-sparsify tool.

Relates to: RHBZ#1130506

Maros Zatko (1):
  qemu: add support for detect-zeroes feature

 docs/schemas/domaincommon.rng | 12 ++++++++++++
 src/conf/domain_conf.c        | 19 +++++++++++++++++++
 src/conf/domain_conf.h        | 10 ++++++++++
 src/libvirt_private.syms      |  1 +
 src/qemu/qemu_capabilities.c  |  6 +++++-
 src/qemu/qemu_capabilities.h  |  1 +
 src/qemu/qemu_command.c       | 11 +++++++++++
 7 files changed, 59 insertions(+), 1 deletion(-)

--

-- 
1.9.3

Pavel Hrdina | 24 Apr 14:28 2015
Picon

[libvirt] [PATCH] build: add pragma directive to fix build on some gcc

Commit 1268820a removed obsolete index() function and replaced it by
strchr.  Few versions of gcc has a bug and reports a warning about
strchr:

../../src/util/virstring.c:1006: error: logical '&&' with non-zero
constant will always evaluate as true [-Wlogical-op]

Signed-off-by: Pavel Hrdina <phrdina <at> redhat.com>
---

Pushed as build-breaker fix.

 src/util/virstring.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/util/virstring.c b/src/util/virstring.c
index 7b0cad7..5794f96 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
 <at>  <at>  -986,6 +986,16  <at>  <at>  virStringHasControlChars(const char *str)
 }

 
+/* Work around spurious strchr() diagnostics given by -Wlogical-op
+ * for gcc < 4.6.  Doing it via a local pragma keeps the damage
+ * smaller than disabling it on the package level.  Unfortunately, the
+ * affected GCCs don't allow diagnostic push/pop which would have
+ * further reduced the impact. */
+#if BROKEN_GCC_WLOGICALOP
+# pragma GCC diagnostic ignored "-Wlogical-op"
+#endif
+
+
 /**
  * virStringStripControlChars:
  *  <at> str: the string to strip
--

-- 
2.0.5

Jiri Denemark | 24 Apr 12:03 2015
Picon

[libvirt] [PATCH] Fix memory leak in virNetSocketNewConnectUNIX

==26726==    by 0x673CD67: __vasprintf_chk (vasprintf_chk.c:80)
==26726==    by 0x5673605: UnknownInlinedFun (stdio2.h:210)
==26726==    by 0x5673605: virVasprintfInternal (virstring.c:476)
==26726==    by 0x56736EE: virAsprintfInternal (virstring.c:497)
==26726==    by 0x5680C37: virGetUserRuntimeDirectory (virutil.c:866)
==26726==    by 0x5783A89: virNetSocketNewConnectUNIX (virnetsocket.c:572)
==26726==    by 0x57751AF: virNetClientNewUNIX (virnetclient.c:344)
==26726==    by 0x57689B3: doRemoteOpen (remote_driver.c:895)
==26726==    by 0x5769F8E: remoteConnectOpen (remote_driver.c:1195)
==26726==    by 0x57092DF: do_open (libvirt.c:1189)
==26726==    by 0x570A7BF: virConnectOpenAuth (libvirt.c:1341)

https://bugzilla.redhat.com/show_bug.cgi?id=1215042
Signed-off-by: Jiri Denemark <jdenemar <at> redhat.com>
---
 src/rpc/virnetsocket.c | 44 +++++++++++++++++++++-----------------------
 1 file changed, 21 insertions(+), 23 deletions(-)

diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index a59e3e1..7ae2796 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
 <at>  <at>  -546,6 +546,7  <at>  <at>  int virNetSocketNewConnectUNIX(const char *path,
     virSocketAddr localAddr;
     virSocketAddr remoteAddr;
     char *rundir = NULL;
+    int ret = -1;

     memset(&localAddr, 0, sizeof(localAddr));
     memset(&remoteAddr, 0, sizeof(remoteAddr));
 <at>  <at>  -559,50 +560,50  <at>  <at>  int virNetSocketNewConnectUNIX(const char *path,
             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                            _("Auto-spawn of daemon requested, "
                              "but no binary specified"));
-            goto error;
+            goto cleanup;
         }

         if (!(binname = last_component(binary)) || binname[0] == '\0') {
             virReportError(VIR_ERR_INTERNAL_ERROR,
                            _("Cannot determine basename for binary '%s'"),
                            binary);
-            goto error;
+            goto cleanup;
         }

         if (!(rundir = virGetUserRuntimeDirectory()))
-            goto error;
+            goto cleanup;

         if (virFileMakePathWithMode(rundir, 0700) < 0) {
             virReportSystemError(errno,
                                  _("Cannot create user runtime directory '%s'"),
                                  rundir);
-            goto error;
+            goto cleanup;
         }

         if (virAsprintf(&lockpath, "%s/%s.lock", rundir, binname) < 0)
-            goto error;
+            goto cleanup;

         if ((lockfd = open(lockpath, O_RDWR | O_CREAT, 0600)) < 0 ||
             virSetCloseExec(lockfd) < 0) {
             virReportSystemError(errno, _("Unable to create lock '%s'"), lockpath);
-            goto error;
+            goto cleanup;
         }

         if (virFileLock(lockfd, false, 0, 1, true) < 0) {
             virReportSystemError(errno, _("Unable to lock '%s'"), lockpath);
-            goto error;
+            goto cleanup;
         }
     }

     if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) {
         virReportSystemError(errno, "%s", _("Failed to create socket"));
-        goto error;
+        goto cleanup;
     }

     remoteAddr.data.un.sun_family = AF_UNIX;
     if (virStrcpyStatic(remoteAddr.data.un.sun_path, path) == NULL) {
         virReportSystemError(ENOMEM, _("Path %s too long for unix socket"), path);
-        goto error;
+        goto cleanup;
     }
     if (remoteAddr.data.un.sun_path[0] == ' <at> ')
         remoteAddr.data.un.sun_path[0] = '\0';
 <at>  <at>  -612,42 +613,39  <at>  <at>  int virNetSocketNewConnectUNIX(const char *path,
         if (!(spawnDaemon && errno == ENOENT)) {
             virReportSystemError(errno, _("Failed to connect socket to '%s'"),
                                  path);
-            goto error;
+            goto cleanup;
         }

         if (virNetSocketForkDaemon(binary) < 0)
-            goto error;
+            goto cleanup;

         retries--;
         usleep(5000);
     }

-    if (lockfd != -1) {
-        unlink(lockpath);
-        VIR_FORCE_CLOSE(lockfd);
-        VIR_FREE(lockpath);
-    }
-
     localAddr.len = sizeof(localAddr.data);
     if (getsockname(fd, &localAddr.data.sa, &localAddr.len) < 0) {
         virReportSystemError(errno, "%s", _("Unable to get local socket name"));
-        goto error;
+        goto cleanup;
     }

     if (!(*retsock = virNetSocketNew(&localAddr, &remoteAddr, true, fd, -1, 0)))
-        goto error;
+        goto cleanup;

-    return 0;
+    ret = 0;

- error:
+ cleanup:
     if (lockfd != -1) {
         unlink(lockpath);
         VIR_FORCE_CLOSE(lockfd);
     }
     VIR_FREE(lockpath);
     VIR_FREE(rundir);
-    VIR_FORCE_CLOSE(fd);
-    return -1;
+
+    if (ret == -1)
+        VIR_FORCE_CLOSE(fd);
+
+    return ret;
 }
 #else
 int virNetSocketNewConnectUNIX(const char *path ATTRIBUTE_UNUSED,
--

-- 
2.3.5


Gmane