Shanzhi Yu | 28 Feb 10:51 2015
Picon

[libvirt] [PATCH v2] qemu: snapshot: remove the redundant 'if' check

When the domain's source disk type is network, if source protocol
is rbd or sheepdog, the 'if().. break' will end the current case,
which lead to miss check the driver type is raw or qcow2. Libvirt
will allow to create internal snapshot for a running domain with
raw format disk which based on rbd storage.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1179533
Signed-off-by: Shanzhi Yu <shyu <at> redhat.com>
---
 src/qemu/qemu_driver.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e282464..544ed82 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
 <at>  <at>  -13422,11 +13422,6  <at>  <at>  qemuDomainSnapshotPrepare(virConnectPtr conn,
                                                       active) < 0)
                 goto cleanup;

-            if (dom_disk->src->type == VIR_STORAGE_TYPE_NETWORK &&
-                (dom_disk->src->protocol == VIR_STORAGE_NET_PROTOCOL_SHEEPDOG ||
-                 dom_disk->src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD)) {
-                break;
-            }
             if (vm->def->disks[i]->src->format > 0 &&
                 vm->def->disks[i]->src->format != VIR_STORAGE_FILE_QCOW2) {
                 virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
--

-- 
2.1.0
(Continue reading)

Luyao Huang | 28 Feb 10:08 2015
Picon

[libvirt] [PATCHv2 0/4]add support for graphics to get a IPv6 address

https://bugzilla.redhat.com/show_bug.cgi?id=1192318

We already support add a IPv6 address to graphics listen address
and xml like this:

    <graphics type='spice' port='5900' autoport='yes' listen='2001b8:ca2:2::1' keymap='en-us'>
      <listen type='address' address='2001b8:ca2:2::1'/>
    </graphics>

However we do not support get a IPv6 address for the network.

add some helpers and rework networkGetNetworkAddress to make it
can get a IPv6 address when we need.

Luyao Huang (4):
  util: introduce 2 new helpers for get interface IPv6 address
  conf: introduce new family attribute in graphics listen for chose IP
    family
  network: rework networkGetNetworkAddress to make it can get IPv6
    address
  qemu: fix a error coverd issue in 2 place

 docs/formatdomain.html.in                          | 10 ++-
 docs/schemas/domaincommon.rng                      |  8 ++
 src/conf/domain_conf.c                             | 20 +++++
 src/conf/domain_conf.h                             |  9 ++
 src/libvirt_private.syms                           |  1 +
 src/network/bridge_driver.c                        | 15 ++--
 src/network/bridge_driver.h                        |  6 +-
 src/qemu/qemu_command.c                            | 22 +++--
(Continue reading)

Eric Blake | 28 Feb 00:38 2015
Picon

[libvirt] new warning from ar on rawhide systems

When compiling libvirt (and probably other packages) on Fedora rawhide
systems, I'm seeing a new warning message on every link line.

# rpm -q libtool gcc binutils
libtool-2.4.6-1.fc23.x86_64
gcc-5.0.0-0.16.fc23.x86_64
binutils-2.25-6.fc23.x86_64

For an example of the warning during a 'make V=1':

> libtool: link: rm -fr  .libs/libvirt_driver_qemu_impl.a .libs/libvirt_driver_qemu_impl.la
> libtool: link: ar cru .libs/libvirt_driver_qemu_impl.a
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_agent.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_capabilities.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_command.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_domain.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_cgroup.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_hostdev.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_hotplug.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_conf.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_process.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_migration.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_monitor.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_monitor_text.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_monitor_json.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_driver.o
qemu/.libs/libvirt_driver_qemu_impl_la-qemu_interface.o 
> ar: `u' modifier ignored since `D' is the default (see `U')
> libtool: link: ranlib .libs/libvirt_driver_qemu_impl.a

(Continue reading)

Ján Tomko | 27 Feb 16:30 2015
Picon

[libvirt] [PATCH 0/3] Only talk to qemu guest agent when the domain is running

Previously, only virDomainObjIsActive() was used to check domain liveness.
This includes states like 'VIR_DOMAIN_PMSUSPENDED', where QEMU is running,
but the guest is not.

Explicitly check the state against VIR_DOMAIN_RUNNING and refuse to
communicate with the agent if it does not match.

https://bugzilla.redhat.com/show_bug.cgi?id=872424

Ján Tomko (3):
  Check for qemu guest agent availability after getting the job
  Pass virDomainObjPtr to qemuDomainAgentAvailable
  Check if domain is running in qemuDomainAgentIsAvailable

 src/qemu/qemu_domain.c | 11 ++++++++++-
 src/qemu/qemu_domain.h |  2 +-
 src/qemu/qemu_driver.c | 49 +++++++++++++++++++++++++------------------------
 3 files changed, 36 insertions(+), 26 deletions(-)

--

-- 
2.0.5

--
libvir-list mailing list
libvir-list <at> redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Michal Privoznik | 27 Feb 16:13 2015
Picon

[libvirt] [PATCH] docs: Add mist.io as libvirt-based application

As reported on the libvirt-users list [1], there's new web
application called mist.io which uses libvirt as one of its
backends. Lets add it into our list of libivrt based
applications.

1: https://www.redhat.com/archives/libvirt-users/2015-February/msg00096.html

Signed-off-by: Michal Privoznik <mprivozn <at> redhat.com>
---
 docs/apps.html.in | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/docs/apps.html.in b/docs/apps.html.in
index 4403ce6..79ee73a 100644
--- a/docs/apps.html.in
+++ b/docs/apps.html.in
 <at>  <at>  -404,6 +404,14  <at>  <at> 
         functions, such as live migration that allows for load
         balancing between cluster nodes, monitoring CPU, memory.
       </dd>
+      <dt><a href="http://mist.io/">mist.io</a></dt>
+      <dd>
+        Mist.io is an open source project and a service that can assist you in
+        managing your virtual machines on a unified way, providing a simple
+        interface for all of your infrastructure (multiple public cloud
+        providers, OpenStack based public/private clouds, Docker servers, bare
+        metal servers and now KVM hypervisors).
+      </dd>
     </dl>

(Continue reading)

Pavel Hrdina | 27 Feb 15:35 2015
Picon

[libvirt] [PATCH 0/2] fix corner case of spice graphics channel mode settings

Pavel Hrdina (2):
  qemu: remove duplicated code for allocating spice ports
  qemu: check defaultMode for spice graphics independently

 src/qemu/qemu_driver.c  | 45 ++----------------------------
 src/qemu/qemu_process.c | 73 ++++++++++++++++++++++++++++---------------------
 src/qemu/qemu_process.h |  5 ++++
 3 files changed, 49 insertions(+), 74 deletions(-)

--

-- 
2.0.5

Vasiliy Tolstov | 27 Feb 14:38 2015
Picon

[libvirt] [PATCH v4] Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

If a user specify ehernet device create it via libvirt and run
script if it provided. After this commit user does not need to
run external script to create tap device or add root to qemu
process.

Signed-off-by: Vasiliy Tolstov <v.tolstov <at> selfip.ru>
---
 src/qemu/qemu_command.c | 135 +++++++++++++++++++++++++++++-------------------
 src/qemu/qemu_hotplug.c |  13 ++---
 src/qemu/qemu_process.c |   6 +++
 3 files changed, 93 insertions(+), 61 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 24b2ad9..284a97c 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
 <at>  <at>  -278,10 +278,41  <at>  <at>  static int qemuCreateInBridgePortWithHelper(virQEMUDriverConfigPtr cfg,
     return *tapfd < 0 ? -1 : 0;
 }

+/**
+ * qemuExecuteEthernetScript:
+ *  <at> ifname: the interface name
+ *  <at> script: the script name
+ * This function executes script for new tap device created by libvirt.
+ * Returns 0 in case of success or -1 on failure
+ */
+static int qemuExecuteEthernetScript(const char *ifname, const char *script)
+{
+    virCommandPtr cmd;
(Continue reading)

Erik Skultety | 27 Feb 12:45 2015
Picon

[libvirt] [PATCH] docs: add a note that attr 'managed' is only used by PCI devices

Our documentation isn't 100% clear about hostdev 'managed' attribute usage,
because it only makes sense to use it with PCI devices, yet we format
this attribute to all hostdev devices. By adding a note into the docs,
we can possibly avoid confusion from customer's side and also avoid a solution
using ternary logic.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1155887
---
 docs/formatdomain.html.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index fb0a0d1..6276a61 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
 <at>  <at>  -3110,6 +3110,12  <at>  <at> 
             then this setting not required.
           </dd>
         </dl>
+        <p>
+          Note: The <code>managed</code> attribute is only used with PCI devices
+          and is ignored by all the other device types, thus setting
+          <code>managed</code> explicitly with other than PCI device has the same
+          effect as omitting it.
+        </p>
       </dd>
       <dt><code>source</code></dt>
       <dd>The source element describes the device as seen from the host using
--

-- 
1.9.3
(Continue reading)

Ján Tomko | 27 Feb 12:07 2015
Picon

[libvirt] [PATCH] Really fix XML formatting flags in SaveImageUpdateDef

Commit cf2d4c6 used a logical or instead of bitwise or,
effectively passing 1, that is VIR_DOMAIN_XML_INACTIVE.
Yep, that's right.

This was caught by a warning when building with clang.

https://bugzilla.redhat.com/show_bug.cgi?id=1183869
---
 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e9aa0b5..e282464 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
 <at>  <at>  -5734,7 +5734,7  <at>  <at>  qemuDomainSaveImageUpdateDef(virQEMUDriverPtr driver,

     if (!(newdef_migr = qemuDomainDefCopy(driver,
                                           newdef,
-                                          QEMU_DOMAIN_FORMAT_LIVE_FLAGS ||
+                                          QEMU_DOMAIN_FORMAT_LIVE_FLAGS |
                                           VIR_DOMAIN_XML_MIGRATABLE)))
         goto cleanup;

--

-- 
2.0.5

Pavel Hrdina | 27 Feb 09:46 2015
Picon

[libvirt] [PATCH v2] docs: add a note that spice channel is usable only with spice graphics

To prevent a confusion about missing chardev argument in qemu
command line add a note about that behavior into documentation.

Signed-off-by: Pavel Hrdina <phrdina <at> redhat.com>
---
 docs/formatdomain.html.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index fb0a0d1..2f2976c 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
 <at>  <at>  -5372,6 +5372,10  <at>  <at>  qemu-kvm -net nic,model=? /dev/null
       under a channel name specified in the <code>channel</code>
       attribute.  <span class="since">Since 1.2.2</span>
     </p>
+    <p>
+      Note: in order for the spiceport to be usable, the domain must have
+      spice graphics as well.
+    </p>

 <pre>
   ...
--

-- 
2.0.5

jiahu | 27 Feb 06:52 2015
Picon

[libvirt] [libvirt-test-API][PATCH 0/2] Add coredump_with_format test case

The coredump_with_format.py uses coreDumpWithFormat() to validate
new API virDomainCoreDumpWithFormat of libvirt.

jiahu (2):
  Add coredump_with_format test case
  Add coredump_with_format test case to linux_domain conf

 cases/linux_domain.conf              |  44 +++++++
 repos/domain/coredump_with_format.py | 239 +++++++++++++++++++++++++++++++++++
 2 files changed, 283 insertions(+)
 create mode 100644 repos/domain/coredump_with_format.py

--

-- 
1.8.3.1


Gmane