Michal Privoznik | 3 May 10:33 2016
Picon

[libvirt] [PATCH v2 0/2] qemu: Refresh guest's RTC on daemon restart

v2 of:

https://www.redhat.com/archives/libvir-list/2016-April/msg02001.html

diff to v1:
-Peter's review suggestions worked in

Michal Privoznik (2):
  qemu: Introduce qemuMonitorGetRTCTime
  qemu: Refresh RTC adjustment on qemuProcessReconnect

 src/qemu/qemu_monitor.c      | 11 +++++++++++
 src/qemu/qemu_monitor.h      |  3 +++
 src/qemu/qemu_monitor_json.c | 41 +++++++++++++++++++++++++++++++++++++++++
 src/qemu/qemu_monitor_json.h |  3 +++
 src/qemu/qemu_process.c      | 44 ++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 102 insertions(+)

--

-- 
2.8.1

Bjoern Walk | 3 May 08:10 2016
Picon

[libvirt] [PATCH 0/4] virt-host-validate: add s390 support

This patch series adds support to the s390 platform for the virt-host-validate
tool which detects virtualization capabilities of the host.

It has been tested on x86 that no regression is introduced.

Bjoern Walk (4):
  tools: virt-host-validate: fix missing translation marker
  tools: virt-host-validate: fix CPU flag detection
  tools: virt-host-validate: improve error handling
  tools: virt-host-validate: HW virt support on s390

 tools/virt-host-validate-common.c | 12 +++++++-----
 tools/virt-host-validate-common.h |  1 +
 tools/virt-host-validate-qemu.c   | 31 ++++++++++++++++++++++++-------
 3 files changed, 32 insertions(+), 12 deletions(-)

--

-- 
2.6.6

Jim Fehlig | 3 May 03:01 2016
Gravatar

[libvirt] [PATCH 0/3] libxl: support Xen migration stream V2

Hi all,

This patch adds support for Xen migration stream V2 to the libvirt
libxl driver. In the process it fixes save/restore and migration
tests in OSSTest, which have been failing since libvirt commit
e7440656.

Patch1 changes the libxl API requirement from version 4.2 to 4.4,
enabling use of an extended libxl_domain_create_restore() function
that allows passing restore parameters such as stream version.

Patch2 adds support for migration stream V2 in the basic save/restore
logic, taking advantage of a save image header that includes a version
field. The version is set to '2' if the host produces a V2 migration
stream. This patch fixes the failing save/restore tests in OSSTest.

Patch3 adds support for migration stream V2 in the migration logic.
The migration code does not use the save image header and instead
uses libvirt's migration protocol to transfer domain configuration
and other such goodies from source to destination. The patch
enables sending version information in the Begin and Prepare
migration phases so the correct stream version information can be
passed to libxl_domain_create_restore(). An upshot of this approach
is safely detecting and aborting a migration from a V2 host to a
V1-only host. This patch fixes the failing migration tests in
OSSTest.

Jim Fehlig (3):
  libxl: switch to using libxl_domain_create_restore from v4.4 API
  libxl: support Xen migration stream V2 in save/restore
(Continue reading)

Cole Robinson | 3 May 01:09 2016
Picon
Gravatar

[libvirt] [PATCH] qemu: hotplug: Report error if we hit tray status timeout

If we exceed the timeout waiting for the tray status to change,
we don't report an error. Fix it
---
I hit this trying to eject floppy media for a win10 VM with F24
qemu, but I didn't dig deeper to figure out _why_ it's timing out...

 src/qemu/qemu_hotplug.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 03e5309..e5f8a38 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
 <at>  <at>  -224,7 +224,13  <at>  <at>  qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver,
             goto error;

         while (disk->tray_status != VIR_DOMAIN_DISK_TRAY_OPEN) {
-            if (virDomainObjWaitUntil(vm, now + CHANGE_MEDIA_TIMEOUT) != 0)
+            int rc2 = virDomainObjWaitUntil(vm, now + CHANGE_MEDIA_TIMEOUT);
+            if (rc2 == 1) {
+                virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                               _("timed out waiting for "
+                                 "disk tray status update"));
+            }
+            if (rc2 != 0)
                 goto error;
         }
     } while (rc < 0);
--

-- 
2.7.4
(Continue reading)

John Ferlan | 3 May 00:30 2016
Picon

[libvirt] [PATCH REPOST 0/7] Add support for virtio-scsi-{pci, ccw} iothread support

Repost of :

http://www.redhat.com/archives/libvir-list/2016-April/msg01539.html

Essentially the same patches as previous, but refreshed to current HEAD
of '6620cd1ef'.  I did remove patch 5 since it's not necessary. Also
had to adjust one test to add the new default panic device for ccw.

John Ferlan (7):
  qemu: Add capability for virtio-scsi iothreads
  docs: clarify disk iothread support
  docs: Reformat the Controllers description
  conf: Move virDomainControllerModelTypeToString
  conf: Add support for virtio-scsi iothreads
  qemu: Use switch for qemuCheckIOThreads
  qemu: Add 'iothread' to command line for supported controller

 docs/formatdomain.html.in                          |  87 ++++++---
 docs/schemas/domaincommon.rng                      |   3 +
 src/conf/domain_conf.c                             |  54 ++++--
 src/conf/domain_conf.h                             |   1 +
 src/qemu/qemu_capabilities.c                       |   9 +
 src/qemu/qemu_capabilities.h                       |   1 +
 src/qemu/qemu_command.c                            | 115 ++++++++++--
 tests/qemucapabilitiesdata/caps_1.2.2-1.replies    |  80 +++++----
 tests/qemucapabilitiesdata/caps_1.3.1-1.replies    |  80 +++++----
 tests/qemucapabilitiesdata/caps_1.4.2-1.replies    |  88 +++++----
 tests/qemucapabilitiesdata/caps_1.5.3-1.replies    |  88 +++++----
 tests/qemucapabilitiesdata/caps_1.6.0-1.replies    |  88 +++++----
 tests/qemucapabilitiesdata/caps_1.6.50-1.replies   |  88 +++++----
(Continue reading)

John Ferlan | 2 May 23:51 2016
Picon

[libvirt] [PATCH v2 0/8] Add IV Secret Object support

v1 here (specifically patches 11 & 12)
http://www.redhat.com/archives/libvir-list/2016-April/msg01077.html

What's new/changed:

Patches 1-3 address comments made by Jan in his review of v1.

Patch 4 is essentially following through on the Patch 3 comment

Patch 5 was part of patch 11, but I split it out for easier review

Patch 6 is the remainder of the former patch 11. Other than using the
...SECRET_INFO_TYPE_xxx nomenclature, no other real changes.

Patch 7 was part of patch 12, but I split it out to reduce the amount
to review.  Beyond the aforementioned ...SECRET_INFO_TYPE_xxx changes,
I removed qemuDomainSecretInfoGetAlias.  Initially created to help with
any hotplug code, but that's not necessary, so remove it for now. It was
brought up on Jan's comments as well. Create qemuDomainSecretSetup in
order to address Jan's other comment about a common API

This code could be merged with patch 8, but separating it *and* leaving
qemuDomainSecretHaveEncrypt essentially brain-dead worked made for a
shorter pile to look at

Patch 8 is the remainder of patch 12.  I investigated extracting the
iSCSI and RBD code out, but it really just didn't make practice sense.
I altered qemuBuildSecretIVCommandLine to just access the IV alias directly
since the callers were adjusted to only try to build the IV object if
necessary. The qemuBuild{Disk|Hostdev}iSCSICommandLine were renamed to
(Continue reading)

Vasiliy Tolstov | 2 May 21:12 2016
Picon
Gravatar

Re: [libvirt] RFC filesystem pool proposal description.

2016-04-29 19:12 GMT+03:00 Maxim Nestratov <mnestratov <at> virtuozzo.com>:
> I wonder, if my reply clarify the original message or it's still unclear and
> it's better to step back more and describe the problem in more details?

Yes, may be i'm interesting in this feature too, but i can miss
something. Does you want to allow format and mount needed paths/devs
via libvirt to allow to use it as pools?
Now i need some cookbooks for chef to format needed devices and mount
it before define pools....

--

-- 
Vasiliy Tolstov,
e-mail: v.tolstov <at> selfip.ru

Michal Privoznik | 2 May 18:07 2016
Picon

Re: [libvirt] [PATCH 5/7] virnetserverclient: Add an internal method to retrieve client's identity

On 29.04.2016 15:45, Erik Skultety wrote:
> This method just aggregates various client object attributes, like socket
> address, connection type (RO/RW), and some TCP/TLS/UNIX identity in an atomic
> manner.
> 
> Signed-off-by: Erik Skultety <eskultet <at> redhat.com>
> ---
>  src/rpc/virnetserverclient.c | 26 ++++++++++++++++++++++++++
>  src/rpc/virnetserverclient.h |  3 +++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c
> index 396b0cc..ef1b568 100644
> --- a/src/rpc/virnetserverclient.c
> +++ b/src/rpc/virnetserverclient.c
>  <at>  <at>  -1612,3 +1612,29  <at>  <at>  virNetServerClientGetTransport(virNetServerClientPtr client)
>  
>      return ret;
>  }
> +
> +int
> +virNetServerClientGetInfo(virNetServerClientPtr client,
> +                          bool *readonly, const char **sock_addr,
> +                          virIdentityPtr *identity)
> +{
> +    int ret = -1;
> +
> +    virObjectLock(client);
> +    *readonly = client->readonly;
> +
(Continue reading)

Michal Privoznik | 2 May 18:07 2016
Picon

Re: [libvirt] [PATCH 4/7] virneserverclient: Introduce virNetServerClientHasSASLSession

On 29.04.2016 15:45, Erik Skultety wrote:
> We do have a similar method, serving the same purpose, for TLS, but we lack
> one for SASL. So introduce one, in order for other modules to be able to find
> out, if a SASL session is active, or better said, that a SASL session exists
> at all.
> 
> Signed-off-by: Erik Skultety <eskultet <at> redhat.com>
> ---
>  src/rpc/virnetserverclient.c | 9 +++++++++
>  src/rpc/virnetserverclient.h | 1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c
> index a7b3b15..396b0cc 100644
> --- a/src/rpc/virnetserverclient.c
> +++ b/src/rpc/virnetserverclient.c
>  <at>  <at>  -863,6 +863,15  <at>  <at>  virNetSASLSessionPtr
virNetServerClientGetSASLSession(virNetServerClientPtr clie
>      virObjectUnlock(client);
>      return sasl;
>  }
> +
> +bool virNetServerClientHasSASLSession(virNetServerClientPtr client)
> +{
> +    bool has = false;
> +    virObjectLock(client);
> +    has = !!client->sasl;
> +    virObjectUnlock(client);
> +    return has;
> +}
(Continue reading)

Michal Privoznik | 2 May 18:07 2016
Picon

Re: [libvirt] [PATCH 7/7] virt-admin: Introduce command client-info

On 29.04.2016 15:45, Erik Skultety wrote:
> Wire-up the client identity getter into virt-admin tool. This patch adjusts
> man-page accordingly.
> 
> Signed-off-by: Erik Skultety <eskultet <at> redhat.com>
> ---
>  tools/virt-admin.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 91 insertions(+)

Missing documentation.

> 
> diff --git a/tools/virt-admin.c b/tools/virt-admin.c
> index f0fecdd..72c54ae 100644
> --- a/tools/virt-admin.c
> +++ b/tools/virt-admin.c
>  <at>  <at>  -655,6 +655,91  <at>  <at>  cmdSrvClientsList(vshControl *ctl, const vshCmd *cmd)
>      return ret;
>  }
>  
> +/* -------------------
> + * Command client-info
> + * -------------------
> + */
> +
> +static const vshCmdInfo info_client_info[] = {
> +    {.name = "help",
> +     .data = N_("retrieve client's identity info from <server>")
> +    },
> +    {.name = "desc",
(Continue reading)

Michal Privoznik | 2 May 18:07 2016
Picon

Re: [libvirt] [PATCH 0/7] Admin API: Add support for client identity info retrieval

On 29.04.2016 15:45, Erik Skultety wrote:
> This series adds support for client identity retrieval, i.e. information like
> remote IP (if connected remotely), uid,gid,pid, as well as username if
> connected locally and also information regarding authentication (if used).
> 
> The series is rebased on the listing clients series, because it relies on the
> gendispatch stuff, so for testing purposes checkout my remote branch
> https://github.com/eskultety/libvirt/tree/list-clients-info-disconnect which
> also covers the next series about client disconnect.
> 
> Erik Skultety (7):
>   admin: Introduce virAdmServerLookupClient
>   admin: include: Introduce some client's identity related typed params
>     macros
>   virnetsocket: Provide socket address format in a more standard form
>   virneserverclient: Introduce virNetServerClientHasSASLSession
>   virnetserverclient: Add an internal method to retrieve client's
>     identity
>   admin: Introduce virAdmClientGetInfo API
>   virt-admin: Introduce command client-info
> 
>  daemon/admin.c                  |  59 ++++++++++++++++++
>  daemon/admin_server.c           | 102 +++++++++++++++++++++++++++++++
>  daemon/admin_server.h           |   9 +++
>  daemon/remote.c                 |  13 +++-
>  include/libvirt/libvirt-admin.h | 130 ++++++++++++++++++++++++++++++++++++++++
>  include/libvirt/virterror.h     |   1 +
>  src/admin/admin_protocol.x      |  34 ++++++++++-
>  src/admin/admin_remote.c        |  47 +++++++++++++++
>  src/admin_protocol-structs      |  20 +++++++
(Continue reading)


Gmane