Maros Zatko | 24 May 19:11 2016
Picon

[PATCH] rescue: add --autosysroot option RHBZ#1183493

--autosysroot option uses suggestions to user on how to mount filesystems
and change root suggested by --suggest option in virt-rescue.

Commands are passed on kernel command line in format
guestfs_command=command;. Command ends with a semicolon and there can be
multiple commands specified. These are executed just before bash starts.
On successfull run user is presented directly with bash in chroot
environment.

RFE: RHBZ#1183493
Depends on commit: utils: make guestfs_int_count_strings return 0 on NULL input

Maros Zatko (1):
  rescue: add --autosysroot option RHBZ#1183493

 appliance/init  |   6 +++
 rescue/rescue.c | 160 ++++++++++++++++++++++++++++++++++++++++++++------------
 2 files changed, 134 insertions(+), 32 deletions(-)

--

-- 
2.5.5
Pino Toscano | 24 May 18:21 2016
Picon

[PATCH 1/3] inspect: recognize the Void Linux distribution

Since Void Linux provides only an /etc/os-release with no VERSION_ID
field, then special-case it to avoid that the os-release parsing ignore
it.

This provides basic distro identification, and icon.
---
 generator/actions.ml         |  4 ++++
 inspector/virt-inspector.rng |  1 +
 src/guestfs-internal.h       |  1 +
 src/inspect-fs-unix.c        | 14 ++++++++++++--
 src/inspect-fs.c             |  2 ++
 src/inspect-icon.c           | 13 +++++++++++++
 src/inspect.c                |  1 +
 7 files changed, 34 insertions(+), 2 deletions(-)

diff --git a/generator/actions.ml b/generator/actions.ml
index b17808e..25d3c0d 100644
--- a/generator/actions.ml
+++ b/generator/actions.ml
 <at>  <at>  -1183,6 +1183,10  <at>  <at>  Ubuntu.

 The distro could not be determined.

+=item \"voidlinux\"
+
+Void Linux.
+
 =item \"windows\"

 Windows does not have distributions.  This string is
(Continue reading)

Maros Zatko | 24 May 18:20 2016
Picon

[PATCH] utils: make guestfs_int_count_strings return 0 on NULL input

This miniature patch makes function guestfs_int_count_strings accept NULL input
and return 0 signalling that it is empty list. It makes it more usefull with
NULL initialized variables and a tiny bit more robust.

Maros Zatko (1):
  utils: make guestfs_int_count_strings return 0 on NULL input

 src/utils.c | 3 +++
 1 file changed, 3 insertions(+)

--

-- 
2.5.5
Pino Toscano | 23 May 18:25 2016
Picon

[PATCH 1/5] mllib: make external_command echo the command executed

Add an optional parameter to disable this behaviour, so the Curl module
in v2v won't print user-sensible data (like passwords).
---
 builder/checksums.ml   | 1 -
 builder/downloader.ml  | 1 -
 builder/sigchecker.ml  | 1 -
 mllib/common_utils.ml  | 4 +++-
 mllib/common_utils.mli | 7 +++++--
 v2v/curl.ml            | 2 +-
 6 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/builder/checksums.ml b/builder/checksums.ml
index 95103e9..c8cdc98 100644
--- a/builder/checksums.ml
+++ b/builder/checksums.ml
 <at>  <at>  -43,7 +43,6  <at>  <at>  let verify_checksum csum filename =
   in

   let cmd = sprintf "%s %s" prog (quote filename) in
-  debug "%s" cmd;
   let lines = external_command cmd in
   match lines with
   | [] ->
diff --git a/builder/downloader.ml b/builder/downloader.ml
index e31748d..7dc0a29 100644
--- a/builder/downloader.ml
+++ b/builder/downloader.ml
 <at>  <at>  -99,7 +99,6  <at>  <at>  and download_to t ?(progress_bar = false) ~proxy uri filename =
       t.curl
       (if verbose () then "" else " -s -S")
(Continue reading)

Cédric Bosdonnat | 23 May 15:31 2016
Gravatar

[PATCH v3 0/3] SUSE VMDP support

Hi there,

Here is v3 of the remaining patches. Diff to v2:
 * Removed the patch related to QXL
 * Fixed the firstboot script with Roman's comments
 * Fixed ova with subfolders test
 * Handle MF-relative path in ova files
 * Fixed now unneeded match case as per Richard's comment

Cédric Bosdonnat (3):
  customize: fix windows firstboot script
  v2v: add support for SUSE VMDP drivers
  v2v: handle subfolders in ova files

 customize/firstboot.ml                 |  10 +--
 v2v/Makefile.am                        |   1 +
 v2v/convert_windows.ml                 |  77 +++++++++++++-----
 v2v/input_ova.ml                       |   6 +-
 v2v/test-v2v-i-ova-subfolders.expected |  18 +++++
 v2v/test-v2v-i-ova-subfolders.ovf      | 138 +++++++++++++++++++++++++++++++++
 v2v/test-v2v-i-ova-subfolders.sh       |  65 ++++++++++++++++
 v2v/windows_virtio.ml                  |  35 ++++++---
 8 files changed, 312 insertions(+), 38 deletions(-)
 create mode 100644 v2v/test-v2v-i-ova-subfolders.expected
 create mode 100644 v2v/test-v2v-i-ova-subfolders.ovf
 create mode 100755 v2v/test-v2v-i-ova-subfolders.sh

--

-- 
2.6.6

(Continue reading)

Richard W.M. Jones | 22 May 22:35 2016
Picon
Gravatar

ocaml tools: Use a common debug function.

Add a Common_utils.debug function for printing messages
only when in verbose mode.

Rich.
Richard W.M. Jones | 22 May 22:34 2016
Picon
Gravatar

[PATCH 0/2] uefi: Add new locations for UEFI files on Fedora.

https://bugzilla.redhat.com/show_bug.cgi?id=1338083

Now that UEFI is fully open source the UEFI firmware can be included
in Fedora.  The location will be slightly different.  These patches do
a bit of code rearrangement and add the new paths.

Rich.
Richard W.M. Jones | 21 May 14:14 2016
Picon
Gravatar

[PATCH] umask: Use /proc/≤PID>/status to read umask in Linux >= 4.7.

Since Linux 4.7, the process umask is available in /proc/≤pid>/status.
See:
https://github.com/torvalds/linux/commit/3e42979e65dace1f9268dd5440e5ab096b8dee59

Use this value if available, else fall back to the existing codepath
for Linux <= 4.6 and other Unix.
---
 src/umask.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 78 insertions(+), 8 deletions(-)

diff --git a/src/umask.c b/src/umask.c
index b8748e8..3f32337 100644
--- a/src/umask.c
+++ b/src/umask.c
 <at>  <at>  -18,12 +18,22  <at>  <at> 

 /**
  * Return current umask in a thread-safe way.
+ *
+ * glibc documents, but does not actually implement, a "getumask(3)"
+ * call.
+ *
+ * We use C<Umask> from F</proc/I<PID>/status> for Linux E<ge> 4.7.
+ * For older Linux and other Unix, this file implements an expensive
+ * but thread-safe way to get the current process's umask.
+ *
+ * Thanks to: Josh Stone, Jiri Jaburek, Eric Blake.
  */

 #include <config.h>
(Continue reading)

Eric Blake | 20 May 16:04 2016
Picon
Gravatar

[PATCH] protocol: Ignore rest of option when replying with error

We must consume the payload of any option received, whether or
not we can answer the option successfully, in order to be in
sync for reading the next option.  This is particularly true
once clients start using NBD_OPT_GO, as long as we don't happen
to service that option.

Signed-off-by: Eric Blake <eblake <at> redhat.com>
---
 src/connections.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/connections.c b/src/connections.c
index 0c93f35..840e315 100644
--- a/src/connections.c
+++ b/src/connections.c
 <at>  <at>  -334,6 +334,10  <at>  <at>  _negotiate_handshake_newstyle_options (struct connection *conn)
         if (send_newstyle_option_reply (conn, option, NBD_REP_ERR_INVALID)
             == -1)
           return -1;
+        if (xread (conn->sockin, data, optlen) == -1) {
+          nbdkit_error ("read: %m");
+          return -1;
+        }
         continue;
       }

 <at>  <at>  -351,6 +355,10  <at>  <at>  _negotiate_handshake_newstyle_options (struct connection *conn)
       /* Unknown option. */
       if (send_newstyle_option_reply (conn, option, NBD_REP_ERR_UNSUP) == -1)
         return -1;
(Continue reading)

Pino Toscano | 20 May 13:28 2016
Picon

[PATCH] tests: disable UUID change on ext journal_dev

Newer versions of e2fsprogs refuse modifying journal devices, causing
the test #1 of get_e2uuid to fail with:

  libguestfs: error: set_e2uuid: Cannot modify a journal device.

Since the test case just needs to verify get_e2uuid runs without
failing, run it without expecting a certain UUID set earlier.

Followup of commit da4812ab6b44c29cb3cf181c7aa896420ecb8aa6.
---
 generator/actions.ml | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/generator/actions.ml b/generator/actions.ml
index 3566371..b17808e 100644
--- a/generator/actions.ml
+++ b/generator/actions.ml
 <at>  <at>  -5349,14 +5349,13  <at>  <at>  of a filesystem." };
     style = RString "uuid", [Device "device"], [];
     proc_nr = Some 83;
     deprecated_by = Some "vfs_uuid";
-    tests =
-      (* Regression test for RHBZ#597112. *)
-      (let uuid = uuidgen () in [
-        InitNone, Always, TestResultString (
-          [["mke2journal"; "1024"; "/dev/sdc"];
-           ["set_e2uuid"; "/dev/sdc"; uuid];
-           ["get_e2uuid"; "/dev/sdc"]], uuid), []
-      ]);
+    tests = [
(Continue reading)

Pino Toscano | 19 May 18:57 2016
Picon

[PATCH 0/3] misc tests-only changes

Hi,

small series with small improvements to the tests.

Pino Toscano (3):
  tests: specify the image format when possible
  tests: remove remaining relative paths to binaries
  fish: generate test-prep.sh with generator

 .gitignore                                |  1 +
 align/test-virt-alignment-scan.sh         |  2 +-
 cat/Makefile.am                           |  2 +-
 cat/test-virt-cat.sh                      |  4 ++--
 cat/test-virt-filesystems.sh              |  4 ++--
 cat/test-virt-log.sh                      |  2 +-
 cat/test-virt-ls.sh                       |  4 ++--
 customize/test-virt-customize.sh          |  2 +-
 df/Makefile.am                            |  2 +-
 df/test-virt-df.sh                        |  2 +-
 diff/test-virt-diff.sh                    |  4 ++--
 edit/test-virt-edit.sh                    |  6 +++---
 fish/test-copy.sh                         |  2 +-
 fish/test-inspect.sh                      |  2 +-
 fish/test-prep.sh                         | 35 -------------------------------
 fish/test-run.sh                          |  2 +-
 format/test-virt-format.sh                |  4 ++--
 fuse/test-fuse-umount-race.sh             |  6 +++---
 fuse/test-guestmount-fd.c                 |  4 ++--
 fuse/test-guestunmount-fd.c               |  2 +-
 fuse/test-guestunmount-not-mounted.sh     |  2 +-
(Continue reading)


Gmane