David Gerard | 27 Jan 11:21 2015
Picon

Build for Google Docs (was: Re: Build failure in 4.4 branch with --enable-ext-google-docs on Xubuntu 14.04 amd64: "undefined reference to symbol 'dlclose <at> <at> GLIBC_2.2.5'")

Miklos wrote:
>On Sun, Jan 25, 2015 at 04:27:12PM +0000, David Gerard <dgerard at gmail.com> wrote:

>> I want to write a blog post saying how I did
>> this - before I do so, will there be a problem putting it up with that
>> secret (which is presumably the one in every TDF build)? Should I use
>> another one? If so, how do I obtain another one?

>Even if it's not hard to get the TDF secret from the binaries, it's not
>fair to advertise them. The more widely it's known, the more probable
>that someone will reuse it in some nasty application, then the
>TDF-registered app ID will get shut down, making LibreOffice users sad.
>See here on how to obtain your own ID:
>https://developers.google.com/drive/web/about-auth
>If you write a blog post about this topic, that's great, but I guess
>best to not mention any ID explicitly, they are kind of a secret anyway.

OK, I'll do it that way :-)

- d.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 26 Jan 22:52 2015

[Bug 88205] Adapt uses of css::uno::Sequence to use initializer_list ctor

changed bug 88205
What Removed Added
See Also   https://bugs.documentfoundation.org/show_bug.cgi?id=88815

You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 26 Jan 22:42 2015

[Bug 88205] Adapt uses of css::uno::Sequence to use initializer_list ctor

changed bug 88205
What Removed Added
CC   michael.meeks <at> collabora.com

Comment # 1 on bug 88205 from As Stephan says that's really great for the getSupportedServiceNames cases: a quick: $ git grep -5 getSupportedServiceNames shows you a load of these places (when you get through accessibility) where we can turn two or often three lines into one like this: css::uno::Sequence< OUString > BridgeFactory::static_getSupportedServiceNames() { - OUString name("com.sun.star.bridge.BridgeFactory"); - return css::uno::Sequence< OUString >(&name, 1); + return css::uno::Sequence<OUString>{ "com.sun.star.bridge.BridgeFactory" }; } Then again - it's not clear to me that this wouldn't produce rather more efficient code with a var-arg method that took C strings =) but at least far more terse. Thanks !
You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks | 26 Jan 22:31 2015

feature/barcode feedback sought ...

Hi guys,

	So - I just checked some initial QR code integration into the
feature/barcode branch; it sort of works ;-) but it raises a number of
interesting questions and/or opportunities; and I'd love some quick
directional input from someone clueful =)

	First - what is it so far:

	* I hacked an existing smiley to add the (existing but
	  apparently un-used / buggy) custom draw:engine pieces thus:

    <draw:custom-shape draw:style-name="gr1" draw:text-style-name="P1"
draw:layer="layout" svg:width="8.128cm" svg:height="6.35cm"
svg:x="5.445cm" svg:y="5.064cm"

   draw:engine="org.libreoffice.draw.barcode" draw:data="LibreOffice
prototype, native QR code rendering, thanks to Collabora">
...
    </draw:custom-shape>

	It -looks- like this code was intended to add a rather sexy extension
point for custom shapes via the drawing::XCustomShapeEngine IDL file.
Usually I love to hate UNO - but in this case it looks like what could
be possible there is rather sexy.

	My -hope- is that this with minimal tweaking would allow me to have
arbitrary python plugins rendering interesting document content - and
also serializing their rendered state as an OLE-style preview to the
XML.

	Of course - I'd love to have some feedback on my sanity - quite
possibly this is utterly crazy; quite possibly there are 3x easier &
better ways to achieve the same thing (?) =)

	Known problems:

	* for QR codes (but prolly not bar-codes) the idea of
	  representing a bitmap as a ton of polypolygons is prolly
	  not the greatest idea.
		+ but while you can put arbitrary XShape's in there
		  I suspect serializing that into an attribute is
		  unlikely to work well.

	* no UI yet you need to

	* script-ability - I guess we'd want some field / data-driven
	  / easy-automation magic:
		+ would this work better as a field ?
		+ how about as a general draw shape (the svx draw shapes
		  seem pretty horrible).

	* bar-code specifications:
		+ some of the spec's are a bit strict: "no less
		  than 2mm between X and Y"
		+ that gives some UI / rendering / unit constraints
		+ currently not captured.

	* zint
		+ software quality appears to be dire
			+ hint if you are conditionally replacing
			  malloc with "alloca" on some platforms
			  with no other associated changes - something
			  is wrong.
		+ horribly un-maintained: pick the best of at least 3x
		  under-loved forks.
		  http://users.freedesktop.org/~michael/zint.tar.bz2
		  has a snapshot. 
		+ at least it renders more kinds of bar-codes than
		  is sensible

	Known bugs:

	* ODF / back-compatibility - we re-export the original (in my
	  case smiley) custom-shape which shows up as an unhelpful
	  fallback for older LibreOffice'n.

	* zint is sufficiently bad & closely tied to layout / text
	  rendering etc. it's prolly easier to re-write

	* no system-zint: we're internal / static only - and this is not
	  a good idea; but I'll list it here anyway for completeness.

	I have a blog entry with obligatory screenshot here:

	https://people.gnome.org/~michael/blog/2015-01-25.html

	I'd love to have some clue on how best to fiddle with this / re-work it
somewhere that it fits.

	And yes I have seen this plugin:

	http://extensions.openoffice.org/en/project/qr-code-generator

	which appears to use some google web plugin to render bitmaps
remotely ;-) not great if they contain confidential data etc.

	Thanks !

		Michael.

--

-- 
 michael.meeks <at> collabora.com  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 26 Jan 14:32 2015

[Bug 60739] cut/paste coding redux

Comment # 10 on bug 60739 from Factorise FN_WORDCOUNT_DIALOG case in https://gerrit.libreoffice.org/14182 . More cases could be cleaned up : FN_FORMAT_FOOTNOTE_DLG FN_NUMBERING_OUTLINE_DLG: SID_OPEN_XML_FILTERSETTINGS ... I'm planning to change the other ones, referencing this bug. Any objection ?
You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Stephan Bergmann | 26 Jan 11:28 2015
Picon

-fnothrow-opt

In case anybody ever wonders: -fnothrow-opt (treating "throw ()" like 
"noexcept",

<https://gcc.gnu.org/onlinedocs/gcc-4.6.4/gcc/C_002b_002b-Dialect-Options.html#index-fnothrow_002dopt-148>; 
only available in GCC, not in Clang) would appear to not buy us anything 
for LO:  For one, it has zero effect on the generated code with 
-fno-enforce-eh-specs (enabled for --disable-dbgutil; only available in 
GCC, not in Clang).  For another, even if we used -fenforce-eh-specs, my 
GCC 4.9.2 --disable-dbgutil Linux master build would only shrink instdir 
by 20 bytes (from 1,817,288 to 1,817,268).
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 26 Jan 10:08 2015

[Bug 60739] cut/paste coding redux

changed bug 60739
What Removed Added
Assignee libreoffice-bugs <at> lists.freedesktop.org lefevre00 <at> yahoo.fr

You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 25 Jan 23:04 2015

[Bug 39439] Web search for UI strings

changed bug 39439
What Removed Added
Status NEW ASSIGNED

You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 25 Jan 22:27 2015

[Bug 79641] LibreOffice 4.4 most annoying bugs

changed bug 79641
What Removed Added
Depends on   88792

You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
scan-admin | 25 Jan 14:23 2015

New Defects reported by Coverity Scan for LibreOffice


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

70 new defect(s) introduced to LibreOffice found with Coverity Scan.
503 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 70 defect(s)

** CID 440858:  Argument cannot be negative  (NEGATIVE_RETURNS)
/svtools/source/brwbox/brwbox1.cxx: 310 in BrowseBox::ToggleSelectedColumn()()

** CID 703982:  Unchecked return value  (CHECKED_RETURN)
/sc/source/core/data/table2.cxx: 2758 in ScTable::SetRowHeightRange(int, int, unsigned short,
double, double)()

** CID 704680:  Dereference after null check  (FORWARD_NULL)
/sc/source/filter/excel/xeformula.cxx: 591 in XclExpFmlaCompImpl::Init(XclFormulaType, const
ScTokenArray &, const ScAddress *, std::vector<XclExpRefLogEntry,
std::allocator<XclExpRefLogEntry>> *)()

** CID 735323:  Unchecked return value  (CHECKED_RETURN)
/sd/source/filter/eppt/eppt.cxx: 394 in PPTWriter::ImplWriteSlideMaster(unsigned int, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>)()

** CID 982431:  Division or modulo by float zero  (DIVIDE_BY_ZERO)
/vcl/source/filter/wmf/winwmf.cxx: 233 in WMFReader::ReadRecordParams(unsigned short)()
/vcl/source/filter/wmf/winwmf.cxx: 253 in WMFReader::ReadRecordParams(unsigned short)()

** CID 982432:  Division or modulo by float zero  (DIVIDE_BY_ZERO)
/vcl/source/filter/wmf/winwmf.cxx: 233 in WMFReader::ReadRecordParams(unsigned short)()
/vcl/source/filter/wmf/winwmf.cxx: 253 in WMFReader::ReadRecordParams(unsigned short)()

** CID 984091:  Uninitialized scalar field  (UNINIT_CTOR)
/filter/source/msfilter/msdffimp.cxx: 5562 in SvxMSDffManager::SvxMSDffManager(SvStream &,
const rtl::OUString &, unsigned int, SvStream *, SdrModel *, long, unsigned int, unsigned long,
SvStream *)()

** CID 1242859:  Untrusted loop bound  (TAINTED_SCALAR)
/vcl/source/gdi/regionband.cxx: 268 in RegionBand::load(SvStream &)()

** CID 1244944:  Use of untrusted scalar value  (TAINTED_SCALAR)
/vcl/source/gdi/cvtsvm.cxx: 404 in ImplReadExtendedPolyPolygonAction(SvStream &,
tools::PolyPolygon &)()

** CID 1244945:  Untrusted value as argument  (TAINTED_SCALAR)

** CID 1244946:  Untrusted value as argument  (TAINTED_SCALAR)

** CID 1266440:  Unchecked return value  (CHECKED_RETURN)
/svx/source/tbxctrls/Palette.cxx: 196 in PaletteSOC::LoadColorSet(SvxColorValueSet &)()

** CID 1266441:  Unchecked return value  (CHECKED_RETURN)
/sw/source/filter/ww8/rtfattributeoutput.cxx: 3837 in
RtfAttributeOutput::FlyFrameGraphic(const SwFlyFrmFmt *, const SwGrfNode *)()
/sw/source/filter/ww8/rtfattributeoutput.cxx: 3853 in
RtfAttributeOutput::FlyFrameGraphic(const SwFlyFrmFmt *, const SwGrfNode *)()

** CID 1266442:  Dereference after null check  (FORWARD_NULL)
/sw/source/uibase/docvw/edtwin.cxx: 2976 in SwEditWin::MouseButtonDown(const MouseEvent &)()

** CID 1266443:  Dereference after null check  (FORWARD_NULL)
/sw/source/core/layout/trvlfrm.cxx: 749 in lcl_UpDown(SwPaM *, const SwCntntFrm *, const SwCntntFrm
*(*)(const SwCntntFrm *), bool)()

** CID 1266444:  Explicit null dereferenced  (FORWARD_NULL)
/sw/source/filter/ww8/wrtw8nds.cxx: 1528 in WW8Export::TrueFrameBgBrush(const SwFrmFmt &) const()

** CID 1266445:  Explicit null dereferenced  (FORWARD_NULL)
/cppuhelper/source/component_context.cxx: 747 in cppu::ComponentContext::disposing()()

** CID 1266446:  Explicit null dereferenced  (FORWARD_NULL)
/sw/source/core/undo/unattr.cxx: 594 in SwUndoFmtResetAttr::SwUndoFmtResetAttr(SwFmt &,
unsigned short)()

** CID 1266447:  Explicit null dereferenced  (FORWARD_NULL)
/sw/source/filter/ww8/wrtw8nds.cxx: 1508 in WW8Export::GetCurrentPageBgBrush() const()

** CID 1266448:  Explicit null dereferenced  (FORWARD_NULL)
/sc/source/filter/excel/xiescher.cxx: 243 in XclImpDrawObjBase::ReadObj4(const XclImpRoot &,
XclImpStream &)()

________________________________________________________________________________________________________
*** CID 440858:  Argument cannot be negative  (NEGATIVE_RETURNS)
/svtools/source/brwbox/brwbox1.cxx: 310 in BrowseBox::ToggleSelectedColumn()()
304     {
305         sal_uInt16 nSelectedColId = BROWSER_INVALIDID;
306         if ( pColSel && pColSel->GetSelectCount() )
307         {
308             DoHideCursor( "ToggleSelectedColumn" );
309             ToggleSelection();
>>>     CID 440858:  Argument cannot be negative  (NEGATIVE_RETURNS)
>>>     "this->pColSel->FirstSelected(false)" is passed to a parameter that cannot be negative. [Note: The
source code implementation of the function has been overridden by a builtin model.]
310             nSelectedColId = (*pCols)[ pColSel->FirstSelected() ]->GetId();
311             pColSel->SelectAll(false);
312         }
313         return nSelectedColId;
314     }
315     

________________________________________________________________________________________________________
*** CID 703982:  Unchecked return value  (CHECKED_RETURN)
/sc/source/core/data/table2.cxx: 2758 in ScTable::SetRowHeightRange(int, int, unsigned short,
double, double)()
2752                 if (pDrawLayer->HasObjectsInRows( nTab, nStartRow, nEndRow ))
2753                     bSingle = true;
2754     
2755             if (bSingle)
2756             {
2757                 ScFlatUInt16RowSegments::RangeData aData;
>>>     CID 703982:  Unchecked return value  (CHECKED_RETURN)
>>>     Calling "getRangeData" without checking return value (as is done elsewhere 5 out of 6 times).
2758                 mpRowHeights->getRangeData(nStartRow, aData);
2759                 if (nNewHeight == aData.mnValue && nEndRow <= aData.mnRow2)
2760                     bSingle = false;    // no difference in this range
2761             }
2762             if (bSingle)
2763             {

________________________________________________________________________________________________________
*** CID 704680:  Dereference after null check  (FORWARD_NULL)
/sc/source/filter/excel/xeformula.cxx: 591 in XclExpFmlaCompImpl::Init(XclFormulaType, const
ScTokenArray &, const ScAddress *, std::vector<XclExpRefLogEntry,
std::allocator<XclExpRefLogEntry>> *)()
585             case EXC_FMLATYPE_CHART:
586                 mxData->mbOk = pScBasePos != 0;
587                 OSL_ENSURE( mxData->mbOk, "XclExpFmlaCompImpl::Init - missing cell address" );
588                 mxData->mpScBasePos = pScBasePos;
589             break;
590             case EXC_FMLATYPE_SHARED:
>>>     CID 704680:  Dereference after null check  (FORWARD_NULL)
>>>     Comparing "pScBasePos" to null implies that "pScBasePos" might be null.
591                 mxData->mbOk = pScBasePos != 0;
592                 OSL_ENSURE( mxData->mbOk, "XclExpFmlaCompImpl::Init - missing cell address" );
593                 // clone the passed token array, convert references relative to current cell position
594                 mxData->mxOwnScTokArr.reset( rScTokArr.Clone() );
595                 ScCompiler::MoveRelWrap( *mxData->mxOwnScTokArr, GetDocPtr(), *pScBasePos, MAXCOL, MAXROW );
596                 // don't remember pScBasePos in mxData->mpScBasePos, shared formulas use real relative refs

________________________________________________________________________________________________________
*** CID 735323:  Unchecked return value  (CHECKED_RETURN)
/sd/source/filter/eppt/eppt.cxx: 394 in PPTWriter::ImplWriteSlideMaster(unsigned int, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>)()
388         {
389             if ( nInstance == EPP_TEXTTYPE_notUsed )
390                 continue;
391     
392             // the auto color is dependent to the page background,so we have to set a page that is in the right context
393             if ( nInstance == EPP_TEXTTYPE_Notes )
>>>     CID 735323:  Unchecked return value  (CHECKED_RETURN)
>>>     Calling "GetPageByIndex" without checking return value (as is done elsewhere 5 out of 6 times).
394                 GetPageByIndex( 0, NOTICE );
395             else
396                 GetPageByIndex( 0, MASTER );
397     
398             mpPptEscherEx->BeginAtom();
399     

________________________________________________________________________________________________________
*** CID 982431:  Division or modulo by float zero  (DIVIDE_BY_ZERO)
/vcl/source/filter/wmf/winwmf.cxx: 233 in WMFReader::ReadRecordParams(unsigned short)()
227             break;
228     
229             case W_META_SCALEWINDOWEXT:
230             {
231                 short nXNum = 0, nXDenom = 0, nYNum = 0, nYDenom = 0;
232                 pWMF->ReadInt16( nYDenom ).ReadInt16( nYNum ).ReadInt16( nXDenom ).ReadInt16( nXNum );
>>>     CID 982431:  Division or modulo by float zero  (DIVIDE_BY_ZERO)
>>>     In expression "(double)nXNum / nXDenom", division by expression "nXDenom" which may be zero has
undefined behavior.
233                 pOut->ScaleWinExt( (double)nXNum / nXDenom, (double)nYNum / nYDenom );
234             }
235             break;
236     
237             case W_META_SETVIEWPORTORG:
238             case W_META_SETVIEWPORTEXT:
/vcl/source/filter/wmf/winwmf.cxx: 253 in WMFReader::ReadRecordParams(unsigned short)()
247             break;
248     
249             case W_META_SCALEVIEWPORTEXT:
250             {
251                 short nXNum = 0, nXDenom = 0, nYNum = 0, nYDenom = 0;
252                 pWMF->ReadInt16( nYDenom ).ReadInt16( nYNum ).ReadInt16( nXDenom ).ReadInt16( nXNum );
>>>     CID 982431:  Division or modulo by float zero  (DIVIDE_BY_ZERO)
>>>     In expression "(double)nXNum / nXDenom", division by expression "nXDenom" which may be zero has
undefined behavior.
253                 pOut->ScaleDevExt( (double)nXNum / nXDenom, (double)nYNum / nYDenom );
254             }
255             break;
256     
257             case W_META_LINETO:
258             {

________________________________________________________________________________________________________
*** CID 982432:  Division or modulo by float zero  (DIVIDE_BY_ZERO)
/vcl/source/filter/wmf/winwmf.cxx: 233 in WMFReader::ReadRecordParams(unsigned short)()
227             break;
228     
229             case W_META_SCALEWINDOWEXT:
230             {
231                 short nXNum = 0, nXDenom = 0, nYNum = 0, nYDenom = 0;
232                 pWMF->ReadInt16( nYDenom ).ReadInt16( nYNum ).ReadInt16( nXDenom ).ReadInt16( nXNum );
>>>     CID 982432:  Division or modulo by float zero  (DIVIDE_BY_ZERO)
>>>     In expression "(double)nYNum / nYDenom", division by expression "nYDenom" which may be zero has
undefined behavior.
233                 pOut->ScaleWinExt( (double)nXNum / nXDenom, (double)nYNum / nYDenom );
234             }
235             break;
236     
237             case W_META_SETVIEWPORTORG:
238             case W_META_SETVIEWPORTEXT:
/vcl/source/filter/wmf/winwmf.cxx: 253 in WMFReader::ReadRecordParams(unsigned short)()
247             break;
248     
249             case W_META_SCALEVIEWPORTEXT:
250             {
251                 short nXNum = 0, nXDenom = 0, nYNum = 0, nYDenom = 0;
252                 pWMF->ReadInt16( nYDenom ).ReadInt16( nYNum ).ReadInt16( nXDenom ).ReadInt16( nXNum );
>>>     CID 982432:  Division or modulo by float zero  (DIVIDE_BY_ZERO)
>>>     In expression "(double)nYNum / nYDenom", division by expression "nYDenom" which may be zero has
undefined behavior.
253                 pOut->ScaleDevExt( (double)nXNum / nXDenom, (double)nYNum / nYDenom );
254             }
255             break;
256     
257             case W_META_LINETO:
258             {

________________________________________________________________________________________________________
*** CID 984091:  Uninitialized scalar field  (UNINIT_CTOR)
/filter/source/msfilter/msdffimp.cxx: 5562 in SvxMSDffManager::SvxMSDffManager(SvStream &,
const rtl::OUString &, unsigned int, SvStream *, SdrModel *, long, unsigned int, unsigned long,
SvStream *)()
5556         CheckTxBxStoryChain();
5557     
5558         // restore old FilePos of the stream(s)
5559         rStCtrl.Seek( nOldPosCtrl );
5560         if( &rStCtrl != pStData )
5561             pStData->Seek( nOldPosData );
>>>     CID 984091:  Uninitialized scalar field  (UNINIT_CTOR)
>>>     Non-static class member "mnIdClusters" is not initialized in this constructor nor in any functions
that it calls.
5562     }
5563     
5564     SvxMSDffManager::SvxMSDffManager( SvStream& rStCtrl_, const OUString& rBaseURL )
5565         :DffPropertyReader( *this ),
5566          pFormModel( NULL ),
5567          pBLIPInfos(   new SvxMSDffBLIPInfos  ),

________________________________________________________________________________________________________
*** CID 1242859:  Untrusted loop bound  (TAINTED_SCALAR)
/vcl/source/gdi/regionband.cxx: 268 in RegionBand::load(SvStream &)()
262                 return;
263             }
264     
265             // get next header
266             rIStrm.ReadUInt16( nTmp16 );
267         }
>>>     CID 1242859:  Untrusted loop bound  (TAINTED_SCALAR)
>>>     Using tainted variable "(StreamEntryType)nTmp16" as a loop boundary.
268         while(STREAMENTRY_END != (StreamEntryType)nTmp16);
269     
270     }
271     
272     void RegionBand::save(SvStream& rOStrm) const
273     {

________________________________________________________________________________________________________
*** CID 1244944:  Use of untrusted scalar value  (TAINTED_SCALAR)
/vcl/source/gdi/cvtsvm.cxx: 408 in ImplReadExtendedPolyPolygonAction(SvStream &,
tools::PolyPolygon &)()
402             return;
403     
404         for(sal_uInt16 a(0); a < nPolygonCount; a++)
405         {
406             sal_uInt16 nPointCount(0);
407             rIStm.ReadUInt16( nPointCount );
>>>     CID 1244944:  Use of untrusted scalar value  (TAINTED_SCALAR)
>>>     Passing tainted variable "nPointCount" to a tainted sink.
408             Polygon aCandidate(nPointCount);
409     
410             if(nPointCount)
411             {
412                 for(sal_uInt16 b(0); b < nPointCount; b++)
413                 {
/vcl/source/gdi/cvtsvm.cxx: 404 in ImplReadExtendedPolyPolygonAction(SvStream &,
tools::PolyPolygon &)()
398         sal_uInt16 nPolygonCount(0);
399         rIStm.ReadUInt16( nPolygonCount );
400     
401         if (!nPolygonCount)
402             return;
403     
>>>     CID 1244944:  Use of untrusted scalar value  (TAINTED_SCALAR)
>>>     Using tainted variable "nPolygonCount" as a loop boundary.
404         for(sal_uInt16 a(0); a < nPolygonCount; a++)
405         {
406             sal_uInt16 nPointCount(0);
407             rIStm.ReadUInt16( nPointCount );
408             Polygon aCandidate(nPointCount);
409     

________________________________________________________________________________________________________
*** CID 1244945:  Untrusted value as argument  (TAINTED_SCALAR)
/tools/source/generic/poly2.cxx: 637 in tools::PolyPolygon::Read(SvStream &)()
631         {
632             if ( mpImplPolyPolygon->mnRefCount > 1 )
633                 mpImplPolyPolygon->mnRefCount--;
634             else
635                 delete mpImplPolyPolygon;
636     
>>>     CID 1244945:  Untrusted value as argument  (TAINTED_SCALAR)
>>>     Passing tainted variable "nPolyCount" to a tainted sink.
637             mpImplPolyPolygon = new ImplPolyPolygon( nPolyCount );
638     
639             for ( sal_uInt16 i = 0; i < nPolyCount; i++ )
640             {
641                 pPoly = new Polygon;
642                 pPoly->ImplRead( rIStream );

________________________________________________________________________________________________________
*** CID 1244946:  Untrusted value as argument  (TAINTED_SCALAR)
/tools/source/generic/poly2.cxx: 588 in tools::ReadPolyPolygon(SvStream &, tools::PolyPolygon &)()
582         {
583             if ( rPolyPoly.mpImplPolyPolygon->mnRefCount > 1 )
584                 rPolyPoly.mpImplPolyPolygon->mnRefCount--;
585             else
586                 delete rPolyPoly.mpImplPolyPolygon;
587     
>>>     CID 1244946:  Untrusted value as argument  (TAINTED_SCALAR)
>>>     Passing tainted variable "nPolyCount" to a tainted sink.
588             rPolyPoly.mpImplPolyPolygon = new ImplPolyPolygon( nPolyCount );
589     
590             for ( sal_uInt16 i = 0; i < nPolyCount; i++ )
591             {
592                 pPoly = new Polygon;
593                 ReadPolygon( rIStream, *pPoly );

________________________________________________________________________________________________________
*** CID 1266440:  Unchecked return value  (CHECKED_RETURN)
/svx/source/tbxctrls/Palette.cxx: 196 in PaletteSOC::LoadColorSet(SvxColorValueSet &)()
190     void PaletteSOC::LoadColorSet( SvxColorValueSet& rColorSet )
191     {
192         if( !mbLoadedPalette )
193         {
194             mbLoadedPalette = true;
195             mpColorList =
XPropertyList::AsColorList(XPropertyList::CreatePropertyListFromURL(XCOLOR_LIST, maFPath));
>>>     CID 1266440:  Unchecked return value  (CHECKED_RETURN)
>>>     Calling "Load" without checking return value (as is done elsewhere 9 out of 10 times).
196             mpColorList->Load();
197         }
198         rColorSet.Clear();
199         if( mpColorList.is() )
200             rColorSet.addEntriesForXColorList( *mpColorList );
201     }

________________________________________________________________________________________________________
*** CID 1266441:  Unchecked return value  (CHECKED_RETURN)
/sw/source/filter/ww8/rtfattributeoutput.cxx: 3837 in
RtfAttributeOutput::FlyFrameGraphic(const SwFlyFrmFmt *, const SwGrfNode *)()
3831         bool bWritePicProp = !pFrame || pFrame->IsInline();
3832         if (pBLIPType)
3833             ExportPICT(pFlyFrmFmt, aSize, aRendered, aMapped, rCr, pBLIPType, pGraphicAry, nSize,
m_rExport, &m_rExport.Strm(), bWritePicProp);
3834         else
3835         {
3836             aStream.Seek(0);
>>>     CID 1266441:  Unchecked return value  (CHECKED_RETURN)
>>>     Calling "Export" without checking return value (as is done elsewhere 12 out of 15 times).
3837             GraphicConverter::Export(aStream, rGraphic, CVT_WMF);
3838             pBLIPType = OOO_STRING_SVTOOLS_RTF_WMETAFILE;
3839             aStream.Seek(STREAM_SEEK_TO_END);
3840             nSize = aStream.Tell();
3841             pGraphicAry = (sal_uInt8*)aStream.GetData();
3842     
/sw/source/filter/ww8/rtfattributeoutput.cxx: 3853 in
RtfAttributeOutput::FlyFrameGraphic(const SwFlyFrmFmt *, const SwGrfNode *)()
3847         {
3848             if (!bIsWMF)
3849             {
3850                 m_rExport.Strm().WriteCharPtr("}" "{" OOO_STRING_SVTOOLS_RTF_NONSHPPICT);
3851     
3852                 aStream.Seek(0);
>>>     CID 1266441:  Unchecked return value  (CHECKED_RETURN)
>>>     Calling "Export" without checking return value (as is done elsewhere 12 out of 15 times).
3853                 GraphicConverter::Export(aStream, rGraphic, CVT_WMF);
3854                 pBLIPType = OOO_STRING_SVTOOLS_RTF_WMETAFILE;
3855                 aStream.Seek(STREAM_SEEK_TO_END);
3856                 nSize = aStream.Tell();
3857                 pGraphicAry = (sal_uInt8*)aStream.GetData();
3858     

________________________________________________________________________________________________________
*** CID 1266442:  Dereference after null check  (FORWARD_NULL)
/sw/source/uibase/docvw/edtwin.cxx: 2976 in SwEditWin::MouseButtonDown(const MouseEvent &)()
2970         if( rSh.FinishOLEObj() )
2971             return; // end InPlace and the click doesn't count anymore
2972     
2973         SET_CURR_SHELL( &rSh );
2974     
2975         SdrView *pSdrView = rSh.GetDrawView();
>>>     CID 1266442:  Dereference after null check  (FORWARD_NULL)
>>>     Comparing "pSdrView" to null implies that "pSdrView" might be null.
2976         if ( pSdrView )
2977         {
2978             if (pSdrView->MouseButtonDown( rMEvt, this ) )
2979             {
2980                 rSh.GetView().GetViewFrame()->GetBindings().InvalidateAll(false);
2981                 return; // SdrView's event evaluated

________________________________________________________________________________________________________
*** CID 1266443:  Dereference after null check  (FORWARD_NULL)
/sw/source/core/layout/trvlfrm.cxx: 749 in lcl_UpDown(SwPaM *, const SwCntntFrm *, const SwCntntFrm
*(*)(const SwCntntFrm *), bool)()
743             pStart->GetCharRect( aRect, *pPam->GetPoint() );
744             Point aCenter = aRect.Center();
745             nX = bVert ? aCenter.Y() : aCenter.X();
746     
747             pTable = pCnt ? pCnt->FindTabFrm() : 0;
748             if ( !pTable )
>>>     CID 1266443:  Dereference after null check  (FORWARD_NULL)
>>>     Assigning: "pTable" = "pStTab".
749                 pTable = pStTab;
750     
751             if ( pStTab &&
752                 !pStTab->GetUpper()->IsInTab() &&
753                 !pTable->GetUpper()->IsInTab() )
754             {

________________________________________________________________________________________________________
*** CID 1266444:  Explicit null dereferenced  (FORWARD_NULL)
/sw/source/filter/ww8/wrtw8nds.cxx: 1528 in WW8Export::TrueFrameBgBrush(const SwFrmFmt &) const()
1522         while (pFlyFmt)
1523         {
1524             //If not set, or "no fill", get real bg
1525             const SfxPoolItem* pItem = 0;
1526             SfxItemState eState =
1527                 pFlyFmt->GetItemState(RES_BACKGROUND, true, &pItem);
>>>     CID 1266444:  Explicit null dereferenced  (FORWARD_NULL)
>>>     Assigning: "pRet" = "pItem".
1528             pRet = static_cast<const SvxBrushItem*>(pItem);
1529             if (SfxItemState::SET != eState || (!pRet->GetGraphic() &&
1530                 pRet->GetColor() == COL_TRANSPARENT))
1531             {
1532                 pRet = 0;
1533                 const SwFmtAnchor* pAnchor = &pFlyFmt->GetAnchor();

________________________________________________________________________________________________________
*** CID 1266445:  Explicit null dereferenced  (FORWARD_NULL)
/cppuhelper/source/component_context.cxx: 747 in cppu::ComponentContext::disposing()()
741             &envs, &envCount, &rtl_allocateMemory, OUString("java").pData);
742         assert(envCount >= 0);
743         assert(envCount == 0 || envs != nullptr);
744         for (sal_Int32 i = 0; i != envCount; ++i) {
745             assert(envs[i] != nullptr);
746             assert(envs[i]->dispose != nullptr);
>>>     CID 1266445:  Explicit null dereferenced  (FORWARD_NULL)
>>>     Dereferencing null pointer "envs".
747             (*envs[i]->dispose)(envs[i]);
748         }
749         rtl_freeMemory(envs);
750     }
751     
752     ComponentContext::ComponentContext(

________________________________________________________________________________________________________
*** CID 1266446:  Explicit null dereferenced  (FORWARD_NULL)
/sw/source/core/undo/unattr.cxx: 594 in SwUndoFmtResetAttr::SwUndoFmtResetAttr(SwFmt &,
unsigned short)()
588         , m_pChangedFormat( &rChangedFormat )
589         , m_nWhichId( nWhichId )
590     {
591         const SfxPoolItem* pItem = 0;
592         if (rChangedFormat.GetItemState( nWhichId, false, &pItem ) == SfxItemState::SET)
593         {
>>>     CID 1266446:  Explicit null dereferenced  (FORWARD_NULL)
>>>     Passing null pointer "pItem" to "Clone", which dereferences it. (The dereference happens because
this is a virtual function call.)
594             m_pOldItem.reset( pItem->Clone() );
595         }
596     }
597     
598     SwUndoFmtResetAttr::~SwUndoFmtResetAttr()
599     {

________________________________________________________________________________________________________
*** CID 1266447:  Explicit null dereferenced  (FORWARD_NULL)
/sw/source/filter/ww8/wrtw8nds.cxx: 1508 in WW8Export::GetCurrentPageBgBrush() const()
1502                         : pDoc->GetPageDesc(0).GetMaster();
1503     
1504         const SfxPoolItem* pItem = 0;
1505         //If not set, or "no fill", get real bg
1506         SfxItemState eState = rFmt.GetItemState(RES_BACKGROUND, true, &pItem);
1507     
>>>     CID 1266447:  Explicit null dereferenced  (FORWARD_NULL)
>>>     Assigning: "pRet" = "pItem".
1508         const SvxBrushItem* pRet = static_cast<const SvxBrushItem*>(pItem);
1509         if (SfxItemState::SET != eState || (!pRet->GetGraphic() &&
1510             pRet->GetColor() == COL_TRANSPARENT))
1511         {
1512             pRet = &(DefaultItemGet<SvxBrushItem>(*pDoc,RES_BACKGROUND));
1513         }

________________________________________________________________________________________________________
*** CID 1266448:  Explicit null dereferenced  (FORWARD_NULL)
/sc/source/filter/excel/xiescher.cxx: 243 in XclImpDrawObjBase::ReadObj4(const XclImpRoot &,
XclImpStream &)()
237                     OSL_TRACE( "XclImpDrawObjBase::ReadObj4 - unknown object type 0x%04hX", nObjType );
238                     rRoot.GetTracer().TraceUnsupportedObjects();
239                     xDrawObj.reset( new XclImpPhObj( rRoot ) );
240             }
241         }
242     
>>>     CID 1266448:  Explicit null dereferenced  (FORWARD_NULL)
>>>     Dereferencing null pointer "xDrawObj".
243         xDrawObj->mnTab = rRoot.GetCurrScTab();
244         xDrawObj->ImplReadObj4( rStrm );
245         return xDrawObj;
246     }
247     
248     XclImpDrawObjRef XclImpDrawObjBase::ReadObj5( const XclImpRoot& rRoot, XclImpStream& rStrm )

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/211?tab=overview

To manage Coverity Scan email notifications for "libreoffice <at> lists.freedesktop.org", click
https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939 .

_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 25 Jan 14:13 2015

[Bug 79641] LibreOffice 4.4 most annoying bugs

Comment # 36 on bug 79641 from Added https://bugs.documentfoundation.org/show_bug.cgi?id=88786 Sign result with a rest between a number and an array is changed.
You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Gmane