LibreOffice development

Thomas Arnhold | 19 May 2013 18:24

Font family case-sensitiveness

Hi,

A quick grep on the source reveals that there case-sensitive and 
case-insensitive comparisons for the font family name. This looks pretty 
suspicious.

git grep -i \"starsymbol\" -- *.cxx

Should we always check case-insensitive or convert all lower-case ones 
to "StarSymbol" (most/all? definitions of this string are mixed case).

The same holds for "opensymbol". Maybe more...

And maybe there is more work with GetFamilyName()..., see 
79e5615fa103a52ce41ed682b624c13fd9a9d1eb.

Ideas?

Thomas

headers

leo2013 | 19 May 2013 17:45

Build libreoffice error for xml2 on windows7.

These days, I'm trying to build the libreoffice on windows7(sp1,x64).
I referenced to the wiki:
https://wiki.documentfoundation.org/Development/BuildingOnWindows
I download some software accoring to the wiki site:
https://wiki.documentfoundation.org/Development/Windows_Build_Dependencies
1.windows sdk
2.vs2012
3.DirectX sdk
4.GDI+ Redistributable (but not used according to the note)
5.Dot NET SDK v2.0 (Important: x86, not x64!!!)
6.Java Development Kit (use a 32bit SDK)
7.Microsoft Visual C++ 2010 SP1 Redistributable Package (x86) (but not used
cause I used vs2012)
8.Apache ANT
9.Junit 4
10.Mozilla build tooling (only for stable LibreOffice versions <4.1) (but
not used)
11.LO patched GNU make 3.82: install it at the cygwin path /opt/lo/bin/make
12.LO patched ccache: install it at the cygwin path /opt/lo/bin/ccache
13.Cygwin's setup.exe
After installing and configuring them, I began to build source codes from
site:
http://cgit.freedesktop.org/libreoffice/core/log/?h=feature/formula-core-rework
I used:
--with-parallelism=4
--disable-odk
--with-junit=/opt/lo/misc/junit-4.10.jar 
--with-ant-home=/opt/lo/misc/apache-ant-1.9.0
--with-jdk-home=D:/x86/Java/jdk1.7.0_21
--enable-pch

(Continue reading)

headers

Arnaud Versini (via Code Review | 19 May 2013 17:34

[PATCH] Use clock_gettime when available on *nix

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3964

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/3964/1

Use clock_gettime when available on *nix

Change-Id: I65df2b119dbda274749ab2b4d0825fbdf44eb4e8
---
M sal/osl/unx/time.c
1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/sal/osl/unx/time.c b/sal/osl/unx/time.c
index 4294cd2..796e882 100644
--- a/sal/osl/unx/time.c
+++ b/sal/osl/unx/time.c
 <at>  <at>  -24,6 +24,7  <at>  <at> 
 #include <osl/time.h>
 #include <time.h>
 #include <assert.h>
+#include <unistd>

 /* FIXME: detection should be done in configure script */
 #if defined(MACOSX) || defined(FREEBSD) || defined(NETBSD) || \
 <at>  <at>  -34,7 +35,11  <at>  <at>

(Continue reading)

headers

Lionel Elie Mamane (via Code Review | 19 May 2013 13:30

[PATCH libreoffice-3-6] fdo#47951 work around underlying cause

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3963

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3963/1

fdo#47951 work around underlying cause

The true cause is that the flat text file database driver mishandles
the case of two ResultSets being open on the same table: the moving
commands of one impact the other.

Since in this case:

 - one ResultSet is open by the dispatch of
   ".component:DB/DataSourceBrowser", that is the grid UI shown to the
   user, and that ResultSet is kept open to serve requests by the user
   to scroll;

 - the second ResultSet is opened by the call to
   pNewDBMgr->GetColumnNames
   and that ResultSet is closed by the time GetColumnNames returns

We just swap the order of these calls to work around the underlying
driver bug.

(Continue reading)

headers

Lionel Elie Mamane (via Code Review | 19 May 2013 13:27

[PATCH libreoffice-3-6] fdo#47951 flat text table: update m_nRowPos when moving by b...

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3962

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3962/1

fdo#47951 flat text table: update m_nRowPos when moving by bookmark

Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
---
M connectivity/source/drivers/flat/ETable.cxx
1 file changed, 14 insertions(+), 0 deletions(-)

diff --git a/connectivity/source/drivers/flat/ETable.cxx b/connectivity/source/drivers/flat/ETable.cxx
index b7f61ed..fc1124e 100644
--- a/connectivity/source/drivers/flat/ETable.cxx
+++ b/connectivity/source/drivers/flat/ETable.cxx
 <at>  <at>  -873,15 +873,29  <at>  <at> 
             break;
         case IResultSetHelper::BOOKMARK:
             {
+                m_nRowPos = 0;
                 TRowPositionsInFile::const_iterator aFind = m_aFilePosToEndLinePos.find(nOffset);
                 m_bNeedToReadLine = aFind != m_aFilePosToEndLinePos.end();
                 if ( m_bNeedToReadLine )
                 {

(Continue reading)

headers

Lionel Elie Mamane (via Code Review | 19 May 2013 13:26

[PATCH libreoffice-4-0] fdo#47951 flat text table: update m_nRowPos when moving by b...

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3961

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3961/1

fdo#47951 flat text table: update m_nRowPos when moving by bookmark

Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
---
M connectivity/source/drivers/flat/ETable.cxx
1 file changed, 14 insertions(+), 0 deletions(-)

diff --git a/connectivity/source/drivers/flat/ETable.cxx b/connectivity/source/drivers/flat/ETable.cxx
index 9fe48f0..8ae7935 100644
--- a/connectivity/source/drivers/flat/ETable.cxx
+++ b/connectivity/source/drivers/flat/ETable.cxx
 <at>  <at>  -869,15 +869,29  <at>  <at> 
             break;
         case IResultSetHelper::BOOKMARK:
             {
+                m_nRowPos = 0;
                 TRowPositionsInFile::const_iterator aFind = m_aFilePosToEndLinePos.find(nOffset);
                 m_bNeedToReadLine = aFind != m_aFilePosToEndLinePos.end();
                 if ( m_bNeedToReadLine )
                 {

(Continue reading)

headers

Arnaud Versini (via Code Review | 19 May 2013 13:25

[PATCH] Multi threaded version of osl_getGlobalTime on Unix

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3960

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/3960/1

Multi threaded version of osl_getGlobalTime on Unix

Change-Id: Ibb9d23780600437f607d866ff3d396b96879245d
---
M sal/osl/unx/salinit.cxx
M sal/osl/unx/time.c
2 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/sal/osl/unx/salinit.cxx b/sal/osl/unx/salinit.cxx
index 327ca0e..b33e5f3 100644
--- a/sal/osl/unx/salinit.cxx
+++ b/sal/osl/unx/salinit.cxx
 <at>  <at>  -38,6 +38,8  <at>  <at> 

 extern "C" {

+void sal_initGlobalTimer();
+
 void sal_detail_initialize(int argc, char ** argv) {
 #if defined MACOSX

(Continue reading)

headers

Lionel Elie Mamane (via Code Review | 19 May 2013 13:25

[PATCH libreoffice-4-0] fdo#47951 work around underlying cause

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3959

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/3959/1

fdo#47951 work around underlying cause

The true cause is that the flat text file database driver mishandles
the case of two ResultSets being open on the same table: the moving
commands of one impact the other.

Since in this case:

 - one ResultSet is open by the dispatch of
   ".component:DB/DataSourceBrowser", that is the grid UI shown to the
   user, and that ResultSet is kept open to serve requests by the user
   to scroll;

 - the second ResultSet is opened by the call to
   pNewDBMgr->GetColumnNames
   and that ResultSet is closed by the time GetColumnNames returns

We just swap the order of these calls to work around the underlying
driver bug.

(Continue reading)

headers

Alexander Thurgood | 19 May 2013 10:58

Build failure of Gallery on Mac OSX in gengal.bin on master

Hi all,

Since yesterday, I have been geting a build failure on OSX 10.8 in
gengal.bin with the following, even after a make clean and fresh pull
from master :

[build GAL] arrows
[build GAL] computers
2013-05-18 15:08:21.331 gengal.bin(89486:707) No Info.plist file in
application bundle or no NSPrincipalClass in the Info.plist file, exiting
2013-05-18 15:08:21.331 gengal.bin(89486:707) *** -[NSAutoreleasePool
release]: This pool has already been released, do not drain it (double
release)
make [1]: ***
[/Users/Shared/Repos/LO/core/workdir/unxmacxi.pro/Gallery/arrows.done]
Error 1

This appears to be a direct result of Matus' commit :

bae52ee3ef48d58deb6d7ff312b3f3db20c9c0f2

Alex

headers

Marcos Paulo dos Santos (via Code Review | 19 May 2013 00:42

[PATCH] fdo#38838 Replacement of the String with OUString

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3958

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/3958/1

fdo#38838 Replacement of the String with OUString

Change-Id: I1feaa0bee39868aedd768202b584cabc1010f4d6
---
M cui/source/tabpages/tabarea.cxx
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cui/source/tabpages/tabarea.cxx b/cui/source/tabpages/tabarea.cxx
index 236333d..a5b6772 100644
--- a/cui/source/tabpages/tabarea.cxx
+++ b/cui/source/tabpages/tabarea.cxx
 <at>  <at>  -135,7 +135,7  <at>  <at> 

     // save the tables when they have been changed

-    const String aPath( SvtPathOptions().GetPalettePath() );
+    const OUString aPath( SvtPathOptions().GetPalettePath() );

     if( mnHatchingListState & CT_MODIFIED )
     {

(Continue reading)

headers

Kohei Yoshida | 18 May 2013 22:11

Fwd: libreoffice + liborcus build problem

Forwarding it to the list.

---------- Forwarded message ----------
From: Arkadiusz Miśkiewicz <arekm <at> maven.pl>
Date: Sat, May 18, 2013 at 3:17 PM
Subject: libreoffice + liborcus build problem
To: Kohei Yoshida <kohei.yoshida <at> gmail.com>

Hi,

Trying to build libreoffice 4.0.3.3 with liborcus 0.5.1 and that unfortunately
fails with:

http://tnij.org/vqp8 (build log)

eg:
sc/source/filter/orcus/orcusfiltersimpl.cxx:36:20: error: cannot declare
variable 'aFactory' to be of abstract type 'ScOrcusFactory'
sc/source/filter/orcus/interface.cxx:32:69: error: cannot allocate an object
of abstract type 'ScOrcusSheet'

and similar.

Is there fix for that somewhere in libreoffice git branches?

Thanks,
--
Arkadiusz Miśkiewicz, arekm / maven.pl

<div>
<p>Forwarding it to the list.<br><br></p>
<div class="gmail_quote">---------- Forwarded message ----------<br>From: Arkadiusz Mi&#347;kiewicz <span dir="ltr">&lt;<a href="mailto:arekm <at> maven.pl">arekm <at> maven.pl</a>&gt;</span><br>
Date: Sat, May 18, 2013 at 3:17 PM<br>Subject: libreoffice + liborcus build problem<br>To: Kohei Yoshida &lt;<a href="mailto:kohei.yoshida <at> gmail.com">kohei.yoshida <at> gmail.com</a>&gt;<br><br><br><br>
Hi,<br><br>
Trying to build libreoffice 4.0.3.3 with liborcus 0.5.1 and that unfortunately<br>
fails with:<br><br><a href="http://tnij.org/vqp8" target="_blank">http://tnij.org/vqp8</a> &nbsp;(build log)<br><br>
eg:<br>
sc/source/filter/orcus/orcusfiltersimpl.cxx:36:20: error: cannot declare<br>
variable 'aFactory' to be of abstract type 'ScOrcusFactory'<br>
sc/source/filter/orcus/interface.cxx:32:69: error: cannot allocate an object<br>
of abstract type 'ScOrcusSheet'<br><br>
and similar.<br><br>
Is there fix for that somewhere in libreoffice git branches?<br><br><br>
Thanks,<br><span class="HOEnZb">--<br>
Arkadiusz Mi&#347;kiewicz, arekm / <a href="http://maven.pl" target="_blank">maven.pl</a><br></span>
</div>
<br>
</div>

860	May 2013
2235	April 2013
2239	March 2013
1456	February 2013
1629	January 2013
1238	December 2012
1355	November 2012
1318	October 2012
1313	September 2012
1605	August 2012
1648	July 2012
1554	June 2012
1414	May 2012
1660	April 2012
1734	March 2012
2195	February 2012
1783	January 2012
1326	December 2011
1459	November 2011
1007	October 2011
1374	September 2011
1481	August 2011
1148	July 2011
1434	June 2011
1703	May 2011
1233	April 2011
1185	March 2011
1515	February 2011
1512	January 2011
1494	December 2010
1769	November 2010
1194	October 2010
4	January 2006

Mon	Tue	Wed	Thu	Fri	Sat	Sun

		1	2	3	4	5
6	7	8	9	10	11	12
13	14	15	16	17	18	19
20	21	22	23	24	25	26
27	28	29	30	31