Matthew Nicholls | 29 Mar 17:24 2015
Picon

Matthew Nicholls license statement

All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.

Matthew.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
scan-admin | 29 Mar 12:32 2015

New Defects reported by Coverity Scan for LibreOffice


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)

** CID 1292224:  Control flow issues  (DEADCODE)
/vcl/source/window/btndlg.cxx: 308 in ButtonDialog::AddButton(StandardButtonType, unsigned
short, unsigned short, long)()

________________________________________________________________________________________________________
*** CID 1292224:  Control flow issues  (DEADCODE)
/vcl/source/window/btndlg.cxx: 308 in ButtonDialog::AddButton(StandardButtonType, unsigned
short, unsigned short, long)()
302             nBtnFlags |= BUTTONDIALOG_HELPBUTTON;
303         else if ( (eType == StandardButtonType::Cancel) || (eType == StandardButtonType::Close) )
304             nBtnFlags |= BUTTONDIALOG_CANCELBUTTON;
305         pItem->mpPushButton = ImplCreatePushButton( nBtnFlags );
306     
307         // Standard-Buttons have the right text already
>>>     CID 1292224:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "pItem->mpPushButton->GetType() == 328" inside this
statement: "if (!(eType == StandardButt...".
308         if ( !((eType == StandardButtonType::OK)     && (pItem->mpPushButton->GetType() ==
WINDOW_OKBUTTON)) ||
(Continue reading)

Tor Lillqvist | 29 Mar 08:21 2015
Picon
Picon

How many degrees of headlessness do we need?

As far as I see, we have the following command-line options or other ways to avoid display of GUI elements:

- The --quickstart switch. Starts a LO instance that *initially* has no GUI. But when the user then actually wants to use LO, it is that instance that wakes up and shows the GUI. When the user "quits", the process stays running but goes back to showing no GUI.

- The --invisible switch. Not much used? Exact semantics unknown. What is the intended interaction with existing LibreOffice instances, is there the normal IPC pipe thing going on, so that only one LO instance runs per user session?

- The --headless switch. Perhaps newer than --invisible? Not sure why a separate one is needed and what the exact intended semantics are. Again, how is it supposed to affect the interaction with other LibreOffice instances?

On Linux (and other X11-using Unixes), --headless is tightly coupled to the 'vclplug' concept, as there used to be a 'headless' (actually called 'svp') vclplug that was used (instead of a "generic" X11, GTK or KDE one) in headless mode. Nowadays the 'svp' code is not technically a vclplug any more, but that is just an implementation detail. On Windows and OS X, --headless support is presumably broken to some degree.

Note that Application::EnableHeadlessMode takes a boolean parameter 'dialogsAreFatal', so this mode actually splits into two.

- The Application::EnableConsoleOnly() and IsConsoleOnly() API. No command-line switch. Very new, from 2013. Used only in one program, gengal, for OS X. Not sure if actually does what Michael (who doesn't use OS X) thinks it does. Unclear why the 'headless' thing could not be used instead. (Yesterday I made EnableConsoleOnly() also call EnableHeadlessMode(true).)

-  LibreOfficeKit use of LO code. At least to me, it should be obvious that when some arbitrary program, possibly running as a daemon, as a web service, etc, uses LibreOfficeKit to handle documents, no LO GUI should ever be displayed. Currently LibreOfficeKit turns on 'headless', and since yesterday, also 'console-only'.

This is a mess and needs clarification. There are five modes of headlessness. Do these modes form a hierarchy? Or is it possible, and meaningful, to have a LibreOffice instance that is headless but not invisible, for instance? Could we at least finally kill the quick start concept, which surely is outdated by now?

Then there is also the issue that many (or all?) programs that use LibreOfficeKit should be able to run totally isolated from other processes using LO code (LO itself, or other instances of the same or other LOKit-using processes). There should be no inter-process communication. Perhaps even no reading or writing of user configuration. But this is a separate topic.

--tml
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Picon

CppCheck Report Update


A new cppcheck report is available at : http://dev-builds.libreoffice.org/cppcheck_reports/master/

Note:
    The script generating this report was run at :
        2015-29-03_03:19:25 with user buildslave at host vm140 as
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www

    It can be found and improved here:
        https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh

_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 28 Mar 19:25 2015

[Bug 75025] LibreOffice 4.3 most annoying bugs

changed bug 75025
What Removed Added
Depends on   49514

Comment # 100 on bug 75025 from Add bug #49514 - Search/Find "continue at the beginning" ignores previous footnotes (regression). This bug breaks trust in a basic function and is especially bad since users might not even realize anything is wrong. I've even submitted papers with obvious errors that could have easily been caught if search/find worked correctly.
You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 28 Mar 14:15 2015

[Bug 75025] LibreOffice 4.3 most annoying bugs

Bug 75025 depends on bug 86321, which changed state.
What Removed Added
Status RESOLVED REOPENED
Resolution FIXED ---

You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Justin Luth | 28 Mar 12:36 2015
Picon

Fwd: How do you enable the #ifdef DEBUG sections?

There are sections of the code marked #ifdef DEBUG.  How can I properly
enable compiling those sections in?

For example, I want to enable DEBUG_ELEMENT in
writerfilter/source/ooxml/OOXMLFastContextHandler.cxx.  If I simply add
a "#define DEBUG_ELEMENT" I get errors about some of the code in the
define block (error: ‘debug_logger’ was not declared in this scope).

The document wiki.documentfoundation.org/Development/How_to_debug does
not mention #ifdef debugging blocks.  I'm already compiling with
--enable-dbgutil.  (Linux Mint 12.04, running "make" from a terminal)

Thanks. 
Justin

_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Crashtest VM | 28 Mar 10:48 2015
Picon

Crash test update

New crashtest update available at http://dev-builds.libreoffice.org/crashtest/757f461ef12548af0be470f7c05ff67df3dc1314/
Attachment (exportCrashes.csv): application/octet-stream, 2400 bytes
Attachment (importCrash.csv): application/octet-stream, 14 KiB
Attachment (validationErrors.csv): application/octet-stream, 3364 bytes
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 28 Mar 03:57 2015

[Bug 90290] reduce some copy&paste code in ucalc

Comment # 1 on bug 90290 from And inside of the checkFormula implementation we should use CPPUNIT_ASSERT_EQUAL_MESSAGE which will print the expected and actual string in case of a failure.
You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 28 Mar 03:30 2015

[Bug 90290] reduce some copy&paste code in ucalc

changed bug 90290
What Removed Added
Status UNCONFIRMED NEW
CC   libreoffice <at> lists.freedesktop.org
Ever confirmed   1
Whiteboard   EasyHack DifficultyBeginner SkillCpp

You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bugzilla-daemon | 28 Mar 03:10 2015

[Bug 75025] LibreOffice 4.3 most annoying bugs

Bug 75025 depends on bug 86321, which changed state.
What Removed Added
Status NEW RESOLVED
Resolution --- FIXED

You are receiving this mail because:
  • You are on the CC list for the bug.
_______________________________________________
LibreOffice mailing list
LibreOffice <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Gmane