Michele Calgaro | 26 Oct 04:22 2014

Improvements to the "Patches from GIT" web page

The new "patches from GIT" page looks good and so does the search field 
at the bottom. Anyhow IMO there are still a few things to fix:

1) email addresses are shown in full, which is not that good being a 
page available without any login.
It would be advisable to remove them, both from the committer column and 
the Log message column (for signed-off commits).

2) I believe the correct name of the committer column should be "Author"

3) The page still displays with problems if the width of the browser 
window is small enough (the blue left side menu overlaps the page contents)

4) The search field would probably be better if it was at the top, since 
it does not take up much page space. At the moment we need to scroll the 
whole page if we want to search for a particular commit

5) the 'page navigation' (the one saying 'Now viewing patches...') would 
be better if it had links to the next and previous adjacent pages as in 
most search engines (something like [1], [2], [3], .... to make it clear)

6) IMO, the name "Patches from GIT" is misleading for new users, as I 
already said in a previous email. Would be better to call it "GIT 
Commits" or "Commit history" or something with "commit" in it

Hope this is useful.

(Continue reading)

Jonesy | 25 Oct 00:03 2014

Web Site

While you're at it . . .


at the bottom:

	"TDE R14.0.0: Anticipated in early 2014."

Maybe  "... 4th Quarter 2014" ?

Looking forward to it!

  Marvin L Jones     | Marvin     | W3DHJ  | linux
   Pueblo, Colorado  |   <at>          | Jonesy |  FreeBSD   __
    38.238N 104.547W |   jonz.net | DM78rf |   OS/2     SK

Timothy Pearson | 24 Oct 19:21 2014

New feature on TDE Patches page


After growing tired of the difficulty of looking up exactly what changed
in the various GIT hashes being thrown around during development I added a
project-wide hash lookup feature on the TDE Patches from GIT page.  I have
also added a direct link to each patch on cgit, though those links may
take up to 24 hours to activate after a commit is pushed.

Let me know what you think.  I hope this helps with code auditing;
suggestions are of course welcome!

Slávek Banko | 24 Oct 02:59 2014

Additional patches to push

Hi Tim,

I have two small patches:

1) adept - fixes switching back to green icon - see

2) tdemultimedia - fixes systray popup menu damage,
  similar, as was in Amarok - see

Can I push or do I have to wait after RC1?



Calvin Morrison | 21 Oct 21:55 2014

homepage images

Alexandre | 21 Oct 16:59 2014

RE: Re: [trinity-users] New TDE site released

> > The sequence went something like this, IIRC:
> >
> > A few emails back, Alexandre asked that I underline the headers, because
> > he
> > didn't think they were sufficiently differentiated.
> >
> > I didn't want to underline them because I was afraid it would suggest that
> > the
> > other links weren't links, if you see what I mean, so I italicized them
> > instead.
> >
> > It was all mixed in with the discussion about the drop shadow.
> >
> > E. Liddell
> OK, thanks for the info. Alexandre, do you see a problem with making the
> headers non-underlined and non-italic? The color differences set them
> apart well enough for me.
> Also, while I haven't had time to evaluate a proper overhaul of the patch
> pages I have at least modified the backend so as to allow pagination.
> Patches are now available by default in 100-patch lists, starting with the
> newest. Everything else currently functions the same as before.
> E. Liddell, now that the patches page is a little easier to work with, can
> you send me an example of what the aforementioned css-driven table should
> look like? I can implement the changes quickly on this end.
> Thanks!
> Tim


Even if I see well my colors, the color difference is not 100% evident to me, but with the italic text, it is more visible. Also, if the user is noodle enough to not know that it is a link, then too bad for him... But it is not such a big matter in the end...

Also, can you replace the TDE logo with a well resized one, to avoid blur?

Thank you!

Michele Calgaro | 21 Oct 12:31 2014

Bugszilla to main TDE homepage missing link

 From the bugszilla page it is not possible to go directly to the TDE website.
A link would be good.
Perhaps a solution would be to make the TDE Icon on the top left part of the banner clickable as in many other
pages of 
the new website.


Timothy Pearson | 21 Oct 07:07 2014

TDE site glitch on iOS

Hi E. Liddell,

Not sure if there's anything you can do about this but I was browsing the
TDE site on iOS and got the attached glitch.

Is there any way to force the horizontal scrollbar to show up in this case
instead of overlaying the left hand menu bar on top of the text?  This is
one of the very few cases where horizontal scrolling is preferable to what
we have now.



Calvin Morrison | 19 Oct 22:54 2014

new website - patches

Hi guys,

It would be really cool to drop a 'smart' table into the patches page, or have an alternative page that provided that support. Datatables is a great example of this. It's a pseudo excel style table, backed by some javascript. it would make it easy to search through commits, export data to excel, sort of date, etc.

Just a thought,

Slávek Banko | 19 Oct 12:10 2014

Re: [trinity-commits] [SCM] [tde-packaging][master] 7c94b170

On Sunday 19 of October 2014 08:59:51 trinity-git-server <at> pearsoncomputing.net 
> Branch: master
>  7c94b170     2014-10-19 01:59:23    Michele Calgaro
>   Fixed tdewebdev FTBFS in Debian/Ubuntu distros.
> Signed-off-by: Michele Calgaro <michele.calgaro@...>
>   M debian/lenny/tdewebdev/debian/kxsldbg-trinity.install
>  M debian/squeeze/tdewebdev/debian/kxsldbg-trinity.install
>  M ubuntu/maverick/tdewebdev/debian/kxsldbg-trinity.install
>   diff --git a/debian/lenny/tdewebdev/debian/kxsldbg-trinity.install
> b/debian/lenny/tdewebdev/debian/kxsldbg-trinity.install index
> 28d1bba..d6c1b3a 100644
> --- a/debian/lenny/tdewebdev/debian/kxsldbg-trinity.install
> +++ b/debian/lenny/tdewebdev/debian/kxsldbg-trinity.install
>  <at>  <at>  -16,18 +16,18  <at>  <at> 
>  debian/tmp/opt/trinity/share/doc/tde/HTML/en/xsldbg/xsldbghelp.xml
>  debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/1downarrow.png
>  debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/configure.png
> -debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/system-log-out.pn
> +debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/system/log-out.pn
>g debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/hash.png
> debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/mark.png
> debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/next.png
> -debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/system-run.png
> +debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/system/run.png
> debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/step.png
> debian/tmp/opt/trinity/share/icons/hicolor/16x16/actions/xsldbg_*.png
> debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/1downarrow.png
> debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/configure.png
> -debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/system-log-out.pn
> +debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/system/log-out.pn
>g debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/next.png
> -debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/system-run.png
> +debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/system/run.png
> debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/step.png
> debian/tmp/opt/trinity/share/icons/hicolor/22x22/actions/xsldbg_*.png
> debian/tmp/opt/trinity/share/services/kxsldbg_part.desktop


I think you've hit on the problem, which I feared - automake does not install 
icons as intended, but automatically adds extra subfolder. If you look at the 
rest of the commit e12d7923 see that program refers to the icon 'system-run'. 
This will require an adjustment in the common 'admin' module => rebuild 
everything again.



Slávek Banko | 18 Oct 18:28 2014

Re: Additional patches to push

On Saturday 18 of October 2014 16:15:11 Michele Calgaro wrote:
> I have other patches for TDevelop, they fix the API doc generation and toc
> list as well. One patch for the main repo and one for the packaging repo.
> Can I push or do I have to wait until RC2?

IMO: On TDevelop not depend on any other packages, so it's no problem, if it 
moves backward in the build queue on build-farm. Therefore, I see no problem 
to push patches now.