Re: [PATCH] rrdcached: Fix permissions of the default socket.

Hi Florian,

Nov 23 Florian Forster wrote:

> From: Florian Forster <ff <at> octo.it>
>
> If neither the "-l" nor the "-P" options have been given, a UNIX domain
> socket at a default location is created. However, due to a missing
> initialization in this case, the "permissions" field will be left at
> zero (no command allowed).
>
> This patch fixes this problem by allowing all commands on the default
> socket if no "-P" option is given.

thanks, its added.

cheers
tobi

--

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi <at> oetiker.ch ++41 62 775 9902 / sb: -9900

Re: [PATCH] rrd_daemon: pay attention to the return value of realpath

Hi Alex,

Nov 22 kevin brintnall wrote:

> Alex, realpath(x,NULL) is not portable.  I think keeping the temporary
> buffer is best. Ideas?

I have included the patch without the realpath(...,NULL) but a
delayed strdup instead ... r2153

cheers
tobi

>
> -kb
>
> On Mon, Nov 22, 2010 at 9:17 AM, <kernel-hacker <at> bennee.com> wrote:
>
> > From: Alex Bennee <ajb <at> cbnl.com>
> >
> > When the realpath() change was introduced it failed to take account of the
> > potential
> > for a failure of realpath if it can't navigate to the full path. As a
> > result the strdup
> > would fail.
> >
> > Unfortunatly this change broke rrdcached's automatic creation of it's
> > journal path (although
> > in my case this is handled by packaging). However we still make the call to
> > rrd_mkdir_p to

Re: [PATCH] libdbi

Hi HJJ,

Nov 10 Hans Jørgen Jakobsen wrote:

> Here is a patch for libdbi access.
> 1) Sigma calculation had an error. The first data value in each bin didn't get
> squared.

added this to 1.4 and to trunk
>
> 2) "rrdfillmissing" was dummy. I have added code to do the work. The parameter
> has NOW to be in seconds. In doc it is given in steps. The size of steps
> depends to much on size of graph so I think its easier to use seconds and
> internal calculate the number of steps.

added this to trunk

thanks
tobi
>
> (I have mailed with Martin Sperl)
> /hjj

--

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi <at> oetiker.ch ++41 62 775 9902 / sb: -9900

_______________________________________________
rrd-developers mailing list
rrd-developers <at> lists.oetiker.ch

Re: [PATCH] CBNL: Packaging changes for 10.04 upgrade

Hi Alex,

rrdtool >= 1.4 does not contain debian build files anymore ...

Find the latest debian packaging files at
git://git.snow-crash.org/pkg-rrdtool.git and mirrored at
git://git.tokkee.org/pkg-rrdtool.git

Please sync with Sebastian Harl sh <at> tokkee.org

cheers
tobi

Nov 12 kernel-hacker <at> bennee.com wrote:

> From: Alex Bennee <ajb <at> cbnl.com>
>
> ---
>  debian/changelog          |   21 +++++++++++++++++++++
>  debian/rrdcached.dirs     |    2 ++
>  debian/rrdcached.postinst |    6 ++++--
>  debian/rules              |    3 ++-
>  4 files changed, 29 insertions(+), 3 deletions(-)
>  create mode 100644 debian/rrdcached.dirs
>
> diff --git a/debian/changelog b/debian/changelog
> index 10bad13..387b76e 100644
> --- a/debian/changelog
> +++ b/debian/changelog
>  <at>  <at>  -1,3 +1,24  <at>  <at> 

Re: [PATCH] Avoid hard coded buffer lengths in rrd_client.c.

Hi Kevin,

Nov 16 kevin brintnall wrote:

> The buffer length for command buffers should be controlled by a single
> #define.
>
> I put this into "rrd_client.h"..  Since that header is exposed as part of
> the API perhaps we should consider renaming it to "RRD_CMD_MAX" or
> somesuch?  Or we could put it into "rrd_tool.h".  Thoughts?

I have added the patch and renamed CMD_MAX to RRD_CMD_MAX. I think
rrd_client.h is a good place as it will be primarily useful to
people using the rrd_client.c ..

cheers
tobi

>
> ---
>  src/rrd_client.c |   20 ++++++++++----------
>  src/rrd_client.h |    2 ++
>  src/rrd_daemon.c |    2 --
>  3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/src/rrd_client.c b/src/rrd_client.c
> index 870a27b..893e526 100644
> --- a/src/rrd_client.c
> +++ b/src/rrd_client.c
>  <at>  <at>  -304,7 +304,7  <at>  <at>  static int buffer_add_string (const char *str, /* {{{ */

Re: RRDTOOL 1.4.4 fetch with RRDCACHED_ADDRESS

Hi Swami,

Nov 18 swami wrote:

> Hi,
>      Am trying to get my rrdtool work with RRDCACHED and am facing fetch issue where looks like its not able to
locate the file with the relative path.
>
>      Here is what i do, in steps
>
> 1)    /usr/local/third-party/rrd/bin/rrdcached -l 127.0.0.1 -w 600 -b /var/stats/rrd_data
> 2) set RRDCACHED_ADDRESS
>        export RRDCACHED_ADDRESS=127.0.0.1
> 2) create rrd
>        /usr/local/third-party/rrd/bin/rrdtool  create /var/stats/rrd_data/remote_peer_data/rp4.rrd
-s 3\
>        DS:AccelTrafficBytesIn:COUNTER:60:0:U\
>        RRA:AVERAGE:0.5:1:1200\
>        RRA:MAX:0.5:1:1200\
>        RRA:LAST:0.5:1:1200\
> 3) update some values
>        /usr/local/third-party/rrd/bin/rrdtool update remote_peer_data/rp4.rrd N:10
>        /usr/local/third-party/rrd/bin/rrdtool update remote_peer_data/rp4.rrd N:10
>         /usr/local/third-party/rrd/bin/rrdtool update remote_peer_data/rp4.rrd N:10
>
> 4) telnet localhost 42217
>    PENDING rp4.rrd
> 3 updates pending
> 1290128668:10
> 1290128672:10

Re: RRDcached chaining mode

Steve,

what is the state on this patch ?

Comments ?

cheers
tobi

Oct 4 Steve Shipway wrote:

> Attached is a small patch for rrdtool to allow chaining of update requests received via rrdcached on to a
second instance of rrdcached specified by a command line parameter -C.
>
> EG:
> $ rrdcached -l unix:/tmp/a.sock -b /var/rrda
> $ rrdcached -l unix:/tmp/b.sock -b /var/rrdb -C unix:/tmp/a.sock
> $ rrdtool update --daemon unix:/tmp/b.sock foo.rrd N:1:1
>
> This updates foo.rrd in both /var/rrdb and /var/rrda, provided it exists, of course.  This also works over
TCP sockets, and you can mix and match UNIX and TCP sockets if you like.  This patch only chains UPDATE
requests, not CREATEs, STATs, or anything else.
>
> The requests are sent to the remote daemon immediately after they are added to the update queue for the
receiving daemon (thus avoiding any trouble of how to handle them after queueing).  If the relay fails then
an error is logged BUT the rrdcached still returns a success code to the remote client (as there is no
'warning' code for a partial success).
>
> I've run this here for a few days keeping a shadow copy of our secondary MRTG server's RRD files, and it
worked without problem.  There was a bit of an issue when I defined two instances to chain to each other,

Re: RRDcached chaining mode

As far as I can see, it is working fine, although ONLY for UPDATE -- really we should chain at least INFO, and
probably FLUSH as well.  The biggest risk, as I see it, is a memory leak somewhere.

I've not made any more changes to the code since I posted it; I've just left it running here in our environment
to see if there are any memory issues (none so far, since the other errors were picked up on...)

I was hoping for some feedback from the rest of the rrd-developers community before passing it on to you
officially, but people have been too busy, I guess

Steve

Steve Shipway
University of Auckland ITS
UNIX Systems Design Lead
s.shipway <at> auckland.ac.nz
Ph: +64 9 373 7599 ext 86487

________________________________________
From: Tobias Oetiker [tobi <at> oetiker.ch]
Sent: Wednesday, 22 December 2010 8:01 p.m.
To: Steve Shipway
Cc: rrd-developers <at> lists.oetiker.ch
Subject: Re: [rrd-developers] RRDcached chaining mode

Steve,

what is the state on this patch ?

Comments ?

Re: RRDcached chaining mode

Today Steve Shipway wrote:

> As far as I can see, it is working fine, although ONLY for UPDATE
> -- really we should chain at least INFO, and probably FLUSH as
> well.  The biggest risk, as I see it, is a memory leak somewhere.
>
> I've not made any more changes to the code since I posted it;
> I've just left it running here in our environment to see if there
> are any memory issues (none so far, since the other errors were
> picked up on...)
>
> I was hoping for some feedback from the rest of the
> rrd-developers community before passing it on to you officially,
> but people have been too busy, I guess

ok, so let it simmer some more ... nothing lost ...

cheers and merry christmas!
tobi

--

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi <at> oetiker.ch ++41 62 775 9902 / sb: -9900

rrdcached support for --template

Hello list,

I believe this question has been asked before, but I was not able to 
find a record of a response in the archives.

Is there a plan to enable rrdcached support for 'rrdtool update 
--template ...', and if so what is the approximate time frame? Apologies 
in advance if the feature has already been added and I've missed it.

Thanks!

Eric Schoeller
University of Colorado, Boulder
Information Technology Services