Shaun Reitan | 1 Nov 2010 19:36

rrdcache Update success response..

On a successful update you get the following response.

     0 errors, enqueued 1 value(s).

The problem i see with this response is that if you carve up the 
response using perl (or any other language) using a whitespace as a 
delimiter you will end up with the following...

	status = 0
	message = errors, enqueued 1 value(s).

The problem i see here with this response is that the message indicates 
there was errors even though i think what it's really trying to say was 
0 errors.  The response should probably really say

0 0 errors, enqueued 1 value(s).
OR
0 no errors, enqueued 1 value(s).

maybe this is a bug?

--
Shaun Retian
Chief Technical Officer
Network Data Center Host, Inc.
http://www.ndchost.com
Shaun Reitan | 1 Nov 2010 19:39

Re: [PATCH] Add support for rrdcache to use host_access authentication.

On 10/30/2010 8:51 PM, Steve Shipway wrote:
> I like this one, rrdcached needs TCP-wrappers support since it has so little internal security.  I'd
actually assumed it already had this, though I'd not checked... I'm using a hostbased firewall to protect
it, anyway.
>
> As you say, it would probably need to add the options in to the configure script to detect libwrap, and so on.

Are you any good with setting up the configure side?  maybe you can 
complete this patch and it can be included into the code and be released 
with the next version of rrdtool!

--
Shaun Retian
Chief Technical Officer
Network Data Center Host, Inc.
http://www.ndchost.com
Steve Shipway | 1 Nov 2010 19:51
Picon
Picon
Favicon

Re: rrdcache Update success response..

This is not actually a complete success message, a complete success doesnt have the 'errors,' prefix.  The
initial '0' is the status code -- 0 for "OK,no more lines follow".

The 'errors, enqueued' message is a 'partial success' message; possibly it thinks you sent two values and
only one was correctly enqueued (check for multiple or trailing spaces in the command you sent which could
be taken as a badly-formatted value)

Steve

Steve Shipway
University of Auckland ITS
UNIX Systems Design Lead
s.shipway <at> auckland.ac.nz
Ph: +64 9 373 7599 ext 86487

________________________________________
From: rrd-developers-bounces+steve=steveshipway.org <at> lists.oetiker.ch
[rrd-developers-bounces+steve=steveshipway.org <at> lists.oetiker.ch] on behalf of Shaun Reitan [mailinglists <at> unix-scripts.com]
Sent: Tuesday, 2 November 2010 7:36 a.m.
To: rrd-developers <at> lists.oetiker.ch
Subject: [rrd-developers] rrdcache Update success response..

On a successful update you get the following response.

     0 errors, enqueued 1 value(s).

The problem i see with this response is that if you carve up the
response using perl (or any other language) using a whitespace as a
delimiter you will end up with the following...

(Continue reading)

Shaun Reitan | 1 Nov 2010 21:38

Re: rrdcache Update success response..

On 11/1/2010 11:51 AM, Steve Shipway wrote:
> This is not actually a complete success message, a complete success doesnt have the 'errors,' prefix.  The
initial '0' is the status code -- 0 for "OK,no more lines follow".
>
> The 'errors, enqueued' message is a 'partial success' message; possibly it thinks you sent two values and
only one was correctly enqueued (check for multiple or trailing spaces in the command you sent which could
be taken as a badly-formatted value)
>
> Steve

Are you sure?  looking at src/rrd_daemon.c for that function the last 
few lines show...

   if (values_num < 1)
     return send_response(sock, RESP_ERR, "No values updated.\n");
   else
     return send_response(sock, RESP_OK,
                          "errors, enqueued %i value(s).\n", values_num);

 From what i can tell so far, there is no other code in this function 
that would send a success message than what i have pasted above.

--
Shaun Retian
Chief Technical Officer
Network Data Center Host, Inc.
http://www.ndchost.com
Steve Shipway | 1 Nov 2010 23:07
Picon
Picon
Favicon

Re: rrdcache Update success response..

Ah... you're right.  Serves me right for working from the trunk version of rrd_daemon.c which has already
been hacked about with to add the chaining code, coincidentally fixing this without realising it on the
way.  

Checking the actual 1.4.4 code I see that it does indeed say 'errors' but exit with an OK status if it enqueues
>0 values.  The 'errors' prefix is completely superfluous as the processing doesnt even count the errors...

If Tobi accepts my chaining code submission then the problem will go away :)

Steve Shipway
University of Auckland ITS
UNIX Systems Design Lead
s.shipway <at> auckland.ac.nz
Ph: +64 9 373 7599 ext 86487

________________________________________
From: Shaun Reitan [mailinglists <at> unix-scripts.com]
Sent: Tuesday, 2 November 2010 9:38 a.m.
To: Steve Shipway
Cc: rrd-developers <at> lists.oetiker.ch
Subject: Re: rrdcache Update success response..

On 11/1/2010 11:51 AM, Steve Shipway wrote:
> This is not actually a complete success message, a complete success doesnt have the 'errors,' prefix.  The
initial '0' is the status code -- 0 for "OK,no more lines follow".
>
> The 'errors, enqueued' message is a 'partial success' message; possibly it thinks you sent two values and
only one was correctly enqueued (check for multiple or trailing spaces in the command you sent which could
be taken as a badly-formatted value)
>
(Continue reading)

Shaun Reitan | 1 Nov 2010 23:13

Re: rrdcache Update success response..

On 11/1/2010 3:07 PM, Steve Shipway wrote:
> Ah... you're right.  Serves me right for working from the trunk version of rrd_daemon.c which has already
been hacked about with to add the chaining code, coincidentally fixing this without realising it on the way.
>
> Checking the actual 1.4.4 code I see that it does indeed say 'errors' but exit with an OK status if it
enqueues>0 values.  The 'errors' prefix is completely superfluous as the processing doesnt even count
the errors...

The code i pasted you was from this version rrdtool-1.4.99910102900

--
Shaun Retian
Chief Technical Officer
Network Data Center Host, Inc.
http://www.ndchost.com
Shaun Reitan | 3 Nov 2010 23:11

[PATCH] hosts_access rrdtool patch

Here is a complete patch for rrdtool that will add hosts_access support 
to rrdcached.

--
Shaun Retian
Chief Technical Officer
Network Data Center Host, Inc.
http://www.ndchost.com

--------------
Index: src/rrd_daemon.c
===================================================================
--- src/rrd_daemon.c    (revision 2141)
+++ src/rrd_daemon.c    (working copy)
 <at>  <at>  -109,6 +109,10  <at>  <at> 
  #include <libgen.h>
  #include <grp.h>

+#ifdef HAVE_LIBWRAP
+#include <tcpd.h>
+#endif /* HAVE_LIBWRAP */
+
  #include <glib-2.0/glib.h>
  /* }}} */

 <at>  <at>  -2636,6 +2640,21  <at>  <at> 
    }

    pthread_mutex_lock (&connection_threads_lock);
+#ifdef HAVE_LIBWRAP
(Continue reading)

Thorsten von Eicken | 4 Nov 2010 00:24

heat maps in RRDtool

We just started a beta offering based on some fun new RRDtool stuff. 
Hope to be able to contribute the code back sometime soonish... 
<http://wp.me/pccX7-9L>
     Thorsten
Tobias Oetiker | 4 Nov 2010 06:39
Picon
Gravatar

Re: heat maps in RRDtool

Hi Thorsten,

looks cool

cheers
tobi

Yesterday Thorsten von Eicken wrote:

> We just started a beta offering based on some fun new RRDtool stuff.
> Hope to be able to contribute the code back sometime soonish...
> <http://wp.me/pccX7-9L>
>      Thorsten
>
> _______________________________________________
> rrd-developers mailing list
> rrd-developers <at> lists.oetiker.ch
> https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers
>
>

--

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi <at> oetiker.ch ++41 62 775 9902 / sb: -9900
Peter Stamfest | 4 Nov 2010 08:28
Picon

RRD Web 2.0 style Demo Java Web Application


Hi List,

In the last few weeks I have already shown you two of the things I'm currently working on (Java RRD binding and interactively exploring an RRD graph using "Web-2.0" style interaction with a graph itself).

I have now whipped up a demo Java Webapp (in the form of a WAR file) integrating these two technologies. The implementation is dual-licensed (GPL or commercially for my own projects). Consulting on these things is of course possible ;-)



Have fun!


Downloads:

Mercurial repository for the Web-App:

        http://oss.stamfest.net/rrd-web-20-standalone/

For the current java-rrd binding:

        http://oss.stamfest.net/java-rrd-hg/

(use "hg clone <URL>" to clone the repo)

And the web-app can be downloaded from:

        http://oss.stamfest.net/rrd-web-20-standalone/demo.war

Unfortunately, it does not work under all Java Application-Servers due to problems with the DWR (http://directwebremoting.org/dwr/index.html) library in some such servers (specifically, jetty does not work).

It does work using tomcat, though.

Feedback would be welcome!

peter
_______________________________________________
rrd-developers mailing list
rrd-developers <at> lists.oetiker.ch
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

Gmane