Jeff Butler (JIRA | 2 Jan 2009 04:45
Picon
Favicon

Closed: (IBATIS-571) Ibator generated sqlmap file should add quotes to the sql keyword,like "date"


     [
https://issues.apache.org/jira/browse/IBATIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Butler closed IBATIS-571.
------------------------------

    Resolution: Fixed

I added support to Ibator to allow for auto-delimiting of recognized SQL keywords.

> Ibator generated sqlmap file should add quotes to the sql keyword,like "date"
> -----------------------------------------------------------------------------
>
>                 Key: IBATIS-571
>                 URL: https://issues.apache.org/jira/browse/IBATIS-571
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 2.3.4
>            Reporter: qubicllj
>            Assignee: Jeff Butler
>
> Ibator generated sqlmap file should add quotes to the sql keyword,like "date"

Build Administrator | 4 Jan 2009 04:11
Favicon

[parabuild] BUILD for IBATIS (#119) on localhost TIMED OUT: Timed out after 240 minutes and was stopped.

BUILD result
------------------------------------------------------------

BUILD for IBATIS (#119) on localhost TIMED OUT: Timed out after 240 minutes and was stopped.

Build status:
  http://parabuild.viewtier.com:8080/parabuild/index.htm?view=detailed&buildid=150

Suspect Changes
------------------------------------------------------------

Change(s) by cbegin :

 - removed properties file, put props directly in the build.xml;
   Time: 03:10 PM 01/03/2009; Change list: 731122

Change(s) Details:
  http://parabuild.viewtier.com:8080/parabuild/build/changes.htm?buildrunid=11314

BUILD logs
------------------------------------------------------------

BUILD log:
  http://parabuild.viewtier.com:8080/parabuild/build/log.htm?logid=16262
Error Lines:
  http://parabuild.viewtier.com:8080/parabuild/build/log.htm?logid=16263
JUnit Tests:
  http://parabuild.viewtier.com:8080/parabuild/build/log.htm?logid=16264

Log Lines Around Error
(Continue reading)

Build Administrator | 4 Jan 2009 08:20
Favicon

[parabuild] BUILD for IBATIS (#120) on localhost TIMED OUT: Timed out after 240 minutes and was stopped.

BUILD result
------------------------------------------------------------

BUILD for IBATIS (#120) on localhost TIMED OUT: Timed out after 240 minutes and was stopped.

Build status:
  http://parabuild.viewtier.com:8080/parabuild/index.htm?view=detailed&buildid=150

Suspect Changes
------------------------------------------------------------

Change(s) by cbegin :

 - fixed bug with prop name;
   Time: 05:55 PM 01/03/2009; Change list: 731156

 - removed properties file, put props directly in the build.xml;
   Time: 03:10 PM 01/03/2009; Change list: 731122

Change(s) Details:
  http://parabuild.viewtier.com:8080/parabuild/build/changes.htm?buildrunid=11316

BUILD logs
------------------------------------------------------------

BUILD log:
  http://parabuild.viewtier.com:8080/parabuild/build/log.htm?logid=16266
Error Lines:
  http://parabuild.viewtier.com:8080/parabuild/build/log.htm?logid=16267
JUnit Tests:
(Continue reading)

Abhigyan Agrawal (JIRA | 8 Jan 2009 11:56
Picon
Favicon

Created: (IBATIS-575) Sqlj support for ibatis-java

Sqlj support for ibatis-java
----------------------------

                 Key: IBATIS-575
                 URL: https://issues.apache.org/jira/browse/IBATIS-575
             Project: iBatis for Java
          Issue Type: New Feature
          Components: SQL Maps
    Affects Versions: 2.3.4
         Environment: Java on all platforms
            Reporter: Abhigyan Agrawal
             Fix For: 2.3.4

Please refer to the following post on the dev list regarding SQLJ support in iBATIS:

http://www.mail-archive.com/dev <at> ibatis.apache.org/msg02593.html

This issue contains 
1) The contribution - patches containing the changes in iBATIS runtime for SQLJ support. (For version 2.3.4.7)
2) An example iBATIS application that uses the above patches for providing iBATIS the ability to access a
database via SQLJ in addition to JDBC without code change to application. 

Suematsu Shinya (JIRA | 12 Jan 2009 01:30
Picon
Favicon

Created: (IBATIS-576) Message properties for iBATIS

Message properties for iBATIS
-----------------------------

                 Key: IBATIS-576
                 URL: https://issues.apache.org/jira/browse/IBATIS-576
             Project: iBatis for Java
          Issue Type: Wish
          Components: SQL Maps
    Affects Versions: 2.3.4
         Environment: Java on all platforms
            Reporter: Suematsu Shinya
            Priority: Minor
             Fix For: 2.3.4

Ibator has message property file, but iBatis core module does not have it. If it were, I can easily localize iBATIS.

Amir Pashazadeh (JIRA | 12 Jan 2009 19:42
Picon
Favicon

Commented: (IBATIS-576) Message properties for iBATIS


    [
https://issues.apache.org/jira/browse/IBATIS-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663041#action_12663041
] 

Amir Pashazadeh commented on IBATIS-576:
----------------------------------------

I can't imagine usage of internationalization for iBatis, it is a DAO framework not a GUI one.

> Message properties for iBATIS
> -----------------------------
>
>                 Key: IBATIS-576
>                 URL: https://issues.apache.org/jira/browse/IBATIS-576
>             Project: iBatis for Java
>          Issue Type: Wish
>          Components: SQL Maps
>    Affects Versions: 2.3.4
>         Environment: Java on all platforms
>            Reporter: Suematsu Shinya
>            Priority: Minor
>             Fix For: 2.3.4
>
>
> Ibator has message property file, but iBatis core module does not have it. If it were, I can easily localize iBATIS.

Kevin Yang (JIRA | 12 Jan 2009 22:20
Picon
Favicon

Commented: (IBATIS-535) iBatis not closing JDBC statements


    [
https://issues.apache.org/jira/browse/IBATIS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663098#action_12663098
] 

Kevin Yang commented on IBATIS-535:
-----------------------------------

It's not a bug.  There is a un-documented SqlMap paramter "statementCachingEnabled", 

1. When statementCachingEnabled=true, the sessionScope will always cache the statement:

SessionScope.java

  public void putPreparedStatement(SqlMapExecutorDelegate delegate, String sql, PreparedStatement
ps) {
    if (delegate.isStatementCacheEnabled()) {
      if (!isInBatch()) {
        if (hasPreparedStatementFor(sql))
          throw new SqlMapException("Duplicate prepared statement found.  This is likely a bug.");
        preparedStatements.put(sql, ps);
      }
    }
  }

so the statement won't be closed in SqlExecutor.java, that's because sessionScop cached the ps
  private static void closeStatement(SessionScope sessionScope, PreparedStatement ps) {
    if (ps != null) {
      if (!sessionScope.hasPreparedStatement(ps)) {
        try {
(Continue reading)

Kevin Yang (JIRA | 12 Jan 2009 22:24
Picon
Favicon

Issue Comment Edited: (IBATIS-535) iBatis not closing JDBC statements


    [
https://issues.apache.org/jira/browse/IBATIS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663098#action_12663098
] 

kevinyang edited comment on IBATIS-535 at 1/12/09 1:22 PM:
------------------------------------------------------------

It's not a bug.  There is a un-documented SqlMap paramter "statementCachingEnabled", 

1. When statementCachingEnabled=true, the sessionScope will always cache the statement:

SessionScope.java

  public void putPreparedStatement(SqlMapExecutorDelegate delegate, String sql, PreparedStatement
ps) {
    if (delegate.isStatementCacheEnabled()) {
      if (!isInBatch()) {
        if (hasPreparedStatementFor(sql))
          throw new SqlMapException("Duplicate prepared statement found.  This is likely a bug.");
        preparedStatements.put(sql, ps);
      }
    }
  }

So ps.close() will be by passed, that's because sessionScop cached the ps, sessionScope.hasPreparedStatement(ps)=true

  private static void closeStatement(SessionScope sessionScope, PreparedStatement ps) {
    if (ps != null) {
      if (!sessionScope.hasPreparedStatement(ps)) {
(Continue reading)

Suematsu Shinya (JIRA | 14 Jan 2009 02:07
Picon
Favicon

Commented: (IBATIS-576) Message properties for iBATIS


    [
https://issues.apache.org/jira/browse/IBATIS-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663582#action_12663582
] 

Suematsu Shinya commented on IBATIS-576:
----------------------------------------

I think internationalization is not less effective even if it is the DAO framework.
Ibator users and DAO framework users are basically the same developers. Some are not good at English. 
When the message is output in English, they will question the person who maintains framework, even if they
are clear messages. 

> Message properties for iBATIS
> -----------------------------
>
>                 Key: IBATIS-576
>                 URL: https://issues.apache.org/jira/browse/IBATIS-576
>             Project: iBatis for Java
>          Issue Type: Wish
>          Components: SQL Maps
>    Affects Versions: 2.3.4
>         Environment: Java on all platforms
>            Reporter: Suematsu Shinya
>            Priority: Minor
>             Fix For: 2.3.4
>
>
> Ibator has message property file, but iBatis core module does not have it. If it were, I can easily localize iBATIS.

(Continue reading)

omkaram sangem (JIRA | 15 Jan 2009 23:51
Picon
Favicon

Commented: (IBATIS-115) automapping and/or ignoreMissingColumns


    [
https://issues.apache.org/jira/browse/IBATIS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664310#action_12664310
] 

omkaram sangem commented on IBATIS-115:
---------------------------------------

It looks like this is not fixed in the Release 2.3.4. Even though the release was made after the patch date 
2008-06-02 (The patch attachment date).
When I looked at the SVN source the later versions of the patched files are missing the fix.
Is there a way to get a Jar file with the fixes. 

Thanks a lot for the help in advance.

> automapping and/or ignoreMissingColumns
> ---------------------------------------
>
>                 Key: IBATIS-115
>                 URL: https://issues.apache.org/jira/browse/IBATIS-115
>             Project: iBatis for Java
>          Issue Type: New Feature
>          Components: SQL Maps
>    Affects Versions: 2.0.9b
>            Reporter: ow
>         Attachments: ignore-missing-cols.zip
>
>
> This was requested about a year ago. Somewhat similar to what Ruby-on-Rails does.
> http://sourceforge.net/forum/forum.php?thread_id=1110825&forum_id=206694
(Continue reading)


Gmane