Developers list for iBatis SQL Maping DAO for Java and .NET

Sylvain Laurent (JIRA | 3 Oct 2008 10:16

Picon

Created: (IBATIS-540) Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil

Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil
-------------------------------------------------------------------------

                 Key: IBATIS-540
                 URL: https://issues.apache.org/jira/browse/IBATIS-540
             Project: iBatis for Java
          Issue Type: Bug
          Components: SQL Maps
    Affects Versions: 2.3.3, 2.3.4
            Reporter: Sylvain Laurent
         Attachments: ibatis patch for classloader memleak.txt

I'm using iBatis in a webapp with Spring and facing memory leaks upon redeployment oft he webapp.
I tracked the leaks to ibatis, where the class ResultObjectFactoryUtil has a static ThreadLocal factorySettings

The problem is that the value bound to a Thread through this ThreadLocal is never nullified, and since the
"factorySettings" is a static variable, the ThreadLocal instance is reachable as long as the
ClassLoader of the webapp is reachable. But since the FactorySettings instance is bound to the Thread
through a strong reference (see the JDK implementation of ThreadLocal in ThreadLocalMap$Entry), the
classloader is finally never collected...

The solution is to always cleanup the ThreadLocal after usage (in SqlExecurtor)
I attach a patch for iBatis 2.3.4 to this issue

Sylvain Laurent (JIRA | 3 Oct 2008 10:22

Picon

Commented: (IBATIS-376) Hot deploy issue


    [
https://issues.apache.org/jira/browse/IBATIS-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636570#action_12636570
] 

Sylvain Laurent commented on IBATIS-376:
----------------------------------------

I opened a new issue IBATIS-376 for a different leak.

The leak in this IBATIS-376 issue does not occur in my case because Spring's iBatis support does not make use
of getLocalSqlMapSession(), but rather use openSession().

> Hot deploy issue
> ----------------
>
>                 Key: IBATIS-376
>                 URL: https://issues.apache.org/jira/browse/IBATIS-376
>             Project: iBatis for Java
>          Issue Type: Improvement
>          Components: SQL Maps
>    Affects Versions: 2.2.0
>         Environment: ALL
>            Reporter: kevin chae
>         Attachments: SqlMapClientCleaner.zip
>
>
> Hi Clinton and team.
> I found an interesting issue.
> In case of hot deploy

(Continue reading)

Kai Grabfelder (JIRA | 3 Oct 2008 13:08

Picon

Commented: (IBATIS-540) Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil


    [
https://issues.apache.org/jira/browse/IBATIS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636605#action_12636605
] 

Kai Grabfelder commented on IBATIS-540:
---------------------------------------

doesn't this has a performance impact? What's the point of using the ThreadLocal if it is cleaned just right
after it has been set?

> Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil
> -------------------------------------------------------------------------
>
>                 Key: IBATIS-540
>                 URL: https://issues.apache.org/jira/browse/IBATIS-540
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: SQL Maps
>    Affects Versions: 2.3.3, 2.3.4
>            Reporter: Sylvain Laurent
>         Attachments: ibatis patch for classloader memleak.txt
>
>
> I'm using iBatis in a webapp with Spring and facing memory leaks upon redeployment oft he webapp.
> I tracked the leaks to ibatis, where the class ResultObjectFactoryUtil has a static ThreadLocal factorySettings
> The problem is that the value bound to a Thread through this ThreadLocal is never nullified, and since the
"factorySettings" is a static variable, the ThreadLocal instance is reachable as long as the
ClassLoader of the webapp is reachable. But since the FactorySettings instance is bound to the Thread
through a strong reference (see the JDK implementation of ThreadLocal in ThreadLocalMap$Entry), the

(Continue reading)

Sylvain Laurent (JIRA | 3 Oct 2008 15:10

Picon

Commented: (IBATIS-540) Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil


    [
https://issues.apache.org/jira/browse/IBATIS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636625#action_12636625
] 

Sylvain Laurent commented on IBATIS-540:
----------------------------------------

According to the comments in the original class, it was a way of passing around some data without changing
the prototypes of many methods.
There's no performance impact, anyway the ThreadLocal is setup before each call. My patch just clean it up
after the call

> Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil
> -------------------------------------------------------------------------
>
>                 Key: IBATIS-540
>                 URL: https://issues.apache.org/jira/browse/IBATIS-540
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: SQL Maps
>    Affects Versions: 2.3.3, 2.3.4
>            Reporter: Sylvain Laurent
>         Attachments: ibatis patch for classloader memleak.txt
>
>
> I'm using iBatis in a webapp with Spring and facing memory leaks upon redeployment oft he webapp.
> I tracked the leaks to ibatis, where the class ResultObjectFactoryUtil has a static ThreadLocal factorySettings
> The problem is that the value bound to a Thread through this ThreadLocal is never nullified, and since the
"factorySettings" is a static variable, the ThreadLocal instance is reachable as long as the

(Continue reading)

Kai Grabfelder (JIRA | 3 Oct 2008 15:52

Picon

Commented: (IBATIS-540) Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil


    [
https://issues.apache.org/jira/browse/IBATIS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636636#action_12636636
] 

Kai Grabfelder commented on IBATIS-540:
---------------------------------------

cool, then I guess it is save to apply it .  <at> Devs? What do you think?

> Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil
> -------------------------------------------------------------------------
>
>                 Key: IBATIS-540
>                 URL: https://issues.apache.org/jira/browse/IBATIS-540
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: SQL Maps
>    Affects Versions: 2.3.3, 2.3.4
>            Reporter: Sylvain Laurent
>         Attachments: ibatis patch for classloader memleak.txt
>
>
> I'm using iBatis in a webapp with Spring and facing memory leaks upon redeployment oft he webapp.
> I tracked the leaks to ibatis, where the class ResultObjectFactoryUtil has a static ThreadLocal factorySettings
> The problem is that the value bound to a Thread through this ThreadLocal is never nullified, and since the
"factorySettings" is a static variable, the ThreadLocal instance is reachable as long as the
ClassLoader of the webapp is reachable. But since the FactorySettings instance is bound to the Thread
through a strong reference (see the JDK implementation of ThreadLocal in ThreadLocalMap$Entry), the
classloader is finally never collected...

(Continue reading)

Jeff Butler | 3 Oct 2008 15:58

Picon

Re: Commented: (IBATIS-540) Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil

+1.  I'll do it.

Jeff Butler

On Fri, Oct 3, 2008 at 8:52 AM, Kai Grabfelder (JIRA)
<ibatis-dev <at> incubator.apache.org> wrote:
>
>    [
https://issues.apache.org/jira/browse/IBATIS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636636#action_12636636 ]
>
> Kai Grabfelder commented on IBATIS-540:
> ---------------------------------------
>
> cool, then I guess it is save to apply it .  <at> Devs? What do you think?
>
>> Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil
>> -------------------------------------------------------------------------
>>
>>                 Key: IBATIS-540
>>                 URL: https://issues.apache.org/jira/browse/IBATIS-540
>>             Project: iBatis for Java
>>          Issue Type: Bug
>>          Components: SQL Maps
>>    Affects Versions: 2.3.3, 2.3.4
>>            Reporter: Sylvain Laurent
>>         Attachments: ibatis patch for classloader memleak.txt
>>
>>
>> I'm using iBatis in a webapp with Spring and facing memory leaks upon redeployment oft he webapp.
>> I tracked the leaks to ibatis, where the class ResultObjectFactoryUtil has a static ThreadLocal factorySettings

(Continue reading)

nospam@kaigrabfelder.de | 3 Oct 2008 17:36

Picon

ibator - current status

Hi Jeff,

whats the status of the ibator eclipse plugin? Can we help you in any way? Is the current trunk version
already stable enough to test it and file jira issues for it?

Regards

Kai

Jeff Butler | 3 Oct 2008 18:12

Picon

Re: ibator - current status

I'm working on a pretty significant refactoring of ibator.  The tests
are running successfully, but I still have some work to do related to
changes in the configuration DTD.

The goal of the refactoring was to get away from huge classes with
1000's of lines of code - it was too difficult to maintain and not
really OO.  It's better now.

This will also change (and simplify) supplying your own
implementations to ibator if you want to override any of the default
behaviors.

As for status and timing - I think I'll be able to check in the first
cut of the refactoring soon, maybe even this weekend.

If anyone wants to help, I think a good area to start on would be in
the Eclipse arena.  I'd like to do an Eclipse launch configuration for
ibator, rather than the simple menu option of Abator.  If you are
interested in working on that, then you could try to do a launch
configuration for Abator with the existing plugin - it would be easy
to convert it to ibator once the time comes.

If you have issues/enhancements for ibator than you can feel free to
file JIRA issues, but don't spend much time on working with ibator
internals until I check in the refactored code - the internals have
changed significantly. (In case anyone is worried, the code generated
by ibator is virtually identical to code generated by Abator - but
there is a new method "insertSelective").

Jeff Butler

(Continue reading)

Jeff Butler (JIRA | 3 Oct 2008 18:20

Picon

Closed: (IBATIS-540) Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil


     [
https://issues.apache.org/jira/browse/IBATIS-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Butler closed IBATIS-540.
------------------------------

    Resolution: Fixed

Fixed in SVN.

It was a bit more difficult than the patch suggested - because SqlExecuter can be called recursively if
there are nested sub-selects in result maps.  So I changed ResultObjectFactoryUtil to implement a Stack
rather than a single instance of the configuration.  This will also make the calls to the
ResultObjectFactory more accurate - because the statement id's will be correct in all cases (even if the
call is a result of a nested sub select).

I believe the issue is fixed, but if you find more issues feel free to reopen.

> Classloader memory leak because of ThreadLocal in ResultObjectFactoryUtil
> -------------------------------------------------------------------------
>
>                 Key: IBATIS-540
>                 URL: https://issues.apache.org/jira/browse/IBATIS-540
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: SQL Maps
>    Affects Versions: 2.3.3, 2.3.4
>            Reporter: Sylvain Laurent
>            Assignee: Jeff Butler

(Continue reading)

Richard Banks (JIRA | 7 Oct 2008 09:57

Picon

Created: (IBATISNET-283) Result mappings should work with interfaces when QueryForObject is passed an existing object

Result mappings should work with interfaces when QueryForObject is passed an existing object
--------------------------------------------------------------------------------------------

                 Key: IBATISNET-283
                 URL: https://issues.apache.org/jira/browse/IBATISNET-283
             Project: iBatis for .NET
          Issue Type: Bug
          Components: DataMapper
    Affects Versions: DataMapper 1.6.1
            Reporter: Richard Banks

In the IBatisNet.DataMapper.DataExchange.DotNetObjectDataExchange class the method public
override void SetData(ref object target, ResultProperty mapping, object dataBaseValue)
 does a check against types using this statement:

   if ((type != this._parameterClass) && !type.IsSubclassOf(this._parameterClass))

The problem here is that IsSubclassOf doesn't check for interface implementations.  When 
_parameterClass is an interface you also need to check using 

type.GetInterfaces().Contains(this._parameterClass)

This would then allow for result mappings to use interfaces, which is really useful when you are using an IoC
container to instantiate the class being populated, for example:

ISale sale = Container.Resolve<ISale>();
...
Mapper.Instance().QueryForObject<ISale>("uspSelectSale", saleNumber, sale);

Thanks

(Continue reading)

Group

gmane.comp.db.ibatis.devel.

Advertisement

Project Web Page

Developers list for iBatis SQL Maping DAO for Java and .NET

Search Archive

Page

1 | 2 | 3 | 4 | 5

Articles in period: 45

October 2008

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

Need help on calling stored procedure from ibatis (10 Jun 2010)
What is the JDK version required for iBatis latest (4 Jun 2010)
Moving iBatis to the Attic (22 May 2010)
[ANNOUNCEMENT] iBATIS Project Team Moving to Google Code (21 May 2010)
Created: (IBATIS-790) Wiki sign up not working (15 May 2010)
License header in source files (13 May 2010)
[ANNOUNCEMENT] iBATIS Wiki Moved (30 Apr 2010)
Wiki down? (28 Apr 2010)
iBatis 3 Java, an annotation for select, with result map in XML (20 Apr 2010)
[VOTE] Use Sonatype Nexus for Maven Releases (13 Apr 2010)
Changed Maven Artifact ID and location for iBATIS 3 (29 Mar 2010)
MetaClass.findProperty usage in NestedResultSetHandler.createRowKeyFor (27 Feb 2010)
help with ibatis 3 & objectwrapper, metaobject, etc. (24 Feb 2010)
Migrator: system properties via command line. (21 Feb 2010)
Maven Releasing Questions (19 Feb 2010)
Project Champion (9 Feb 2010)
IBatis2.3.4 throws : java.sql.SQLException: Invalid column type when p (1 Feb 2010)
Mapper interfaces inheritance (12 Jan 2010)
Small suggestion - method for checking if a DB transaction is in progr (6 Jan 2010)
Possible race condition using org.apache.ibatis.cache.Cache#hasKey ? (31 Dec 2009)
SoftCacheTest is Failing (23 Dec 2009)

Archives

4	June 2010
10	May 2010
9	April 2010
4	March 2010
19	February 2010
4	January 2010
17	December 2009
9	November 2009
2	October 2009
13	September 2009
58	August 2009
22	July 2009
41	June 2009
49	May 2009
28	April 2009
38	March 2009
13	February 2009
11	January 2009
50	December 2008
13	November 2008
45	October 2008
65	September 2008
50	August 2008
62	July 2008
54	June 2008
61	May 2008
40	April 2008
75	March 2008
19	February 2008
31	January 2008
22	December 2007
21	November 2007
34	October 2007
43	September 2007
29	August 2007
17	July 2007
56	June 2007
35	May 2007
41	April 2007
74	March 2007
164	February 2007
63	January 2007
57	December 2006
114	November 2006
146	October 2006
102	September 2006
111	August 2006
161	July 2006
152	June 2006
68	May 2006
48	April 2006
89	March 2006
172	February 2006
84	January 2006
149	December 2005
83	November 2005
137	October 2005
136	September 2005
84	August 2005
137	July 2005
233	June 2005
339	May 2005
236	April 2005
123	March 2005
178	February 2005
231	January 2005
138	December 2004
16	November 2004

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template