Re: Color bands in the day view
Jean-Francois LARVOIRE <jf.larvoire <at> free.fr>
2004-02-01 18:16:03 GMT
There is a problem with this approach: The CSS file is not included on the
server side, but on the client side.
For the PHP variables to work in the style sheet, we'd have to rename it as
mrbs.css.php, and include config.inc.php inside it. I'm not sure of all the
----- Original Message -----
From: "David Watts" <davidwwatts <at> yahoo.com>
To: "Jean-Francois LARVOIRE" <jf.larvoire <at> free.fr>; "MRBS"
<mrbs-general <at> lists.sourceforge.net>
Sent: Sunday, February 01, 2004 1:40 PM
Subject: Re: [MRBS-general] Color bands in the day view
> Yes it would be good to define all the colors etc in the style sheet.
> I previously tried to modify the colours via the style sheet, but
> discovered that some colour definitions are made directly in the PHP/HTML
> files, which makes it that much harder to upgrade to a new version of
> MRBS, if you've made mods.
> I think a goal to strive for is to make maintenance of the system as easy
> as possible, both from a devloper point of view and an administrator point
> of view.
> How about this:
> * Define variable in the config.inc.php file for all style settings (eg
> colours and fonts used throughout the system). This would include the
> $color_odd_rows and $color_even_rows variables and the like as well as the
> color definitions of the system overall (backgrounds, text colours,
> * Use those variable in the CSS file as well as in the PHP files where
> colors need to be specified directly into the HTML
> The result would be full use of the CSS (good for developers) but also all
> the actual color definitions are in the user-editable config.inc.php file.
> --- Jean-Francois LARVOIRE <jf.larvoire <at> free.fr> wrote:
> > I thought about this too, but I don't think it's the right way to go.
> > All style settings must be defined in the style sheet.
> > ----
> > Which means that the right design for the alternating stripes would be:
> > - Remove the $stripe_color setting I put in config.inc.php.
> > - Define 2 classes "even_rows" and "odd_rows".
> > - Define their colors in mrbs.css, by default both white (Unless there's
> > a consensus for a light grey for odd rows?)
> > - Update day.php to pass the above two classes alternatively to
> > tdcell().
> > What do you think about this?