Victor, that's just silly.
If you look at the pull request, my point before was that our date handling is over complicated.
On the initial PR that you raised, https://github.com/mantisbt/mantisbt/pull/380
Atrol/Rombert said +1 to your PR aka #380
I said "definitely a -1 to this, but before I go into details, are you hitting it on Centos/RHEL"
Damien also said -1, and then also said he’d do a PR.
Hence there are now 2 PR’s following up your initial work.
In the case of damien’s request, as I say I believe it overcomplicates our handling of date times and that we should look at simplifying the functionality.
If you actually spent the time to look, you may see my point.
Anyway, Given that I’ve got a -1 to Damien’s pull request and you’ve now given a -1 to my pull request, and both myself and damien gave a -1 to your pull request, we have now hit a situation where to move forward, I’d like to request a mailing list discussion on both Pull requests, as it seems we are not going to get agreement via Github.
It’s 12:30AM now so don’t have time now, I will write up arguments for and against the PR’s tomorrow, and then we can discuss, and if need be have a vote at the end.
Hopefully Damien will be more mature then yourself, and actually take the time to look and consider what we are actually trying to do.
From: Victor Boctor [mailto:notifications-9UaJU3cA/F/QT0dZR+AlfA@public.gmane.org]
Sent: 20 October 2014 00:07
Subject: Re: [mantisbt] Simplify timezone configuration within Mantis (#387)
-1 - I'm not even going to review this. We don't need 3 pull requests for a fix. If you have feedback give it to Damien who spent the time to write a thorough fix. There are two options here:
- Give him the feedback that he can incorporate.
- If you want to go further than he has the bandwidth to do as part of his checkin, then do follow up pull requests after his work is checked in.
Reply to this email directly or view it on GitHub.