1 Mar 2010 02:27
[mantisbt-commits] mantisbt.git branch, master-1.2.x, updated. release-1.2.0-9-g3cca927
The branch, master-1.2.x has been updated
via 3cca9275b16481529a5e2c3d94d783009e67cfb6 (commit)
from 76cd989ee2ec94f3b5dde199c609d266a8c0bdf2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3cca9275b16481529a5e2c3d94d783009e67cfb6
Author: David Hicks <hickseydr@...>
Date: Mon Mar 1 12:22:55 2010 +1100
Fix #11571: Versions 1.1 and 1.10 are treated as duplicates
A problem was discovered on manage_proj_edit_page.php where if versions
1.1 and 1.10 were both shown, clicking 'edit' for 1.1 would bring up the
edit version page for the 1.10 version instead.
This is due to an incorrect version name comparison in version_get_id
whereby the following check between strings was occurring:
if( "1.1" == "1.10" ) { ... }
PHP evaluates this expression to true because 1.1 and 1.10 are treated
as floats. We however need to preserve the string type during this
comparison, thus we need to use the === comparison operator instead.
-----------------------------------------------------------------------
(Continue reading)
RSS Feed